Re: [PATCH 15/18] arm64: dts: ti: k3-j721s2: Add overlay for DS90UB954-Q1EVM

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing build target for the J784S4 EVM using the UB954 overlay.
--

commit ad82842381a6b0a7a7dca389cbef513840daf997
Author: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>

arm64: dts: ti: k3-j721s2: Add overlay for DS90UB954-Q1EVM

This commit adds a device tree overlay for the DS90UB954-Q1EVM deserializer
board. It enables connecting FPDLink-III based sensors to TI EVMs by
aggregating data from up to two cameras. The overlay is integrated to support
the J721S2-EVM.

Link: https://www.ti.com/tool/DS90UB954-Q1EVM

> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> index aba187384009f..697d13b13b19e 100644
> --- a/arch/arm64/boot/dts/ti/Makefile
> +++ b/arch/arm64/boot/dts/ti/Makefile
[ ... ]
> @@ -346,6 +347,8 @@ k3-j721s2-evm-fpdlink-fusion-dtbs := k3-j721s2-evm.dtb \
>  	k3-j721s2-evm-fusion.dtbo
>  k3-j721s2-evm-pcie1-ep-dtbs := k3-j721s2-common-proc-board.dtb \
>  	k3-j721s2-evm-pcie1-ep.dtbo
> +k3-j721s2-evm-ub954-dtbs := k3-j721s2-evm.dtb \
> +	k3-j721s2-evm-ub954.dtbo
>  k3-j721s2-evm-usb0-type-a-dtbs := k3-j721s2-common-proc-board.dtb \
>  	k3-j721s2-evm-usb0-type-a.dtbo

[Severity: Low]
Does this Makefile omit a combined build target for the J784S4 EVM?

Looking at the newly added overlay file, the comment explicitly mentions
support for the J784S4 EVM as well:

arch/arm64/boot/dts/ti/k3-j721s2-evm-ub954.dtso:
    /*
     * DT Overlay for DS90UB954-Q1EVM FPDLink-III deserializer board on J721S2 and J784S4 EVM
     * https://www.ti.com/tool/DS90UB954-Q1EVM

Without a corresponding k3-j784s4-evm-ub954-dtbs target here in the Makefile,
the overlay is not validated against the J784S4 base DTB during the build.
Should a build target for the J784S4 be added to match the intent stated in
the overlay header?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702093123.1048575-1-y-abhilashchandra@ti.com?part=15