Re: [PATCH v2 03/20] media: imx355: Remove duplicated registers from the mode tables

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Register 0x030b (value 0x01) was accidentally omitted when common registers were moved into the global register array, causing it to be dropped entirely from the initialization sequence.
--

--- Patch [3]: [PATCH v2 03/20] media: imx355: Remove duplicated registers from the mode tables ---
commit 5dff7585c6b01310348ab92104e830ef77f11da0
Author: Dave Stevenson <dave.stevenson@raspberrypi.com>

media: imx355: Remove duplicated registers from the mode tables

A large number of registers are identical within all the modes.
This patch moves those duplicated registers to imx355_global_regs to
reduce duplication.

> diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
> index ad9a9464175b1..83a59aa8b0985 100644
> --- a/drivers/media/i2c/imx355.c
> +++ b/drivers/media/i2c/imx355.c
> @@ -221,6 +221,28 @@ static const struct imx355_reg imx355_global_regs[] = {
>  	{ 0x68b0, 0x00 },
>  	{ 0x3058, 0x00 },
>  	{ 0x305a, 0x00 },
> +	{ 0x0112, 0x0a },
> +	{ 0x0113, 0x0a },
> +	{ 0x0114, 0x03 },
> +	{ 0x0301, 0x05 },
> +	{ 0x0303, 0x01 },
> +	{ 0x0305, 0x02 },
> +	{ 0x0306, 0x00 },
> +	{ 0x0307, 0x78 },
> +	{ 0x030d, 0x02 },

[Severity: High]
Was register 0x030b unintentionally omitted from this list?

The original mode tables contained { 0x030b, 0x01 } between 0x0307 and 0x030d,
but it appears missing in the new global register array.

Omitting this PLL configuration register initialization could leave the clock
divider in an undefined state. Does this misconfigure the pixel clock when
imx355_global_regs is applied during sensor start-up?

> +	{ 0x0310, 0x00 },
> +	{ 0x0220, 0x00 },
> +	{ 0x0222, 0x01 },

[ ... ]

> @@ -253,32 +270,11 @@ static const struct imx355_reg mode_3268x2448_regs[] = {
>  	{ 0x034d, 0xc4 },
>  	{ 0x034e, 0x09 },
>  	{ 0x034f, 0x90 },
> -	{ 0x0301, 0x05 },
> -	{ 0x0303, 0x01 },
> -	{ 0x0305, 0x02 },
> -	{ 0x0306, 0x00 },
> -	{ 0x0307, 0x78 },
> -	{ 0x030b, 0x01 },
> -	{ 0x030d, 0x02 },
> -	{ 0x0310, 0x00 },
>  	{ 0x0700, 0x00 },
>  	{ 0x0701, 0x10 },

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707-media-imx355-v2-0-1683ec07b897@raspberrypi.com?part=3