Re: [PATCH v2 11/20] media: imx355: Add support for get_selection

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The TRY crop rectangle is not updated when the TRY format is changed, causing get_selection(TRY) to return stale or incorrect crop data.
--

--- Patch [11]: [PATCH v2 11/20] media: imx355: Add support for get_selection ---
commit c10d5f7839a602e25b0eddb66d5d44872dd34f8a
Author: Dave Stevenson <dave.stevenson@raspberrypi.com>

media: imx355: Add support for get_selection
    
Provide all the cropping information via get_selection.

> diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
> index 354092295b7c3..0f5fbe21d7fb2 100644
> --- a/drivers/media/i2c/imx355.c
> +++ b/drivers/media/i2c/imx355.c
[ ... ]
> @@ -891,6 +899,50 @@ imx355_set_pad_format(struct v4l2_subdev *sd,
>  	return 0;
>  }
>  
> +static void
> +__imx355_get_pad_crop(struct imx355 *imx355,
> +		      struct v4l2_subdev_state *sd_state, unsigned int pad,
> +		      enum v4l2_subdev_format_whence which, struct v4l2_rect *r)
> +{
> +	switch (which) {
> +	case V4L2_SUBDEV_FORMAT_TRY:
> +		*r = *v4l2_subdev_state_get_crop(sd_state, pad);

[Severity: Medium]
Will this return stale or incorrect crop data when negotiating the TRY format?

In imx355_set_pad_format(), when the TRY format is changed via
VIDIOC_SUBDEV_S_FMT, only the frame format is updated:

	if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
		framefmt = v4l2_subdev_state_get_format(sd_state, fmt->pad);
		*framefmt = fmt->format;
	} else {
		imx355->cur_mode = mode;
        ...

Because the corresponding TRY crop rectangle in the subdev state is left
unmodified, a subsequent call to VIDIOC_SUBDEV_G_SELECTION with
V4L2_SUBDEV_FORMAT_TRY and V4L2_SEL_TGT_CROP seems like it will return
outdated crop geometry.

Should imx355_set_pad_format() be updated to keep the TRY crop rectangle
in sync?

> +		break;
> +	case V4L2_SUBDEV_FORMAT_ACTIVE:
> +		*r = imx355->cur_mode->crop;
> +		break;
> +	}
> +}
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707-media-imx355-v2-0-1683ec07b897@raspberrypi.com?part=11