Re: [PATCH v2 05/20] media: imx355: Programmatically set the crop parameters for each mode

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing initialization of the 0x030b PLL configuration register.
--

--- Patch [5]: [PATCH v2 05/20] media: imx355: Programmatically set the crop parameters for each mode ---
commit 4df459187456782ee3ca7366e5ecefcdad82a80b
Author: Dave Stevenson <dave.stevenson@raspberrypi.com>

media: imx355: Programmatically set the crop parameters for each mode
    
Currently the cropping is set via register entries in the per mode
register lists. Add the crop information to the mode structure as
a v4l2_rect, and set the registers programmatically.

> diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
> index 28b210f1a8689..363b5667b6c9a 100644
> --- a/drivers/media/i2c/imx355.c
> +++ b/drivers/media/i2c/imx355.c
[ ... ]
> @@ -253,21 +261,9 @@ static const struct imx355_reg_list imx355_global_setting = {
>  static const struct imx355_reg mode_3268x2448_regs[] = {
>  	{ 0x0342, 0x0e },
>  	{ 0x0343, 0x58 },

[Severity: High]
Is the 0x030b PLL configuration register missing from the global settings?

It looks like the 0x030b register (value 0x01) was accidentally omitted
when moving identical registers from the per-mode arrays to the global
register array in the commit "media: imx355: Remove duplicated registers
from the mode tables".

Could this omission leave the hardware at its power-on reset state and
prevent the sensor from streaming correctly when imx355_start_streaming()
applies the global settings?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707-media-imx355-v2-0-1683ec07b897@raspberrypi.com?part=5