Re: [PATCH v2 14/20] media: imx355: Set the colorspace in the format

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added colorspace fields are not initialized for the default TRY format in `imx355_open()`.
--

--- Patch [14]: [PATCH v2 14/20] media: imx355: Set the colorspace in the format ---
commit 8e7fc1bcad81f6e37fba5685592010dfd48dcc99
Author: Dave Stevenson <dave.stevenson@raspberrypi.com>

media: imx355: Set the colorspace in the format

This commit updates the imx355 driver to set the appropriate colorspace
fields for a raw image sensor, rather than leaving them as 0.

(Note: The format of this review is altered to provide a free-form summary
due to restrictions on quoting the original patch code.)

[Severity: Medium]
Does this code leave the TRY format in an inconsistent state?

The commit adds assignments for colorspace, ycbcr_enc, quantization, and
xfer_func in imx355_update_pad_format(). However, looking at imx355_open()
in drivers/media/i2c/imx355.c, the try_fmt fields are manually initialized
when the subdev file handle is opened, but the new colorspace assignments
are missing from this initialization.

This means the initial TRY format queried via VIDIOC_SUBDEV_G_FMT might
return an inconsistent colorspace (V4L2_COLORSPACE_DEFAULT) compared to the
ACTIVE format default (V4L2_COLORSPACE_RAW) until a format is explicitly
set. Should the TRY format initialization in imx355_open() be updated to
include these new default values?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707-media-imx355-v2-0-1683ec07b897@raspberrypi.com?part=14