Re: [PATCH v2 12/20] media: imx355: Use pm_runtime autosuspend_delay

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing pm_runtime_dont_use_autosuspend() leaves device PM configuration in an inconsistent state on teardown.
--

--- Patch [12]: [PATCH v2 12/20] media: imx355: Use pm_runtime autosuspend_delay ---
commit 2fa89d9640a2f437c76ce04712298549178132d2
Author: Dave Stevenson <dave.stevenson@raspberrypi.com>

media: imx355: Use pm_runtime autosuspend_delay

Avoid powering the sensor up and down unnecessarily by using pm_runtime's
autosuspend_delay feature.

> diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
> index 0f5fbe21d7fb2..c7a24c69c0df8 100644
> --- a/drivers/media/i2c/imx355.c
> +++ b/drivers/media/i2c/imx355.c
[ ... ]
> @@ -1430,6 +1430,8 @@ static int imx355_probe(struct i2c_client *client)
>  	pm_runtime_set_active(imx355->dev);
>  	pm_runtime_enable(imx355->dev);
>  	pm_runtime_idle(imx355->dev);
> +	pm_runtime_set_autosuspend_delay(imx355->dev, 1000);
> +	pm_runtime_use_autosuspend(imx355->dev);
>  
>  	ret = v4l2_async_register_subdev_sensor(&imx355->sd);
>  	if (ret < 0)

[Severity: Medium]
Should there be matching calls to pm_runtime_dont_use_autosuspend() during
teardown?

Since pm_runtime_use_autosuspend() sets the use_autosuspend flag, leaving it
set on driver unbind or probe failure leaves the device PM configuration in an
inconsistent state.

For example, if probe fails after this point, the error path disables runtime
PM without undoing the autosuspend usage:

imx355_probe() {
    ...
error_media_entity_runtime_pm:
    pm_runtime_disable(imx355->dev);
    pm_runtime_set_suspended(imx355->dev);
    ...
}

The same pattern appears in the driver removal path:

imx355_remove() {
    ...
    pm_runtime_disable(imx355->dev);

    if (!pm_runtime_status_suspended(imx355->dev)) {
    ...
}

Could this cause state leakage that affects subsequent driver bindings?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707-media-imx355-v2-0-1683ec07b897@raspberrypi.com?part=12