* [PATCH 01/12] arm64: dts: apple: t8112: Add SMC hwmon node
2026-07-12 9:43 [PATCH 00/12] arm64: dts: apple: Add SMC hwmon nodes James Calligeros
@ 2026-07-12 9:43 ` James Calligeros
2026-07-12 9:53 ` sashiko-bot
2026-07-12 9:43 ` [PATCH 02/12] arm64: dts: apple: t8103: " James Calligeros
` (10 subsequent siblings)
11 siblings, 1 reply; 16+ messages in thread
From: James Calligeros @ 2026-07-12 9:43 UTC (permalink / raw)
To: Sven Peter, Janne Grunau, Neal Gompa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: asahi, linux-arm-kernel, devicetree, linux-kernel,
James Calligeros
Add the SMC hwmon subdevice
Signed-off-by: James Calligeros <jcalligeros99@gmail.com>
---
arch/arm64/boot/dts/apple/t8112.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/apple/t8112.dtsi b/arch/arm64/boot/dts/apple/t8112.dtsi
index 85c47422d4e8..a3241c816c26 100644
--- a/arch/arm64/boot/dts/apple/t8112.dtsi
+++ b/arch/arm64/boot/dts/apple/t8112.dtsi
@@ -921,6 +921,10 @@ smc_reboot: reboot {
"boot_error_count", "panic_count";
};
+ smc_hwmon: hwmon {
+ compatible = "apple,smc-hwmon";
+ };
+
rtc {
compatible = "apple,smc-rtc";
nvmem-cells = <&rtc_offset>;
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 01/12] arm64: dts: apple: t8112: Add SMC hwmon node
2026-07-12 9:43 ` [PATCH 01/12] arm64: dts: apple: t8112: Add SMC hwmon node James Calligeros
@ 2026-07-12 9:53 ` sashiko-bot
0 siblings, 0 replies; 16+ messages in thread
From: sashiko-bot @ 2026-07-12 9:53 UTC (permalink / raw)
To: James Calligeros; +Cc: conor+dt, robh, devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Adding an unconditionally enabled `smc_hwmon` node without child sensors triggers a spurious `dev_err` on boot on all T8112 platforms.
--
--- Patch [1]: [PATCH 01/12] arm64: dts: apple: t8112: Add SMC hwmon node ---
commit 98dce99825d4d377b6a5ac4bb63591402516eb04
Author: James Calligeros <jcalligeros99@gmail.com>
arm64: dts: apple: t8112: Add SMC hwmon node
This commit adds the SMC hwmon subdevice node to the Apple T8112 device tree.
> diff --git a/arch/arm64/boot/dts/apple/t8112.dtsi b/arch/arm64/boot/dts/apple/t8112.dtsi
> index 85c47422d4e8e..a3241c816c26b 100644
> --- a/arch/arm64/boot/dts/apple/t8112.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8112.dtsi
> @@ -921,6 +921,10 @@ smc_reboot: reboot {
> "boot_error_count", "panic_count";
> };
>
> + smc_hwmon: hwmon {
> + compatible = "apple,smc-hwmon";
> + };
> +
[Severity: Medium]
Will this unconditionally enabled node trigger a spurious error on boot?
Because this node is added without any child sensors and lacks a
status = "disabled" property, the SMC MFD core will instantiate the
macsmc-hwmon platform device.
When the probe function runs, it won't find any sensors, and will print an
error message to the kernel log before returning -ENODEV:
drivers/hwmon/macsmc-hwmon.c:macsmc_hwmon_probe() {
...
if (!hwmon->curr.count && !hwmon->fan.count &&
!hwmon->power.count && !hwmon->temp.count &&
!hwmon->volt.count) {
dev_err(hwmon->dev,
"No valid sensors found of any supported type\n");
return -ENODEV;
}
...
}
Should this node be added with status = "disabled" to prevent the
macsmc-hwmon driver from probing and polluting dmesg on platforms
without sensors?
> rtc {
> compatible = "apple,smc-rtc";
> nvmem-cells = <&rtc_offset>;
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260712-smc-subdev-dt-v1-0-7763006d57c7@gmail.com?part=1
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 02/12] arm64: dts: apple: t8103: Add SMC hwmon node
2026-07-12 9:43 [PATCH 00/12] arm64: dts: apple: Add SMC hwmon nodes James Calligeros
2026-07-12 9:43 ` [PATCH 01/12] arm64: dts: apple: t8112: Add SMC hwmon node James Calligeros
@ 2026-07-12 9:43 ` James Calligeros
2026-07-12 9:55 ` sashiko-bot
2026-07-12 9:43 ` [PATCH 03/12] arm64: dts: apple: t600x: " James Calligeros
` (9 subsequent siblings)
11 siblings, 1 reply; 16+ messages in thread
From: James Calligeros @ 2026-07-12 9:43 UTC (permalink / raw)
To: Sven Peter, Janne Grunau, Neal Gompa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: asahi, linux-arm-kernel, devicetree, linux-kernel,
James Calligeros
Add the SMC hwmon subdevice
Signed-off-by: James Calligeros <jcalligeros99@gmail.com>
---
arch/arm64/boot/dts/apple/t8103.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi
index da774096b667..4d6a0411f086 100644
--- a/arch/arm64/boot/dts/apple/t8103.dtsi
+++ b/arch/arm64/boot/dts/apple/t8103.dtsi
@@ -918,6 +918,10 @@ smc_reboot: reboot {
"boot_error_count", "panic_count";
};
+ smc_hwmon: hwmon {
+ compatible = "apple,smc-hwmon";
+ };
+
rtc {
compatible = "apple,smc-rtc";
nvmem-cells = <&rtc_offset>;
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 02/12] arm64: dts: apple: t8103: Add SMC hwmon node
2026-07-12 9:43 ` [PATCH 02/12] arm64: dts: apple: t8103: " James Calligeros
@ 2026-07-12 9:55 ` sashiko-bot
0 siblings, 0 replies; 16+ messages in thread
From: sashiko-bot @ 2026-07-12 9:55 UTC (permalink / raw)
To: James Calligeros; +Cc: conor+dt, devicetree, robh
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Adding an empty `smc_hwmon` node without `status = "disabled"` causes the `macsmc_hwmon` driver to fail its probe and print a `dev_err` on every boot for all t8103 devices.
--
--- Patch [2]: [PATCH 02/12] arm64: dts: apple: t8103: Add SMC hwmon node ---
commit 537fe4eb204476276f256c169a803f44dce48ec8
Author: James Calligeros <jcalligeros99@gmail.com>
arm64: dts: apple: t8103: Add SMC hwmon node
This commit adds the SMC hwmon subdevice node to the t8103 device tree.
> diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi
> --- a/arch/arm64/boot/dts/apple/t8103.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8103.dtsi
[ ... ]
> @@ -918,6 +918,10 @@ smc_reboot: reboot {
> "boot_error_count", "panic_count";
> };
>
> + smc_hwmon: hwmon {
> + compatible = "apple,smc-hwmon";
> + };
[Severity: Medium]
Will this empty hwmon node cause a spurious error message on boot for all
t8103 devices?
When the macsmc_hwmon driver probes this node without any child sensor nodes
defined, it evaluates the empty node, finds 0 sensors, and prints an error:
drivers/hwmon/macsmc-hwmon.c:macsmc_hwmon_probe() {
...
if (!hwmon->curr.count && !hwmon->fan.count &&
!hwmon->power.count && !hwmon->temp.count &&
!hwmon->volt.count) {
dev_err(hwmon->dev,
"No valid sensors found of any supported type\n");
return -ENODEV;
}
...
}
Should this node include status = "disabled" by default to prevent the driver
from failing its probe and polluting the kernel log?
> +
> rtc {
> compatible = "apple,smc-rtc";
> nvmem-cells = <&rtc_offset>;
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260712-smc-subdev-dt-v1-0-7763006d57c7@gmail.com?part=2
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 03/12] arm64: dts: apple: t600x: Add SMC hwmon node
2026-07-12 9:43 [PATCH 00/12] arm64: dts: apple: Add SMC hwmon nodes James Calligeros
2026-07-12 9:43 ` [PATCH 01/12] arm64: dts: apple: t8112: Add SMC hwmon node James Calligeros
2026-07-12 9:43 ` [PATCH 02/12] arm64: dts: apple: t8103: " James Calligeros
@ 2026-07-12 9:43 ` James Calligeros
2026-07-12 9:43 ` [PATCH 04/12] arm64: dts: apple: t602x: " James Calligeros
` (8 subsequent siblings)
11 siblings, 0 replies; 16+ messages in thread
From: James Calligeros @ 2026-07-12 9:43 UTC (permalink / raw)
To: Sven Peter, Janne Grunau, Neal Gompa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: asahi, linux-arm-kernel, devicetree, linux-kernel,
James Calligeros
Add the SMC hwmon subdevice
Signed-off-by: James Calligeros <jcalligeros99@gmail.com>
---
arch/arm64/boot/dts/apple/t600x-die0.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/apple/t600x-die0.dtsi b/arch/arm64/boot/dts/apple/t600x-die0.dtsi
index f715b19efd16..17db8d7a850c 100644
--- a/arch/arm64/boot/dts/apple/t600x-die0.dtsi
+++ b/arch/arm64/boot/dts/apple/t600x-die0.dtsi
@@ -45,6 +45,10 @@ smc_reboot: reboot {
"boot_error_count", "panic_count";
};
+ smc_hwmon: hwmon {
+ compatible = "apple,smc-hwmon";
+ };
+
rtc {
compatible = "apple,smc-rtc";
nvmem-cells = <&rtc_offset>;
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 04/12] arm64: dts: apple: t602x: Add SMC hwmon node
2026-07-12 9:43 [PATCH 00/12] arm64: dts: apple: Add SMC hwmon nodes James Calligeros
` (2 preceding siblings ...)
2026-07-12 9:43 ` [PATCH 03/12] arm64: dts: apple: t600x: " James Calligeros
@ 2026-07-12 9:43 ` James Calligeros
2026-07-12 9:43 ` [PATCH 05/12] arm64: dts: apple: Add common SMC hwmon infrastructure James Calligeros
` (7 subsequent siblings)
11 siblings, 0 replies; 16+ messages in thread
From: James Calligeros @ 2026-07-12 9:43 UTC (permalink / raw)
To: Sven Peter, Janne Grunau, Neal Gompa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: asahi, linux-arm-kernel, devicetree, linux-kernel,
James Calligeros
Add the SMC hwmon subdevice
Signed-off-by: James Calligeros <jcalligeros99@gmail.com>
---
arch/arm64/boot/dts/apple/t602x-die0.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/apple/t602x-die0.dtsi b/arch/arm64/boot/dts/apple/t602x-die0.dtsi
index 8622ddea7b44..301df2f006a0 100644
--- a/arch/arm64/boot/dts/apple/t602x-die0.dtsi
+++ b/arch/arm64/boot/dts/apple/t602x-die0.dtsi
@@ -122,6 +122,10 @@ smc_reboot: reboot {
"boot_error_count", "panic_count";
};
+ smc_hwmon: hwmon {
+ compatible = "apple,smc-hwmon";
+ };
+
rtc {
compatible = "apple,smc-rtc";
nvmem-cells = <&rtc_offset>;
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 05/12] arm64: dts: apple: Add common SMC hwmon infrastructure
2026-07-12 9:43 [PATCH 00/12] arm64: dts: apple: Add SMC hwmon nodes James Calligeros
` (3 preceding siblings ...)
2026-07-12 9:43 ` [PATCH 04/12] arm64: dts: apple: t602x: " James Calligeros
@ 2026-07-12 9:43 ` James Calligeros
2026-07-12 9:43 ` [PATCH 06/12] arm64: dts: apple: t8103: Add common SMC hwmon sensors James Calligeros
` (6 subsequent siblings)
11 siblings, 0 replies; 16+ messages in thread
From: James Calligeros @ 2026-07-12 9:43 UTC (permalink / raw)
To: Sven Peter, Janne Grunau, Neal Gompa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: asahi, linux-arm-kernel, devicetree, linux-kernel,
James Calligeros
Apple's System Management Controller exposes the readings
from numerous sensors scattered around the SoC and elsewhere
in the machine. Some of these sensors are reliably common
on all devices, whereas others are exposed at SMC keys
specific to either the SoC or even the particular device.
To account for this and expose the right sensors for the
right device without tedious Devicetree duplication, we
can include fragments of increasing specificity in the
per-device .dts files such that the individual keys
(of which there are potentially hundreds) do not need to
be copied in for every device.
Add the initial set of SMC hwmon sensors that are common
to multiple devices so that they can be included in
the per-device Devicetrees.
Co-developed-by: Janne Grunau <j@jannau.net>
Signed-off-by: Janne Grunau <j@jannau.net>
Signed-off-by: James Calligeros <jcalligeros99@gmail.com>
---
arch/arm64/boot/dts/apple/hwmon-common.dtsi | 38 ++++++++++++++++++++++++++++++++++++++
arch/arm64/boot/dts/apple/hwmon-fan-dual.dtsi | 23 +++++++++++++++++++++++
arch/arm64/boot/dts/apple/hwmon-fan.dtsi | 17 +++++++++++++++++
arch/arm64/boot/dts/apple/hwmon-laptop.dtsi | 38 ++++++++++++++++++++++++++++++++++++++
arch/arm64/boot/dts/apple/hwmon-mini.dtsi | 16 ++++++++++++++++
5 files changed, 132 insertions(+)
diff --git a/arch/arm64/boot/dts/apple/hwmon-common.dtsi b/arch/arm64/boot/dts/apple/hwmon-common.dtsi
new file mode 100644
index 000000000000..a35c7b14fec8
--- /dev/null
+++ b/arch/arm64/boot/dts/apple/hwmon-common.dtsi
@@ -0,0 +1,38 @@
+// SPDX-License-Identifier: GPL-2.0+ OR MIT
+/*
+ * hwmon sensors expected on all systems
+ *
+ * Copyright The Asahi Linux Contributors
+ */
+
+&smc_hwmon {
+ power-PSTR {
+ apple,key-id = "PSTR";
+ label = "Total System Power";
+ };
+
+ power-PDTR {
+ apple,key-id = "PDTR";
+ label = "AC Input Power";
+ };
+
+ power-PMVR {
+ apple,key-id = "PMVR";
+ label = "3.8 V Rail Power";
+ };
+
+ temperature-TH0x {
+ apple,key-id = "TH0x";
+ label = "NAND Flash Temperature";
+ };
+
+ voltage-VD0R {
+ apple,key-id = "VD0R";
+ label = "AC Input Voltage";
+ };
+
+ current-ID0R {
+ apple,key-id = "ID0R";
+ label = "AC Input Current";
+ };
+};
diff --git a/arch/arm64/boot/dts/apple/hwmon-fan-dual.dtsi b/arch/arm64/boot/dts/apple/hwmon-fan-dual.dtsi
new file mode 100644
index 000000000000..e87997d21e22
--- /dev/null
+++ b/arch/arm64/boot/dts/apple/hwmon-fan-dual.dtsi
@@ -0,0 +1,23 @@
+// SPDX-License-Identifier: GPL-2.0+ OR MIT
+/*
+ * Copyright The Asahi Linux Contributors
+ *
+ * Fan hwmon sensors for machines with 2 fan.
+ */
+
+#include "hwmon-fan.dtsi"
+
+&smc_hwmon {
+ fan-F0Ac {
+ label = "Fan 1";
+ };
+
+ fan-F1Ac {
+ apple,key-id = "F1Ac";
+ label = "Fan 2";
+ apple,fan-minimum = "F1Mn";
+ apple,fan-maximum = "F1Mx";
+ apple,fan-target = "F1Tg";
+ apple,fan-mode = "F1Md";
+ };
+};
diff --git a/arch/arm64/boot/dts/apple/hwmon-fan.dtsi b/arch/arm64/boot/dts/apple/hwmon-fan.dtsi
new file mode 100644
index 000000000000..180eb8d7441f
--- /dev/null
+++ b/arch/arm64/boot/dts/apple/hwmon-fan.dtsi
@@ -0,0 +1,17 @@
+// SPDX-License-Identifier: GPL-2.0+ OR MIT
+/*
+ * Copyright The Asahi Linux Contributors
+ *
+ * Fan hwmon sensors for machines with a single fan.
+ */
+
+&smc_hwmon {
+ fan-F0Ac {
+ apple,key-id = "F0Ac";
+ label = "Fan";
+ apple,fan-minimum = "F0Mn";
+ apple,fan-maximum = "F0Mx";
+ apple,fan-target = "F0Tg";
+ apple,fan-mode = "F0Md";
+ };
+};
diff --git a/arch/arm64/boot/dts/apple/hwmon-laptop.dtsi b/arch/arm64/boot/dts/apple/hwmon-laptop.dtsi
new file mode 100644
index 000000000000..cadffd000c76
--- /dev/null
+++ b/arch/arm64/boot/dts/apple/hwmon-laptop.dtsi
@@ -0,0 +1,38 @@
+// SPDX-License-Identifier: GPL-2.0+ OR MIT
+/*
+ * hwmon sensors expected on all laptops
+ *
+ * Copyright The Asahi Linux Contributors
+ */
+
+&smc_hwmon {
+ power-PHPC {
+ apple,key-id = "PHPC";
+ label = "Heatpipe Power";
+ };
+
+ temperature-TB0T {
+ apple,key-id = "TB0T";
+ label = "Battery Hotspot";
+ };
+
+ temperature-TCHP {
+ apple,key-id = "TCHP";
+ label = "Charge Regulator Temp";
+ };
+
+ temperature-TW0P {
+ apple,key-id = "TW0P";
+ label = "WiFi/BT Module Temp";
+ };
+
+ voltage-SBAV {
+ apple,key-id = "SBAV";
+ label = "Battery Voltage";
+ };
+
+ voltage-VD0R {
+ apple,key-id = "VD0R";
+ label = "Charger Input Voltage";
+ };
+};
diff --git a/arch/arm64/boot/dts/apple/hwmon-mini.dtsi b/arch/arm64/boot/dts/apple/hwmon-mini.dtsi
new file mode 100644
index 000000000000..7fd86e911acf
--- /dev/null
+++ b/arch/arm64/boot/dts/apple/hwmon-mini.dtsi
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: GPL-2.0+ OR MIT
+/*
+ * hwmon sensors common to the Mac mini desktop
+ * models, but not the Studio or Pro.
+ *
+ * Copyright The Asahi Linux Contributors
+ */
+
+#include "hwmon-fan.dtsi"
+
+&smc_hwmon {
+ temperature-TW0P {
+ apple,key-id = "TW0P";
+ label = "WiFi/BT Module Temp";
+ };
+};
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 06/12] arm64: dts: apple: t8103: Add common SMC hwmon sensors
2026-07-12 9:43 [PATCH 00/12] arm64: dts: apple: Add SMC hwmon nodes James Calligeros
` (4 preceding siblings ...)
2026-07-12 9:43 ` [PATCH 05/12] arm64: dts: apple: Add common SMC hwmon infrastructure James Calligeros
@ 2026-07-12 9:43 ` James Calligeros
2026-07-12 9:43 ` [PATCH 07/12] arm64: dts: apple: t8112: " James Calligeros
` (5 subsequent siblings)
11 siblings, 0 replies; 16+ messages in thread
From: James Calligeros @ 2026-07-12 9:43 UTC (permalink / raw)
To: Sven Peter, Janne Grunau, Neal Gompa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: asahi, linux-arm-kernel, devicetree, linux-kernel,
James Calligeros
Add the SMC hwmon sensors common to all SoCs
Signed-off-by: James Calligeros <jcalligeros99@gmail.com>
---
arch/arm64/boot/dts/apple/t8103.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi
index 4d6a0411f086..5b68bf0df4e6 100644
--- a/arch/arm64/boot/dts/apple/t8103.dtsi
+++ b/arch/arm64/boot/dts/apple/t8103.dtsi
@@ -1250,3 +1250,4 @@ port02: pci@2,0 {
};
#include "t8103-pmgr.dtsi"
+#include "hwmon-common.dtsi"
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 07/12] arm64: dts: apple: t8112: Add common SMC hwmon sensors
2026-07-12 9:43 [PATCH 00/12] arm64: dts: apple: Add SMC hwmon nodes James Calligeros
` (5 preceding siblings ...)
2026-07-12 9:43 ` [PATCH 06/12] arm64: dts: apple: t8103: Add common SMC hwmon sensors James Calligeros
@ 2026-07-12 9:43 ` James Calligeros
2026-07-12 9:43 ` [PATCH 08/12] arm64: dts: apple: t600x: " James Calligeros
` (4 subsequent siblings)
11 siblings, 0 replies; 16+ messages in thread
From: James Calligeros @ 2026-07-12 9:43 UTC (permalink / raw)
To: Sven Peter, Janne Grunau, Neal Gompa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: asahi, linux-arm-kernel, devicetree, linux-kernel,
James Calligeros
Add the SMC hwmon sensors common to all SoCs
Signed-off-by: James Calligeros <jcalligeros99@gmail.com>
---
arch/arm64/boot/dts/apple/t8112.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/apple/t8112.dtsi b/arch/arm64/boot/dts/apple/t8112.dtsi
index a3241c816c26..ec248ca052cb 100644
--- a/arch/arm64/boot/dts/apple/t8112.dtsi
+++ b/arch/arm64/boot/dts/apple/t8112.dtsi
@@ -1289,3 +1289,4 @@ port03: pci@3,0 {
};
#include "t8112-pmgr.dtsi"
+#include "hwmon-common.dtsi"
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 08/12] arm64: dts: apple: t600x: Add common SMC hwmon sensors
2026-07-12 9:43 [PATCH 00/12] arm64: dts: apple: Add SMC hwmon nodes James Calligeros
` (6 preceding siblings ...)
2026-07-12 9:43 ` [PATCH 07/12] arm64: dts: apple: t8112: " James Calligeros
@ 2026-07-12 9:43 ` James Calligeros
2026-07-12 9:43 ` [PATCH 09/12] arm64: dts: apple: t602x: " James Calligeros
` (3 subsequent siblings)
11 siblings, 0 replies; 16+ messages in thread
From: James Calligeros @ 2026-07-12 9:43 UTC (permalink / raw)
To: Sven Peter, Janne Grunau, Neal Gompa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: asahi, linux-arm-kernel, devicetree, linux-kernel,
James Calligeros
Add the SMC hwmon sensors common to all SoCs
Signed-off-by: James Calligeros <jcalligeros99@gmail.com>
---
arch/arm64/boot/dts/apple/t6001.dtsi | 2 ++
arch/arm64/boot/dts/apple/t6002.dtsi | 2 ++
2 files changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/apple/t6001.dtsi b/arch/arm64/boot/dts/apple/t6001.dtsi
index 6dcb71a1d65a..4fb934d7e71f 100644
--- a/arch/arm64/boot/dts/apple/t6001.dtsi
+++ b/arch/arm64/boot/dts/apple/t6001.dtsi
@@ -67,3 +67,5 @@ p-core-pmu-affinity {
&gpu {
compatible = "apple,agx-g13c", "apple,agx-g13s";
};
+
+#include "hwmon-common.dtsi"
diff --git a/arch/arm64/boot/dts/apple/t6002.dtsi b/arch/arm64/boot/dts/apple/t6002.dtsi
index a532e5401c4e..0f81fc612a2a 100644
--- a/arch/arm64/boot/dts/apple/t6002.dtsi
+++ b/arch/arm64/boot/dts/apple/t6002.dtsi
@@ -305,3 +305,5 @@ &ps_gfx {
&gpu {
compatible = "apple,agx-g13d", "apple,agx-g13s";
};
+
+#include "hwmon-common.dtsi"
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 09/12] arm64: dts: apple: t602x: Add common SMC hwmon sensors
2026-07-12 9:43 [PATCH 00/12] arm64: dts: apple: Add SMC hwmon nodes James Calligeros
` (7 preceding siblings ...)
2026-07-12 9:43 ` [PATCH 08/12] arm64: dts: apple: t600x: " James Calligeros
@ 2026-07-12 9:43 ` James Calligeros
2026-07-12 9:43 ` [PATCH 10/12] arm64: dts: apple: t8103: jxxx: Add device-specific " James Calligeros
` (2 subsequent siblings)
11 siblings, 0 replies; 16+ messages in thread
From: James Calligeros @ 2026-07-12 9:43 UTC (permalink / raw)
To: Sven Peter, Janne Grunau, Neal Gompa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: asahi, linux-arm-kernel, devicetree, linux-kernel,
James Calligeros
Add the SMC hwmon sensors common to all SoCs
Signed-off-by: James Calligeros <jcalligeros99@gmail.com>
---
arch/arm64/boot/dts/apple/t6021.dtsi | 2 ++
arch/arm64/boot/dts/apple/t6022.dtsi | 2 ++
2 files changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/apple/t6021.dtsi b/arch/arm64/boot/dts/apple/t6021.dtsi
index 62907ad6a546..5175797baf62 100644
--- a/arch/arm64/boot/dts/apple/t6021.dtsi
+++ b/arch/arm64/boot/dts/apple/t6021.dtsi
@@ -67,3 +67,5 @@ p-core-pmu-affinity {
&gpu {
compatible = "apple,agx-g14c", "apple,agx-g14s";
};
+
+#include "hwmon-common.dtsi"
diff --git a/arch/arm64/boot/dts/apple/t6022.dtsi b/arch/arm64/boot/dts/apple/t6022.dtsi
index e73bf2f7510a..7585fd609d34 100644
--- a/arch/arm64/boot/dts/apple/t6022.dtsi
+++ b/arch/arm64/boot/dts/apple/t6022.dtsi
@@ -347,3 +347,5 @@ &ps_gfx {
&gpu {
compatible = "apple,agx-g14d", "apple,agx-g14s";
};
+
+#include "hwmon-common.dtsi"
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 10/12] arm64: dts: apple: t8103: jxxx: Add device-specific SMC hwmon sensors
2026-07-12 9:43 [PATCH 00/12] arm64: dts: apple: Add SMC hwmon nodes James Calligeros
` (8 preceding siblings ...)
2026-07-12 9:43 ` [PATCH 09/12] arm64: dts: apple: t602x: " James Calligeros
@ 2026-07-12 9:43 ` James Calligeros
2026-07-12 9:43 ` [PATCH 11/12] arm64: dts: apple: t8112: " James Calligeros
2026-07-12 9:43 ` [PATCH 12/12] arm64: dts: apple: t60xx: " James Calligeros
11 siblings, 0 replies; 16+ messages in thread
From: James Calligeros @ 2026-07-12 9:43 UTC (permalink / raw)
To: Sven Peter, Janne Grunau, Neal Gompa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: asahi, linux-arm-kernel, devicetree, linux-kernel,
James Calligeros
Add the device-specific hwmon sensors for select T8103-based devices
Signed-off-by: James Calligeros <jcalligeros99@gmail.com>
---
arch/arm64/boot/dts/apple/t8103-j274.dts | 2 ++
arch/arm64/boot/dts/apple/t8103-j293.dts | 3 +++
arch/arm64/boot/dts/apple/t8103-j313.dts | 2 ++
3 files changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/apple/t8103-j274.dts b/arch/arm64/boot/dts/apple/t8103-j274.dts
index 52965258200d..1212852251e0 100644
--- a/arch/arm64/boot/dts/apple/t8103-j274.dts
+++ b/arch/arm64/boot/dts/apple/t8103-j274.dts
@@ -74,3 +74,5 @@ &pcie0_dart_2 {
&i2c2 {
status = "okay";
};
+
+#include "hwmon-mini.dtsi"
diff --git a/arch/arm64/boot/dts/apple/t8103-j293.dts b/arch/arm64/boot/dts/apple/t8103-j293.dts
index 52f63ae7a58d..1d074b9e6018 100644
--- a/arch/arm64/boot/dts/apple/t8103-j293.dts
+++ b/arch/arm64/boot/dts/apple/t8103-j293.dts
@@ -132,3 +132,6 @@ dfr_panel_in: endpoint {
&displaydfr_dart {
status = "okay";
};
+
+#include "hwmon-laptop.dtsi"
+#include "hwmon-fan.dtsi"
diff --git a/arch/arm64/boot/dts/apple/t8103-j313.dts b/arch/arm64/boot/dts/apple/t8103-j313.dts
index 9eb2825d25dc..f8b2b1637b9d 100644
--- a/arch/arm64/boot/dts/apple/t8103-j313.dts
+++ b/arch/arm64/boot/dts/apple/t8103-j313.dts
@@ -54,3 +54,5 @@ &typec0 {
&typec1 {
label = "USB-C Left-front";
};
+
+#include "hwmon-laptop.dtsi"
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 11/12] arm64: dts: apple: t8112: jxxx: Add device-specific SMC hwmon sensors
2026-07-12 9:43 [PATCH 00/12] arm64: dts: apple: Add SMC hwmon nodes James Calligeros
` (9 preceding siblings ...)
2026-07-12 9:43 ` [PATCH 10/12] arm64: dts: apple: t8103: jxxx: Add device-specific " James Calligeros
@ 2026-07-12 9:43 ` James Calligeros
2026-07-12 9:43 ` [PATCH 12/12] arm64: dts: apple: t60xx: " James Calligeros
11 siblings, 0 replies; 16+ messages in thread
From: James Calligeros @ 2026-07-12 9:43 UTC (permalink / raw)
To: Sven Peter, Janne Grunau, Neal Gompa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: asahi, linux-arm-kernel, devicetree, linux-kernel,
James Calligeros
Add the device-specific hwmon sensors for select T8112-based devices
Signed-off-by: James Calligeros <jcalligeros99@gmail.com>
---
arch/arm64/boot/dts/apple/t8112-j413.dts | 2 ++
arch/arm64/boot/dts/apple/t8112-j415.dts | 2 ++
arch/arm64/boot/dts/apple/t8112-j473.dts | 2 ++
arch/arm64/boot/dts/apple/t8112-j493.dts | 3 +++
4 files changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/apple/t8112-j413.dts b/arch/arm64/boot/dts/apple/t8112-j413.dts
index 1a08a41f369b..7ccfceb08093 100644
--- a/arch/arm64/boot/dts/apple/t8112-j413.dts
+++ b/arch/arm64/boot/dts/apple/t8112-j413.dts
@@ -91,3 +91,5 @@ &i2c4 {
&fpwm1 {
status = "okay";
};
+
+#include "hwmon-laptop.dtsi"
diff --git a/arch/arm64/boot/dts/apple/t8112-j415.dts b/arch/arm64/boot/dts/apple/t8112-j415.dts
index e37c56d9fb4d..fdc3409d2e07 100644
--- a/arch/arm64/boot/dts/apple/t8112-j415.dts
+++ b/arch/arm64/boot/dts/apple/t8112-j415.dts
@@ -91,3 +91,5 @@ &i2c4 {
&fpwm1 {
status = "okay";
};
+
+#include "hwmon-laptop.dtsi"
diff --git a/arch/arm64/boot/dts/apple/t8112-j473.dts b/arch/arm64/boot/dts/apple/t8112-j473.dts
index 438f972546b8..105a9d118980 100644
--- a/arch/arm64/boot/dts/apple/t8112-j473.dts
+++ b/arch/arm64/boot/dts/apple/t8112-j473.dts
@@ -84,3 +84,5 @@ &typec0 {
&typec1 {
label = "USB-C Back-right";
};
+
+#include "hwmon-mini.dtsi"
diff --git a/arch/arm64/boot/dts/apple/t8112-j493.dts b/arch/arm64/boot/dts/apple/t8112-j493.dts
index ec116da3e4dd..7cea5c594810 100644
--- a/arch/arm64/boot/dts/apple/t8112-j493.dts
+++ b/arch/arm64/boot/dts/apple/t8112-j493.dts
@@ -146,3 +146,6 @@ touchbar0: touchbar@0 {
touchscreen-inverted-y;
};
};
+
+#include "hwmon-laptop.dtsi"
+#include "hwmon-fan.dtsi"
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 12/12] arm64: dts: apple: t60xx: jxxx: Add device-specific SMC hwmon sensors
2026-07-12 9:43 [PATCH 00/12] arm64: dts: apple: Add SMC hwmon nodes James Calligeros
` (10 preceding siblings ...)
2026-07-12 9:43 ` [PATCH 11/12] arm64: dts: apple: t8112: " James Calligeros
@ 2026-07-12 9:43 ` James Calligeros
2026-07-12 9:52 ` sashiko-bot
11 siblings, 1 reply; 16+ messages in thread
From: James Calligeros @ 2026-07-12 9:43 UTC (permalink / raw)
To: Sven Peter, Janne Grunau, Neal Gompa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: asahi, linux-arm-kernel, devicetree, linux-kernel,
James Calligeros
Add the device-specific hwmon sensors for select T60xx-based devices
Signed-off-by: James Calligeros <jcalligeros99@gmail.com>
---
arch/arm64/boot/dts/apple/t6001-j375c.dts | 2 ++
arch/arm64/boot/dts/apple/t6002-j375d.dts | 2 ++
arch/arm64/boot/dts/apple/t600x-j314-j316.dtsi | 2 ++
arch/arm64/boot/dts/apple/t6020-j474s.dts | 2 ++
arch/arm64/boot/dts/apple/t6021-j475c.dts | 2 ++
arch/arm64/boot/dts/apple/t6022-j475d.dts | 2 ++
6 files changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/apple/t6001-j375c.dts b/arch/arm64/boot/dts/apple/t6001-j375c.dts
index 2e7c23714d4d..08276114c1d8 100644
--- a/arch/arm64/boot/dts/apple/t6001-j375c.dts
+++ b/arch/arm64/boot/dts/apple/t6001-j375c.dts
@@ -24,3 +24,5 @@ &wifi0 {
&bluetooth0 {
brcm,board-type = "apple,okinawa";
};
+
+#include "hwmon-fan-dual.dtsi"
diff --git a/arch/arm64/boot/dts/apple/t6002-j375d.dts b/arch/arm64/boot/dts/apple/t6002-j375d.dts
index a2a24d028cbb..e6eb6b6c386d 100644
--- a/arch/arm64/boot/dts/apple/t6002-j375d.dts
+++ b/arch/arm64/boot/dts/apple/t6002-j375d.dts
@@ -184,6 +184,8 @@ atcphy5_usb3: endpoint {
};
};
+#include "hwmon-fan-dual.dtsi"
+
/* delete unused USB nodes on die 1 */
/delete-node/ &dwc3_2_dart_0_die1;
diff --git a/arch/arm64/boot/dts/apple/t600x-j314-j316.dtsi b/arch/arm64/boot/dts/apple/t600x-j314-j316.dtsi
index fee84f809a9c..caded1636f3d 100644
--- a/arch/arm64/boot/dts/apple/t600x-j314-j316.dtsi
+++ b/arch/arm64/boot/dts/apple/t600x-j314-j316.dtsi
@@ -367,3 +367,5 @@ &atcphy3 {
};
#include "spi1-nvram.dtsi"
+#include "hwmon-laptop.dtsi"
+#include "hwmon-fan-dual.dtsi"
diff --git a/arch/arm64/boot/dts/apple/t6020-j474s.dts b/arch/arm64/boot/dts/apple/t6020-j474s.dts
index 7c7ad5b8ad18..e3c2635d84fa 100644
--- a/arch/arm64/boot/dts/apple/t6020-j474s.dts
+++ b/arch/arm64/boot/dts/apple/t6020-j474s.dts
@@ -45,3 +45,5 @@ &pcie0 {
<0x200 &pcie0_dart_2 1 1>,
<0x300 &pcie0_dart_3 1 1>;
};
+
+#include "hwmon-mini.dtsi"
diff --git a/arch/arm64/boot/dts/apple/t6021-j475c.dts b/arch/arm64/boot/dts/apple/t6021-j475c.dts
index 533e35774874..82689c380cdf 100644
--- a/arch/arm64/boot/dts/apple/t6021-j475c.dts
+++ b/arch/arm64/boot/dts/apple/t6021-j475c.dts
@@ -35,3 +35,5 @@ &port01 {
&pcie0_dart_1 {
status = "okay";
};
+
+#include "hwmon-fan.dtsi"
diff --git a/arch/arm64/boot/dts/apple/t6022-j475d.dts b/arch/arm64/boot/dts/apple/t6022-j475d.dts
index 31f24bbda968..f50a6d56f3d8 100644
--- a/arch/arm64/boot/dts/apple/t6022-j475d.dts
+++ b/arch/arm64/boot/dts/apple/t6022-j475d.dts
@@ -44,6 +44,8 @@ &typec5 {
label = "USB-C Front Left";
};
+#include "hwmon-fan.dtsi"
+
/* delete unused USB nodes on die 1 */
/delete-node/ &dwc3_2_dart_0_die1;
/delete-node/ &dwc3_2_dart_1_die1;
--
2.55.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 12/12] arm64: dts: apple: t60xx: jxxx: Add device-specific SMC hwmon sensors
2026-07-12 9:43 ` [PATCH 12/12] arm64: dts: apple: t60xx: " James Calligeros
@ 2026-07-12 9:52 ` sashiko-bot
0 siblings, 0 replies; 16+ messages in thread
From: sashiko-bot @ 2026-07-12 9:52 UTC (permalink / raw)
To: James Calligeros; +Cc: conor+dt, devicetree, robh
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] M2 Mac Studio models incorrectly include the single-fan hwmon configuration instead of the dual-fan configuration.
--
--- Patch [12]: [PATCH 12/12] arm64: dts: apple: t60xx: jxxx: Add device-specific SMC hwmon sensors ---
commit 9b6661d8907736a04d8f29e1718ac346ff51ced8
Author: James Calligeros <jcalligeros99@gmail.com>
arm64: dts: apple: t60xx: jxxx: Add device-specific SMC hwmon sensors
Add the device-specific hwmon sensors for select T60xx-based devices.
[ ... ]
> diff --git a/arch/arm64/boot/dts/apple/t6021-j475c.dts b/arch/arm64/boot/dts/apple/t6021-j475c.dts
> index 533e357748746..82689c380cdf2 100644
> --- a/arch/arm64/boot/dts/apple/t6021-j475c.dts
> +++ b/arch/arm64/boot/dts/apple/t6021-j475c.dts
> @@ -35,3 +35,5 @@ &port01 {
> &pcie0_dart_1 {
> status = "okay";
> };
> +
> +#include "hwmon-fan.dtsi"
[Severity: Medium]
Should this M2 Max Mac Studio use hwmon-fan-dual.dtsi instead of
hwmon-fan.dtsi?
Using the single-fan configuration might cause hardware monitoring telemetry
to miss the second fan on this device, leading to incomplete fan statistics
in userspace.
> diff --git a/arch/arm64/boot/dts/apple/t6022-j475d.dts b/arch/arm64/boot/dts/apple/t6022-j475d.dts
> index 31f24bbda9689..f50a6d56f3d8e 100644
> --- a/arch/arm64/boot/dts/apple/t6022-j475d.dts
> +++ b/arch/arm64/boot/dts/apple/t6022-j475d.dts
> @@ -44,6 +44,8 @@ &typec5 {
> label = "USB-C Front Left";
> };
>
> +#include "hwmon-fan.dtsi"
[Severity: Medium]
Does this M2 Ultra Mac Studio also need hwmon-fan-dual.dtsi rather than
hwmon-fan.dtsi?
Similar to the M2 Max model, using the single-fan configuration could cause
hardware monitoring to miss the second fan's telemetry.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260712-smc-subdev-dt-v1-0-7763006d57c7@gmail.com?part=12
^ permalink raw reply [flat|nested] 16+ messages in thread