From: "Rob Herring (Arm)" <robh@kernel.org>
To: Rajesh Gumasta <rgumasta@nvidia.com>
Cc: linux-tegra@vger.kernel.org, nm@ti.com, andersson@kernel.org,
krzk+dt@kernel.org, linux-mmc@vger.kernel.org,
kyarlagadda@nvidia.com, thierry.reding@gmail.com,
linux-i2c@vger.kernel.org, sjg@chromium.org,
andi.shyti@kernel.org, conor+dt@kernel.org,
ulf.hansson@linaro.org, devicetree@vger.kernel.org,
jonathanh@nvidia.com
Subject: Re: [PATCH V3 2/3] dt-binding: i2c: nvidia,tegra20-i2c: Add register-setting support
Date: Fri, 25 Jul 2025 02:40:34 -0500 [thread overview]
Message-ID: <175342923470.141295.13172940562486185515.robh@kernel.org> (raw)
In-Reply-To: <20250725052225.23510-3-rgumasta@nvidia.com>
On Fri, 25 Jul 2025 10:52:24 +0530, Rajesh Gumasta wrote:
> Add register setting support for the NVIDIA Tegra20 I2C controllers. An
> i2c-controller-common.yaml binding document has been added a top-level
> binding document so that all I2C controllers can use this binding. This
> new binding document defines some generic register setting properties
> for I2C and some standard I2C operating modes that the register settings
> need to be programmed for. This new binding document is used by the
> NVIDIA Tegra20 I2C binding to enable the use of the 'reg-settings'
> binding for this device.
>
> Signed-off-by: Rajesh Gumasta <rgumasta@nvidia.com>
> ---
> .../bindings/i2c/i2c-controller-common.yaml | 73 +++++++++++++++++++
> .../bindings/i2c/nvidia,tegra20-i2c.yaml | 64 +++++++++++++++-
> 2 files changed, 134 insertions(+), 3 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/i2c/i2c-controller-common.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.example.dts:24.22-73.11: Warning (i2c_bus_bridge): /example-0/i2c@7000c000: incorrect #address-cells for I2C bus
Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.example.dts:24.22-73.11: Warning (i2c_bus_bridge): /example-0/i2c@7000c000: incorrect #size-cells for I2C bus
Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'i2c_bus_bridge'
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250725052225.23510-3-rgumasta@nvidia.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-07-25 7:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 5:22 [PATCH V3 0/3] Introduce a generic register settings dt-binding Rajesh Gumasta
2025-07-25 5:22 ` [PATCH V3 1/3] dt-binding: Add register-settings binding Rajesh Gumasta
2025-07-25 6:47 ` Krzysztof Kozlowski
2025-07-29 9:15 ` Jon Hunter
2025-07-29 9:28 ` Krzysztof Kozlowski
2025-07-29 14:05 ` Thierry Reding
2025-09-05 10:36 ` Jon Hunter
2025-09-29 4:39 ` Chintan Vankar
2025-09-30 15:01 ` Jon Hunter
2025-10-09 10:15 ` Jon Hunter
2025-10-09 16:33 ` Rob Herring
2025-10-14 14:30 ` Jon Hunter
2025-07-25 5:22 ` [PATCH V3 2/3] dt-binding: i2c: nvidia,tegra20-i2c: Add register-setting support Rajesh Gumasta
2025-07-25 7:40 ` Rob Herring (Arm) [this message]
2025-07-25 9:20 ` Jon Hunter
2025-07-25 5:22 ` [PATCH V3 3/3] dt-binding: mmc: tegra: " Rajesh Gumasta
2025-07-25 6:48 ` [PATCH V3 0/3] Introduce a generic register settings dt-binding Krzysztof Kozlowski
2025-07-25 9:13 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175342923470.141295.13172940562486185515.robh@kernel.org \
--to=robh@kernel.org \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=kyarlagadda@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nm@ti.com \
--cc=rgumasta@nvidia.com \
--cc=sjg@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox