Re: [PATCH V3 1/3] dt-binding: Add register-settings binding

[Krzysztof Kozlowski <krzk@kernel.org>]

On 29/07/2025 11:15, Jon Hunter wrote:
> 
> On 25/07/2025 07:47, Krzysztof Kozlowski wrote:
>> On 25/07/2025 07:22, Rajesh Gumasta wrote:
>>> +description: |
>>> +  Register Settings provides a generic way to specify register configurations
>>> +  for any hardware controllers. Settings are specified under a "reg-settings"
>>> +  sub-node under the controller device tree node. It allows defining both
>>> +  default and operating mode specific register settings in the device tree.
>>> +
>>> +properties:
>>> +  reg-settings:
>>> +    type: object
>>> +    description: |
>>> +      Container node for register settings configurations. Each child node
>>> +      represents a specific configuration mode or operating condition.
>>> +
>>> +    additionalProperties:
>>> +      type: object
>>
>> I don't understand what does this binding bring. It is empty.
> 
> 
> Yes this is very much similar to the pinctrl.yaml that defines a 
> top-level object that can then be used by different devices and those 

No, it is not similar. pinctrl.yaml defines common properties and common
schema for class of devices - pin controllers.

There is nothing common here, nothing defined except that you have
unspecified children nodes.

> devices can then define the properties they need. So the examples for 
> I2C and MMC really demonstrate how this would be used in the subsequent 
> patches. Obviously we are open to any ideas on how if there are better 
> or preferred ways to do this.

I don't see this part addressing comments from Rob - you need more users
of this. Adding fake (empty, no-op) common schema is not solving it.

Best regards,
Krzysztof