From: "Ville Syrjälä" <syrjala@sci.fi>
To: Oliver Neukum <oliver@neukum.org>
Cc: daniel.ritz@gmx.ch, Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jkosina@suse.cz>,
linux-usb@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [rft]power management for usbtouch
Date: Fri, 27 Jun 2008 16:17:35 +0300 [thread overview]
Message-ID: <20080627131735.GC19430@sci.fi> (raw)
In-Reply-To: <200806271050.02579.oliver@neukum.org>
On Fri, Jun 27, 2008 at 10:50:00AM +0200, Oliver Neukum wrote:
> Hi,
>
> this patch should fix everything you complained about. As I don't have
> the hardware, please test.
I don't have the hardware either so can't help you there.
> static void usbtouch_close(struct input_dev *input)
> {
> struct usbtouch_usb *usbtouch = input_get_drvdata(input);
>
> + mutex_lock(&usbtouch->lock);
> + usbtouch->open = 0;
> + mutex_unlock(&usbtouch->lock);
> usb_kill_urb(usbtouch->irq);
usb_kill_urb() is still not protected by the mutex but a resume
happening here wouldn't resubmit the urb so I suppose it's OK to leave
it like that.
--
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-06-27 13:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 13:57 [rft]power management for usbtouch Oliver Neukum
2008-06-26 14:45 ` Ville Syrjälä
[not found] ` <20080626144545.GF22310-ORSVBvAovxo@public.gmane.org>
2008-06-26 14:56 ` Oliver Neukum
[not found] ` <200806261656.06457.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-06-27 8:50 ` Oliver Neukum
2008-06-27 13:17 ` Ville Syrjälä [this message]
2008-06-27 16:10 ` Ville Syrjälä
[not found] ` <20080627161036.GE19430-ORSVBvAovxo@public.gmane.org>
2008-06-27 19:07 ` Oliver Neukum
2008-06-27 20:20 ` Ville Syrjälä
[not found] ` <20080627202027.GG19430-ORSVBvAovxo@public.gmane.org>
2008-06-27 20:41 ` Oliver Neukum
[not found] ` <200806272241.22513.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-06-27 20:51 ` Ville Syrjälä
[not found] ` <20080627205147.GI19430-ORSVBvAovxo@public.gmane.org>
2008-06-27 20:57 ` Oliver Neukum
2008-06-27 21:28 ` Ville Syrjälä
2008-06-28 10:52 ` Oliver Neukum
2008-06-28 11:22 ` Ville Syrjälä
[not found] ` <20080628112258.GK19430-ORSVBvAovxo@public.gmane.org>
2008-06-28 12:53 ` Oliver Neukum
2008-06-28 16:33 ` Alan Stern
2008-06-28 22:47 ` Oliver Neukum
[not found] ` <200806290047.56736.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-06-30 15:29 ` Dmitry Torokhov
2008-06-30 15:47 ` Alan Stern
2008-06-30 16:02 ` Dmitry Torokhov
[not found] ` <20080630115953.ZZRA012-NG0XCrj25/nJrYCpivWRnl5pS2h4L8biXqFh9Ls21Oc@public.gmane.org>
2008-06-30 16:16 ` Alan Stern
2008-06-30 16:30 ` Dmitry Torokhov
2008-06-30 16:58 ` Alan Stern
2008-06-30 22:46 ` Oliver Neukum
[not found] ` <200807010046.34219.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-07-01 7:59 ` Jiri Kosina
2008-07-01 9:08 ` Oliver Neukum
2008-07-01 12:56 ` Dmitry Torokhov
2008-07-01 15:00 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.0807011058340.2780-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2008-07-01 16:02 ` Dmitry Torokhov
[not found] ` <20080701085504.ZZRA012-NG0XCrj25/nJrYCpivWRnl5pS2h4L8biXqFh9Ls21Oc@public.gmane.org>
2008-07-01 16:57 ` Oliver Neukum
[not found] ` <200807011857.02259.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-07-01 17:39 ` Ville Syrjälä
2008-07-01 19:03 ` Alan Stern
2008-06-27 13:17 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080627131735.GC19430@sci.fi \
--to=syrjala@sci.fi \
--cc=daniel.ritz@gmx.ch \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox