Re: Linking Patchwork with Sashiko?

[Mauro Carvalho Chehab <mchehab+huawei@kernel.org>]

On Mon, 20 Jul 2026 21:16:47 +0200
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote:

> On Mon, 20 Jul 2026 09:55:37 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > On Fri, 17 Jul 2026 15:25:59 +0200
> > Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote:
> >   
> > > That's one of the reasons why I do think media needs its own custom
> > > prompts.    
> > 
> > Reading this thread I've come to the conclusion that different systems
> > have different results from Sashiko. Sashko gets confused with some of
> > the tracing logic, but that's because tracing does some hacks to keep
> > the overhead down (it's where live text updates started). It reports
> > issues sometimes that are not a problem due to the way the code was
> > designed.  
> 
> There is a custom prompt for tracing:
> 
> 	https://github.com/sashiko-dev/sashiko/blob/main/third_party/prompts/kernel/subsystem/tracing.md
> 
> Probably, if you run Sashiko without it you would get more false
> positives.
> 
> > But I fortunately know of these areas and can easily see when
> > Sashiko falls over it. Hence, these false positives do not waste my
> > time as I'm already aware of them. (I do take a deeper look to make
> > sure it's not reporting something similar that may truly be a bug).
> > 
> > But I can see where this could cause a bit more problems with a
> > different sub-system.
> > 
> > Hence, I don't believe there should be a one-size-fits-all for the
> > entire kernel,  
> 
> It is not like that. On static analyzers like Coverity, smatch,
> sparse, coccinelle... there's no space for per-subsystem adjustments.
> 
> Now, with LLM, each subsystem may have custom prompts:
> 
> 	https://github.com/sashiko-dev/sashiko/tree/main/third_party/prompts/kernel/subsystem
> 
> Also, when LLM parses a C file, it can pick some things from
> the documentation on it.

Btw, Sashiko has gained its first set of adjustments for media today:
	https://github.com/sashiko-dev/sashiko/issues/334

	https://github.com/sashiko-dev/sashiko/commit/b0aad67f2d5918dd5da768fde15a144f8435d387
	https://github.com/sashiko-dev/sashiko/commit/8ac8e51fd79c8560404efe62d0c9ce38defce5af

Hopefully, it will help to prevent some false positives noticed on
past reviews.

-- 
Thanks,
Mauro