[PATCH v2 0/2] Enable Inline crypto engine for kodiak

[PATCH v2 0/2] Enable Inline crypto engine for kodiak

[Neeraj Soni]

Document Inline Crypto Engine (ICE) handle for SDHC and add its device-tree
node to enable it for kodiak.

How this patch was tested:
- export ARCH=arm64
- export CROSS_COMPILE=aarch64-linux-gnu-
- make menuconfig
- make defconifg
- make DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/sdhci-msm.yaml dt_binding_check
- make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y dtbs

---
Changes in v2:
- Removed the "if: required:" description for "qcom,ice" dt-binding
  as the ICE node is optional.
- Corrected the ICE dt node entry according to the dt-binding description.
- Added test details.

Changes in v1:
- Updated the dt-binding for ICE node.
- Added the dt node for ICE for kodiak.

Neeraj Soni (2):
  dt-bindings: mmc: sdhci-msm: Add ICE phandle
  arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC

 Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++++
 arch/arm64/boot/dts/qcom/kodiak.dtsi                 | 9 +++++++++
 2 files changed, 13 insertions(+)

--
2.34.1

[PATCH v2 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle

[Neeraj Soni]

Starting with sc7280(kodiak), the ICE will have its own device-tree node.
So add the qcom,ice property to reference it.

Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
index 938be8228d66..8a6a25ceabe1 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
+++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
@@ -140,6 +140,10 @@ properties:
     $ref: /schemas/types.yaml#/definitions/uint32
     description: platform specific settings for DLL_CONFIG reg.
 
+  qcom,ice:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description: phandle to the Inline Crypto Engine node
+
   iommus:
     minItems: 1
     maxItems: 8
-- 
2.34.1

[PATCH v2 2/2] arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC

[Neeraj Soni]

Add an ICE node to kodiak SoC description and enable it by adding a
phandle to the SDHC node.

Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/kodiak.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi
index c2ccbb67f800..fb2a9c0ea0f5 100644
--- a/arch/arm64/boot/dts/qcom/kodiak.dtsi
+++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi
@@ -1045,6 +1045,8 @@ sdhc_1: mmc@7c4000 {
 			qcom,dll-config = <0x0007642c>;
 			qcom,ddr-config = <0x80040868>;
 
+			qcom,ice = <&sdhc_ice>;
+
 			mmc-ddr-1_8v;
 			mmc-hs200-1_8v;
 			mmc-hs400-1_8v;
@@ -1071,6 +1073,13 @@ opp-384000000 {
 			};
 		};
 
+		sdhc_ice: crypto@7C8000 {
+			compatible = "qcom,sc7280-inline-crypto-engine",
+				     "qcom,inline-crypto-engine";
+			reg = <0x0 0x007C8000 0x0 0x18000>;
+			clocks = <&gcc GCC_SDCC1_ICE_CORE_CLK>;
+		};
+
 		gpi_dma0: dma-controller@900000 {
 			#dma-cells = <3>;
 			compatible = "qcom,sc7280-gpi-dma", "qcom,sm6350-gpi-dma";
-- 
2.34.1

Re: [PATCH v2 0/2] Enable Inline crypto engine for kodiak

[Rob Herring]

On Wed, 14 Jan 2026 15:18:46 +0530, Neeraj Soni wrote:
> Document Inline Crypto Engine (ICE) handle for SDHC and add its device-tree
> node to enable it for kodiak.
> 
> How this patch was tested:
> - export ARCH=arm64
> - export CROSS_COMPILE=aarch64-linux-gnu-
> - make menuconfig
> - make defconifg
> - make DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/sdhci-msm.yaml dt_binding_check
> - make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y dtbs
> 
> ---
> Changes in v2:
> - Removed the "if: required:" description for "qcom,ice" dt-binding
>   as the ICE node is optional.
> - Corrected the ICE dt node entry according to the dt-binding description.
> - Added test details.
> 
> Changes in v1:
> - Updated the dt-binding for ICE node.
> - Added the dt node for ICE for kodiak.
> 
> Neeraj Soni (2):
>   dt-bindings: mmc: sdhci-msm: Add ICE phandle
>   arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC
> 
>  Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++++
>  arch/arm64/boot/dts/qcom/kodiak.dtsi                 | 9 +++++++++
>  2 files changed, 13 insertions(+)
> 
> --
> 2.34.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/v6.19-rc1-102-g3af51501e2b8 (exact match)
 Base: tags/v6.19-rc1-102-g3af51501e2b8 (use --merge-base to override)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20260114094848.3790487-1-neeraj.soni@oss.qualcomm.com:

arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/sc7280-herobrine-crd-pro.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: pmic@2 (qcom,pm8350c): pwm:nvmem: [[386, 387]] is too short
	from schema $id: http://devicetree.org/schemas/mfd/qcom,spmi-pmic.yaml
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: pwm (qcom,pm8350c-pwm): nvmem: [[386, 387]] is too short
	from schema $id: http://devicetree.org/schemas/leds/leds-qcom-lpg.yaml
arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/qcm6490-idp.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/qcm6490-particle-tachyon.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/sc7280-idp.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/sc7280-idp2.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-lte.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme-lte.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1-lte.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/qcs6490-radxa-dragon-q6a.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
	from schema $id: http://devicetree.org/schemas/simple-bus.yaml

Re: [PATCH v2 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle

[Krzysztof Kozlowski]

On Wed, Jan 14, 2026 at 03:18:47PM +0530, Neeraj Soni wrote:
> Starting with sc7280(kodiak), the ICE will have its own device-tree node.
> So add the qcom,ice property to reference it.
> 
> Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> index 938be8228d66..8a6a25ceabe1 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> @@ -140,6 +140,10 @@ properties:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      description: platform specific settings for DLL_CONFIG reg.
>  
> +  qcom,ice:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: phandle to the Inline Crypto Engine node

Description should also say: for what purpose.

You either have this phandle or ICE address space on sc7280 and newer.
You cannot have both, so your schema should encode it properly.

Otherwise you just sent something which already was on the list and it
even was reviewed:

https://lore.kernel.org/all/ba3da82d-999b-b040-5230-36e60293e0fd@linaro.org/

You even copied the commit msg but did copy the authorship!

Anyway v3 and v4 were not correct and probably v2 should be used after
adjusting it with my comments.


Best regards,
Krzysztof

Re: [PATCH v2 2/2] arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC

[Krzysztof Kozlowski]

On Wed, Jan 14, 2026 at 03:18:48PM +0530, Neeraj Soni wrote:
> Add an ICE node to kodiak SoC description and enable it by adding a
> phandle to the SDHC node.
> 
> Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/kodiak.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi
> index c2ccbb67f800..fb2a9c0ea0f5 100644
> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi
> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi
> @@ -1045,6 +1045,8 @@ sdhc_1: mmc@7c4000 {
>  			qcom,dll-config = <0x0007642c>;
>  			qcom,ddr-config = <0x80040868>;
>  
> +			qcom,ice = <&sdhc_ice>;
> +
>  			mmc-ddr-1_8v;
>  			mmc-hs200-1_8v;
>  			mmc-hs400-1_8v;
> @@ -1071,6 +1073,13 @@ opp-384000000 {
>  			};
>  		};
>  
> +		sdhc_ice: crypto@7C8000 {

Why this became uppercase?

> +			compatible = "qcom,sc7280-inline-crypto-engine",
> +				     "qcom,inline-crypto-engine";
> +			reg = <0x0 0x007C8000 0x0 0x18000>;

And this? there is no uppercase at all, so maybye you copied it from
downstream, but that's not right approach - do not use downstream code.

Best regards,
Krzysztof

Re: [PATCH v2 2/2] arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC

[Neeraj Soni]

Hi,

On 1/15/2026 2:35 PM, Krzysztof Kozlowski wrote:
> On Wed, Jan 14, 2026 at 03:18:48PM +0530, Neeraj Soni wrote:
>> Add an ICE node to kodiak SoC description and enable it by adding a
>> phandle to the SDHC node.
>>
>> Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com>
>> ---
>>  arch/arm64/boot/dts/qcom/kodiak.dtsi | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi
>> index c2ccbb67f800..fb2a9c0ea0f5 100644
>> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi
>> @@ -1045,6 +1045,8 @@ sdhc_1: mmc@7c4000 {
>>  			qcom,dll-config = <0x0007642c>;
>>  			qcom,ddr-config = <0x80040868>;
>>  
>> +			qcom,ice = <&sdhc_ice>;
>> +
>>  			mmc-ddr-1_8v;
>>  			mmc-hs200-1_8v;
>>  			mmc-hs400-1_8v;
>> @@ -1071,6 +1073,13 @@ opp-384000000 {
>>  			};
>>  		};
>>  
>> +		sdhc_ice: crypto@7C8000 {
> 
> Why this became uppercase?
Thnaks for pointing out. I will fix this next patch.
> 
>> +			compatible = "qcom,sc7280-inline-crypto-engine",
>> +				     "qcom,inline-crypto-engine";
>> +			reg = <0x0 0x007C8000 0x0 0x18000>;
> 
> And this? there is no uppercase at all, so maybye you copied it from
> downstream, but that's not right approach - do not use downstream code.
> 
Yes it was copied but i missed to align with upstream. Thanks for pointing out. This will be fixed in next patch.
> Best regards,
> Krzysztof
> 
Regards
Neeraj

Re: [PATCH v2 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle

[Neeraj Soni]

Hi,

On 1/15/2026 2:33 PM, Krzysztof Kozlowski wrote:
> On Wed, Jan 14, 2026 at 03:18:47PM +0530, Neeraj Soni wrote:
>> Starting with sc7280(kodiak), the ICE will have its own device-tree node.
>> So add the qcom,ice property to reference it.
>>
>> Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com>
>> ---
>>  Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>> index 938be8228d66..8a6a25ceabe1 100644
>> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>> @@ -140,6 +140,10 @@ properties:
>>      $ref: /schemas/types.yaml#/definitions/uint32
>>      description: platform specific settings for DLL_CONFIG reg.
>>  
>> +  qcom,ice:
>> +    $ref: /schemas/types.yaml#/definitions/phandle
>> +    description: phandle to the Inline Crypto Engine node
> 
> Description should also say: for what purpose.
> 
> You either have this phandle or ICE address space on sc7280 and newer.
> You cannot have both, so your schema should encode it properly.
> 
Sure. I will update this in next patch.

> Otherwise you just sent something which already was on the list and it
> even was reviewed:
> 
> https://lore.kernel.org/all/ba3da82d-999b-b040-5230-36e60293e0fd@linaro.org/
> 
> You even copied the commit msg but did copy the authorship!
> 
Sure. Thanks for pointing out. I will fix the authorship in next patch.

> Anyway v3 and v4 were not correct and probably v2 should be used after
> adjusting it with my comments.
> 
Okay. As i see your comment in v2 here:
https://lore.kernel.org/all/c8eea30f-5ea2-cfc9-273a-3c6e99a316b9@linaro.org/

i guess what you want is not to drop the entries for clock but rather capture it
in the "description" of the ICE phandle entry. Is this understanding correct?
> 
> Best regards,
> Krzysztof
> 
Regards,
Neeraj

Re: [PATCH v2 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle

[Krzysztof Kozlowski]

On 16/01/2026 07:50, Neeraj Soni wrote:
> Hi,
> 
> On 1/15/2026 2:33 PM, Krzysztof Kozlowski wrote:
>> On Wed, Jan 14, 2026 at 03:18:47PM +0530, Neeraj Soni wrote:
>>> Starting with sc7280(kodiak), the ICE will have its own device-tree node.
>>> So add the qcom,ice property to reference it.
>>>
>>> Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com>
>>> ---
>>>  Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>>> index 938be8228d66..8a6a25ceabe1 100644
>>> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>>> @@ -140,6 +140,10 @@ properties:
>>>      $ref: /schemas/types.yaml#/definitions/uint32
>>>      description: platform specific settings for DLL_CONFIG reg.
>>>  
>>> +  qcom,ice:
>>> +    $ref: /schemas/types.yaml#/definitions/phandle
>>> +    description: phandle to the Inline Crypto Engine node
>>
>> Description should also say: for what purpose.
>>
>> You either have this phandle or ICE address space on sc7280 and newer.
>> You cannot have both, so your schema should encode it properly.
>>
> Sure. I will update this in next patch.
> 
>> Otherwise you just sent something which already was on the list and it
>> even was reviewed:
>>
>> https://lore.kernel.org/all/ba3da82d-999b-b040-5230-36e60293e0fd@linaro.org/
>>
>> You even copied the commit msg but did copy the authorship!
>>
> Sure. Thanks for pointing out. I will fix the authorship in next patch.

If you add if:then: cases, the patch will differ, so make it your own.
But sending exactly the same patch with the same commit msg as what is
already on the lists under your own name is not correct.

> 
>> Anyway v3 and v4 were not correct and probably v2 should be used after
>> adjusting it with my comments.
>>
> Okay. As i see your comment in v2 here:
> https://lore.kernel.org/all/c8eea30f-5ea2-cfc9-273a-3c6e99a316b9@linaro.org/
> 
> i guess what you want is not to drop the entries for clock but rather capture it
> in the "description" of the ICE phandle entry. Is this understanding correct?

Clocks should not be touched, but reg should.


Best regards,
Krzysztof

Re: [PATCH v2 2/2] arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC

[Krzysztof Kozlowski]

On 16/01/2026 06:59, Neeraj Soni wrote:
>> Why this became uppercase?
> Thnaks for pointing out. I will fix this next patch.
>>
>>> +			compatible = "qcom,sc7280-inline-crypto-engine",
>>> +				     "qcom,inline-crypto-engine";
>>> +			reg = <0x0 0x007C8000 0x0 0x18000>;
>>
>> And this? there is no uppercase at all, so maybye you copied it from
>> downstream, but that's not right approach - do not use downstream code.
>>
> Yes it was copied but i missed to align with upstream. Thanks for pointing out. This will be fixed in next patch.

And that's the problem. You must NEVER COPY downstream DTS. We repeat it
and repeat it...

Best regards,
Krzysztof

Re: [PATCH v2 0/2] Enable Inline crypto engine for kodiak

[Krzysztof Kozlowski]

On 14/01/2026 17:18, Rob Herring wrote:
> 
> On Wed, 14 Jan 2026 15:18:46 +0530, Neeraj Soni wrote:
>> Document Inline Crypto Engine (ICE) handle for SDHC and add its device-tree
>> node to enable it for kodiak.
>>
>> How this patch was tested:
>> - export ARCH=arm64
>> - export CROSS_COMPILE=aarch64-linux-gnu-
>> - make menuconfig
>> - make defconifg
>> - make DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/sdhci-msm.yaml dt_binding_check
>> - make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y dtbs
>>
>> ---
>> Changes in v2:
>> - Removed the "if: required:" description for "qcom,ice" dt-binding
>>   as the ICE node is optional.
>> - Corrected the ICE dt node entry according to the dt-binding description.
>> - Added test details.
>>

Is this another report being ignored by the author? I'll start the list.

Best regards,
Krzysztof

Re: [PATCH v2 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle

[Neeraj Soni]

Hi,

On 1/16/2026 12:48 PM, Krzysztof Kozlowski wrote:
> On 16/01/2026 07:50, Neeraj Soni wrote:
>> Hi,
>>
>> On 1/15/2026 2:33 PM, Krzysztof Kozlowski wrote:
>>> On Wed, Jan 14, 2026 at 03:18:47PM +0530, Neeraj Soni wrote:
>>>> Starting with sc7280(kodiak), the ICE will have its own device-tree node.
>>>> So add the qcom,ice property to reference it.
>>>>
>>>> Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com>
>>>> ---
>>>>  Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++++
>>>>  1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>>>> index 938be8228d66..8a6a25ceabe1 100644
>>>> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>>>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>>>> @@ -140,6 +140,10 @@ properties:
>>>>      $ref: /schemas/types.yaml#/definitions/uint32
>>>>      description: platform specific settings for DLL_CONFIG reg.
>>>>  
>>>> +  qcom,ice:
>>>> +    $ref: /schemas/types.yaml#/definitions/phandle
>>>> +    description: phandle to the Inline Crypto Engine node
>>>
>>> Description should also say: for what purpose.
>>>
>>> You either have this phandle or ICE address space on sc7280 and newer.
>>> You cannot have both, so your schema should encode it properly.
>>>
>> Sure. I will update this in next patch.
>>
>>> Otherwise you just sent something which already was on the list and it
>>> even was reviewed:
>>>
>>> https://lore.kernel.org/all/ba3da82d-999b-b040-5230-36e60293e0fd@linaro.org/
>>>
>>> You even copied the commit msg but did copy the authorship!
>>>
>> Sure. Thanks for pointing out. I will fix the authorship in next patch.
> 
> If you add if:then: cases, the patch will differ, so make it your own.

Okay.

> But sending exactly the same patch with the same commit msg as what is
> already on the lists under your own name is not correct.
> >>
Okay this was not intended and have taken care of authorship in my other posts but i will ensure
not to repeat in future.

>>> Anyway v3 and v4 were not correct and probably v2 should be used after
>>> adjusting it with my comments.
>>>
>> Okay. As i see your comment in v2 here:
>> https://lore.kernel.org/all/c8eea30f-5ea2-cfc9-273a-3c6e99a316b9@linaro.org/
>>
>> i guess what you want is not to drop the entries for clock but rather capture it
>> in the "description" of the ICE phandle entry. Is this understanding correct?
> 
> Clocks should not be touched, but reg should.
> 
Okay but In sdhci-msm.yaml file:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml#n78

the currenty entries for "reg-names" do not specify for which hardware register range they are added. So shall i add something like
this:
-if
   required
      -qcom,ice
   then
     properties:
        reg:
          minItems: 1
          maxItems: 3

        reg-names:
          minItems: 1
          maxItems: 3
    else
      properties:
        reg:
          minItems: 1
          maxItems: 4

        reg-names:
          minItems: 1
          maxItems: 4

Indicating that reg: maxItems: and reg-names: max: will be "3" if seperate ICE phandle is added since the ICE register entries will not be needed.
> 
> Best regards,
> Krzysztof
> 

Re: [PATCH v2 2/2] arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC

[Neeraj Soni]

Hi,

On 1/16/2026 12:49 PM, Krzysztof Kozlowski wrote:
> On 16/01/2026 06:59, Neeraj Soni wrote:
>>> Why this became uppercase?
>> Thnaks for pointing out. I will fix this next patch.
>>>
>>>> +			compatible = "qcom,sc7280-inline-crypto-engine",
>>>> +				     "qcom,inline-crypto-engine";
>>>> +			reg = <0x0 0x007C8000 0x0 0x18000>;
>>>
>>> And this? there is no uppercase at all, so maybye you copied it from
>>> downstream, but that's not right approach - do not use downstream code.
>>>
>> Yes it was copied but i missed to align with upstream. Thanks for pointing out. This will be fixed in next patch.
> 
> And that's the problem. You must NEVER COPY downstream DTS. We repeat it
> and repeat it...
> 
Sure and i apologize for missing this. I will be fixing this in next patch and will ensure this is not repeated
in any future posts.

> Best regards,
> Krzysztof
> 

Re: [PATCH v2 0/2] Enable Inline crypto engine for kodiak

[Neeraj Soni]

Hi,

On 1/16/2026 10:24 PM, Krzysztof Kozlowski wrote:
> On 14/01/2026 17:18, Rob Herring wrote:
>>
>> On Wed, 14 Jan 2026 15:18:46 +0530, Neeraj Soni wrote:
>>> Document Inline Crypto Engine (ICE) handle for SDHC and add its device-tree
>>> node to enable it for kodiak.
>>>
>>> How this patch was tested:
>>> - export ARCH=arm64
>>> - export CROSS_COMPILE=aarch64-linux-gnu-
>>> - make menuconfig
>>> - make defconifg
>>> - make DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/sdhci-msm.yaml dt_binding_check
>>> - make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y dtbs
>>>
>>> ---
>>> Changes in v2:
>>> - Removed the "if: required:" description for "qcom,ice" dt-binding
>>>   as the ICE node is optional.
>>> - Corrected the ICE dt node entry according to the dt-binding description.
>>> - Added test details.
>>>
> 
> Is this another report being ignored by the author? I'll start the list.
> 
No i did not ignore this. I see this comment in the message:

"Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not.
No need to reply unless the platform maintainer has comments."

So the intention was to wait for the comments from maintainer

> Best regards,
> Krzysztof
> 

Re: [PATCH v2 1/2] dt-bindings: mmc: sdhci-msm: Add ICE phandle

[Krzysztof Kozlowski]

On 19/01/2026 10:47, Neeraj Soni wrote:
> Hi,
> 
> On 1/16/2026 12:48 PM, Krzysztof Kozlowski wrote:
>> On 16/01/2026 07:50, Neeraj Soni wrote:
>>> Hi,
>>>
>>> On 1/15/2026 2:33 PM, Krzysztof Kozlowski wrote:
>>>> On Wed, Jan 14, 2026 at 03:18:47PM +0530, Neeraj Soni wrote:
>>>>> Starting with sc7280(kodiak), the ICE will have its own device-tree node.
>>>>> So add the qcom,ice property to reference it.
>>>>>
>>>>> Signed-off-by: Neeraj Soni <neeraj.soni@oss.qualcomm.com>
>>>>> ---
>>>>>  Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++++
>>>>>  1 file changed, 4 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>>>>> index 938be8228d66..8a6a25ceabe1 100644
>>>>> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>>>>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
>>>>> @@ -140,6 +140,10 @@ properties:
>>>>>      $ref: /schemas/types.yaml#/definitions/uint32
>>>>>      description: platform specific settings for DLL_CONFIG reg.
>>>>>  
>>>>> +  qcom,ice:
>>>>> +    $ref: /schemas/types.yaml#/definitions/phandle
>>>>> +    description: phandle to the Inline Crypto Engine node
>>>>
>>>> Description should also say: for what purpose.
>>>>
>>>> You either have this phandle or ICE address space on sc7280 and newer.
>>>> You cannot have both, so your schema should encode it properly.
>>>>
>>> Sure. I will update this in next patch.
>>>
>>>> Otherwise you just sent something which already was on the list and it
>>>> even was reviewed:
>>>>
>>>> https://lore.kernel.org/all/ba3da82d-999b-b040-5230-36e60293e0fd@linaro.org/
>>>>
>>>> You even copied the commit msg but did copy the authorship!
>>>>
>>> Sure. Thanks for pointing out. I will fix the authorship in next patch.
>>
>> If you add if:then: cases, the patch will differ, so make it your own.
> 
> Okay.
> 
>> But sending exactly the same patch with the same commit msg as what is
>> already on the lists under your own name is not correct.
>>>>
> Okay this was not intended and have taken care of authorship in my other posts but i will ensure
> not to repeat in future.
> 
>>>> Anyway v3 and v4 were not correct and probably v2 should be used after
>>>> adjusting it with my comments.
>>>>
>>> Okay. As i see your comment in v2 here:
>>> https://lore.kernel.org/all/c8eea30f-5ea2-cfc9-273a-3c6e99a316b9@linaro.org/
>>>
>>> i guess what you want is not to drop the entries for clock but rather capture it
>>> in the "description" of the ICE phandle entry. Is this understanding correct?
>>
>> Clocks should not be touched, but reg should.
>>
> Okay but In sdhci-msm.yaml file:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml#n78
> 
> the currenty entries for "reg-names" do not specify for which hardware register range they are added. So shall i add something like

Read the rest of the binding.

And finally wrap your emails correctly. I am bored asking this over and
over, so if there is silence in the future - you can guess why.

Best regards,
Krzysztof

Re: [PATCH v2 0/2] Enable Inline crypto engine for kodiak

[Neeraj Soni]

Hi,

On 1/14/2026 9:48 PM, Rob Herring wrote:
> 
> On Wed, 14 Jan 2026 15:18:46 +0530, Neeraj Soni wrote:
>> Document Inline Crypto Engine (ICE) handle for SDHC and add its device-tree
>> node to enable it for kodiak.
>>
>> How this patch was tested:
>> - export ARCH=arm64
>> - export CROSS_COMPILE=aarch64-linux-gnu-
>> - make menuconfig
>> - make defconifg
>> - make DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/sdhci-msm.yaml dt_binding_check
>> - make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y dtbs
>>
>> ---
>> Changes in v2:
>> - Removed the "if: required:" description for "qcom,ice" dt-binding
>>   as the ICE node is optional.
>> - Corrected the ICE dt node entry according to the dt-binding description.
>> - Added test details.
>>
>> Changes in v1:
>> - Updated the dt-binding for ICE node.
>> - Added the dt node for ICE for kodiak.
>>
>> Neeraj Soni (2):
>>   dt-bindings: mmc: sdhci-msm: Add ICE phandle
>>   arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC
>>
>>  Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++++
>>  arch/arm64/boot/dts/qcom/kodiak.dtsi                 | 9 +++++++++
>>  2 files changed, 13 insertions(+)
>>
>> --
>> 2.34.1
>>
>>
>>
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> This patch series was applied (using b4) to base:
>  Base: attempting to guess base-commit...
>  Base: tags/v6.19-rc1-102-g3af51501e2b8 (exact match)
>  Base: tags/v6.19-rc1-102-g3af51501e2b8 (use --merge-base to override)
> 
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
> 
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20260114094848.3790487-1-neeraj.soni@oss.qualcomm.com:
> 
> arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-crd-pro.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: pmic@2 (qcom,pm8350c): pwm:nvmem: [[386, 387]] is too short
> 	from schema $id: http://devicetree.org/schemas/mfd/qcom,spmi-pmic.yaml
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: pwm (qcom,pm8350c-pwm): nvmem: [[386, 387]] is too short
> 	from schema $id: http://devicetree.org/schemas/leds/leds-qcom-lpg.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/qcm6490-idp.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/qcm6490-particle-tachyon.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-idp.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-idp2.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-lte.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme-lte.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1-lte.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/qcs6490-radxa-dragon-q6a.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> 
The crypto node i added is not a "bus" node but a leaf node for Inline Crypto Engine (ICE). There are no props like "compatible = "simple-bus"" or "#address-cells" and "#size-cells" 
added in the ICE dt which indicates it is bus device so why the tool expects "ranges" prop? Adding "ranges" as a property in ICE node will be wrong since it is not a "bus" device.
> 
> 
> 
> 
Regards
Neeraj

Re: [PATCH v2 0/2] Enable Inline crypto engine for kodiak

[Rob Herring]

On Mon, Jan 19, 2026 at 6:49 AM Neeraj Soni
<neeraj.soni@oss.qualcomm.com> wrote:
>
> Hi,
>
> On 1/14/2026 9:48 PM, Rob Herring wrote:
> >
> > On Wed, 14 Jan 2026 15:18:46 +0530, Neeraj Soni wrote:
> >> Document Inline Crypto Engine (ICE) handle for SDHC and add its device-tree
> >> node to enable it for kodiak.
> >>
> >> How this patch was tested:
> >> - export ARCH=arm64
> >> - export CROSS_COMPILE=aarch64-linux-gnu-
> >> - make menuconfig
> >> - make defconifg
> >> - make DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/sdhci-msm.yaml dt_binding_check
> >> - make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y dtbs
> >>
> >> ---
> >> Changes in v2:
> >> - Removed the "if: required:" description for "qcom,ice" dt-binding
> >>   as the ICE node is optional.
> >> - Corrected the ICE dt node entry according to the dt-binding description.
> >> - Added test details.
> >>
> >> Changes in v1:
> >> - Updated the dt-binding for ICE node.
> >> - Added the dt node for ICE for kodiak.
> >>
> >> Neeraj Soni (2):
> >>   dt-bindings: mmc: sdhci-msm: Add ICE phandle
> >>   arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC
> >>
> >>  Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++++
> >>  arch/arm64/boot/dts/qcom/kodiak.dtsi                 | 9 +++++++++
> >>  2 files changed, 13 insertions(+)
> >>
> >> --
> >> 2.34.1
> >>
> >>
> >>
> >
> >
> > My bot found new DTB warnings on the .dts files added or changed in this
> > series.
> >
> > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> > are fixed by another series. Ultimately, it is up to the platform
> > maintainer whether these warnings are acceptable or not. No need to reply
> > unless the platform maintainer has comments.
> >
> > If you already ran DT checks and didn't see these error(s), then
> > make sure dt-schema is up to date:
> >
> >   pip3 install dtschema --upgrade
> >
> >
> > This patch series was applied (using b4) to base:
> >  Base: attempting to guess base-commit...
> >  Base: tags/v6.19-rc1-102-g3af51501e2b8 (exact match)
> >  Base: tags/v6.19-rc1-102-g3af51501e2b8 (use --merge-base to override)
> >
> > If this is not the correct base, please add 'base-commit' tag
> > (or use b4 which does this automatically)
> >
> > New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20260114094848.3790487-1-neeraj.soni@oss.qualcomm.com:
> >
> > arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/sc7280-herobrine-crd-pro.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: pmic@2 (qcom,pm8350c): pwm:nvmem: [[386, 387]] is too short
> >       from schema $id: http://devicetree.org/schemas/mfd/qcom,spmi-pmic.yaml
> > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: pwm (qcom,pm8350c-pwm): nvmem: [[386, 387]] is too short
> >       from schema $id: http://devicetree.org/schemas/leds/leds-qcom-lpg.yaml
> > arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/qcm6490-idp.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/qcm6490-particle-tachyon.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/sc7280-idp.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/sc7280-idp2.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-lte.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme-lte.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1-lte.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/qcs6490-radxa-dragon-q6a.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> > arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> >       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> >
> The crypto node i added is not a "bus" node but a leaf node for Inline Crypto Engine (ICE). There are no props like "compatible = "simple-bus"" or "#address-cells" and "#size-cells"
> added in the ICE dt which indicates it is bus device so why the tool expects "ranges" prop? Adding "ranges" as a property in ICE node will be wrong since it is not a "bus" device.

The issue is your unit-address is upper case hex.

Rob

Re: [PATCH v2 0/2] Enable Inline crypto engine for kodiak

[Rob Herring]

On Mon, Jan 19, 2026 at 4:04 AM Neeraj Soni
<neeraj.soni@oss.qualcomm.com> wrote:
>
> Hi,
>
> On 1/16/2026 10:24 PM, Krzysztof Kozlowski wrote:
> > On 14/01/2026 17:18, Rob Herring wrote:
> >>
> >> On Wed, 14 Jan 2026 15:18:46 +0530, Neeraj Soni wrote:
> >>> Document Inline Crypto Engine (ICE) handle for SDHC and add its device-tree
> >>> node to enable it for kodiak.
> >>>
> >>> How this patch was tested:
> >>> - export ARCH=arm64
> >>> - export CROSS_COMPILE=aarch64-linux-gnu-
> >>> - make menuconfig
> >>> - make defconifg
> >>> - make DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/sdhci-msm.yaml dt_binding_check
> >>> - make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y dtbs
> >>>
> >>> ---
> >>> Changes in v2:
> >>> - Removed the "if: required:" description for "qcom,ice" dt-binding
> >>>   as the ICE node is optional.
> >>> - Corrected the ICE dt node entry according to the dt-binding description.
> >>> - Added test details.
> >>>
> >
> > Is this another report being ignored by the author? I'll start the list.
> >
> No i did not ignore this. I see this comment in the message:
>
> "Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not.
> No need to reply unless the platform maintainer has comments."

This statement applies when the previous sentences in that paragraph
are true. Those say:

> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series.

You are adding a new node here and there's warnings for that node.
Clearly these are not existing warnings and unlikely fixed by another
series.

Rob

Re: [PATCH v2 0/2] Enable Inline crypto engine for kodiak

[Neeraj Soni]

On 1/20/2026 6:55 AM, Rob Herring wrote:
> On Mon, Jan 19, 2026 at 6:49 AM Neeraj Soni
> <neeraj.soni@oss.qualcomm.com> wrote:
>>
>> Hi,
>>
>> On 1/14/2026 9:48 PM, Rob Herring wrote:
>>>
>>> On Wed, 14 Jan 2026 15:18:46 +0530, Neeraj Soni wrote:
>>>> Document Inline Crypto Engine (ICE) handle for SDHC and add its device-tree
>>>> node to enable it for kodiak.
>>>>
>>>> How this patch was tested:
>>>> - export ARCH=arm64
>>>> - export CROSS_COMPILE=aarch64-linux-gnu-
>>>> - make menuconfig
>>>> - make defconifg
>>>> - make DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/sdhci-msm.yaml dt_binding_check
>>>> - make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y dtbs
>>>>
>>>> ---
>>>> Changes in v2:
>>>> - Removed the "if: required:" description for "qcom,ice" dt-binding
>>>>   as the ICE node is optional.
>>>> - Corrected the ICE dt node entry according to the dt-binding description.
>>>> - Added test details.
>>>>
>>>> Changes in v1:
>>>> - Updated the dt-binding for ICE node.
>>>> - Added the dt node for ICE for kodiak.
>>>>
>>>> Neeraj Soni (2):
>>>>   dt-bindings: mmc: sdhci-msm: Add ICE phandle
>>>>   arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC
>>>>
>>>>  Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++++
>>>>  arch/arm64/boot/dts/qcom/kodiak.dtsi                 | 9 +++++++++
>>>>  2 files changed, 13 insertions(+)
>>>>
>>>> --
>>>> 2.34.1
>>>>
>>>>
>>>>
>>>
>>>
>>> My bot found new DTB warnings on the .dts files added or changed in this
>>> series.
>>>
>>> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
>>> are fixed by another series. Ultimately, it is up to the platform
>>> maintainer whether these warnings are acceptable or not. No need to reply
>>> unless the platform maintainer has comments.
>>>
>>> If you already ran DT checks and didn't see these error(s), then
>>> make sure dt-schema is up to date:
>>>
>>>   pip3 install dtschema --upgrade
>>>
>>>
>>> This patch series was applied (using b4) to base:
>>>  Base: attempting to guess base-commit...
>>>  Base: tags/v6.19-rc1-102-g3af51501e2b8 (exact match)
>>>  Base: tags/v6.19-rc1-102-g3af51501e2b8 (use --merge-base to override)
>>>
>>> If this is not the correct base, please add 'base-commit' tag
>>> (or use b4 which does this automatically)
>>>
>>> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20260114094848.3790487-1-neeraj.soni@oss.qualcomm.com:
>>>
>>> arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/sc7280-herobrine-crd-pro.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: pmic@2 (qcom,pm8350c): pwm:nvmem: [[386, 387]] is too short
>>>       from schema $id: http://devicetree.org/schemas/mfd/qcom,spmi-pmic.yaml
>>> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: pwm (qcom,pm8350c-pwm): nvmem: [[386, 387]] is too short
>>>       from schema $id: http://devicetree.org/schemas/leds/leds-qcom-lpg.yaml
>>> arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/qcm6490-idp.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/qcm6490-particle-tachyon.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/sc7280-idp.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/sc7280-idp2.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-lte.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme-lte.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1-lte.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/qcs6490-radxa-dragon-q6a.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>> arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
>>>       from schema $id: http://devicetree.org/schemas/simple-bus.yaml
>>>
>> The crypto node i added is not a "bus" node but a leaf node for Inline Crypto Engine (ICE). There are no props like "compatible = "simple-bus"" or "#address-cells" and "#size-cells"
>> added in the ICE dt which indicates it is bus device so why the tool expects "ranges" prop? Adding "ranges" as a property in ICE node will be wrong since it is not a "bus" device.
> 
> The issue is your unit-address is upper case hex.
> 
Thanks and i will fix upper case in next patch but the logs are bit confusing to indicate upper case issue as "ranges" prop missing.

> Rob
> 
Regards
Neeraj