Re: [PATCH v2 1/8] PCI: Add pcie_wait_after_link_train() helper

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The header drivers/pci/pci.h fails to include <linux/delay.h> despite using msleep() in a static inline function.
--

commit 3b0eb6b945c6f31bfd19dfe4708d2d2cc57ab371
Author: Hans Zhang <18255117159@163.com>

PCI: Add pcie_wait_after_link_train() helper

This commit introduces a static inline helper pcie_wait_after_link_train()
to enforce a minimum 100 ms wait after Link training completes for downstream
ports supporting speeds greater than 5.0 GT/s. This allows multiple host
controller drivers to share the delay logic.

> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
> index 4a14f88e543a2..a8705a2a2d852 100644
> --- a/drivers/pci/pci.h
> +++ b/drivers/pci/pci.h
> @@ -60,6 +60,19 @@ struct pcie_tlp_log;
>   */
>  #define PCIE_RESET_CONFIG_WAIT_MS	100
>  
> +/**
> + * pcie_wait_after_link_train - Wait 100 ms if link speed > 5 GT/s
> + * @max_link_speed: the maximum link speed (2 = 5.0 GT/s, 3 = 8.0 GT/s, ...)
> + *
> + * Must be called after Link training completes and before the first
> + * Configuration Request is sent.
> + */
> +static inline void pcie_wait_after_link_train(int max_link_speed)
> +{
> +	if (max_link_speed > 2)
> +		msleep(PCIE_RESET_CONFIG_WAIT_MS);

Does this file need to include <linux/delay.h>?

The new helper uses msleep(), but drivers/pci/pci.h does not include
<linux/delay.h>. While this might not cause immediate build failures if
callers already include the header, it could cause implicit function
declaration errors for any future C files that include pci.h without
including <linux/delay.h> first.

> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260506152346.166056-1-18255117159@163.com?part=1