Re: [PATCH v2 4/8] PCI: j721e: Set max_link_speed to enable 100 ms delay after link up

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Compilation error due to incorrect member access operator on pointer `cdns_pcie`.
--

commit 0760ab7da4f40a125fce1efb70ebb7172483b069
Author: Hans Zhang <18255117159@163.com>

PCI: j721e: Set max_link_speed to enable 100 ms delay after link up

This commit sets the max_link_speed property to the maximum supported
link speed from the device tree to activate post-link delay logic. This
ensures a 100 ms delay after link training completes.

> diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c
> index bfdfe98d5aba7..ee85b8e04f5b8 100644
> --- a/drivers/pci/controller/cadence/pci-j721e.c
> +++ b/drivers/pci/controller/cadence/pci-j721e.c
> @@ -206,6 +206,7 @@ static int j721e_pcie_set_link_speed(struct j721e_pcie *pcie,
>  	    (pcie_get_link_speed(link_speed) == PCI_SPEED_UNKNOWN))
>  		link_speed = 2;
>  
> +	pcie->cdns_pcie.max_link_speed = link_speed;

Will this cause a compilation error? Looking at the definition of
struct j721e_pcie, cdns_pcie is declared as a pointer:

struct j721e_pcie {
        struct cdns_pcie *cdns_pcie;
        ...
};

Since cdns_pcie is a pointer, does this code need to use the arrow
operator (pcie->cdns_pcie->max_link_speed) instead of the dot operator
to compile correctly?

>  	val = link_speed - 1;
>  	ret = regmap_update_bits(syscon, offset, GENERATION_SEL_MASK, val);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260506152346.166056-1-18255117159@163.com?part=4