Linux Trace Kernel
 help / color / mirror / Atom feed
* [PATCH] tracing: 'select' GENERIC_TRACER, not 'depends'
@ 2026-11-16 22:46 Brian Norris
  2026-11-16 22:58 ` sashiko-bot
  2026-11-17 13:53 ` Steven Rostedt
  0 siblings, 2 replies; 13+ messages in thread
From: Brian Norris @ 2026-11-16 22:46 UTC (permalink / raw)
  To: Steven Rostedt, Masami Hiramatsu
  Cc: linux-kernel, linux-trace-kernel, Mathieu Desnoyers, Brian Norris

GENERIC_TRACER is not a user-selectable symbol, so it's impossible to
enable FTRACE_STARTUP_TEST unless one also enables some other symbol
that 'selects' GENERIC_TRACER for us.

This very file also suggests:

  All tracer options should select GENERIC_TRACER

So, use 'select', not 'depends on'.

Fixes: 60a11774b38f ("ftrace: add self-tests")
Signed-off-by: Brian Norris <briannorris@chromium.org>
---

 kernel/trace/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 35d043b19332..8084d46ef2a0 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -1135,7 +1135,7 @@ config FTRACE_SELFTEST
 
 config FTRACE_STARTUP_TEST
 	bool "Perform a startup test on ftrace"
-	depends on GENERIC_TRACER
+	select GENERIC_TRACER
 	select FTRACE_SELFTEST
 	help
 	  This option performs a series of startup tests on ftrace. On bootup
-- 
2.56.1.703.gf848ed807c-goog


^ permalink raw reply related	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2026-11-17 21:41 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16 22:46 [PATCH] tracing: 'select' GENERIC_TRACER, not 'depends' Brian Norris
2026-11-16 22:58 ` sashiko-bot
2026-11-17 13:55   ` Steven Rostedt
2026-11-17 18:23     ` Brian Norris
2026-11-17 18:36       ` sashiko-bot
2026-11-17 18:42         ` Brian Norris
2026-11-17 19:22       ` Steven Rostedt
2026-11-17 19:23         ` Steven Rostedt
2026-11-17 20:35           ` Brian Norris
2026-11-17 21:10             ` Steven Rostedt
2026-11-17 21:41               ` Brian Norris
2026-11-17 13:53 ` Steven Rostedt
2026-11-17 17:45   ` Brian Norris

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox