From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs@vger.kernel.org, cem@kernel.org, djwong@kernel.org
Subject: Re: [PATCH 3/3] xfs: re-use refcount scrub/repair code for rtrefcount
Date: Wed, 7 Oct 2026 06:51:17 -0700 [thread overview]
Message-ID: <asZOVQfQU3TpEBgv@infradead.org> (raw)
In-Reply-To: <20261002211038.2139655-4-sandeen@redhat.com>
On Fri, Oct 02, 2026 at 04:08:11PM -0500, Eric Sandeen wrote:
> Some code in scrub/rtrefcount.c is copied from scrub/refcount.c; it
> differs only in function & structure names and a couple types and
> macros, which share the same underlying types and values.
>
> Similarly for code in fs/xfs/scrub/[rt]refcount_repair.c
>
> Export the refcount versions, use them for rtrefcount scrubbing,
Not really an export fortunately :)
> eliminate the copies, and add build-time asserts so that the type/value
> matches mentioned above do not drift.
> 5 files changed, 72 insertions(+), 316 deletions(-)
Nice code savings!
Looks good modulo the commit log nitpick:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-10-07 13:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 21:08 [PATCH 0/3] xfs: more misc code deduplication Eric Sandeen
2026-10-02 21:08 ` [PATCH 1/3] xfs: factor out xfs_dir2_sf_copy_entries helper Eric Sandeen
2026-10-05 12:14 ` Carlos Maiolino
2026-10-07 13:50 ` Christoph Hellwig
2026-10-02 21:08 ` [PATCH 2/3] xfs: factor out xrep_reset_fork_to_extents helper for scrub/repair Eric Sandeen
2026-10-05 13:07 ` Carlos Maiolino
2026-10-05 14:12 ` Eric Sandeen
2026-10-05 19:11 ` [PATCH V2 " Eric Sandeen
2026-10-05 20:20 ` Darrick J. Wong
2026-10-05 20:43 ` Eric Sandeen
2026-10-05 21:17 ` Darrick J. Wong
2026-10-06 8:32 ` Carlos Maiolino
2026-10-07 13:52 ` Christoph Hellwig
2026-10-07 15:25 ` [PATCH V3 " Eric Sandeen
2026-10-08 11:02 ` Carlos Maiolino
2026-10-02 21:08 ` [PATCH 3/3] xfs: re-use refcount scrub/repair code for rtrefcount Eric Sandeen
2026-10-05 20:38 ` Darrick J. Wong
2026-10-06 8:25 ` Carlos Maiolino
2026-10-07 13:51 ` Christoph Hellwig [this message]
2026-10-07 15:32 ` Eric Sandeen
2026-10-07 15:37 ` Darrick J. Wong
2026-10-08 11:15 ` Carlos Maiolino
2026-10-08 11:09 ` Carlos Maiolino
2026-10-08 13:32 ` [PATCH 0/3] xfs: more misc code deduplication Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asZOVQfQU3TpEBgv@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox