From: Christoph Hellwig <hch@infradead.org>
To: Carlos Maiolino <cem@kernel.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
Eric Sandeen <sandeen@redhat.com>,
Eric Sandeen <sandeen@sandeen.net>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH V2 2/3] xfs: factor out xrep_reset_fork_to_extents helper for scrub/repair
Date: Wed, 7 Oct 2026 06:52:44 -0700 [thread overview]
Message-ID: <asZOrBetW814MMDs@infradead.org> (raw)
In-Reply-To: <asSwijU34G7m5RiQ@cronus.toxiclabs.cc>
On Tue, Oct 06, 2026 at 10:32:44AM +0200, Carlos Maiolino wrote:
> > There shouldn't be any, I just thought it looks cleaner. :)
>
> Perhaps...
>
> ilog_flags |= (whichfork == XFS_DATA_FORK ? XFS_ILOG_DDATA : XFS_ILOG_ADATA)
>
> ?
Urgg.
> But the switch indeed looks nicer.
Agreed, switch over if over ternary operator.
But either version is rechnically correct, so for whichever version
lands:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-10-07 13:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 21:08 [PATCH 0/3] xfs: more misc code deduplication Eric Sandeen
2026-10-02 21:08 ` [PATCH 1/3] xfs: factor out xfs_dir2_sf_copy_entries helper Eric Sandeen
2026-10-05 12:14 ` Carlos Maiolino
2026-10-07 13:50 ` Christoph Hellwig
2026-10-02 21:08 ` [PATCH 2/3] xfs: factor out xrep_reset_fork_to_extents helper for scrub/repair Eric Sandeen
2026-10-05 13:07 ` Carlos Maiolino
2026-10-05 14:12 ` Eric Sandeen
2026-10-05 19:11 ` [PATCH V2 " Eric Sandeen
2026-10-05 20:20 ` Darrick J. Wong
2026-10-05 20:43 ` Eric Sandeen
2026-10-05 21:17 ` Darrick J. Wong
2026-10-06 8:32 ` Carlos Maiolino
2026-10-07 13:52 ` Christoph Hellwig [this message]
2026-10-07 15:25 ` [PATCH V3 " Eric Sandeen
2026-10-08 11:02 ` Carlos Maiolino
2026-10-02 21:08 ` [PATCH 3/3] xfs: re-use refcount scrub/repair code for rtrefcount Eric Sandeen
2026-10-05 20:38 ` Darrick J. Wong
2026-10-06 8:25 ` Carlos Maiolino
2026-10-07 13:51 ` Christoph Hellwig
2026-10-07 15:32 ` Eric Sandeen
2026-10-07 15:37 ` Darrick J. Wong
2026-10-08 11:15 ` Carlos Maiolino
2026-10-08 11:09 ` Carlos Maiolino
2026-10-08 13:32 ` [PATCH 0/3] xfs: more misc code deduplication Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asZOrBetW814MMDs@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox