Re: [PATCH 2/3] xfs: factor out xrep_reset_fork_to_extents helper for scrub/repair

[Eric Sandeen <sandeen@redhat.com>]

On 10/5/26 8:07 AM, Carlos Maiolino wrote:
> On Fri, Oct 02, 2026 at 04:08:10PM -0500, Eric Sandeen wrote:
>> The open-coded 8-line series of steps to reset a fork to empty extents
>> format is repeated 3 times; factor this out into a helper to eliminate
>> cut and paste.
>>
>> +/* Discard the contents of this fork and initialize as empty extent-format. */
>> +void
>> +xrep_reset_fork_to_extents(
>> +	struct xfs_scrub	*sc,
>> +	int			whichfork)
>> +{
>> +	struct xfs_ifork	*ifp = xfs_ifork_ptr(sc->ip, whichfork);
>> +
>> +	xfs_idestroy_fork(ifp);
>> +	ifp->if_format = XFS_DINODE_FMT_EXTENTS;
>> +	ifp->if_nextents = 0;
>> +	ifp->if_bytes = 0;
>> +	ifp->if_data = NULL;
>> +	ifp->if_height = 0;
>> +}
> 
> Why not also move xfs_trans_log_inode() here?
> Sure it will need to use a different flag depending on the fork type,
> but then the whole reset and log will be contained within there.
> 
Hm yeah, could do. I don't know if hiding the logging in the helper obfuscates
things or not. Any others have thoughts? (I can see if there's precedent for
whether logging should happen in the main flow or in a helper elsewhere, too.)

Thanks,
-Eric