[PATCH 0/8] staging: rtl8723bs: remove warnings in rtw_btcoex.h

[PATCH 0/8] staging: rtl8723bs: remove warnings in rtw_btcoex.h

[Linus Probert]

This series eliminates all remaining checkpatch warnings in
rtw_btcoex.h. Such as CamelCase, redundant blank lines and unnamed
function definition arguments.

Linus Probert (8):
  staging: rtl8723bs: remove blank line in rtw_btcoex.h
  staging: rtl8723bs: add function definition arg names to rtw_btcoex.h
  staging: rtl8723bs: rename rtw_btcoex_MediaStatusNotify()
  staging: rtl8723bs: rename rtw_btcoex_media_status_notify definition arg
  staging: rtl8723bs: rtw_btcoex_HaltNotify() -> rtw_btcoex_halt_notify()
  staging: rtl8723bs: rename rtw_btcoex_RejectApAggregatedPacket()
  staging: rtl8723bs: rtw_btcoex_LPS_Enter() -> rtw_btcoex_lps_enter()
  staging: rtl8723bs: rename rtw_btcoex_LPS_Leave to rtw_btcoex_lps_leave

 drivers/staging/rtl8723bs/core/rtw_ap.c        |  2 +-
 drivers/staging/rtl8723bs/core/rtw_btcoex.c    | 10 +++++-----
 drivers/staging/rtl8723bs/core/rtw_cmd.c       |  4 ++--
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c  |  2 +-
 drivers/staging/rtl8723bs/hal/hal_btcoex.c     | 12 ++++++------
 drivers/staging/rtl8723bs/include/rtw_btcoex.h | 11 +++++------
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c   |  2 +-
 7 files changed, 21 insertions(+), 22 deletions(-)

-- 
2.54.0

[PATCH 1/8] staging: rtl8723bs: remove blank line in rtw_btcoex.h

[Linus Probert]

Removes redundant blank line in rtw_btcoex.h.
Found using checkpatch.pl.

Signed-off-by: Linus Probert <linus.probert@gmail.com>
---
 drivers/staging/rtl8723bs/include/rtw_btcoex.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/include/rtw_btcoex.h b/drivers/staging/rtl8723bs/include/rtw_btcoex.h
index 19764c80b8ba..5554118bbe36 100644
--- a/drivers/staging/rtl8723bs/include/rtw_btcoex.h
+++ b/drivers/staging/rtl8723bs/include/rtw_btcoex.h
@@ -9,7 +9,6 @@
 
 #include <drv_types.h>
 
-
 #define	PACKET_NORMAL			0
 #define	PACKET_DHCP				1
 #define	PACKET_ARP				2
-- 
2.54.0

[PATCH 2/8] staging: rtl8723bs: add function definition arg names to rtw_btcoex.h

[Linus Probert]

Adds function definition argument names to rtw_btcoex.h in order to
conform to kernel code style. This eliminates warnings generated by
checkpatch.pl.

In all cases it's the 'struct adapter *' argument which has been given
the name 'padapter'. This matches the names used in the implementations
of these functions.

Signed-off-by: Linus Probert <linus.probert@gmail.com>
---
 drivers/staging/rtl8723bs/include/rtw_btcoex.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/rtw_btcoex.h b/drivers/staging/rtl8723bs/include/rtw_btcoex.h
index 5554118bbe36..df939b20867b 100644
--- a/drivers/staging/rtl8723bs/include/rtw_btcoex.h
+++ b/drivers/staging/rtl8723bs/include/rtw_btcoex.h
@@ -14,14 +14,14 @@
 #define	PACKET_ARP				2
 #define	PACKET_EAPOL			3
 
-void rtw_btcoex_MediaStatusNotify(struct adapter *, u8 mediaStatus);
-void rtw_btcoex_HaltNotify(struct adapter *);
+void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 mediaStatus);
+void rtw_btcoex_HaltNotify(struct adapter *padapter);
 
 /*  ================================================== */
 /*  Below Functions are called by BT-Coex */
 /*  ================================================== */
-void rtw_btcoex_RejectApAggregatedPacket(struct adapter *, u8 enable);
-void rtw_btcoex_LPS_Enter(struct adapter *);
-void rtw_btcoex_LPS_Leave(struct adapter *);
+void rtw_btcoex_RejectApAggregatedPacket(struct adapter *padapter, u8 enable);
+void rtw_btcoex_LPS_Enter(struct adapter *padapter);
+void rtw_btcoex_LPS_Leave(struct adapter *padapter);
 
 #endif /*  __RTW_BTCOEX_H__ */
-- 
2.54.0

[PATCH 3/8] staging: rtl8723bs: rename rtw_btcoex_MediaStatusNotify()

[Linus Probert]

Renames function rtw_btcoex_MediaStatusNotify to
rtw_btcoex_media_status_notify which removes CamelCase in order to
conform to kernel code style.

Issue found using checkpatch.pl

Signed-off-by: Linus Probert <linus.probert@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ap.c        | 2 +-
 drivers/staging/rtl8723bs/core/rtw_btcoex.c    | 2 +-
 drivers/staging/rtl8723bs/core/rtw_cmd.c       | 4 ++--
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c  | 2 +-
 drivers/staging/rtl8723bs/include/rtw_btcoex.h | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 4b4012411011..5c325626f291 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -2105,5 +2105,5 @@ void stop_ap_mode(struct adapter *padapter)
 
 	rtw_free_mlme_priv_ie_data(pmlmepriv);
 
-	rtw_btcoex_MediaStatusNotify(padapter, 0); /* disconnect */
+	rtw_btcoex_media_status_notify(padapter, 0); /* disconnect */
 }
diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
index 0191a943f0a4..961c034ef719 100644
--- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c
+++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
@@ -8,7 +8,7 @@
 #include <rtw_btcoex.h>
 #include <hal_btcoex.h>
 
-void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 media_status)
+void rtw_btcoex_media_status_notify(struct adapter *padapter, u8 media_status)
 {
 	if ((media_status == RT_MEDIA_CONNECT)
 		&& (check_fwstate(&padapter->mlmepriv, WIFI_AP_STATE) == true)) {
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index c1185c25ed36..14d4d4276dac 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -1291,11 +1291,11 @@ void lps_ctrl_wk_hdl(struct adapter *padapter, u8 lps_ctrl_type)
 		/*  Reset LPS Setting */
 		pwrpriv->LpsIdleCount = 0;
 		rtw_hal_set_hwreg(padapter, HW_VAR_H2C_FW_JOINBSSRPT, (u8 *)(&mstatus));
-		rtw_btcoex_MediaStatusNotify(padapter, mstatus);
+		rtw_btcoex_media_status_notify(padapter, mstatus);
 		break;
 	case LPS_CTRL_DISCONNECT:
 		mstatus = 0;/* disconnect */
-		rtw_btcoex_MediaStatusNotify(padapter, mstatus);
+		rtw_btcoex_media_status_notify(padapter, mstatus);
 		LPS_Leave(padapter, "LPS_CTRL_DISCONNECT");
 		rtw_hal_set_hwreg(padapter, HW_VAR_H2C_FW_JOINBSSRPT, (u8 *)(&mstatus));
 		break;
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index 5f00fe282d1b..3f087ea94b7e 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -5191,7 +5191,7 @@ u8 setopmode_hdl(struct adapter *padapter, u8 *pbuf)
 	if (psetop->mode == Ndis802_11APMode) {
 		/*  Do this after port switch to */
 		/*  prevent from downloading rsvd page to wrong port */
-		rtw_btcoex_MediaStatusNotify(padapter, 1); /* connect */
+		rtw_btcoex_media_status_notify(padapter, 1); /* connect */
 	}
 
 	return H2C_SUCCESS;
diff --git a/drivers/staging/rtl8723bs/include/rtw_btcoex.h b/drivers/staging/rtl8723bs/include/rtw_btcoex.h
index df939b20867b..524f0fba294d 100644
--- a/drivers/staging/rtl8723bs/include/rtw_btcoex.h
+++ b/drivers/staging/rtl8723bs/include/rtw_btcoex.h
@@ -14,7 +14,7 @@
 #define	PACKET_ARP				2
 #define	PACKET_EAPOL			3
 
-void rtw_btcoex_MediaStatusNotify(struct adapter *padapter, u8 mediaStatus);
+void rtw_btcoex_media_status_notify(struct adapter *padapter, u8 mediaStatus);
 void rtw_btcoex_HaltNotify(struct adapter *padapter);
 
 /*  ================================================== */
-- 
2.54.0

[PATCH 4/8] staging: rtl8723bs: rename rtw_btcoex_media_status_notify definition arg

[Linus Probert]

Renames rtw_btcoex_media_status_notify_definition argument mediaStatus
to media_status in order to conform to kernel code style.

This was found using checkpatch.pl

Signed-off-by: Linus Probert <linus.probert@gmail.com>
---
 drivers/staging/rtl8723bs/include/rtw_btcoex.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/include/rtw_btcoex.h b/drivers/staging/rtl8723bs/include/rtw_btcoex.h
index 524f0fba294d..6eced86d6623 100644
--- a/drivers/staging/rtl8723bs/include/rtw_btcoex.h
+++ b/drivers/staging/rtl8723bs/include/rtw_btcoex.h
@@ -14,7 +14,7 @@
 #define	PACKET_ARP				2
 #define	PACKET_EAPOL			3
 
-void rtw_btcoex_media_status_notify(struct adapter *padapter, u8 mediaStatus);
+void rtw_btcoex_media_status_notify(struct adapter *padapter, u8 media_status);
 void rtw_btcoex_HaltNotify(struct adapter *padapter);
 
 /*  ================================================== */
-- 
2.54.0

[PATCH 5/8] staging: rtl8723bs: rtw_btcoex_HaltNotify() -> rtw_btcoex_halt_notify()

[Linus Probert]

Renames function rtw_btcoex_HaltNotify to rtw_btcoex_halt_notify in
order to conform to kernel code style.

Found using checkpatch.pl.

Signed-off-by: Linus Probert <linus.probert@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_btcoex.c    | 2 +-
 drivers/staging/rtl8723bs/include/rtw_btcoex.h | 2 +-
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
index 961c034ef719..24184c8d34de 100644
--- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c
+++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
@@ -18,7 +18,7 @@ void rtw_btcoex_media_status_notify(struct adapter *padapter, u8 media_status)
 	hal_btcoex_MediaStatusNotify(padapter, media_status);
 }
 
-void rtw_btcoex_HaltNotify(struct adapter *padapter)
+void rtw_btcoex_halt_notify(struct adapter *padapter)
 {
 	if (!padapter->bup)
 		return;
diff --git a/drivers/staging/rtl8723bs/include/rtw_btcoex.h b/drivers/staging/rtl8723bs/include/rtw_btcoex.h
index 6eced86d6623..d9ed8f2d8d14 100644
--- a/drivers/staging/rtl8723bs/include/rtw_btcoex.h
+++ b/drivers/staging/rtl8723bs/include/rtw_btcoex.h
@@ -15,7 +15,7 @@
 #define	PACKET_EAPOL			3
 
 void rtw_btcoex_media_status_notify(struct adapter *padapter, u8 media_status);
-void rtw_btcoex_HaltNotify(struct adapter *padapter);
+void rtw_btcoex_halt_notify(struct adapter *padapter);
 
 /*  ================================================== */
 /*  Below Functions are called by BT-Coex */
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index d0feb28b7043..29cc97b29d0b 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -401,7 +401,7 @@ static void rtw_dev_remove(struct sdio_func *func)
 
 	LeaveAllPowerSaveMode(padapter);
 
-	rtw_btcoex_HaltNotify(padapter);
+	rtw_btcoex_halt_notify(padapter);
 
 	rtw_sdio_if1_deinit(padapter);
 
-- 
2.54.0

[PATCH 6/8] staging: rtl8723bs: rename rtw_btcoex_RejectApAggregatedPacket()

[Linus Probert]

Renames rtw_btcoex_RejectApAggregatedPacket to
rtw_btcoex_reject_ap_aggregated_packet in order to conform to kernel
code style.

Found using checkpatch.pl.

Signed-off-by: Linus Probert <linus.probert@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_btcoex.c    | 2 +-
 drivers/staging/rtl8723bs/hal/hal_btcoex.c     | 6 +++---
 drivers/staging/rtl8723bs/include/rtw_btcoex.h | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
index 24184c8d34de..2528520262a6 100644
--- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c
+++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
@@ -32,7 +32,7 @@ void rtw_btcoex_halt_notify(struct adapter *padapter)
 /*  ================================================== */
 /*  Below Functions are called by BT-Coex */
 /*  ================================================== */
-void rtw_btcoex_RejectApAggregatedPacket(struct adapter *padapter, u8 enable)
+void rtw_btcoex_reject_ap_aggregated_packet(struct adapter *padapter, u8 enable)
 {
 	struct mlme_ext_info *pmlmeinfo;
 	struct sta_info *psta;
diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
index 2a2dd60be8bb..77c474919ffc 100644
--- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
+++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
@@ -134,7 +134,7 @@ static void halbtcoutsrc_AggregationCheck(struct btc_coexist *pBtCoexist)
 	bNeedToAct = false;
 
 	if (pBtCoexist->btInfo.bRejectAggPkt) {
-		rtw_btcoex_RejectApAggregatedPacket(padapter, true);
+		rtw_btcoex_reject_ap_aggregated_packet(padapter, true);
 	} else {
 		if (pBtCoexist->btInfo.bPreBtCtrlAggBufSize !=
 			pBtCoexist->btInfo.bBtCtrlAggBufSize) {
@@ -151,8 +151,8 @@ static void halbtcoutsrc_AggregationCheck(struct btc_coexist *pBtCoexist)
 		}
 
 		if (bNeedToAct) {
-			rtw_btcoex_RejectApAggregatedPacket(padapter, true);
-			rtw_btcoex_RejectApAggregatedPacket(padapter, false);
+			rtw_btcoex_reject_ap_aggregated_packet(padapter, true);
+			rtw_btcoex_reject_ap_aggregated_packet(padapter, false);
 		}
 	}
 }
diff --git a/drivers/staging/rtl8723bs/include/rtw_btcoex.h b/drivers/staging/rtl8723bs/include/rtw_btcoex.h
index d9ed8f2d8d14..61a67360af00 100644
--- a/drivers/staging/rtl8723bs/include/rtw_btcoex.h
+++ b/drivers/staging/rtl8723bs/include/rtw_btcoex.h
@@ -20,7 +20,7 @@ void rtw_btcoex_halt_notify(struct adapter *padapter);
 /*  ================================================== */
 /*  Below Functions are called by BT-Coex */
 /*  ================================================== */
-void rtw_btcoex_RejectApAggregatedPacket(struct adapter *padapter, u8 enable);
+void rtw_btcoex_reject_ap_aggregated_packet(struct adapter *padapter, u8 enable);
 void rtw_btcoex_LPS_Enter(struct adapter *padapter);
 void rtw_btcoex_LPS_Leave(struct adapter *padapter);
 
-- 
2.54.0

[PATCH 7/8] staging: rtl8723bs: rtw_btcoex_LPS_Enter() -> rtw_btcoex_lps_enter()

[Linus Probert]

Renames rtw_btcoex_LPS_Enter to rtw_btcoex_lps_enter in order to conform
to kernel code style.

Found using checkpatch.pl.

Signed-off-by: Linus Probert <linus.probert@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_btcoex.c    | 2 +-
 drivers/staging/rtl8723bs/hal/hal_btcoex.c     | 2 +-
 drivers/staging/rtl8723bs/include/rtw_btcoex.h | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
index 2528520262a6..abdeae7ab861 100644
--- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c
+++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
@@ -49,7 +49,7 @@ void rtw_btcoex_reject_ap_aggregated_packet(struct adapter *padapter, u8 enable)
 	}
 }
 
-void rtw_btcoex_LPS_Enter(struct adapter *padapter)
+void rtw_btcoex_lps_enter(struct adapter *padapter)
 {
 	struct pwrctrl_priv *pwrpriv;
 	u8 lps_val;
diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
index 77c474919ffc..fc977d5497c4 100644
--- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
+++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
@@ -49,7 +49,7 @@ static void halbtcoutsrc_EnterLps(struct btc_coexist *pBtCoexist)
 	pBtCoexist->btInfo.bBtCtrlLps = true;
 	pBtCoexist->btInfo.bBtLpsOn = true;
 
-	rtw_btcoex_LPS_Enter(padapter);
+	rtw_btcoex_lps_enter(padapter);
 }
 
 static void halbtcoutsrc_NormalLps(struct btc_coexist *pBtCoexist)
diff --git a/drivers/staging/rtl8723bs/include/rtw_btcoex.h b/drivers/staging/rtl8723bs/include/rtw_btcoex.h
index 61a67360af00..22010239515a 100644
--- a/drivers/staging/rtl8723bs/include/rtw_btcoex.h
+++ b/drivers/staging/rtl8723bs/include/rtw_btcoex.h
@@ -21,7 +21,7 @@ void rtw_btcoex_halt_notify(struct adapter *padapter);
 /*  Below Functions are called by BT-Coex */
 /*  ================================================== */
 void rtw_btcoex_reject_ap_aggregated_packet(struct adapter *padapter, u8 enable);
-void rtw_btcoex_LPS_Enter(struct adapter *padapter);
+void rtw_btcoex_lps_enter(struct adapter *padapter);
 void rtw_btcoex_LPS_Leave(struct adapter *padapter);
 
 #endif /*  __RTW_BTCOEX_H__ */
-- 
2.54.0

[PATCH 8/8] staging: rtl8723bs: rename rtw_btcoex_LPS_Leave to rtw_btcoex_lps_leave

[Linus Probert]

Renames rtw_btcoex_LPS_Leave to rtw_btcoex_lps_leave in order to conform
to kernel code style.

Found using checkpatch.pl.

Signed-off-by: Linus Probert <linus.probert@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_btcoex.c    | 2 +-
 drivers/staging/rtl8723bs/hal/hal_btcoex.c     | 4 ++--
 drivers/staging/rtl8723bs/include/rtw_btcoex.h | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_btcoex.c b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
index abdeae7ab861..d12a65bb3eb7 100644
--- a/drivers/staging/rtl8723bs/core/rtw_btcoex.c
+++ b/drivers/staging/rtl8723bs/core/rtw_btcoex.c
@@ -61,7 +61,7 @@ void rtw_btcoex_lps_enter(struct adapter *padapter)
 	rtw_set_ps_mode(padapter, PS_MODE_MIN, 0, lps_val, "BTCOEX");
 }
 
-void rtw_btcoex_LPS_Leave(struct adapter *padapter)
+void rtw_btcoex_lps_leave(struct adapter *padapter)
 {
 	struct pwrctrl_priv *pwrpriv;
 
diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
index fc977d5497c4..81d25a4404c1 100644
--- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
+++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
@@ -36,7 +36,7 @@ static void halbtcoutsrc_LeaveLps(struct btc_coexist *pBtCoexist)
 	pBtCoexist->btInfo.bBtCtrlLps = true;
 	pBtCoexist->btInfo.bBtLpsOn = false;
 
-	rtw_btcoex_LPS_Leave(padapter);
+	rtw_btcoex_lps_leave(padapter);
 }
 
 static void halbtcoutsrc_EnterLps(struct btc_coexist *pBtCoexist)
@@ -60,7 +60,7 @@ static void halbtcoutsrc_NormalLps(struct btc_coexist *pBtCoexist)
 
 	if (pBtCoexist->btInfo.bBtCtrlLps) {
 		pBtCoexist->btInfo.bBtLpsOn = false;
-		rtw_btcoex_LPS_Leave(padapter);
+		rtw_btcoex_lps_leave(padapter);
 		pBtCoexist->btInfo.bBtCtrlLps = false;
 
 		/*  recover the LPS state to the original */
diff --git a/drivers/staging/rtl8723bs/include/rtw_btcoex.h b/drivers/staging/rtl8723bs/include/rtw_btcoex.h
index 22010239515a..765103498789 100644
--- a/drivers/staging/rtl8723bs/include/rtw_btcoex.h
+++ b/drivers/staging/rtl8723bs/include/rtw_btcoex.h
@@ -22,6 +22,6 @@ void rtw_btcoex_halt_notify(struct adapter *padapter);
 /*  ================================================== */
 void rtw_btcoex_reject_ap_aggregated_packet(struct adapter *padapter, u8 enable);
 void rtw_btcoex_lps_enter(struct adapter *padapter);
-void rtw_btcoex_LPS_Leave(struct adapter *padapter);
+void rtw_btcoex_lps_leave(struct adapter *padapter);
 
 #endif /*  __RTW_BTCOEX_H__ */
-- 
2.54.0

Re: [PATCH 0/8] staging: rtl8723bs: remove warnings in rtw_btcoex.h

[Luka Gejak]

> This series eliminates all remaining checkpatch warnings in
> rtw_btcoex.h. Such as CamelCase, redundant blank lines and unnamed
> function definition arguments.
> 
> Linus Probert (8):
>   staging: rtl8723bs: remove blank line in rtw_btcoex.h
>   staging: rtl8723bs: add function definition arg names to rtw_btcoex.h
>   staging: rtl8723bs: rename rtw_btcoex_MediaStatusNotify()
>   staging: rtl8723bs: rename rtw_btcoex_media_status_notify definition arg
>   staging: rtl8723bs: rtw_btcoex_HaltNotify() -> rtw_btcoex_halt_notify()
>   staging: rtl8723bs: rename rtw_btcoex_RejectApAggregatedPacket()
>   staging: rtl8723bs: rtw_btcoex_LPS_Enter() -> rtw_btcoex_lps_enter()
>   staging: rtl8723bs: rename rtw_btcoex_LPS_Leave to rtw_btcoex_lps_leave
> 
>  drivers/staging/rtl8723bs/core/rtw_ap.c        |  2 +-
>  drivers/staging/rtl8723bs/core/rtw_btcoex.c    | 10 +++++-----
>  drivers/staging/rtl8723bs/core/rtw_cmd.c       |  4 ++--
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c  |  2 +-
>  drivers/staging/rtl8723bs/hal/hal_btcoex.c     | 12 ++++++------
>  drivers/staging/rtl8723bs/include/rtw_btcoex.h | 11 +++++------
>  drivers/staging/rtl8723bs/os_dep/sdio_intf.c   |  2 +-
>  7 files changed, 21 insertions(+), 22 deletions(-)
> 
> -- 
> 2.54.0
>

LGTM, so for the patch series:

Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Best regards,
Luka Gejak

Re: [PATCH 0/8] staging: rtl8723bs: remove warnings in rtw_btcoex.h

[Luka Gejak]

On April 29, 2026 12:18:12 PM GMT+02:00, Luka Gejak <luka.gejak@linux.dev> wrote:
>> This series eliminates all remaining checkpatch warnings in
>> rtw_btcoex.h. Such as CamelCase, redundant blank lines and unnamed
>> function definition arguments.
>> 
>> Linus Probert (8):
>>   staging: rtl8723bs: remove blank line in rtw_btcoex.h
>>   staging: rtl8723bs: add function definition arg names to rtw_btcoex.h
>>   staging: rtl8723bs: rename rtw_btcoex_MediaStatusNotify()
>>   staging: rtl8723bs: rename rtw_btcoex_media_status_notify definition arg
>>   staging: rtl8723bs: rtw_btcoex_HaltNotify() -> rtw_btcoex_halt_notify()
>>   staging: rtl8723bs: rename rtw_btcoex_RejectApAggregatedPacket()
>>   staging: rtl8723bs: rtw_btcoex_LPS_Enter() -> rtw_btcoex_lps_enter()
>>   staging: rtl8723bs: rename rtw_btcoex_LPS_Leave to rtw_btcoex_lps_leave
>> 
>>  drivers/staging/rtl8723bs/core/rtw_ap.c        |  2 +-
>>  drivers/staging/rtl8723bs/core/rtw_btcoex.c    | 10 +++++-----
>>  drivers/staging/rtl8723bs/core/rtw_cmd.c       |  4 ++--
>>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c  |  2 +-
>>  drivers/staging/rtl8723bs/hal/hal_btcoex.c     | 12 ++++++------
>>  drivers/staging/rtl8723bs/include/rtw_btcoex.h | 11 +++++------
>>  drivers/staging/rtl8723bs/os_dep/sdio_intf.c   |  2 +-
>>  7 files changed, 21 insertions(+), 22 deletions(-)
>> 
>> -- 
>> 2.54.0
>>
>
>LGTM, so for the patch series:
>
>Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
>
>Best regards,
>Luka Gejak

One note:
For the future cleanup series, feel free to squash identical logical 
changes into a single patch to keep the commit history concise. It's 
up to Greg if he wants v2 but logic is sound as is.
Best regards,
Luka Gejak

Re: [PATCH 0/8] staging: rtl8723bs: remove warnings in rtw_btcoex.h

[Linus Probert]

On 2026-04-29 12:24:53+02:00, Luka Gejak wrote:
> On April 29, 2026 12:18:12 PM GMT+02:00, Luka Gejak <luka.gejak@linux.dev> wrote:
> 
> >> This series eliminates all remaining checkpatch warnings in
> >
> >LGTM, so for the patch series:
> >
> >Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
> >
> >Best regards,
> >Luka Gejak
> 
> One note:
> For the future cleanup series, feel free to squash identical logical 
> changes into a single patch to keep the commit history concise. It's 
> up to Greg if he wants v2 but logic is sound as is.
> Best regards,
> Luka Gejak

I will make a note of that. In this case what do you consider an
identical logical change? What would you suggest that I squash?

Br,
Linus

Re: [PATCH 0/8] staging: rtl8723bs: remove warnings in rtw_btcoex.h

[Luka Gejak]

On April 29, 2026 12:46:27 PM GMT+02:00, Linus Probert <linus.probert@gmail.com> wrote:
>On 2026-04-29 12:24:53+02:00, Luka Gejak wrote:
>> On April 29, 2026 12:18:12 PM GMT+02:00, Luka Gejak <luka.gejak@linux.dev> wrote:
>> 
>> >> This series eliminates all remaining checkpatch warnings in
>> >
>> >LGTM, so for the patch series:
>> >
>> >Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
>> >
>> >Best regards,
>> >Luka Gejak
>> 
>> One note:
>> For the future cleanup series, feel free to squash identical logical 
>> changes into a single patch to keep the commit history concise. It's 
>> up to Greg if he wants v2 but logic is sound as is.
>> Best regards,
>> Luka Gejak
>
>I will make a note of that. In this case what do you consider an
>identical logical change? What would you suggest that I squash?
>
>Br,
>Linus
>

A logical change refers to the type of cleanup being done. In your 
series, patches 3-8 all do the exact same thing: fix CamelCase names 
for functions defined in rtw_btcoex.h. Instead of 6 separate commits, 
those could be squashed into a single patch. But as I already said it 
is up to Greg if he wants v2 or if he wants to keep v1 as is. Either 
way code itself is good.
Best regards,
Luka Gejak

Re: [PATCH 0/8] staging: rtl8723bs: remove warnings in rtw_btcoex.h

[Dan Carpenter]

On Wed, Apr 29, 2026 at 01:34:41PM +0200, Luka Gejak wrote:
> On April 29, 2026 12:46:27 PM GMT+02:00, Linus Probert <linus.probert@gmail.com> wrote:
> >On 2026-04-29 12:24:53+02:00, Luka Gejak wrote:
> >> On April 29, 2026 12:18:12 PM GMT+02:00, Luka Gejak <luka.gejak@linux.dev> wrote:
> >> 
> >> >> This series eliminates all remaining checkpatch warnings in
> >> >
> >> >LGTM, so for the patch series:
> >> >
> >> >Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
> >> >
> >> >Best regards,
> >> >Luka Gejak
> >> 
> >> One note:
> >> For the future cleanup series, feel free to squash identical logical 
> >> changes into a single patch to keep the commit history concise. It's 
> >> up to Greg if he wants v2 but logic is sound as is.
> >> Best regards,
> >> Luka Gejak
> >
> >I will make a note of that. In this case what do you consider an
> >identical logical change? What would you suggest that I squash?
> >
> >Br,
> >Linus
> >
> 
> A logical change refers to the type of cleanup being done. In your 
> series, patches 3-8 all do the exact same thing: fix CamelCase names 
> for functions defined in rtw_btcoex.h. Instead of 6 separate commits, 
> those could be squashed into a single patch. But as I already said it 
> is up to Greg if he wants v2 or if he wants to keep v1 as is. Either 
> way code itself is good.

Greg has said in the past he prefers them all as separate changes the
way this patchset does it.  He recently asked somone to split up a
typedef patch into one typedef per patch.

regards,
dan carpenter

Re: [PATCH 0/8] staging: rtl8723bs: remove warnings in rtw_btcoex.h

[Luka Gejak]

On April 29, 2026 2:06:30 PM GMT+02:00, Dan Carpenter <error27@gmail.com> wrote:
>On Wed, Apr 29, 2026 at 01:34:41PM +0200, Luka Gejak wrote:
>> On April 29, 2026 12:46:27 PM GMT+02:00, Linus Probert <linus.probert@gmail.com> wrote:
>> >On 2026-04-29 12:24:53+02:00, Luka Gejak wrote:
>> >> On April 29, 2026 12:18:12 PM GMT+02:00, Luka Gejak <luka.gejak@linux.dev> wrote:
>> >> 
>> >> >> This series eliminates all remaining checkpatch warnings in
>> >> >
>> >> >LGTM, so for the patch series:
>> >> >
>> >> >Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
>> >> >
>> >> >Best regards,
>> >> >Luka Gejak
>> >> 
>> >> One note:
>> >> For the future cleanup series, feel free to squash identical logical 
>> >> changes into a single patch to keep the commit history concise. It's 
>> >> up to Greg if he wants v2 but logic is sound as is.
>> >> Best regards,
>> >> Luka Gejak
>> >
>> >I will make a note of that. In this case what do you consider an
>> >identical logical change? What would you suggest that I squash?
>> >
>> >Br,
>> >Linus
>> >
>> 
>> A logical change refers to the type of cleanup being done. In your 
>> series, patches 3-8 all do the exact same thing: fix CamelCase names 
>> for functions defined in rtw_btcoex.h. Instead of 6 separate commits, 
>> those could be squashed into a single patch. But as I already said it 
>> is up to Greg if he wants v2 or if he wants to keep v1 as is. Either 
>> way code itself is good.
>
>Greg has said in the past he prefers them all as separate changes the
>way this patchset does it.  He recently asked somone to split up a
>typedef patch into one typedef per patch.
>
>regards,
>dan carpenter
>

Thanks for that information Dan, I wasn't awear of that.
Best regards,
Luka Gejak

Re: [PATCH 0/8] staging: rtl8723bs: remove warnings in rtw_btcoex.h

[Linus Probert]

On 2026-04-29 14:18:55+02:00, Luka Gejak wrote:
> On April 29, 2026 2:06:30 PM GMT+02:00, Dan Carpenter <error27@gmail.com> wrote:
> 
> >On Wed, Apr 29, 2026 at 01:34:41PM +0200, Luka Gejak wrote:
> >
> >Greg has said in the past he prefers them all as separate changes the
> >way this patchset does it.  He recently asked somone to split up a
> >typedef patch into one typedef per patch.
> >
> >regards,
> >dan carpenter
> 
> Thanks for that information Dan, I wasn't awear of that.
> Best regards,
> Luka Gejak

Thanks, then I did understand your suggestion correctly. Just wasn't
sure. As Dan stated I've learnt that Greg prefers one commit per function
for these cases.

Thanks,
Linus

Re: [PATCH 0/8] staging: rtl8723bs: remove warnings in rtw_btcoex.h

[Greg KH]

On Wed, Apr 29, 2026 at 02:51:06PM +0200, Linus Probert wrote:
> On 2026-04-29 14:18:55+02:00, Luka Gejak wrote:
> > On April 29, 2026 2:06:30 PM GMT+02:00, Dan Carpenter <error27@gmail.com> wrote:
> > 
> > >On Wed, Apr 29, 2026 at 01:34:41PM +0200, Luka Gejak wrote:
> > >
> > >Greg has said in the past he prefers them all as separate changes the
> > >way this patchset does it.  He recently asked somone to split up a
> > >typedef patch into one typedef per patch.
> > >
> > >regards,
> > >dan carpenter
> > 
> > Thanks for that information Dan, I wasn't awear of that.
> > Best regards,
> > Luka Gejak
> 
> Thanks, then I did understand your suggestion correctly. Just wasn't
> sure. As Dan stated I've learnt that Greg prefers one commit per function
> for these cases.

Yes, this is great, thanks!

greg k-h