Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line

Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1456 bytes --]



On Tue, 13 Sep 2016, Namrata A Shettar wrote:

> This patch removes an unnecessary blank line that caused checkpatch issue.

Actually, commit messages and subject lines should be written in the
imperative.  So you should say eg

Remove unnecessary blank line

instead of

Removes unnecessary blank line

julia

>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
> Changes in v2:
>   - Changed the subject line
>   - Changed description of patch
>
>  drivers/staging/comedi/comedi_pcmcia.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_pcmcia.c
> b/drivers/staging/comedi/comedi_pcmcia.c
> index d7072a5..ec8a0ad 100644
> --- a/drivers/staging/comedi/comedi_pcmcia.c
> +++ b/drivers/staging/comedi/comedi_pcmcia.c
> @@ -18,7 +18,6 @@
>
>  #include <linux/module.h>
>  #include <linux/kernel.h>
> -
>  #include "comedi_pcmcia.h"
>
>  /**
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAFrQyDErWX1NgsruZtt10hi
> hZR2J3cvK-Q9Zj_dp_GLc_0mLmA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line

[Arnd Bergmann]

On Tuesday, September 13, 2016 11:51:53 AM CEST Namrata A Shettar wrote:
> --- a/drivers/staging/comedi/comedi_pcmcia.c
> +++ b/drivers/staging/comedi/comedi_pcmcia.c
> @@ -18,7 +18,6 @@
> 
>  #include <linux/module.h>
>  #include <linux/kernel.h>
> -
>  #include "comedi_pcmcia.h"
> 
>  /**
> 

I would argue that checkpatch is wrong here, it's very common to have
an empty line between the global and the local header files.

	Arnd

Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line

[Julia Lawall]

On Tue, 13 Sep 2016, Arnd Bergmann wrote:

> On Tuesday, September 13, 2016 11:51:53 AM CEST Namrata A Shettar wrote:
> > --- a/drivers/staging/comedi/comedi_pcmcia.c
> > +++ b/drivers/staging/comedi/comedi_pcmcia.c
> > @@ -18,7 +18,6 @@
> >
> >  #include <linux/module.h>
> >  #include <linux/kernel.h>
> > -
> >  #include "comedi_pcmcia.h"
> >
> >  /**
> >
>
> I would argue that checkpatch is wrong here, it's very common to have
> an empty line between the global and the local header files.

I forwarded this to Joe Perches, and he pointed out that checkpatch
doesn't give a warning for this.  Namrata, what version of the kernel are
you using?

julia


>
> 	Arnd
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/2284008.DIPsHg5UWl%40wuerfel.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1889 bytes --]



On Tue, 13 Sep 2016, Namrata A Shettar wrote:

> Yes I realize that this may be wrong.Thank you for your inputs!
>
>  Also,The version of the kernel I am using is : 4.8.0-rc2+

You should be using what you get by doing the following command:

git clone -b staging-testing git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git

Maybe this is what you already have?

julia

>
> Thanks,
> Namrata
>
> On Tuesday, September 13, 2016 at 3:06:06 PM UTC+5:30, Julia Lawall wrote:
>
>
>       On Tue, 13 Sep 2016, Arnd Bergmann wrote:
>
>       > On Tuesday, September 13, 2016 11:51:53 AM CEST Namrata A
>       Shettar wrote:
>       > > --- a/drivers/staging/comedi/comedi_pcmcia.c
>       > > +++ b/drivers/staging/comedi/comedi_pcmcia.c
>       > > @@ -18,7 +18,6 @@
>       > >
>       > >  #include <linux/module.h>
>       > >  #include <linux/kernel.h>
>       > > -
>       > >  #include "comedi_pcmcia.h"
>       > >
>       > >  /**
>       > >
>       >
>       > I would argue that checkpatch is wrong here, it's very common
>       to have
>       > an empty line between the global and the local header files.
>
>       I forwarded this to Joe Perches, and he pointed out that
>       checkpatch
>       doesn't give a warning for this.  Namrata, what version of the
>       kernel are
>       you using?
>
>       julia
>
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/e2fdc076-900a-4a25-9e5a-
> 49d693bd3c74%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>