[PATCH 0/2] regulator: pca9450: Minor fixes

[PATCH 0/2] regulator: pca9450: Minor fixes

[Peng Fan (OSS)]

Two minor fixes:
- Correct interrupt type
- Correct probed name

More information could be found in each commit log.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Peng Fan (2):
      regulator: pca9450: Correct interrupt type
      regulator: pca9450: Correct probed name for PCA9452

 drivers/regulator/pca9450-regulator.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)
---
base-commit: 343f51842f4ed7143872f3aa116a214a5619a4b9
change-id: 20260310-pca9450-irq-c2bd4acc4bd9

Best regards,
-- 
Peng Fan <peng.fan@nxp.com>

[PATCH 1/2] regulator: pca9450: Correct interrupt type

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

Kernel warning on i.MX8MP-EVK when doing module test:
irq: type mismatch, failed to map hwirq-3 for gpio@30200000!

Per PCA945[X] specification: The IRQ_B pin is pulled low when any unmasked
interrupt bit status is changed and it is released high once application
processor read INT1 register.

So the interrupt should be configured as IRQF_TRIGGER_LOW, not
IRQF_TRIGGER_FALLING.

Fixes: 0935ff5f1f0a4 ("regulator: pca9450: add pca9450 pmic driver")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/regulator/pca9450-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c
index 5fa8682642505ab01736a9fb1ef8761d77ef6b2d..2205f6de37e7d4eb8a0abf7deebf319395a2bc75 100644
--- a/drivers/regulator/pca9450-regulator.c
+++ b/drivers/regulator/pca9450-regulator.c
@@ -1369,7 +1369,7 @@ static int pca9450_i2c_probe(struct i2c_client *i2c)
 	if (pca9450->irq) {
 		ret = devm_request_threaded_irq(pca9450->dev, pca9450->irq, NULL,
 						pca9450_irq_handler,
-						(IRQF_TRIGGER_FALLING | IRQF_ONESHOT),
+						(IRQF_TRIGGER_LOW | IRQF_ONESHOT),
 						"pca9450-irq", pca9450);
 		if (ret != 0)
 			return dev_err_probe(pca9450->dev, ret, "Failed to request IRQ: %d\n",

-- 
2.37.1

[PATCH 2/2] regulator: pca9450: Correct probed name for PCA9452

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

An incorrect device name was logged for PCA9452 because the dev_info()
ternary omitted PCA9452 and fell through to "pca9450bc". Introduce a
type_name and set it per device type so the probed message matches the
actual PMIC. While here, make the PCA9451A case explicit.

No functional changes.

Fixes: 017b76fb8e5b6 ("regulator: pca9450: Add PMIC pca9452 support")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/regulator/pca9450-regulator.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c
index 2205f6de37e7d4eb8a0abf7deebf319395a2bc75..45d7dc44c2cd081a4ca570933a6284550f1d1402 100644
--- a/drivers/regulator/pca9450-regulator.c
+++ b/drivers/regulator/pca9450-regulator.c
@@ -1293,6 +1293,7 @@ static int pca9450_i2c_probe(struct i2c_client *i2c)
 	struct regulator_dev *ldo5;
 	struct pca9450 *pca9450;
 	unsigned int device_id, i;
+	const char *type_name;
 	int ret;
 
 	pca9450 = devm_kzalloc(&i2c->dev, sizeof(struct pca9450), GFP_KERNEL);
@@ -1303,15 +1304,22 @@ static int pca9450_i2c_probe(struct i2c_client *i2c)
 	case PCA9450_TYPE_PCA9450A:
 		regulator_desc = pca9450a_regulators;
 		pca9450->rcnt = ARRAY_SIZE(pca9450a_regulators);
+		type_name = "pca9450a";
 		break;
 	case PCA9450_TYPE_PCA9450BC:
 		regulator_desc = pca9450bc_regulators;
 		pca9450->rcnt = ARRAY_SIZE(pca9450bc_regulators);
+		type_name = "pca9450bc";
 		break;
 	case PCA9450_TYPE_PCA9451A:
+		regulator_desc = pca9451a_regulators;
+		pca9450->rcnt = ARRAY_SIZE(pca9451a_regulators);
+		type_name = "pca9451a";
+		break;
 	case PCA9450_TYPE_PCA9452:
 		regulator_desc = pca9451a_regulators;
 		pca9450->rcnt = ARRAY_SIZE(pca9451a_regulators);
+		type_name = "pca9452";
 		break;
 	default:
 		dev_err(&i2c->dev, "Unknown device type");
@@ -1413,9 +1421,7 @@ static int pca9450_i2c_probe(struct i2c_client *i2c)
 					  pca9450_i2c_restart_handler, pca9450))
 		dev_warn(&i2c->dev, "Failed to register restart handler\n");
 
-	dev_info(&i2c->dev, "%s probed.\n",
-		type == PCA9450_TYPE_PCA9450A ? "pca9450a" :
-		(type == PCA9450_TYPE_PCA9451A ? "pca9451a" : "pca9450bc"));
+	dev_info(&i2c->dev, "%s probed.\n", type_name);
 
 	return 0;
 }

-- 
2.37.1

Re: [PATCH 1/2] regulator: pca9450: Correct interrupt type

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 765 bytes --]

On Tue, Mar 10, 2026 at 12:25:52PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Kernel warning on i.MX8MP-EVK when doing module test:
> irq: type mismatch, failed to map hwirq-3 for gpio@30200000!
> 
> Per PCA945[X] specification: The IRQ_B pin is pulled low when any unmasked
> interrupt bit status is changed and it is released high once application
> processor read INT1 register.
> 
> So the interrupt should be configured as IRQF_TRIGGER_LOW, not
> IRQF_TRIGGER_FALLING.

There appear to be a bunch of DTS files which specify edge triggered
interrupts for these devices (eg, imx8mm-emtop-som.dtsi and
imx8mp-debix-model-a.dts) though more getting it right.  Not an issue
for this patch but probably wants cleaning up.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: [PATCH 1/2] regulator: pca9450: Correct interrupt type

[Peng Fan (OSS)]

Hi Mark,

Thanks for quick replying.

> Subject: Re: [PATCH 1/2] regulator: pca9450: Correct interrupt type
> 
> On Tue, Mar 10, 2026 at 12:25:52PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Kernel warning on i.MX8MP-EVK when doing module test:
> > irq: type mismatch, failed to map hwirq-3 for gpio@30200000!
> >
> > Per PCA945[X] specification: The IRQ_B pin is pulled low when any
> > unmasked interrupt bit status is changed and it is released high once
> > application processor read INT1 register.
> >
> > So the interrupt should be configured as IRQF_TRIGGER_LOW, not
> > IRQF_TRIGGER_FALLING.
> 
> There appear to be a bunch of DTS files which specify edge triggered
> interrupts for these devices (eg, imx8mm-emtop-som.dtsi and
> imx8mp-debix-model-a.dts) though more getting it right.  Not an issue
> for this patch but probably wants cleaning up.

Yeah. This is just to clean the log that would confuse our customers,
not cause real issues on hardware.

BTW, I am also thinking whether we need to drop setting
IRQF_TIRRGER_[X] when calling request irq in this driver.

If you prefer below, I could do a V2.
diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c
index 45d7dc44c2cd0..d34a240b71922 100644
--- a/drivers/regulator/pca9450-regulator.c
+++ b/drivers/regulator/pca9450-regulator.c
@@ -1377,7 +1377,7 @@ static int pca9450_i2c_probe(struct i2c_client *i2c)
        if (pca9450->irq) {
                ret = devm_request_threaded_irq(pca9450->dev, pca9450->irq, NULL,
                                                pca9450_irq_handler,
-                                               (IRQF_TRIGGER_FALLING | IRQF_ONESHOT),
+                                               IRQF_ONESHOT,
                                                "pca9450-irq", pca9450);

Thanks
Peng.

Re: [PATCH 1/2] regulator: pca9450: Correct interrupt type

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

On Tue, Mar 10, 2026 at 01:24:44PM +0000, Peng Fan (OSS) wrote:

> BTW, I am also thinking whether we need to drop setting
> IRQF_TIRRGER_[X] when calling request irq in this driver.

I can't remember off hand what the effect of that is TBH.  I'm not sure
how it'd interact with incorrectly specified DTs?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 0/2] regulator: pca9450: Minor fixes

[Mark Brown]

On Tue, 10 Mar 2026 12:25:51 +0800, Peng Fan (OSS) wrote:
> Two minor fixes:
> - Correct interrupt type
> - Correct probed name
> 
> More information could be found in each commit log.
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/2] regulator: pca9450: Correct interrupt type
      commit: 5d0efaf47ee90ac60efae790acee3a3ed99ebf80
[2/2] regulator: pca9450: Correct probed name for PCA9452
      commit: 21b3fb7dc19caa488d285e3c47999f7f1a179334

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH 1/2] regulator: pca9450: Correct interrupt type

[Andy Shevchenko]

On Tue, Mar 10, 2026 at 03:34:35PM +0000, Mark Brown wrote:
> On Tue, Mar 10, 2026 at 01:24:44PM +0000, Peng Fan (OSS) wrote:
> 
> > BTW, I am also thinking whether we need to drop setting
> > IRQF_TIRRGER_[X] when calling request irq in this driver.
> 
> I can't remember off hand what the effect of that is TBH.  I'm not sure
> how it'd interact with incorrectly specified DTs?

One may need a quirk for incorrectly specified DTs,
basically something like

	flags = irq_...get flags...(...);
	if (flags & BAD!)
		...issue warning and fix the flags...

	ret = devm_irq_...(flags)

...

Also consider dropping dup error message as devm_*_irq*() already does that
for us.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 1/2] regulator: pca9450: Correct interrupt type

[Laurent Pinchart]

On Tue, Mar 10, 2026 at 01:15:34PM +0000, Mark Brown wrote:
> On Tue, Mar 10, 2026 at 12:25:52PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> > 
> > Kernel warning on i.MX8MP-EVK when doing module test:
> > irq: type mismatch, failed to map hwirq-3 for gpio@30200000!
> > 
> > Per PCA945[X] specification: The IRQ_B pin is pulled low when any unmasked
> > interrupt bit status is changed and it is released high once application
> > processor read INT1 register.
> > 
> > So the interrupt should be configured as IRQF_TRIGGER_LOW, not
> > IRQF_TRIGGER_FALLING.
> 
> There appear to be a bunch of DTS files which specify edge triggered
> interrupts for these devices (eg, imx8mm-emtop-som.dtsi and
> imx8mp-debix-model-a.dts) though more getting it right.  Not an issue
> for this patch but probably wants cleaning up.

This patch creates an interrupt storm on the i.MX8MP-based Debix Model A
board. I'm getting about 700 interrupts per second from the PMIC (and
about 3000 interrupts per second from the I2C controller).

arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts specifies the
PMIC interrupt as IRQ_TYPE_EDGE_RISING, setting it to IRQ_TYPE_LEVEL_LOW
does not help.

Peng, I can run test to debug the issue if you tell me what to test. I'd
like to fix the problem and avoid an annoying regression in v7.0, either
with a follow-up patch, or with a revert if we're too short on time.

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/2] regulator: pca9450: Correct interrupt type

[Peng Fan]

Hi Laurent,

On Mon, Mar 23, 2026 at 12:58:58PM +0200, Laurent Pinchart wrote:
>On Tue, Mar 10, 2026 at 01:15:34PM +0000, Mark Brown wrote:
>> On Tue, Mar 10, 2026 at 12:25:52PM +0800, Peng Fan (OSS) wrote:
>> > From: Peng Fan <peng.fan@nxp.com>
>> > 
>> > Kernel warning on i.MX8MP-EVK when doing module test:
>> > irq: type mismatch, failed to map hwirq-3 for gpio@30200000!
>> > 
>> > Per PCA945[X] specification: The IRQ_B pin is pulled low when any unmasked
>> > interrupt bit status is changed and it is released high once application
>> > processor read INT1 register.
>> > 
>> > So the interrupt should be configured as IRQF_TRIGGER_LOW, not
>> > IRQF_TRIGGER_FALLING.
>> 
>> There appear to be a bunch of DTS files which specify edge triggered
>> interrupts for these devices (eg, imx8mm-emtop-som.dtsi and
>> imx8mp-debix-model-a.dts) though more getting it right.  Not an issue
>> for this patch but probably wants cleaning up.
>
>This patch creates an interrupt storm on the i.MX8MP-based Debix Model A
>board. I'm getting about 700 interrupts per second from the PMIC (and
>about 3000 interrupts per second from the I2C controller).
>
>arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts specifies the
>PMIC interrupt as IRQ_TYPE_EDGE_RISING, setting it to IRQ_TYPE_LEVEL_LOW
>does not help.
>
>Peng, I can run test to debug the issue if you tell me what to test. I'd
>like to fix the problem and avoid an annoying regression in v7.0, either
>with a follow-up patch, or with a revert if we're too short on time.

Please help try whether below changes could help.

I checked the schematic and iomux settings, I suspect the pad settings might
not be correct, it does not have PE set, even it has PUE. Without PE, PUE
will not work per my understanding.

If below patch works for you, I will post this patch to list. otherwise,
we have to revert my patch or remove IRQ_TRIGGER_LOW when calling
devm_request_irq().

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts b/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts
index 9422beee30b29..df7489587e48e 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts
@@ -440,7 +440,7 @@ MX8MP_IOMUXC_SAI5_RXC__I2C6_SDA                                     0x400001c3
 
        pinctrl_pmic: pmicirqgrp {
                fsl,pins = <
-                       MX8MP_IOMUXC_GPIO1_IO03__GPIO1_IO03                             0x41
+                       MX8MP_IOMUXC_GPIO1_IO03__GPIO1_IO03                             0x000001c0
                >;
        };
 
Thanks,
Peng

>
>-- 
>Regards,
>
>Laurent Pinchart
>

Re: [PATCH 1/2] regulator: pca9450: Correct interrupt type

[Laurent Pinchart]

Hi Peng,

On Mon, Mar 23, 2026 at 08:38:24PM +0800, Peng Fan wrote:
> On Mon, Mar 23, 2026 at 12:58:58PM +0200, Laurent Pinchart wrote:
> > On Tue, Mar 10, 2026 at 01:15:34PM +0000, Mark Brown wrote:
> >> On Tue, Mar 10, 2026 at 12:25:52PM +0800, Peng Fan (OSS) wrote:
> >> > From: Peng Fan <peng.fan@nxp.com>
> >> > 
> >> > Kernel warning on i.MX8MP-EVK when doing module test:
> >> > irq: type mismatch, failed to map hwirq-3 for gpio@30200000!
> >> > 
> >> > Per PCA945[X] specification: The IRQ_B pin is pulled low when any unmasked
> >> > interrupt bit status is changed and it is released high once application
> >> > processor read INT1 register.
> >> > 
> >> > So the interrupt should be configured as IRQF_TRIGGER_LOW, not
> >> > IRQF_TRIGGER_FALLING.
> >> 
> >> There appear to be a bunch of DTS files which specify edge triggered
> >> interrupts for these devices (eg, imx8mm-emtop-som.dtsi and
> >> imx8mp-debix-model-a.dts) though more getting it right.  Not an issue
> >> for this patch but probably wants cleaning up.
> >
> > This patch creates an interrupt storm on the i.MX8MP-based Debix Model A
> > board. I'm getting about 700 interrupts per second from the PMIC (and
> > about 3000 interrupts per second from the I2C controller).
> >
> > arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts specifies the
> > PMIC interrupt as IRQ_TYPE_EDGE_RISING, setting it to IRQ_TYPE_LEVEL_LOW
> > does not help.
> >
> > Peng, I can run test to debug the issue if you tell me what to test. I'd
> > like to fix the problem and avoid an annoying regression in v7.0, either
> > with a follow-up patch, or with a revert if we're too short on time.
> 
> Please help try whether below changes could help.
> 
> I checked the schematic and iomux settings, I suspect the pad settings might
> not be correct, it does not have PE set, even it has PUE. Without PE, PUE
> will not work per my understanding.
> 
> If below patch works for you, I will post this patch to list. otherwise,
> we have to revert my patch or remove IRQ_TRIGGER_LOW when calling
> devm_request_irq().
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts b/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts
> index 9422beee30b29..df7489587e48e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts
> @@ -440,7 +440,7 @@ MX8MP_IOMUXC_SAI5_RXC__I2C6_SDA                                     0x400001c3
>  
>         pinctrl_pmic: pmicirqgrp {
>                 fsl,pins = <
> -                       MX8MP_IOMUXC_GPIO1_IO03__GPIO1_IO03                             0x41
> +                       MX8MP_IOMUXC_GPIO1_IO03__GPIO1_IO03                             0x000001c0
>                 >;
>         };
>  

This seems to fix the issue (I've also set the IRQ type to
IRQ_TYPE_LEVEL_LOW).

I have checked the schematics of the Debix board, and there's no pull-up
resistor on the interrupt line, so an internal pull-up is indeed
required.

Will you submit a patch for v7.0 ?

-- 
Regards,

Laurent Pinchart