* [PATCH v2 net-next 1/9] devlink: Add generic parameter ignore_ari
2018-09-24 5:16 [PATCH v2 net-next 0/9] bnxt_en: devlink param updates Vasundhara Volam
@ 2018-09-24 5:16 ` Vasundhara Volam
2018-09-24 5:16 ` [PATCH v2 net-next 2/9] devlink: Add generic parameter msix_vec_per_pf_max Vasundhara Volam
` (8 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: Vasundhara Volam @ 2018-09-24 5:16 UTC (permalink / raw)
To: davem; +Cc: michael.chan, netdev
ignore_ari - Device ignores ARI(Alternate Routing ID) capability,
even when platforms has the support and creates same number of
partitions when platform does not support ARI capability.
Cc: Jiri Pirko <jiri@mellanox.com>
Cc: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
---
include/net/devlink.h | 4 ++++
net/core/devlink.c | 5 +++++
2 files changed, 9 insertions(+)
diff --git a/include/net/devlink.h b/include/net/devlink.h
index b9b89d6..90d8343 100644
--- a/include/net/devlink.h
+++ b/include/net/devlink.h
@@ -362,6 +362,7 @@ enum devlink_param_generic_id {
DEVLINK_PARAM_GENERIC_ID_MAX_MACS,
DEVLINK_PARAM_GENERIC_ID_ENABLE_SRIOV,
DEVLINK_PARAM_GENERIC_ID_REGION_SNAPSHOT,
+ DEVLINK_PARAM_GENERIC_ID_IGNORE_ARI,
/* add new param generic ids above here*/
__DEVLINK_PARAM_GENERIC_ID_MAX,
@@ -380,6 +381,9 @@ enum devlink_param_generic_id {
#define DEVLINK_PARAM_GENERIC_REGION_SNAPSHOT_NAME "region_snapshot_enable"
#define DEVLINK_PARAM_GENERIC_REGION_SNAPSHOT_TYPE DEVLINK_PARAM_TYPE_BOOL
+#define DEVLINK_PARAM_GENERIC_IGNORE_ARI_NAME "ignore_ari"
+#define DEVLINK_PARAM_GENERIC_IGNORE_ARI_TYPE DEVLINK_PARAM_TYPE_BOOL
+
#define DEVLINK_PARAM_GENERIC(_id, _cmodes, _get, _set, _validate) \
{ \
.id = DEVLINK_PARAM_GENERIC_ID_##_id, \
diff --git a/net/core/devlink.c b/net/core/devlink.c
index 65fc366..6b08ad6 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -2676,6 +2676,11 @@ static int devlink_nl_cmd_reload(struct sk_buff *skb, struct genl_info *info)
.name = DEVLINK_PARAM_GENERIC_REGION_SNAPSHOT_NAME,
.type = DEVLINK_PARAM_GENERIC_REGION_SNAPSHOT_TYPE,
},
+ {
+ .id = DEVLINK_PARAM_GENERIC_ID_IGNORE_ARI,
+ .name = DEVLINK_PARAM_GENERIC_IGNORE_ARI_NAME,
+ .type = DEVLINK_PARAM_GENERIC_IGNORE_ARI_TYPE,
+ },
};
static int devlink_param_generic_verify(const struct devlink_param *param)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v2 net-next 2/9] devlink: Add generic parameter msix_vec_per_pf_max
2018-09-24 5:16 [PATCH v2 net-next 0/9] bnxt_en: devlink param updates Vasundhara Volam
2018-09-24 5:16 ` [PATCH v2 net-next 1/9] devlink: Add generic parameter ignore_ari Vasundhara Volam
@ 2018-09-24 5:16 ` Vasundhara Volam
2018-09-24 5:16 ` [PATCH v2 net-next 3/9] devlink: Add generic parameter msix_vec_per_pf_min Vasundhara Volam
` (7 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: Vasundhara Volam @ 2018-09-24 5:16 UTC (permalink / raw)
To: davem; +Cc: michael.chan, netdev
msix_vec_per_pf_max - This param sets the number of MSIX vectors
that the device requests from the host on driver initialization.
This value is set in the device which is applicable per PF.
Cc: Jiri Pirko <jiri@mellanox.com>
Cc: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
---
include/net/devlink.h | 4 ++++
net/core/devlink.c | 5 +++++
2 files changed, 9 insertions(+)
diff --git a/include/net/devlink.h b/include/net/devlink.h
index 90d8343..59be17b 100644
--- a/include/net/devlink.h
+++ b/include/net/devlink.h
@@ -363,6 +363,7 @@ enum devlink_param_generic_id {
DEVLINK_PARAM_GENERIC_ID_ENABLE_SRIOV,
DEVLINK_PARAM_GENERIC_ID_REGION_SNAPSHOT,
DEVLINK_PARAM_GENERIC_ID_IGNORE_ARI,
+ DEVLINK_PARAM_GENERIC_ID_MSIX_VEC_PER_PF_MAX,
/* add new param generic ids above here*/
__DEVLINK_PARAM_GENERIC_ID_MAX,
@@ -384,6 +385,9 @@ enum devlink_param_generic_id {
#define DEVLINK_PARAM_GENERIC_IGNORE_ARI_NAME "ignore_ari"
#define DEVLINK_PARAM_GENERIC_IGNORE_ARI_TYPE DEVLINK_PARAM_TYPE_BOOL
+#define DEVLINK_PARAM_GENERIC_MSIX_VEC_PER_PF_MAX_NAME "msix_vec_per_pf_max"
+#define DEVLINK_PARAM_GENERIC_MSIX_VEC_PER_PF_MAX_TYPE DEVLINK_PARAM_TYPE_U32
+
#define DEVLINK_PARAM_GENERIC(_id, _cmodes, _get, _set, _validate) \
{ \
.id = DEVLINK_PARAM_GENERIC_ID_##_id, \
diff --git a/net/core/devlink.c b/net/core/devlink.c
index 6b08ad6..7e0ac2e 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -2681,6 +2681,11 @@ static int devlink_nl_cmd_reload(struct sk_buff *skb, struct genl_info *info)
.name = DEVLINK_PARAM_GENERIC_IGNORE_ARI_NAME,
.type = DEVLINK_PARAM_GENERIC_IGNORE_ARI_TYPE,
},
+ {
+ .id = DEVLINK_PARAM_GENERIC_ID_MSIX_VEC_PER_PF_MAX,
+ .name = DEVLINK_PARAM_GENERIC_MSIX_VEC_PER_PF_MAX_NAME,
+ .type = DEVLINK_PARAM_GENERIC_MSIX_VEC_PER_PF_MAX_TYPE,
+ },
};
static int devlink_param_generic_verify(const struct devlink_param *param)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v2 net-next 3/9] devlink: Add generic parameter msix_vec_per_pf_min
2018-09-24 5:16 [PATCH v2 net-next 0/9] bnxt_en: devlink param updates Vasundhara Volam
2018-09-24 5:16 ` [PATCH v2 net-next 1/9] devlink: Add generic parameter ignore_ari Vasundhara Volam
2018-09-24 5:16 ` [PATCH v2 net-next 2/9] devlink: Add generic parameter msix_vec_per_pf_max Vasundhara Volam
@ 2018-09-24 5:16 ` Vasundhara Volam
2018-09-24 5:16 ` [PATCH v2 net-next 4/9] bnxt_en: Use ignore_ari devlink parameter Vasundhara Volam
` (6 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: Vasundhara Volam @ 2018-09-24 5:16 UTC (permalink / raw)
To: davem; +Cc: michael.chan, netdev
msix_vec_per_pf_min - This param sets the number of minimal MSIX
vectors required for the device initialization. This value is set
in the device which limits MSIX vectors per PF.
Cc: Jiri Pirko <jiri@mellanox.com>
Cc: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
---
include/net/devlink.h | 4 ++++
net/core/devlink.c | 5 +++++
2 files changed, 9 insertions(+)
diff --git a/include/net/devlink.h b/include/net/devlink.h
index 59be17b..361f525 100644
--- a/include/net/devlink.h
+++ b/include/net/devlink.h
@@ -364,6 +364,7 @@ enum devlink_param_generic_id {
DEVLINK_PARAM_GENERIC_ID_REGION_SNAPSHOT,
DEVLINK_PARAM_GENERIC_ID_IGNORE_ARI,
DEVLINK_PARAM_GENERIC_ID_MSIX_VEC_PER_PF_MAX,
+ DEVLINK_PARAM_GENERIC_ID_MSIX_VEC_PER_PF_MIN,
/* add new param generic ids above here*/
__DEVLINK_PARAM_GENERIC_ID_MAX,
@@ -388,6 +389,9 @@ enum devlink_param_generic_id {
#define DEVLINK_PARAM_GENERIC_MSIX_VEC_PER_PF_MAX_NAME "msix_vec_per_pf_max"
#define DEVLINK_PARAM_GENERIC_MSIX_VEC_PER_PF_MAX_TYPE DEVLINK_PARAM_TYPE_U32
+#define DEVLINK_PARAM_GENERIC_MSIX_VEC_PER_PF_MIN_NAME "msix_vec_per_pf_min"
+#define DEVLINK_PARAM_GENERIC_MSIX_VEC_PER_PF_MIN_TYPE DEVLINK_PARAM_TYPE_U32
+
#define DEVLINK_PARAM_GENERIC(_id, _cmodes, _get, _set, _validate) \
{ \
.id = DEVLINK_PARAM_GENERIC_ID_##_id, \
diff --git a/net/core/devlink.c b/net/core/devlink.c
index 7e0ac2e..8faf889 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -2686,6 +2686,11 @@ static int devlink_nl_cmd_reload(struct sk_buff *skb, struct genl_info *info)
.name = DEVLINK_PARAM_GENERIC_MSIX_VEC_PER_PF_MAX_NAME,
.type = DEVLINK_PARAM_GENERIC_MSIX_VEC_PER_PF_MAX_TYPE,
},
+ {
+ .id = DEVLINK_PARAM_GENERIC_ID_MSIX_VEC_PER_PF_MIN,
+ .name = DEVLINK_PARAM_GENERIC_MSIX_VEC_PER_PF_MIN_NAME,
+ .type = DEVLINK_PARAM_GENERIC_MSIX_VEC_PER_PF_MIN_TYPE,
+ },
};
static int devlink_param_generic_verify(const struct devlink_param *param)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v2 net-next 4/9] bnxt_en: Use ignore_ari devlink parameter
2018-09-24 5:16 [PATCH v2 net-next 0/9] bnxt_en: devlink param updates Vasundhara Volam
` (2 preceding siblings ...)
2018-09-24 5:16 ` [PATCH v2 net-next 3/9] devlink: Add generic parameter msix_vec_per_pf_min Vasundhara Volam
@ 2018-09-24 5:16 ` Vasundhara Volam
2018-09-24 5:16 ` [PATCH v2 net-next 5/9] bnxt_en: return proper error when FW returns HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED Vasundhara Volam
` (5 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: Vasundhara Volam @ 2018-09-24 5:16 UTC (permalink / raw)
To: davem; +Cc: michael.chan, netdev
This patch adds support for ignore_ari generic permanent mode
devlink parameter. This parameter is disabled by default. It can be
enabled using devlink param commands.
ignore_ari - If enabled, device ignores ARI(Alternate Routing ID)
capability, even when platforms has the support and creates same number
of partitions when platform does not support ARI capability.
Cc: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 6 ++++++
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 2 ++
2 files changed, 8 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
index f3b9fbc..58e3061 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
@@ -24,6 +24,8 @@
static const struct bnxt_dl_nvm_param nvm_params[] = {
{DEVLINK_PARAM_GENERIC_ID_ENABLE_SRIOV, NVM_OFF_ENABLE_SRIOV,
BNXT_NVM_SHARED_CFG, 1},
+ {DEVLINK_PARAM_GENERIC_ID_IGNORE_ARI, NVM_OFF_IGNORE_ARI,
+ BNXT_NVM_SHARED_CFG, 1},
};
static int bnxt_hwrm_nvm_req(struct bnxt *bp, u32 param_id, void *msg,
@@ -105,6 +107,10 @@ static int bnxt_dl_nvm_param_set(struct devlink *dl, u32 id,
BIT(DEVLINK_PARAM_CMODE_PERMANENT),
bnxt_dl_nvm_param_get, bnxt_dl_nvm_param_set,
NULL),
+ DEVLINK_PARAM_GENERIC(IGNORE_ARI,
+ BIT(DEVLINK_PARAM_CMODE_PERMANENT),
+ bnxt_dl_nvm_param_get, bnxt_dl_nvm_param_set,
+ NULL),
};
int bnxt_dl_register(struct bnxt *bp)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h
index 2f68dc0..da146492 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h
@@ -33,6 +33,8 @@ static inline void bnxt_link_bp_to_dl(struct bnxt *bp, struct devlink *dl)
}
}
+#define NVM_OFF_IGNORE_ARI 164
+#define NVM_OFF_HW_TC_OFFLOAD 170
#define NVM_OFF_ENABLE_SRIOV 401
enum bnxt_nvm_dir_type {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v2 net-next 5/9] bnxt_en: return proper error when FW returns HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED
2018-09-24 5:16 [PATCH v2 net-next 0/9] bnxt_en: devlink param updates Vasundhara Volam
` (3 preceding siblings ...)
2018-09-24 5:16 ` [PATCH v2 net-next 4/9] bnxt_en: Use ignore_ari devlink parameter Vasundhara Volam
@ 2018-09-24 5:16 ` Vasundhara Volam
2018-09-24 5:16 ` [PATCH v2 net-next 6/9] bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink params Vasundhara Volam
` (4 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: Vasundhara Volam @ 2018-09-24 5:16 UTC (permalink / raw)
To: davem; +Cc: michael.chan, netdev
Return proper error code when Firmware returns
HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED for HWRM_NVM_GET/SET_VARIABLE
commands.
Cc: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
index 58e3061..1b25e3a 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
@@ -77,8 +77,12 @@ static int bnxt_hwrm_nvm_req(struct bnxt *bp, u32 param_id, void *msg,
memcpy(buf, data_addr, bytesize);
dma_free_coherent(&bp->pdev->dev, bytesize, data_addr, data_dma_addr);
- if (rc)
+ if (rc == HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED) {
+ netdev_err(bp->dev, "PF does not have admin privileges to modify NVM config\n");
+ return -EACCES;
+ } else if (rc) {
return -EIO;
+ }
return 0;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v2 net-next 6/9] bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink params.
2018-09-24 5:16 [PATCH v2 net-next 0/9] bnxt_en: devlink param updates Vasundhara Volam
` (4 preceding siblings ...)
2018-09-24 5:16 ` [PATCH v2 net-next 5/9] bnxt_en: return proper error when FW returns HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED Vasundhara Volam
@ 2018-09-24 5:16 ` Vasundhara Volam
2018-09-24 5:16 ` [PATCH v2 net-next 7/9] bnxt_en: Add a driver specific gre_ver_check devlink parameter Vasundhara Volam
` (3 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: Vasundhara Volam @ 2018-09-24 5:16 UTC (permalink / raw)
To: davem; +Cc: michael.chan, netdev
This patch adds support for following generic permanent mode
devlink parameters. They can be modified using devlink param
commands.
msix_vec_per_pf_max - This param sets the number of MSIX vectors
that the device requests from the host on driver initialization.
This value is set in the device which limits MSIX vectors per PF.
msix_vec_per_pf_min - This param sets the number of minimal MSIX
vectors required for the device initialization. Value 0 indicates
a default value is selected. This value is set in the device which
limits MSIX vectors per PF.
Cc: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 50 ++++++++++++++++++++++-
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 5 +++
2 files changed, 53 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
index 1b25e3a..7dc754b 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
@@ -26,6 +26,10 @@
BNXT_NVM_SHARED_CFG, 1},
{DEVLINK_PARAM_GENERIC_ID_IGNORE_ARI, NVM_OFF_IGNORE_ARI,
BNXT_NVM_SHARED_CFG, 1},
+ {DEVLINK_PARAM_GENERIC_ID_MSIX_VEC_PER_PF_MAX,
+ NVM_OFF_MSIX_VEC_PER_PF_MAX, BNXT_NVM_SHARED_CFG, 10},
+ {DEVLINK_PARAM_GENERIC_ID_MSIX_VEC_PER_PF_MIN,
+ NVM_OFF_MSIX_VEC_PER_PF_MIN, BNXT_NVM_SHARED_CFG, 7},
};
static int bnxt_hwrm_nvm_req(struct bnxt *bp, u32 param_id, void *msg,
@@ -54,8 +58,22 @@ static int bnxt_hwrm_nvm_req(struct bnxt *bp, u32 param_id, void *msg,
idx = bp->pf.fw_fid - BNXT_FIRST_PF_FID;
bytesize = roundup(nvm_param.num_bits, BITS_PER_BYTE) / BITS_PER_BYTE;
- if (nvm_param.num_bits == 1)
- buf = &val->vbool;
+ switch (bytesize) {
+ case 1:
+ if (nvm_param.num_bits == 1)
+ buf = &val->vbool;
+ else
+ buf = &val->vu8;
+ break;
+ case 2:
+ buf = &val->vu16;
+ break;
+ case 4:
+ buf = &val->vu32;
+ break;
+ default:
+ return -EFAULT;
+ }
data_addr = dma_zalloc_coherent(&bp->pdev->dev, bytesize,
&data_dma_addr, GFP_KERNEL);
@@ -106,6 +124,26 @@ static int bnxt_dl_nvm_param_set(struct devlink *dl, u32 id,
return bnxt_hwrm_nvm_req(bp, id, &req, sizeof(req), &ctx->val);
}
+static int bnxt_dl_msix_validate(struct devlink *dl, u32 id,
+ union devlink_param_value val,
+ struct netlink_ext_ack *extack)
+{
+ int max_val;
+
+ if (id == DEVLINK_PARAM_GENERIC_ID_MSIX_VEC_PER_PF_MAX)
+ max_val = BNXT_MSIX_VEC_MAX;
+
+ if (id == DEVLINK_PARAM_GENERIC_ID_MSIX_VEC_PER_PF_MIN)
+ max_val = BNXT_MSIX_VEC_MIN_MAX;
+
+ if (val.vu32 < 0 || val.vu32 > max_val) {
+ NL_SET_ERR_MSG_MOD(extack, "MSIX value is exceeding the range");
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
static const struct devlink_param bnxt_dl_params[] = {
DEVLINK_PARAM_GENERIC(ENABLE_SRIOV,
BIT(DEVLINK_PARAM_CMODE_PERMANENT),
@@ -115,6 +153,14 @@ static int bnxt_dl_nvm_param_set(struct devlink *dl, u32 id,
BIT(DEVLINK_PARAM_CMODE_PERMANENT),
bnxt_dl_nvm_param_get, bnxt_dl_nvm_param_set,
NULL),
+ DEVLINK_PARAM_GENERIC(MSIX_VEC_PER_PF_MAX,
+ BIT(DEVLINK_PARAM_CMODE_PERMANENT),
+ bnxt_dl_nvm_param_get, bnxt_dl_nvm_param_set,
+ bnxt_dl_msix_validate),
+ DEVLINK_PARAM_GENERIC(MSIX_VEC_PER_PF_MIN,
+ BIT(DEVLINK_PARAM_CMODE_PERMANENT),
+ bnxt_dl_nvm_param_get, bnxt_dl_nvm_param_set,
+ bnxt_dl_msix_validate),
};
int bnxt_dl_register(struct bnxt *bp)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h
index da146492..0e67c05 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h
@@ -33,10 +33,15 @@ static inline void bnxt_link_bp_to_dl(struct bnxt *bp, struct devlink *dl)
}
}
+#define NVM_OFF_MSIX_VEC_PER_PF_MAX 108
+#define NVM_OFF_MSIX_VEC_PER_PF_MIN 114
#define NVM_OFF_IGNORE_ARI 164
#define NVM_OFF_HW_TC_OFFLOAD 170
#define NVM_OFF_ENABLE_SRIOV 401
+#define BNXT_MSIX_VEC_MAX 1280
+#define BNXT_MSIX_VEC_MIN_MAX 128
+
enum bnxt_nvm_dir_type {
BNXT_NVM_SHARED_CFG = 40,
BNXT_NVM_PORT_CFG,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v2 net-next 7/9] bnxt_en: Add a driver specific gre_ver_check devlink parameter.
2018-09-24 5:16 [PATCH v2 net-next 0/9] bnxt_en: devlink param updates Vasundhara Volam
` (5 preceding siblings ...)
2018-09-24 5:16 ` [PATCH v2 net-next 6/9] bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink params Vasundhara Volam
@ 2018-09-24 5:16 ` Vasundhara Volam
2018-09-24 5:16 ` [PATCH v2 net-next 8/9] devlink: Add Documentation/networking/devlink-params.txt Vasundhara Volam
` (2 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: Vasundhara Volam @ 2018-09-24 5:16 UTC (permalink / raw)
To: davem; +Cc: michael.chan, netdev
This patch adds following driver-specific permanent mode boolean
parameter.
gre_ver_check - Generic Routing Encapsulation(GRE) version check
will be enabled in the device. If disabled, device skips version
checking for GRE packets.
Cc: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 24 ++++++++++++++++++++++-
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 1 +
2 files changed, 24 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
index 7dc754b..fdeb4e5 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c
@@ -21,6 +21,11 @@
#endif /* CONFIG_BNXT_SRIOV */
};
+enum bnxt_dl_param_id {
+ BNXT_DEVLINK_PARAM_ID_BASE = DEVLINK_PARAM_GENERIC_ID_MAX,
+ BNXT_DEVLINK_PARAM_ID_GRE_VER_CHECK,
+};
+
static const struct bnxt_dl_nvm_param nvm_params[] = {
{DEVLINK_PARAM_GENERIC_ID_ENABLE_SRIOV, NVM_OFF_ENABLE_SRIOV,
BNXT_NVM_SHARED_CFG, 1},
@@ -30,6 +35,8 @@
NVM_OFF_MSIX_VEC_PER_PF_MAX, BNXT_NVM_SHARED_CFG, 10},
{DEVLINK_PARAM_GENERIC_ID_MSIX_VEC_PER_PF_MIN,
NVM_OFF_MSIX_VEC_PER_PF_MIN, BNXT_NVM_SHARED_CFG, 7},
+ {BNXT_DEVLINK_PARAM_ID_GRE_VER_CHECK, NVM_OFF_DIS_GRE_VER_CHECK,
+ BNXT_NVM_SHARED_CFG, 1},
};
static int bnxt_hwrm_nvm_req(struct bnxt *bp, u32 param_id, void *msg,
@@ -109,9 +116,15 @@ static int bnxt_dl_nvm_param_get(struct devlink *dl, u32 id,
{
struct hwrm_nvm_get_variable_input req = {0};
struct bnxt *bp = bnxt_get_bp_from_dl(dl);
+ int rc;
bnxt_hwrm_cmd_hdr_init(bp, &req, HWRM_NVM_GET_VARIABLE, -1, -1);
- return bnxt_hwrm_nvm_req(bp, id, &req, sizeof(req), &ctx->val);
+ rc = bnxt_hwrm_nvm_req(bp, id, &req, sizeof(req), &ctx->val);
+ if (!rc)
+ if (id == BNXT_DEVLINK_PARAM_ID_GRE_VER_CHECK)
+ ctx->val.vbool = !ctx->val.vbool;
+
+ return rc;
}
static int bnxt_dl_nvm_param_set(struct devlink *dl, u32 id,
@@ -121,6 +134,10 @@ static int bnxt_dl_nvm_param_set(struct devlink *dl, u32 id,
struct bnxt *bp = bnxt_get_bp_from_dl(dl);
bnxt_hwrm_cmd_hdr_init(bp, &req, HWRM_NVM_SET_VARIABLE, -1, -1);
+
+ if (id == BNXT_DEVLINK_PARAM_ID_GRE_VER_CHECK)
+ ctx->val.vbool = !ctx->val.vbool;
+
return bnxt_hwrm_nvm_req(bp, id, &req, sizeof(req), &ctx->val);
}
@@ -161,6 +178,11 @@ static int bnxt_dl_msix_validate(struct devlink *dl, u32 id,
BIT(DEVLINK_PARAM_CMODE_PERMANENT),
bnxt_dl_nvm_param_get, bnxt_dl_nvm_param_set,
bnxt_dl_msix_validate),
+ DEVLINK_PARAM_DRIVER(BNXT_DEVLINK_PARAM_ID_GRE_VER_CHECK,
+ "gre_ver_check", DEVLINK_PARAM_TYPE_BOOL,
+ BIT(DEVLINK_PARAM_CMODE_PERMANENT),
+ bnxt_dl_nvm_param_get, bnxt_dl_nvm_param_set,
+ NULL),
};
int bnxt_dl_register(struct bnxt *bp)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h
index 0e67c05..e36e41a 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h
@@ -37,6 +37,7 @@ static inline void bnxt_link_bp_to_dl(struct bnxt *bp, struct devlink *dl)
#define NVM_OFF_MSIX_VEC_PER_PF_MIN 114
#define NVM_OFF_IGNORE_ARI 164
#define NVM_OFF_HW_TC_OFFLOAD 170
+#define NVM_OFF_DIS_GRE_VER_CHECK 171
#define NVM_OFF_ENABLE_SRIOV 401
#define BNXT_MSIX_VEC_MAX 1280
--
1.8.3.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v2 net-next 8/9] devlink: Add Documentation/networking/devlink-params.txt
2018-09-24 5:16 [PATCH v2 net-next 0/9] bnxt_en: devlink param updates Vasundhara Volam
` (6 preceding siblings ...)
2018-09-24 5:16 ` [PATCH v2 net-next 7/9] bnxt_en: Add a driver specific gre_ver_check devlink parameter Vasundhara Volam
@ 2018-09-24 5:16 ` Vasundhara Volam
2018-09-24 5:16 ` [PATCH v2 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt Vasundhara Volam
2018-09-24 16:39 ` [PATCH v2 net-next 0/9] bnxt_en: devlink param updates Jakub Kicinski
9 siblings, 0 replies; 16+ messages in thread
From: Vasundhara Volam @ 2018-09-24 5:16 UTC (permalink / raw)
To: davem; +Cc: michael.chan, netdev
This patch adds a new file to add information about some of the
generic configuration parameters set via devlink.
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org
Cc: Jiri Pirko <jiri@mellanox.com>
Cc: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
---
Documentation/networking/devlink-params.txt | 42 +++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
create mode 100644 Documentation/networking/devlink-params.txt
diff --git a/Documentation/networking/devlink-params.txt b/Documentation/networking/devlink-params.txt
new file mode 100644
index 0000000..ae444ff
--- /dev/null
+++ b/Documentation/networking/devlink-params.txt
@@ -0,0 +1,42 @@
+Devlink configuration parameters
+================================
+Following is the list of configuration parameters via devlink interface.
+Each parameter can be generic or driver specific and are device level
+parameters.
+
+Note that the driver-specific files should contain the generic params
+they support to, with supported config modes.
+
+Each parameter can be set in different configuration modes:
+ runtime - set while driver is running, no reset required.
+ driverinit - applied while driver initializes, requires restart
+ driver by devlink reload command.
+ permanent - written to device's non-volatile memory, hard reset
+ required.
+
+Following is the list of parameters:
+====================================
+enable_sriov [DEVICE, GENERIC]
+ Enable Single Root I/O Virtualisation (SRIOV) in
+ the device.
+ Type: Boolean
+
+ignore_ari [DEVICE, GENERIC]
+ Ignore Alternative Routing-ID Interpretation (ARI)
+ capability. If enabled, adapter will ignore ARI
+ capability even when platforms has the support
+ enabled and creates same number of partitions when
+ platform does not support ARI.
+ Type: Boolean
+
+msix_vec_per_pf_max [DEVICE, GENERIC]
+ Provides the maximum number of MSIX interrupts that
+ a device can create. Value is same across all
+ physical functions (PFs) in the device.
+ Type: u32
+
+msix_vec_per_pf_min [DEVICE, GENERIC]
+ Provides the minimum number of MSIX interrupts required
+ for the device initialization. Value is same across all
+ physical functions (PFs) in the device.
+ Type: u32
--
1.8.3.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v2 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt
2018-09-24 5:16 [PATCH v2 net-next 0/9] bnxt_en: devlink param updates Vasundhara Volam
` (7 preceding siblings ...)
2018-09-24 5:16 ` [PATCH v2 net-next 8/9] devlink: Add Documentation/networking/devlink-params.txt Vasundhara Volam
@ 2018-09-24 5:16 ` Vasundhara Volam
2018-09-24 16:24 ` Jakub Kicinski
2018-09-24 16:39 ` [PATCH v2 net-next 0/9] bnxt_en: devlink param updates Jakub Kicinski
9 siblings, 1 reply; 16+ messages in thread
From: Vasundhara Volam @ 2018-09-24 5:16 UTC (permalink / raw)
To: davem; +Cc: michael.chan, netdev
This patch adds a new file to add information about configuration
parameters that are supported by bnxt_en driver via devlink.
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org
Cc: Jiri Pirko <jiri@mellanox.com>
Cc: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
---
Documentation/networking/devlink-params-bnxt.txt | 35 ++++++++++++++++++++++++
1 file changed, 35 insertions(+)
create mode 100644 Documentation/networking/devlink-params-bnxt.txt
diff --git a/Documentation/networking/devlink-params-bnxt.txt b/Documentation/networking/devlink-params-bnxt.txt
new file mode 100644
index 0000000..ca7c457
--- /dev/null
+++ b/Documentation/networking/devlink-params-bnxt.txt
@@ -0,0 +1,35 @@
+enable_sriov [DEVICE, GENERIC]
+ Enable Single Root I/O Virtualisation (SRIOV) in
+ the device.
+ Type: Boolean
+ Configuration mode: Permanent
+
+ignore_ari [DEVICE, GENERIC]
+ Ignore Alternative Routing-ID Interpretation (ARI)
+ capability. If enabled, adapter will ignore ARI
+ capability even when platforms has the support
+ enabled and creates same number of partitions when
+ platform does not support ARI.
+ Type: Boolean
+ Configuration mode: Permanent
+
+msix_vec_per_pf_max [DEVICE, GENERIC]
+ Provides the maximum number of MSIX interrupts that
+ a device can create. Value is same across all
+ physical functions (PFs) in the device.
+ Type: u32
+ Configuration mode: Permanent
+
+msix_vec_per_pf_min [DEVICE, GENERIC]
+ Provides the minimum number of MSIX interrupts required
+ or the device initialization. Value is same across all
+ physical functions (PFs) in the device.
+ Type: u32
+ Configuration mode: Permanent
+
+gre_ver_check [DEVICE, DRIVER-SPECIFIC]
+ Generic Routing Encapsulation (GRE) version check will
+ be enabled in the device. If disabled, device skips
+ version checking for incoming packets.
+ Type: Boolean
+ Configuration mode: Permanent
--
1.8.3.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH v2 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt
2018-09-24 5:16 ` [PATCH v2 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt Vasundhara Volam
@ 2018-09-24 16:24 ` Jakub Kicinski
2018-09-25 4:07 ` Vasundhara Volam
0 siblings, 1 reply; 16+ messages in thread
From: Jakub Kicinski @ 2018-09-24 16:24 UTC (permalink / raw)
To: Vasundhara Volam; +Cc: davem, michael.chan, netdev
On Mon, 24 Sep 2018 10:46:21 +0530, Vasundhara Volam wrote:
> This patch adds a new file to add information about configuration
> parameters that are supported by bnxt_en driver via devlink.
>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> Cc: Jiri Pirko <jiri@mellanox.com>
> Cc: Michael Chan <michael.chan@broadcom.com>
>
> Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
> ---
> Documentation/networking/devlink-params-bnxt.txt | 35 ++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 Documentation/networking/devlink-params-bnxt.txt
>
> diff --git a/Documentation/networking/devlink-params-bnxt.txt b/Documentation/networking/devlink-params-bnxt.txt
> new file mode 100644
> index 0000000..ca7c457
> --- /dev/null
> +++ b/Documentation/networking/devlink-params-bnxt.txt
> @@ -0,0 +1,35 @@
> +enable_sriov [DEVICE, GENERIC]
> + Enable Single Root I/O Virtualisation (SRIOV) in
> + the device.
> + Type: Boolean
> + Configuration mode: Permanent
> +
> +ignore_ari [DEVICE, GENERIC]
> + Ignore Alternative Routing-ID Interpretation (ARI)
> + capability. If enabled, adapter will ignore ARI
> + capability even when platforms has the support
> + enabled and creates same number of partitions when
> + platform does not support ARI.
> + Type: Boolean
> + Configuration mode: Permanent
> +
> +msix_vec_per_pf_max [DEVICE, GENERIC]
> + Provides the maximum number of MSIX interrupts that
> + a device can create. Value is same across all
> + physical functions (PFs) in the device.
> + Type: u32
> + Configuration mode: Permanent
> +
> +msix_vec_per_pf_min [DEVICE, GENERIC]
> + Provides the minimum number of MSIX interrupts required
> + or the device initialization. Value is same across all
> + physical functions (PFs) in the device.
> + Type: u32
> + Configuration mode: Permanent
Why duplicate the description of the generic parameters?
> +gre_ver_check [DEVICE, DRIVER-SPECIFIC]
> + Generic Routing Encapsulation (GRE) version check will
> + be enabled in the device. If disabled, device skips
> + version checking for incoming packets.
> + Type: Boolean
> + Configuration mode: Permanent
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt
2018-09-24 16:24 ` Jakub Kicinski
@ 2018-09-25 4:07 ` Vasundhara Volam
2018-09-25 14:05 ` Jakub Kicinski
0 siblings, 1 reply; 16+ messages in thread
From: Vasundhara Volam @ 2018-09-25 4:07 UTC (permalink / raw)
To: jakub.kicinski; +Cc: David Miller, michael.chan@broadcom.com, Netdev
On Mon, Sep 24, 2018 at 9:54 PM Jakub Kicinski
<jakub.kicinski@netronome.com> wrote:
>
> On Mon, 24 Sep 2018 10:46:21 +0530, Vasundhara Volam wrote:
> > This patch adds a new file to add information about configuration
> > parameters that are supported by bnxt_en driver via devlink.
> >
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Cc: Jonathan Corbet <corbet@lwn.net>
> > Cc: linux-doc@vger.kernel.org
> > Cc: Jiri Pirko <jiri@mellanox.com>
> > Cc: Michael Chan <michael.chan@broadcom.com>
> >
> > Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
> > ---
> > Documentation/networking/devlink-params-bnxt.txt | 35 ++++++++++++++++++++++++
> > 1 file changed, 35 insertions(+)
> > create mode 100644 Documentation/networking/devlink-params-bnxt.txt
> >
> > diff --git a/Documentation/networking/devlink-params-bnxt.txt b/Documentation/networking/devlink-params-bnxt.txt
> > new file mode 100644
> > index 0000000..ca7c457
> > --- /dev/null
> > +++ b/Documentation/networking/devlink-params-bnxt.txt
> > @@ -0,0 +1,35 @@
> > +enable_sriov [DEVICE, GENERIC]
> > + Enable Single Root I/O Virtualisation (SRIOV) in
> > + the device.
> > + Type: Boolean
> > + Configuration mode: Permanent
> > +
> > +ignore_ari [DEVICE, GENERIC]
> > + Ignore Alternative Routing-ID Interpretation (ARI)
> > + capability. If enabled, adapter will ignore ARI
> > + capability even when platforms has the support
> > + enabled and creates same number of partitions when
> > + platform does not support ARI.
> > + Type: Boolean
> > + Configuration mode: Permanent
> > +
> > +msix_vec_per_pf_max [DEVICE, GENERIC]
> > + Provides the maximum number of MSIX interrupts that
> > + a device can create. Value is same across all
> > + physical functions (PFs) in the device.
> > + Type: u32
> > + Configuration mode: Permanent
> > +
> > +msix_vec_per_pf_min [DEVICE, GENERIC]
> > + Provides the minimum number of MSIX interrupts required
> > + or the device initialization. Value is same across all
> > + physical functions (PFs) in the device.
> > + Type: u32
> > + Configuration mode: Permanent
>
> Why duplicate the description of the generic parameters?
Not all generic parameters are used by all drivers. So, I want to add
information about
type and configuration mode about generic parameters used by bnxt_en driver.
I can remove description part keeping type and configuration mode, if
it looks duplication.
>
> > +gre_ver_check [DEVICE, DRIVER-SPECIFIC]
> > + Generic Routing Encapsulation (GRE) version check will
> > + be enabled in the device. If disabled, device skips
> > + version checking for incoming packets.
> > + Type: Boolean
> > + Configuration mode: Permanent
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt
2018-09-25 4:07 ` Vasundhara Volam
@ 2018-09-25 14:05 ` Jakub Kicinski
0 siblings, 0 replies; 16+ messages in thread
From: Jakub Kicinski @ 2018-09-25 14:05 UTC (permalink / raw)
To: Vasundhara Volam; +Cc: David Miller, michael.chan@broadcom.com, Netdev
On Tue, 25 Sep 2018 09:37:20 +0530, Vasundhara Volam wrote:
> > Why duplicate the description of the generic parameters?
> Not all generic parameters are used by all drivers. So, I want to add
> information about
> type and configuration mode about generic parameters used by bnxt_en driver.
> I can remove description part keeping type and configuration mode, if
> it looks duplication.
That'd be better.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 net-next 0/9] bnxt_en: devlink param updates
2018-09-24 5:16 [PATCH v2 net-next 0/9] bnxt_en: devlink param updates Vasundhara Volam
` (8 preceding siblings ...)
2018-09-24 5:16 ` [PATCH v2 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt Vasundhara Volam
@ 2018-09-24 16:39 ` Jakub Kicinski
2018-09-25 4:14 ` Vasundhara Volam
9 siblings, 1 reply; 16+ messages in thread
From: Jakub Kicinski @ 2018-09-24 16:39 UTC (permalink / raw)
To: Vasundhara Volam; +Cc: davem, michael.chan, netdev
On Mon, 24 Sep 2018 10:46:12 +0530, Vasundhara Volam wrote:
> This patchset adds support for 3 generic and 1 driver-specific devlink
> parameters. Add documentation for these configuration parameters.
>
> Also, this patchset adds support to return proper error code if
> HWRM_NVM_GET/SET_VARIABLE commands return error code
> HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED.
>
> v1->v2:
> -Remove hw_tc_offload parameter.
> -Update all patches with Cc of MAINTAINERS.
> -Add more description in commit message for device specific parameter.
> -Add a new Documentation/networking/devlink-params.txt with some
> generic devlink parameters information.
> -Add a new Documentation/networking/devlink-params-bnxt_en.txt with devlink
> parameters information that are supported by bnxt_en driver.
>
> Vasundhara Volam (9):
> devlink: Add generic parameter ignore_ari
> devlink: Add generic parameter msix_vec_per_pf_max
> devlink: Add generic parameter msix_vec_per_pf_min
Nobody agreed with me that we need structure the PCIe bits better so
I'll let go...
> bnxt_en: Use ignore_ari devlink parameter
> bnxt_en: return proper error when FW returns
> HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED
> bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink
> params.
> bnxt_en: Add a driver specific gre_ver_check devlink parameter.
This looks like configuring forwarding rules with devlink, but again,
I won't object if I'm the only one who finds this inappropriate.
You should CC people who gave you feedback on the previous version.
> devlink: Add Documentation/networking/devlink-params.txt
> devlink: Add Documentation/networking/devlink-params-bnxt.txt
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH v2 net-next 0/9] bnxt_en: devlink param updates
2018-09-24 16:39 ` [PATCH v2 net-next 0/9] bnxt_en: devlink param updates Jakub Kicinski
@ 2018-09-25 4:14 ` Vasundhara Volam
2018-09-25 14:06 ` Jakub Kicinski
0 siblings, 1 reply; 16+ messages in thread
From: Vasundhara Volam @ 2018-09-25 4:14 UTC (permalink / raw)
To: jakub.kicinski; +Cc: David Miller, michael.chan@broadcom.com, Netdev
On Mon, Sep 24, 2018 at 10:11 PM Jakub Kicinski
<jakub.kicinski@netronome.com> wrote:
>
> On Mon, 24 Sep 2018 10:46:12 +0530, Vasundhara Volam wrote:
> > This patchset adds support for 3 generic and 1 driver-specific devlink
> > parameters. Add documentation for these configuration parameters.
> >
> > Also, this patchset adds support to return proper error code if
> > HWRM_NVM_GET/SET_VARIABLE commands return error code
> > HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED.
> >
> > v1->v2:
> > -Remove hw_tc_offload parameter.
> > -Update all patches with Cc of MAINTAINERS.
> > -Add more description in commit message for device specific parameter.
> > -Add a new Documentation/networking/devlink-params.txt with some
> > generic devlink parameters information.
> > -Add a new Documentation/networking/devlink-params-bnxt_en.txt with devlink
> > parameters information that are supported by bnxt_en driver.
> >
> > Vasundhara Volam (9):
> > devlink: Add generic parameter ignore_ari
> > devlink: Add generic parameter msix_vec_per_pf_max
> > devlink: Add generic parameter msix_vec_per_pf_min
>
> Nobody agreed with me that we need structure the PCIe bits better so
> I'll let go...
>
> > bnxt_en: Use ignore_ari devlink parameter
> > bnxt_en: return proper error when FW returns
> > HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED
> > bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink
> > params.
> > bnxt_en: Add a driver specific gre_ver_check devlink parameter.
>
> This looks like configuring forwarding rules with devlink, but again,
Do you think, this parameter should be made generic?
> I won't object if I'm the only one who finds this inappropriate.
>
> You should CC people who gave you feedback on the previous version.
Sorry, I will add in the next version of the patchset. Thanks.
>
> > devlink: Add Documentation/networking/devlink-params.txt
> > devlink: Add Documentation/networking/devlink-params-bnxt.txt
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 net-next 0/9] bnxt_en: devlink param updates
2018-09-25 4:14 ` Vasundhara Volam
@ 2018-09-25 14:06 ` Jakub Kicinski
0 siblings, 0 replies; 16+ messages in thread
From: Jakub Kicinski @ 2018-09-25 14:06 UTC (permalink / raw)
To: Vasundhara Volam; +Cc: David Miller, michael.chan@broadcom.com, Netdev
On Tue, 25 Sep 2018 09:44:41 +0530, Vasundhara Volam wrote:
> On Mon, Sep 24, 2018 at 10:11 PM Jakub Kicinski
> <jakub.kicinski@netronome.com> wrote:
> >
> > On Mon, 24 Sep 2018 10:46:12 +0530, Vasundhara Volam wrote:
> > > This patchset adds support for 3 generic and 1 driver-specific devlink
> > > parameters. Add documentation for these configuration parameters.
> > >
> > > Also, this patchset adds support to return proper error code if
> > > HWRM_NVM_GET/SET_VARIABLE commands return error code
> > > HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED.
> > >
> > > v1->v2:
> > > -Remove hw_tc_offload parameter.
> > > -Update all patches with Cc of MAINTAINERS.
> > > -Add more description in commit message for device specific parameter.
> > > -Add a new Documentation/networking/devlink-params.txt with some
> > > generic devlink parameters information.
> > > -Add a new Documentation/networking/devlink-params-bnxt_en.txt with devlink
> > > parameters information that are supported by bnxt_en driver.
> > >
> > > Vasundhara Volam (9):
> > > devlink: Add generic parameter ignore_ari
> > > devlink: Add generic parameter msix_vec_per_pf_max
> > > devlink: Add generic parameter msix_vec_per_pf_min
> >
> > Nobody agreed with me that we need structure the PCIe bits better so
> > I'll let go...
> >
> > > bnxt_en: Use ignore_ari devlink parameter
> > > bnxt_en: return proper error when FW returns
> > > HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED
> > > bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink
> > > params.
> > > bnxt_en: Add a driver specific gre_ver_check devlink parameter.
> >
> > This looks like configuring forwarding rules with devlink, but again,
> Do you think, this parameter should be made generic?
By no means.
> > I won't object if I'm the only one who finds this inappropriate.
> >
> > You should CC people who gave you feedback on the previous version.
> Sorry, I will add in the next version of the patchset. Thanks.
> >
> > > devlink: Add Documentation/networking/devlink-params.txt
> > > devlink: Add Documentation/networking/devlink-params-bnxt.txt
^ permalink raw reply [flat|nested] 16+ messages in thread