* [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD
@ 2014-11-11 13:46 Wei Liu
2014-11-12 10:01 ` Ian Campbell
0 siblings, 1 reply; 10+ messages in thread
From: Wei Liu @ 2014-11-11 13:46 UTC (permalink / raw)
To: xen-devel; +Cc: George Dunlap, Ian Jackson, Wei Liu, Ian Campbell
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Konrad Wilk <konrad.wilk@oracle.com>
---
This is a simple enough bug fix I think it should just go in.
---
tools/libxl/libxl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
index f7961f6..de23fec 100644
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -4164,6 +4164,7 @@ DEFINE_DEVICE_REMOVE(vtpm, destroy, 1)
\
GCNEW(aodev); \
libxl__prepare_ao_device(ao, aodev); \
+ aodev->action = LIBXL__DEVICE_ACTION_ADD; \
aodev->callback = device_addrm_aocomplete; \
aodev->update_json = true; \
libxl__device_##type##_add(egc, domid, type, aodev); \
--
1.7.10.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD
2014-11-11 13:46 [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD Wei Liu
@ 2014-11-12 10:01 ` Ian Campbell
2014-11-12 10:36 ` Wei Liu
0 siblings, 1 reply; 10+ messages in thread
From: Ian Campbell @ 2014-11-12 10:01 UTC (permalink / raw)
To: Wei Liu; +Cc: George Dunlap, Ian Jackson, xen-devel
On Tue, 2014-11-11 at 13:46 +0000, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: George Dunlap <george.dunlap@eu.citrix.com>
> Cc: Konrad Wilk <konrad.wilk@oracle.com>
> ---
> This is a simple enough bug fix I think it should just go in.
Probably, but can you explain in the commit log what the symptoms of not
doing it are, IOW why it is required.
> ---
> tools/libxl/libxl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index f7961f6..de23fec 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -4164,6 +4164,7 @@ DEFINE_DEVICE_REMOVE(vtpm, destroy, 1)
> \
> GCNEW(aodev); \
> libxl__prepare_ao_device(ao, aodev); \
> + aodev->action = LIBXL__DEVICE_ACTION_ADD; \
> aodev->callback = device_addrm_aocomplete; \
> aodev->update_json = true; \
> libxl__device_##type##_add(egc, domid, type, aodev); \
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD
2014-11-12 10:01 ` Ian Campbell
@ 2014-11-12 10:36 ` Wei Liu
0 siblings, 0 replies; 10+ messages in thread
From: Wei Liu @ 2014-11-12 10:36 UTC (permalink / raw)
To: Ian Campbell; +Cc: George Dunlap, Ian Jackson, Wei Liu, xen-devel
On Wed, Nov 12, 2014 at 10:01:24AM +0000, Ian Campbell wrote:
> On Tue, 2014-11-11 at 13:46 +0000, Wei Liu wrote:
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > Cc: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: George Dunlap <george.dunlap@eu.citrix.com>
> > Cc: Konrad Wilk <konrad.wilk@oracle.com>
> > ---
> > This is a simple enough bug fix I think it should just go in.
>
> Probably, but can you explain in the commit log what the symptoms of not
> doing it are, IOW why it is required.
>
OK, I will resubmit with updated commit log.
> > ---
> > tools/libxl/libxl.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> > index f7961f6..de23fec 100644
> > --- a/tools/libxl/libxl.c
> > +++ b/tools/libxl/libxl.c
> > @@ -4164,6 +4164,7 @@ DEFINE_DEVICE_REMOVE(vtpm, destroy, 1)
> > \
> > GCNEW(aodev); \
> > libxl__prepare_ao_device(ao, aodev); \
> > + aodev->action = LIBXL__DEVICE_ACTION_ADD; \
> > aodev->callback = device_addrm_aocomplete; \
> > aodev->update_json = true; \
> > libxl__device_##type##_add(egc, domid, type, aodev); \
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD
@ 2014-11-12 10:39 Wei Liu
2014-11-12 10:55 ` Wei Liu
2014-11-12 10:56 ` Ian Campbell
0 siblings, 2 replies; 10+ messages in thread
From: Wei Liu @ 2014-11-12 10:39 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Jackson, Wei Liu, Ian Campbell
... otherwise when device add operation fails, the error message looks
like "libxl: error: libxl.c:1897:device_addrm_aocomplete: unable to (null)
device", which is not very helpful.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
---
tools/libxl/libxl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
index f7961f6..de23fec 100644
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -4164,6 +4164,7 @@ DEFINE_DEVICE_REMOVE(vtpm, destroy, 1)
\
GCNEW(aodev); \
libxl__prepare_ao_device(ao, aodev); \
+ aodev->action = LIBXL__DEVICE_ACTION_ADD; \
aodev->callback = device_addrm_aocomplete; \
aodev->update_json = true; \
libxl__device_##type##_add(egc, domid, type, aodev); \
--
1.7.10.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD
2014-11-12 10:39 Wei Liu
@ 2014-11-12 10:55 ` Wei Liu
2014-11-12 10:56 ` Ian Campbell
1 sibling, 0 replies; 10+ messages in thread
From: Wei Liu @ 2014-11-12 10:55 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Jackson, Wei Liu, Ian Campbell
And of course this is v2 of this patch. Sorry for not having added that
in the subject line.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD
2014-11-12 10:39 Wei Liu
2014-11-12 10:55 ` Wei Liu
@ 2014-11-12 10:56 ` Ian Campbell
2014-11-12 15:16 ` Konrad Rzeszutek Wilk
2014-11-14 10:35 ` Ian Campbell
1 sibling, 2 replies; 10+ messages in thread
From: Ian Campbell @ 2014-11-12 10:56 UTC (permalink / raw)
To: Wei Liu; +Cc: Ian Jackson, xen-devel
On Wed, 2014-11-12 at 10:39 +0000, Wei Liu wrote:
> ... otherwise when device add operation fails, the error message looks
> like "libxl: error: libxl.c:1897:device_addrm_aocomplete: unable to (null)
> device", which is not very helpful.
Thanks.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> ---
> tools/libxl/libxl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index f7961f6..de23fec 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -4164,6 +4164,7 @@ DEFINE_DEVICE_REMOVE(vtpm, destroy, 1)
> \
> GCNEW(aodev); \
> libxl__prepare_ao_device(ao, aodev); \
> + aodev->action = LIBXL__DEVICE_ACTION_ADD; \
> aodev->callback = device_addrm_aocomplete; \
> aodev->update_json = true; \
> libxl__device_##type##_add(egc, domid, type, aodev); \
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD
2014-11-12 10:56 ` Ian Campbell
@ 2014-11-12 15:16 ` Konrad Rzeszutek Wilk
2014-11-14 10:57 ` Ian Campbell
2014-11-14 10:35 ` Ian Campbell
1 sibling, 1 reply; 10+ messages in thread
From: Konrad Rzeszutek Wilk @ 2014-11-12 15:16 UTC (permalink / raw)
To: Ian Campbell; +Cc: Ian Jackson, Wei Liu, xen-devel
On Wed, Nov 12, 2014 at 10:56:24AM +0000, Ian Campbell wrote:
> On Wed, 2014-11-12 at 10:39 +0000, Wei Liu wrote:
> > ... otherwise when device add operation fails, the error message looks
> > like "libxl: error: libxl.c:1897:device_addrm_aocomplete: unable to (null)
> > device", which is not very helpful.
>
> Thanks.
> >
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > ---
> > tools/libxl/libxl.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> > index f7961f6..de23fec 100644
> > --- a/tools/libxl/libxl.c
> > +++ b/tools/libxl/libxl.c
> > @@ -4164,6 +4164,7 @@ DEFINE_DEVICE_REMOVE(vtpm, destroy, 1)
> > \
> > GCNEW(aodev); \
> > libxl__prepare_ao_device(ao, aodev); \
> > + aodev->action = LIBXL__DEVICE_ACTION_ADD; \
> > aodev->callback = device_addrm_aocomplete; \
> > aodev->update_json = true; \
> > libxl__device_##type##_add(egc, domid, type, aodev); \
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD
2014-11-12 15:16 ` Konrad Rzeszutek Wilk
@ 2014-11-14 10:57 ` Ian Campbell
0 siblings, 0 replies; 10+ messages in thread
From: Ian Campbell @ 2014-11-14 10:57 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: Ian Jackson, Wei Liu, xen-devel
On Wed, 2014-11-12 at 10:16 -0500, Konrad Rzeszutek Wilk wrote:
> On Wed, Nov 12, 2014 at 10:56:24AM +0000, Ian Campbell wrote:
> > On Wed, 2014-11-12 at 10:39 +0000, Wei Liu wrote:
> > > ... otherwise when device add operation fails, the error message looks
> > > like "libxl: error: libxl.c:1897:device_addrm_aocomplete: unable to (null)
> > > device", which is not very helpful.
> >
> > Thanks.
> > >
> > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> >
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD
2014-11-12 10:56 ` Ian Campbell
2014-11-12 15:16 ` Konrad Rzeszutek Wilk
@ 2014-11-14 10:35 ` Ian Campbell
2014-11-14 10:40 ` Ian Campbell
1 sibling, 1 reply; 10+ messages in thread
From: Ian Campbell @ 2014-11-14 10:35 UTC (permalink / raw)
To: Wei Liu, Konrad Rzeszutek Wilk; +Cc: Ian Jackson, xen-devel
On Wed, 2014-11-12 at 10:56 +0000, Ian Campbell wrote:
> On Wed, 2014-11-12 at 10:39 +0000, Wei Liu wrote:
> > ... otherwise when device add operation fails, the error message looks
> > like "libxl: error: libxl.c:1897:device_addrm_aocomplete: unable to (null)
> > device", which is not very helpful.
>
> Thanks.
> >
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
Konrad, in v1 Wei said "This is a simple enough bug fix I think it
should just go in." and I agree.
>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > ---
> > tools/libxl/libxl.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> > index f7961f6..de23fec 100644
> > --- a/tools/libxl/libxl.c
> > +++ b/tools/libxl/libxl.c
> > @@ -4164,6 +4164,7 @@ DEFINE_DEVICE_REMOVE(vtpm, destroy, 1)
> > \
> > GCNEW(aodev); \
> > libxl__prepare_ao_device(ao, aodev); \
> > + aodev->action = LIBXL__DEVICE_ACTION_ADD; \
> > aodev->callback = device_addrm_aocomplete; \
> > aodev->update_json = true; \
> > libxl__device_##type##_add(egc, domid, type, aodev); \
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD
2014-11-14 10:35 ` Ian Campbell
@ 2014-11-14 10:40 ` Ian Campbell
0 siblings, 0 replies; 10+ messages in thread
From: Ian Campbell @ 2014-11-14 10:40 UTC (permalink / raw)
To: Wei Liu; +Cc: xen-devel, Ian Jackson
On Fri, 2014-11-14 at 10:35 +0000, Ian Campbell wrote:
> On Wed, 2014-11-12 at 10:56 +0000, Ian Campbell wrote:
> > On Wed, 2014-11-12 at 10:39 +0000, Wei Liu wrote:
> > > ... otherwise when device add operation fails, the error message looks
> > > like "libxl: error: libxl.c:1897:device_addrm_aocomplete: unable to (null)
> > > device", which is not very helpful.
> >
> > Thanks.
> > >
> > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> >
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> Konrad, in v1 Wei said "This is a simple enough bug fix I think it
> should just go in." and I agree.
Nevermind I've just seen the ack which was in the wrong folder here.
>
> >
> > > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > > ---
> > > tools/libxl/libxl.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> > > index f7961f6..de23fec 100644
> > > --- a/tools/libxl/libxl.c
> > > +++ b/tools/libxl/libxl.c
> > > @@ -4164,6 +4164,7 @@ DEFINE_DEVICE_REMOVE(vtpm, destroy, 1)
> > > \
> > > GCNEW(aodev); \
> > > libxl__prepare_ao_device(ao, aodev); \
> > > + aodev->action = LIBXL__DEVICE_ACTION_ADD; \
> > > aodev->callback = device_addrm_aocomplete; \
> > > aodev->update_json = true; \
> > > libxl__device_##type##_add(egc, domid, type, aodev); \
> >
> >
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-11-14 10:57 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-11 13:46 [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD Wei Liu
2014-11-12 10:01 ` Ian Campbell
2014-11-12 10:36 ` Wei Liu
-- strict thread matches above, loose matches on Subject: below --
2014-11-12 10:39 Wei Liu
2014-11-12 10:55 ` Wei Liu
2014-11-12 10:56 ` Ian Campbell
2014-11-12 15:16 ` Konrad Rzeszutek Wilk
2014-11-14 10:57 ` Ian Campbell
2014-11-14 10:35 ` Ian Campbell
2014-11-14 10:40 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.