From: Minchan Kim <minchan@kernel.org>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Richard Davies <richard@arachsys.com>,
Shaohua Li <shli@kernel.org>, Rik van Riel <riel@redhat.com>,
Avi Kivity <avi@redhat.com>, QEMU-devel <qemu-devel@nongnu.org>,
KVM <kvm@vger.kernel.org>, Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/9] mm: compaction: Abort compaction loop if lock is contended or run too long
Date: Tue, 25 Sep 2012 16:34:57 +0900 [thread overview]
Message-ID: <20120925073456.GL13234@bbox> (raw)
In-Reply-To: <1348224383-1499-5-git-send-email-mgorman@suse.de>
On Fri, Sep 21, 2012 at 11:46:18AM +0100, Mel Gorman wrote:
> From: Shaohua Li <shli@fusionio.com>
>
> Changelog since V2
> o Fix BUG_ON triggered due to pages left on cc.migratepages
> o Make compact_zone_order() require non-NULL arg `contended'
>
> Changelog since V1
> o only abort the compaction if lock is contended or run too long
> o Rearranged the code by Andrea Arcangeli.
>
> isolate_migratepages_range() might isolate no pages if for example when
> zone->lru_lock is contended and running asynchronous compaction. In this
> case, we should abort compaction, otherwise, compact_zone will run a
> useless loop and make zone->lru_lock is even contended.
>
> [minchan@kernel.org: Putback pages isolated for migration if aborting]
> [akpm@linux-foundation.org: compact_zone_order requires non-NULL arg contended]
> Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
> Signed-off-by: Shaohua Li <shli@fusionio.com>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
> Acked-by: Rik van Riel <riel@redhat.com>
Acked-by: Minchan Kim <minchan@kernel.org>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Richard Davies <richard@arachsys.com>,
Shaohua Li <shli@kernel.org>, Rik van Riel <riel@redhat.com>,
Avi Kivity <avi@redhat.com>, QEMU-devel <qemu-devel@nongnu.org>,
KVM <kvm@vger.kernel.org>, Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/9] mm: compaction: Abort compaction loop if lock is contended or run too long
Date: Tue, 25 Sep 2012 16:34:57 +0900 [thread overview]
Message-ID: <20120925073456.GL13234@bbox> (raw)
In-Reply-To: <1348224383-1499-5-git-send-email-mgorman@suse.de>
On Fri, Sep 21, 2012 at 11:46:18AM +0100, Mel Gorman wrote:
> From: Shaohua Li <shli@fusionio.com>
>
> Changelog since V2
> o Fix BUG_ON triggered due to pages left on cc.migratepages
> o Make compact_zone_order() require non-NULL arg `contended'
>
> Changelog since V1
> o only abort the compaction if lock is contended or run too long
> o Rearranged the code by Andrea Arcangeli.
>
> isolate_migratepages_range() might isolate no pages if for example when
> zone->lru_lock is contended and running asynchronous compaction. In this
> case, we should abort compaction, otherwise, compact_zone will run a
> useless loop and make zone->lru_lock is even contended.
>
> [minchan@kernel.org: Putback pages isolated for migration if aborting]
> [akpm@linux-foundation.org: compact_zone_order requires non-NULL arg contended]
> Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
> Signed-off-by: Shaohua Li <shli@fusionio.com>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
> Acked-by: Rik van Riel <riel@redhat.com>
Acked-by: Minchan Kim <minchan@kernel.org>
--
Kind regards,
Minchan Kim
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Mel Gorman <mgorman@suse.de>
Cc: Richard Davies <richard@arachsys.com>, KVM <kvm@vger.kernel.org>,
QEMU-devel <qemu-devel@nongnu.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>, Avi Kivity <avi@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Shaohua Li <shli@kernel.org>
Subject: Re: [Qemu-devel] [PATCH 4/9] mm: compaction: Abort compaction loop if lock is contended or run too long
Date: Tue, 25 Sep 2012 16:34:57 +0900 [thread overview]
Message-ID: <20120925073456.GL13234@bbox> (raw)
In-Reply-To: <1348224383-1499-5-git-send-email-mgorman@suse.de>
On Fri, Sep 21, 2012 at 11:46:18AM +0100, Mel Gorman wrote:
> From: Shaohua Li <shli@fusionio.com>
>
> Changelog since V2
> o Fix BUG_ON triggered due to pages left on cc.migratepages
> o Make compact_zone_order() require non-NULL arg `contended'
>
> Changelog since V1
> o only abort the compaction if lock is contended or run too long
> o Rearranged the code by Andrea Arcangeli.
>
> isolate_migratepages_range() might isolate no pages if for example when
> zone->lru_lock is contended and running asynchronous compaction. In this
> case, we should abort compaction, otherwise, compact_zone will run a
> useless loop and make zone->lru_lock is even contended.
>
> [minchan@kernel.org: Putback pages isolated for migration if aborting]
> [akpm@linux-foundation.org: compact_zone_order requires non-NULL arg contended]
> Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
> Signed-off-by: Shaohua Li <shli@fusionio.com>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
> Acked-by: Rik van Riel <riel@redhat.com>
Acked-by: Minchan Kim <minchan@kernel.org>
--
Kind regards,
Minchan Kim
next prev parent reply other threads:[~2012-09-25 7:34 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 10:46 [PATCH 0/9] Reduce compaction scanning and lock contention Mel Gorman
2012-09-21 10:46 ` [Qemu-devel] " Mel Gorman
2012-09-21 10:46 ` Mel Gorman
2012-09-21 10:46 ` [PATCH 1/9] Revert "mm: compaction: check lock contention first before taking lock" Mel Gorman
2012-09-21 10:46 ` [Qemu-devel] " Mel Gorman
2012-09-21 10:46 ` Mel Gorman
2012-09-21 17:46 ` Rafael Aquini
2012-09-21 17:46 ` [Qemu-devel] " Rafael Aquini
2012-09-21 17:46 ` Rafael Aquini
2012-09-21 10:46 ` [PATCH 2/9] Revert "mm-compaction-abort-compaction-loop-if-lock-is-contended-or-run-too-long-fix" Mel Gorman
2012-09-21 10:46 ` [Qemu-devel] " Mel Gorman
2012-09-21 10:46 ` Mel Gorman
2012-09-21 17:47 ` Rafael Aquini
2012-09-21 17:47 ` [Qemu-devel] " Rafael Aquini
2012-09-21 17:47 ` Rafael Aquini
2012-09-21 10:46 ` [PATCH 3/9] Revert "mm: compaction: abort compaction loop if lock is contended or run too long" Mel Gorman
2012-09-21 10:46 ` [Qemu-devel] " Mel Gorman
2012-09-21 10:46 ` Mel Gorman
2012-09-21 17:48 ` Rafael Aquini
2012-09-21 17:48 ` [Qemu-devel] " Rafael Aquini
2012-09-21 17:48 ` Rafael Aquini
2012-09-21 10:46 ` [PATCH 4/9] mm: compaction: Abort compaction loop if lock is contended or run too long Mel Gorman
2012-09-21 10:46 ` [Qemu-devel] " Mel Gorman
2012-09-21 10:46 ` Mel Gorman
2012-09-21 17:50 ` Rafael Aquini
2012-09-21 17:50 ` [Qemu-devel] " Rafael Aquini
2012-09-21 17:50 ` Rafael Aquini
2012-09-21 21:31 ` Andrew Morton
2012-09-21 21:31 ` [Qemu-devel] " Andrew Morton
2012-09-21 21:31 ` Andrew Morton
2012-09-25 7:34 ` Minchan Kim [this message]
2012-09-25 7:34 ` [Qemu-devel] " Minchan Kim
2012-09-25 7:34 ` Minchan Kim
2012-09-21 10:46 ` [PATCH 5/9] mm: compaction: Acquire the zone->lru_lock as late as possible Mel Gorman
2012-09-21 10:46 ` [Qemu-devel] " Mel Gorman
2012-09-21 10:46 ` Mel Gorman
2012-09-21 17:51 ` Rafael Aquini
2012-09-21 17:51 ` [Qemu-devel] " Rafael Aquini
2012-09-21 17:51 ` Rafael Aquini
2012-09-25 7:05 ` Minchan Kim
2012-09-25 7:05 ` [Qemu-devel] " Minchan Kim
2012-09-25 7:05 ` Minchan Kim
2012-09-25 7:51 ` Mel Gorman
2012-09-25 7:51 ` [Qemu-devel] " Mel Gorman
2012-09-25 7:51 ` Mel Gorman
2012-09-25 8:13 ` Minchan Kim
2012-09-25 8:13 ` [Qemu-devel] " Minchan Kim
2012-09-25 8:13 ` Minchan Kim
2012-09-25 21:39 ` Andrew Morton
2012-09-25 21:39 ` [Qemu-devel] " Andrew Morton
2012-09-25 21:39 ` Andrew Morton
2012-09-26 0:23 ` Minchan Kim
2012-09-26 0:23 ` [Qemu-devel] " Minchan Kim
2012-09-26 0:23 ` Minchan Kim
2012-09-26 10:17 ` Mel Gorman
2012-09-26 10:17 ` [Qemu-devel] " Mel Gorman
2012-09-26 10:17 ` Mel Gorman
2012-09-21 10:46 ` [PATCH 6/9] mm: compaction: Acquire the zone->lock " Mel Gorman
2012-09-21 10:46 ` [Qemu-devel] " Mel Gorman
2012-09-21 10:46 ` Mel Gorman
2012-09-21 17:52 ` Rafael Aquini
2012-09-21 17:52 ` [Qemu-devel] " Rafael Aquini
2012-09-21 17:52 ` Rafael Aquini
2012-09-21 21:35 ` Andrew Morton
2012-09-21 21:35 ` [Qemu-devel] " Andrew Morton
2012-09-21 21:35 ` Andrew Morton
2012-09-24 8:52 ` Mel Gorman
2012-09-24 8:52 ` [Qemu-devel] " Mel Gorman
2012-09-24 8:52 ` Mel Gorman
2012-09-25 7:36 ` Minchan Kim
2012-09-25 7:36 ` [Qemu-devel] " Minchan Kim
2012-09-25 7:36 ` Minchan Kim
2012-09-25 7:35 ` Minchan Kim
2012-09-25 7:35 ` [Qemu-devel] " Minchan Kim
2012-09-25 7:35 ` Minchan Kim
2012-09-21 10:46 ` [PATCH 7/9] Revert "mm: have order > 0 compaction start off where it left" Mel Gorman
2012-09-21 10:46 ` [Qemu-devel] " Mel Gorman
2012-09-21 10:46 ` Mel Gorman
2012-09-21 17:52 ` Rafael Aquini
2012-09-21 17:52 ` [Qemu-devel] " Rafael Aquini
2012-09-21 17:52 ` Rafael Aquini
2012-09-25 7:37 ` Minchan Kim
2012-09-25 7:37 ` [Qemu-devel] " Minchan Kim
2012-09-25 7:37 ` Minchan Kim
2012-09-21 10:46 ` [PATCH 8/9] mm: compaction: Cache if a pageblock was scanned and no pages were isolated Mel Gorman
2012-09-21 10:46 ` [Qemu-devel] " Mel Gorman
2012-09-21 10:46 ` Mel Gorman
2012-09-21 17:53 ` Rafael Aquini
2012-09-21 17:53 ` [Qemu-devel] " Rafael Aquini
2012-09-21 17:53 ` Rafael Aquini
2012-09-21 21:36 ` Andrew Morton
2012-09-21 21:36 ` [Qemu-devel] " Andrew Morton
2012-09-21 21:36 ` Andrew Morton
2012-09-24 9:39 ` Mel Gorman
2012-09-24 9:39 ` [Qemu-devel] " Mel Gorman
2012-09-24 9:39 ` Mel Gorman
2012-09-24 21:26 ` Andrew Morton
2012-09-24 21:26 ` [Qemu-devel] " Andrew Morton
2012-09-24 21:26 ` Andrew Morton
2012-09-25 9:12 ` Mel Gorman
2012-09-25 9:12 ` [Qemu-devel] " Mel Gorman
2012-09-25 9:12 ` Mel Gorman
2012-09-25 20:03 ` Andrew Morton
2012-09-25 20:03 ` [Qemu-devel] " Andrew Morton
2012-09-25 20:03 ` Andrew Morton
2012-09-27 12:06 ` [PATCH] mm: compaction: cache if a pageblock was scanned and no pages were isolated -fix2 Mel Gorman
2012-09-27 12:06 ` [Qemu-devel] " Mel Gorman
2012-09-27 12:06 ` Mel Gorman
2012-09-27 13:12 ` [PATCH 8/9] mm: compaction: Cache if a pageblock was scanned and no pages were isolated Mel Gorman
2012-09-27 13:12 ` [Qemu-devel] " Mel Gorman
2012-09-27 13:12 ` Mel Gorman
2012-09-26 0:49 ` Minchan Kim
2012-09-26 0:49 ` [Qemu-devel] " Minchan Kim
2012-09-26 0:49 ` Minchan Kim
2012-09-27 12:14 ` Mel Gorman
2012-09-27 12:14 ` [Qemu-devel] " Mel Gorman
2012-09-27 12:14 ` Mel Gorman
2012-09-21 10:46 ` [PATCH 9/9] mm: compaction: Restart compaction from near where it left off Mel Gorman
2012-09-21 10:46 ` [Qemu-devel] " Mel Gorman
2012-09-21 10:46 ` Mel Gorman
2012-09-21 17:54 ` Rafael Aquini
2012-09-21 17:54 ` [Qemu-devel] " Rafael Aquini
2012-09-21 17:54 ` Rafael Aquini
2012-09-21 13:51 ` [PATCH 0/9] Reduce compaction scanning and lock contention Rik van Riel
2012-09-21 13:51 ` [Qemu-devel] " Rik van Riel
2012-09-21 13:51 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120925073456.GL13234@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=richard@arachsys.com \
--cc=riel@redhat.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.