All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Richard Davies <richard@arachsys.com>,
	Shaohua Li <shli@kernel.org>, Rik van Riel <riel@redhat.com>,
	Avi Kivity <avi@redhat.com>, QEMU-devel <qemu-devel@nongnu.org>,
	KVM <kvm@vger.kernel.org>, Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] mm: compaction: cache if a pageblock was scanned and no pages were isolated -fix2
Date: Thu, 27 Sep 2012 13:06:21 +0100	[thread overview]
Message-ID: <20120927120621.GB3429@suse.de> (raw)
In-Reply-To: <20120925130352.0d60957a.akpm@linux-foundation.org>

The clearing of PG_migrate_skip potentially takes a long time if the
zone is massive. Be safe and check if it needs to reschedule.

This is a fix for
mm-compaction-cache-if-a-pageblock-was-scanned-and-no-pages-were-isolated.patch

Signed-off-by: Mel Gorman <mgorman@suse.de>
---
 mm/compaction.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/mm/compaction.c b/mm/compaction.c
index fb07abb..722d10f 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -85,6 +85,9 @@ static void reset_isolation_suitable(struct zone *zone)
 	/* Walk the zone and mark every pageblock as suitable for isolation */
 	for (pfn = start_pfn; pfn < end_pfn; pfn += pageblock_nr_pages) {
 		struct page *page;
+
+		cond_resched();
+
 		if (!pfn_valid(pfn))
 			continue;
 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Richard Davies <richard@arachsys.com>,
	Shaohua Li <shli@kernel.org>, Rik van Riel <riel@redhat.com>,
	Avi Kivity <avi@redhat.com>, QEMU-devel <qemu-devel@nongnu.org>,
	KVM <kvm@vger.kernel.org>, Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] mm: compaction: cache if a pageblock was scanned and no pages were isolated -fix2
Date: Thu, 27 Sep 2012 13:06:21 +0100	[thread overview]
Message-ID: <20120927120621.GB3429@suse.de> (raw)
In-Reply-To: <20120925130352.0d60957a.akpm@linux-foundation.org>

The clearing of PG_migrate_skip potentially takes a long time if the
zone is massive. Be safe and check if it needs to reschedule.

This is a fix for
mm-compaction-cache-if-a-pageblock-was-scanned-and-no-pages-were-isolated.patch

Signed-off-by: Mel Gorman <mgorman@suse.de>
---
 mm/compaction.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/mm/compaction.c b/mm/compaction.c
index fb07abb..722d10f 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -85,6 +85,9 @@ static void reset_isolation_suitable(struct zone *zone)
 	/* Walk the zone and mark every pageblock as suitable for isolation */
 	for (pfn = start_pfn; pfn < end_pfn; pfn += pageblock_nr_pages) {
 		struct page *page;
+
+		cond_resched();
+
 		if (!pfn_valid(pfn))
 			continue;
 

WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Richard Davies <richard@arachsys.com>, KVM <kvm@vger.kernel.org>,
	QEMU-devel <qemu-devel@nongnu.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux-MM <linux-mm@kvack.org>, Avi Kivity <avi@redhat.com>,
	Shaohua Li <shli@kernel.org>
Subject: [Qemu-devel] [PATCH] mm: compaction: cache if a pageblock was scanned and no pages were isolated -fix2
Date: Thu, 27 Sep 2012 13:06:21 +0100	[thread overview]
Message-ID: <20120927120621.GB3429@suse.de> (raw)
In-Reply-To: <20120925130352.0d60957a.akpm@linux-foundation.org>

The clearing of PG_migrate_skip potentially takes a long time if the
zone is massive. Be safe and check if it needs to reschedule.

This is a fix for
mm-compaction-cache-if-a-pageblock-was-scanned-and-no-pages-were-isolated.patch

Signed-off-by: Mel Gorman <mgorman@suse.de>
---
 mm/compaction.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/mm/compaction.c b/mm/compaction.c
index fb07abb..722d10f 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -85,6 +85,9 @@ static void reset_isolation_suitable(struct zone *zone)
 	/* Walk the zone and mark every pageblock as suitable for isolation */
 	for (pfn = start_pfn; pfn < end_pfn; pfn += pageblock_nr_pages) {
 		struct page *page;
+
+		cond_resched();
+
 		if (!pfn_valid(pfn))
 			continue;
 

  reply	other threads:[~2012-09-27 12:06 UTC|newest]

Thread overview: 126+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-21 10:46 [PATCH 0/9] Reduce compaction scanning and lock contention Mel Gorman
2012-09-21 10:46 ` [Qemu-devel] " Mel Gorman
2012-09-21 10:46 ` Mel Gorman
2012-09-21 10:46 ` [PATCH 1/9] Revert "mm: compaction: check lock contention first before taking lock" Mel Gorman
2012-09-21 10:46   ` [Qemu-devel] " Mel Gorman
2012-09-21 10:46   ` Mel Gorman
2012-09-21 17:46   ` Rafael Aquini
2012-09-21 17:46     ` [Qemu-devel] " Rafael Aquini
2012-09-21 17:46     ` Rafael Aquini
2012-09-21 10:46 ` [PATCH 2/9] Revert "mm-compaction-abort-compaction-loop-if-lock-is-contended-or-run-too-long-fix" Mel Gorman
2012-09-21 10:46   ` [Qemu-devel] " Mel Gorman
2012-09-21 10:46   ` Mel Gorman
2012-09-21 17:47   ` Rafael Aquini
2012-09-21 17:47     ` [Qemu-devel] " Rafael Aquini
2012-09-21 17:47     ` Rafael Aquini
2012-09-21 10:46 ` [PATCH 3/9] Revert "mm: compaction: abort compaction loop if lock is contended or run too long" Mel Gorman
2012-09-21 10:46   ` [Qemu-devel] " Mel Gorman
2012-09-21 10:46   ` Mel Gorman
2012-09-21 17:48   ` Rafael Aquini
2012-09-21 17:48     ` [Qemu-devel] " Rafael Aquini
2012-09-21 17:48     ` Rafael Aquini
2012-09-21 10:46 ` [PATCH 4/9] mm: compaction: Abort compaction loop if lock is contended or run too long Mel Gorman
2012-09-21 10:46   ` [Qemu-devel] " Mel Gorman
2012-09-21 10:46   ` Mel Gorman
2012-09-21 17:50   ` Rafael Aquini
2012-09-21 17:50     ` [Qemu-devel] " Rafael Aquini
2012-09-21 17:50     ` Rafael Aquini
2012-09-21 21:31   ` Andrew Morton
2012-09-21 21:31     ` [Qemu-devel] " Andrew Morton
2012-09-21 21:31     ` Andrew Morton
2012-09-25  7:34   ` Minchan Kim
2012-09-25  7:34     ` [Qemu-devel] " Minchan Kim
2012-09-25  7:34     ` Minchan Kim
2012-09-21 10:46 ` [PATCH 5/9] mm: compaction: Acquire the zone->lru_lock as late as possible Mel Gorman
2012-09-21 10:46   ` [Qemu-devel] " Mel Gorman
2012-09-21 10:46   ` Mel Gorman
2012-09-21 17:51   ` Rafael Aquini
2012-09-21 17:51     ` [Qemu-devel] " Rafael Aquini
2012-09-21 17:51     ` Rafael Aquini
2012-09-25  7:05   ` Minchan Kim
2012-09-25  7:05     ` [Qemu-devel] " Minchan Kim
2012-09-25  7:05     ` Minchan Kim
2012-09-25  7:51     ` Mel Gorman
2012-09-25  7:51       ` [Qemu-devel] " Mel Gorman
2012-09-25  7:51       ` Mel Gorman
2012-09-25  8:13       ` Minchan Kim
2012-09-25  8:13         ` [Qemu-devel] " Minchan Kim
2012-09-25  8:13         ` Minchan Kim
2012-09-25 21:39         ` Andrew Morton
2012-09-25 21:39           ` [Qemu-devel] " Andrew Morton
2012-09-25 21:39           ` Andrew Morton
2012-09-26  0:23           ` Minchan Kim
2012-09-26  0:23             ` [Qemu-devel] " Minchan Kim
2012-09-26  0:23             ` Minchan Kim
2012-09-26 10:17           ` Mel Gorman
2012-09-26 10:17             ` [Qemu-devel] " Mel Gorman
2012-09-26 10:17             ` Mel Gorman
2012-09-21 10:46 ` [PATCH 6/9] mm: compaction: Acquire the zone->lock " Mel Gorman
2012-09-21 10:46   ` [Qemu-devel] " Mel Gorman
2012-09-21 10:46   ` Mel Gorman
2012-09-21 17:52   ` Rafael Aquini
2012-09-21 17:52     ` [Qemu-devel] " Rafael Aquini
2012-09-21 17:52     ` Rafael Aquini
2012-09-21 21:35   ` Andrew Morton
2012-09-21 21:35     ` [Qemu-devel] " Andrew Morton
2012-09-21 21:35     ` Andrew Morton
2012-09-24  8:52     ` Mel Gorman
2012-09-24  8:52       ` [Qemu-devel] " Mel Gorman
2012-09-24  8:52       ` Mel Gorman
2012-09-25  7:36       ` Minchan Kim
2012-09-25  7:36         ` [Qemu-devel] " Minchan Kim
2012-09-25  7:36         ` Minchan Kim
2012-09-25  7:35   ` Minchan Kim
2012-09-25  7:35     ` [Qemu-devel] " Minchan Kim
2012-09-25  7:35     ` Minchan Kim
2012-09-21 10:46 ` [PATCH 7/9] Revert "mm: have order > 0 compaction start off where it left" Mel Gorman
2012-09-21 10:46   ` [Qemu-devel] " Mel Gorman
2012-09-21 10:46   ` Mel Gorman
2012-09-21 17:52   ` Rafael Aquini
2012-09-21 17:52     ` [Qemu-devel] " Rafael Aquini
2012-09-21 17:52     ` Rafael Aquini
2012-09-25  7:37   ` Minchan Kim
2012-09-25  7:37     ` [Qemu-devel] " Minchan Kim
2012-09-25  7:37     ` Minchan Kim
2012-09-21 10:46 ` [PATCH 8/9] mm: compaction: Cache if a pageblock was scanned and no pages were isolated Mel Gorman
2012-09-21 10:46   ` [Qemu-devel] " Mel Gorman
2012-09-21 10:46   ` Mel Gorman
2012-09-21 17:53   ` Rafael Aquini
2012-09-21 17:53     ` [Qemu-devel] " Rafael Aquini
2012-09-21 17:53     ` Rafael Aquini
2012-09-21 21:36   ` Andrew Morton
2012-09-21 21:36     ` [Qemu-devel] " Andrew Morton
2012-09-21 21:36     ` Andrew Morton
2012-09-24  9:39     ` Mel Gorman
2012-09-24  9:39       ` [Qemu-devel] " Mel Gorman
2012-09-24  9:39       ` Mel Gorman
2012-09-24 21:26       ` Andrew Morton
2012-09-24 21:26         ` [Qemu-devel] " Andrew Morton
2012-09-24 21:26         ` Andrew Morton
2012-09-25  9:12         ` Mel Gorman
2012-09-25  9:12           ` [Qemu-devel] " Mel Gorman
2012-09-25  9:12           ` Mel Gorman
2012-09-25 20:03           ` Andrew Morton
2012-09-25 20:03             ` [Qemu-devel] " Andrew Morton
2012-09-25 20:03             ` Andrew Morton
2012-09-27 12:06             ` Mel Gorman [this message]
2012-09-27 12:06               ` [Qemu-devel] [PATCH] mm: compaction: cache if a pageblock was scanned and no pages were isolated -fix2 Mel Gorman
2012-09-27 12:06               ` Mel Gorman
2012-09-27 13:12             ` [PATCH 8/9] mm: compaction: Cache if a pageblock was scanned and no pages were isolated Mel Gorman
2012-09-27 13:12               ` [Qemu-devel] " Mel Gorman
2012-09-27 13:12               ` Mel Gorman
2012-09-26  0:49           ` Minchan Kim
2012-09-26  0:49             ` [Qemu-devel] " Minchan Kim
2012-09-26  0:49             ` Minchan Kim
2012-09-27 12:14             ` Mel Gorman
2012-09-27 12:14               ` [Qemu-devel] " Mel Gorman
2012-09-27 12:14               ` Mel Gorman
2012-09-21 10:46 ` [PATCH 9/9] mm: compaction: Restart compaction from near where it left off Mel Gorman
2012-09-21 10:46   ` [Qemu-devel] " Mel Gorman
2012-09-21 10:46   ` Mel Gorman
2012-09-21 17:54   ` Rafael Aquini
2012-09-21 17:54     ` [Qemu-devel] " Rafael Aquini
2012-09-21 17:54     ` Rafael Aquini
2012-09-21 13:51 ` [PATCH 0/9] Reduce compaction scanning and lock contention Rik van Riel
2012-09-21 13:51   ` [Qemu-devel] " Rik van Riel
2012-09-21 13:51   ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120927120621.GB3429@suse.de \
    --to=mgorman@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard@arachsys.com \
    --cc=riel@redhat.com \
    --cc=shli@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.