Re: [PATCH 01/28] dt-bindings: sound: Add Apple Macs sound peripherals

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] dt-bindings: schema rejects tdm-slot properties due to additionalProperties: false
- [Low] dt-bindings: missing additionalProperties constraint in cpu and codec nodes
--

commit 6dde9306ab23cf8705214300b5ab2897b3cef4f7
Author: Martin Povišer <povik+lin@cutebit.org>

dt-bindings: sound: Add Apple Macs sound peripherals

This commit adds a device tree binding for Apple Silicon Macs machine-level
integration of sound peripherals, starting with the M1 series.

> diff --git a/Documentation/devicetree/bindings/sound/apple,macaudio.yaml b/Documentation/devicetree/bindings/sound/apple,macaudio.yaml
> new file mode 100644
> index 0000000000000..bd844c9928c99
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/apple,macaudio.yaml
> @@ -0,0 +1,235 @@

[ ... ]

> +patternProperties:
> +  "^dai-link(@[0-9a-f]+)?$":
> +    description: |
> +      Node for each sound peripheral such as the speaker array, headphones jack,
> +      or microphone.
> +    type: object
> +    $ref: tdm-slot.yaml#
> +
> +    additionalProperties: false

[Severity: Low]
Does this block valid properties from tdm-slot.yaml? additionalProperties: false
only evaluates properties explicitly defined in the local schema node. Since
the referenced properties from tdm-slot.yaml are not considered evaluated, they
will be incorrectly rejected. Should this be unevaluatedProperties: false
instead?

> +
> +    properties:
> +      reg:
> +        maxItems: 1
> +
> +      link-name:
> +        description: |
> +          Name for the peripheral, expecting 'Speaker' or 'Speakers' if this is
> +          the speaker array.
> +        $ref: /schemas/types.yaml#/definitions/string
> +
> +      cpu:
> +        type: object
> +
> +        properties:
> +          sound-dai:

[Severity: Low]
Are we missing an additionalProperties: false constraint for the cpu object?
Without it, any extraneous invalid properties or typos like sound_dai will
silently pass schema validation.

> +            description: |
> +              DAI list with CPU-side I2S ports involved in this peripheral.
> +            minItems: 1
> +            maxItems: 2
> +
> +        required:
> +          - sound-dai
> +
> +      codec:
> +        type: object
> +
> +        properties:
> +          sound-dai:

[Severity: Low]
Similar to the cpu object above, does the codec object also need an
additionalProperties: false constraint to catch typos and invalid properties?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260920-macaudio-v1-0-741cc20a74e5@gmail.com?part=1