Re: [PATCH 23/28] arm64: dts: apple: t8112-j473: Add speaker/headset jack nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: missing reg and address-cells in unit-addressed dai-link nodes
--

commit 2807e1e10c5e8e2ab5f1a1be50044624cb7a4535
Author: James Calligeros <jcalligeros99@gmail.com>

arm64: dts: apple: t8112-j473: Add speaker/headset jack nodes

The M2 Mac mini integrates Apple-specific variants of the TI TAS2764
and Cirrus CS42L42. Add these nodes and advertise them to the machine
driver via the sound node.

> diff --git a/arch/arm64/boot/dts/apple/t8112-j473.dts b/arch/arm64/boot/dts/apple/t8112-j473.dts
> index 105a9d118980f..50088283f2e8e 100644
> --- a/arch/arm64/boot/dts/apple/t8112-j473.dts
> +++ b/arch/arm64/boot/dts/apple/t8112-j473.dts

[ ... ]

> +/ {
> +	sound: sound {
> +		compatible = "apple,j473-macaudio", "apple,macaudio";
> +		model = "Mac mini J473";

[Severity: Low]
Does this node need #address-cells = <1>; and #size-cells = <0>; properties
since it has unit-addressed children? Omitting them causes dtc validation
warnings (unit_address_vs_reg) and fails the apple,macaudio.yaml schema check.

> +
> +		dai-link@0 {

[Severity: Low]
Should this node include a reg = <0>; property to match its unit address?

> +			link-name = "Speakers";
> +
> +			codec {
> +				sound-dai = <&speaker>;
> +			};
> +
> +			cpu {
> +				sound-dai = <&mca 0>;
> +			};
> +		};
> +
> +		dai-link@1 {

[Severity: Low]
Should this node include a reg = <1>; property to match its unit address?

> +			link-name = "Headphone Jack";
> +
> +			codec {
> +				sound-dai = <&jack_codec>;
> +			};
> +
> +			cpu {
> +				sound-dai = <&mca 2>;
> +			};
> +		};
> +	};
> +};
> +
>  #include "hwmon-mini.dtsi"

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260920-macaudio-v1-0-741cc20a74e5@gmail.com?part=23