Re: [PATCH 25/28] arm64: dts: apple: t600x-j31x: Add speaker/headset jack nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: typo in dai-tdm-slot-tx-idle-mask property prevents TDM idle configuration
--

commit f5c52499a0a647e882ff3e2323a3096d2ee9614e
Author: James Calligeros <jcalligeros99@gmail.com>

arm64: dts: apple: t600x-j31x: Add speaker/headset jack nodes
    
This commit adds I2C nodes for the speaker and headset jack audio codecs
used in the M1 Pro/Max MacBooks. It also configures the audio routing by
adding the sound machine driver node.

> diff --git a/arch/arm64/boot/dts/apple/t600x-j314-j316.dtsi b/arch/arm64/boot/dts/apple/t600x-j314-j316.dtsi
> index caded1636f3d2..7afd385ce57dc 100644
> --- a/arch/arm64/boot/dts/apple/t600x-j314-j316.dtsi
> +++ b/arch/arm64/boot/dts/apple/t600x-j314-j316.dtsi
[ ... ]
> +/ {
> +	sound: sound {
> +		/* Compatible is set for each machine */
> +
> +		dai-link@0 {
> +			dai-tdm-idle-mode-0 = "zero";
> +			dai-tdm-idle-mode-3 = "zero";
> +			dai-tdm-slot-tx-idle-mode-0 = <0xf0f0f0>;
> +			dai-tdm-slot-tx-idle-mode-3 = <0x0f0f0f>;

[Severity: Medium]
Does the ASoC machine driver look for the property with the "-mode" suffix
here?

Looking at macaudio_get_codec_idle_props() in sound/soc/apple/macaudio.c, it
appears the driver expects dai-tdm-slot-tx-idle-mask-%d to read these
bitmasks. Since the device tree spells this as "...-idle-mode-%d", the
property is not found and the idle_mask will remain 0.

Could this lead to unused TDM slots remaining unmasked during idle, causing
I2S bus noise or zero-stuffing failures?

> +
> +			link-name = "Speakers";
> +
> +			codec {
> +				sound-dai = <&speaker_left_woof1>,
> +					    <&speaker_left_tweet>,

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260920-macaudio-v1-0-741cc20a74e5@gmail.com?part=25