Re: [PATCH 26/28] arm64: dts: apple: t600x-j375: Add speaker/headset jack nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: unit address used without a reg property in dai-link nodes
--

commit 5d066ef5cb7fca6289258dc59c130ce74143e4c4
Author: James Calligeros <jcalligeros99@gmail.com>

arm64: dts: apple: t600x-j375: Add speaker/headset jack nodes

The M1 Max/Ultra Mac Studio integrates Apple-specific variants of
the TI TAS2764 and Cirrus CS42L42. This commit adds these nodes and
advertises them to the machine driver via the sound node.

> diff --git a/arch/arm64/boot/dts/apple/t600x-j375.dtsi b/arch/arm64/boot/dts/apple/t600x-j375.dtsi
> index 8a1494949e4c5..60aa9a870bd9e 100644
> --- a/arch/arm64/boot/dts/apple/t600x-j375.dtsi
> +++ b/arch/arm64/boot/dts/apple/t600x-j375.dtsi
[ ... ]
> +/ {
> +	sound: sound {
> +		/* Compatible is set for each machine */
> +
> +		dai-link@0 {

[Severity: Low]
Does this node need a reg property, or should the unit address be removed?

The Device Tree specification (section 2.2.1) strictly requires that any
node with a unit address (e.g., dai-link@0) must include a corresponding reg
property. Omitting the reg property triggers unit_address_vs_reg warnings
during make dtbs_check.

> +			link-name = "Speaker";
> +
> +			codec {
> +				sound-dai = <&speaker>;
> +			};
> +
> +			cpu {
> +				sound-dai = <&mca 0>;
> +			};
> +		};
> +
> +		dai-link@1 {

[Severity: Low]
Similarly, does this node need a reg property?

Like the node above, using dai-link@1 without a reg property will introduce
a new unit_address_vs_reg dtbs_check warning.

> +			link-name = "Headphone Jack";
> +
> +			codec {
> +				sound-dai = <&jack_codec>;
> +			};
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260920-macaudio-v1-0-741cc20a74e5@gmail.com?part=26