Re: [PATCH 20/28] arm64: dts: apple: t8103-j45x: Add headset jack nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [High] ASoC: apple: macaudio: J457 silently falls back to generic configuration
- [Low] dt-bindings: apple,macaudio: missing reg and address-cells in DT
- [Low] dt-bindings: cirrus,cs42l42: missing required power supply properties
--

commit 5cc5dec336bb9d8d002a9d3bcf32f9e5d5e39879
Author: James Calligeros <jcalligeros99@gmail.com>

arm64: dts: apple: t8103-j45x: Add headset jack nodes

This commit adds headset jack nodes to the M1 iMacs (t8103-j456 and
t8103-j457). It wires up the TI TAS2770 and Cirrus CS42L42 components
and advertises them via the sound node.

> diff --git a/arch/arm64/boot/dts/apple/t8103-j456.dts b/arch/arm64/boot/dts/apple/t8103-j456.dts
> index 090c97bb781b3..41ec1398f981b 100644
> --- a/arch/arm64/boot/dts/apple/t8103-j456.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j456.dts
[ ... ]
> +&i2c1 {
> +	status = "okay";
> +
> +	jack_codec: codec@48 {
> +		compatible = "cirrus,cs42l83";
> +		reg = <0x48>;
> +		interrupts-extended = <&pinctrl_ap 183 IRQ_TYPE_LEVEL_LOW>;
> +		reset-gpios = <&pinctrl_nub 11 GPIO_ACTIVE_HIGH>;
> +		#sound-dai-cells = <0>;
> +		sound-name-prefix = "Jack";

[Severity: Low]
Does this codec node miss required power supply properties? The 
cirrus,cs42l42.yaml schema requires VP-supply, VCP-supply, VD_FILT-supply,
VL-supply, and VA-supply. Furthermore, #sound-dai-cells and sound-name-prefix
do not appear to be declared in the schema, which causes an "additional
properties are not allowed" failure during dtbs_check.

> +		cirrus,ts-inv = <1>;
> +	};
> +};
> +
> +/ {
> +	sound: sound {
> +		compatible = "apple,j456-macaudio", "apple,macaudio";
> +		model = "iMac J456";
> +
> +		dai-link@1 {

[Severity: Low]
This dai-link node defines a unit address (@1) but lacks a corresponding
reg property. Would it be possible to add the reg property here, and also
include #address-cells and #size-cells in the parent sound node so the reg
property can be parsed correctly? Without these, the device tree compiler
will throw unit_address_vs_reg warnings.

[ ... ]
> diff --git a/arch/arm64/boot/dts/apple/t8103-j457.dts b/arch/arm64/boot/dts/apple/t8103-j457.dts
> index ebddde75455c6..aa2a08cb22cb4 100644
> --- a/arch/arm64/boot/dts/apple/t8103-j457.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j457.dts
[ ... ]
> +/ {
> +	sound: sound {
> +		compatible = "apple,j457-macaudio", "apple,macaudio";

[Severity: High]
The macaudio driver expects J457 to use "apple,j456-macaudio" as a DT fallback
and explicitly omits J457 from its macaudio_snd_device_id match table. Since
the "apple,j456-macaudio" compatible string is correctly omitted here to
satisfy the schema, won't of_match_device() silently match the generic
"apple,macaudio" instead? 

If so, this would assign the generic fallback configuration (AMP_NONE,
SPKR_NONE) to J457, which might severely misconfigure its amplifier and
speaker topology.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260920-macaudio-v1-0-741cc20a74e5@gmail.com?part=20