From: sashiko-bot@kernel.org
To: "James Calligeros" <jcalligeros99@gmail.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH 28/28] arm64: dts: apple: t602x-j47x: Add speaker/headset jack nodes
Date: Sun, 20 Sep 2026 05:15:28 +0000 [thread overview]
Message-ID: <20260920051528.D10E21F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260920-macaudio-v1-28-741cc20a74e5@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: apple: incorrect sound card model string for Mac mini J474s
--
commit 633b43ef406edcf6e9ee9884c46d686b36ff8900
Author: James Calligeros <jcalligeros99@gmail.com>
arm64: dts: apple: t602x-j47x: Add speaker/headset jack nodes
The M2 Pro/Max/Ultra Mac mini and Mac Studio integrate Apple-specific
variants of the TI TAS2764 and Cirrus CS42L42. Add these nodes and
advertise them to the machine driver via the sound node.
> diff --git a/arch/arm64/boot/dts/apple/t6020-j474s.dts b/arch/arm64/boot/dts/apple/t6020-j474s.dts
> index e3c2635d84fad..e79315b15f114 100644
> --- a/arch/arm64/boot/dts/apple/t6020-j474s.dts
> +++ b/arch/arm64/boot/dts/apple/t6020-j474s.dts
> @@ -46,4 +46,9 @@ &pcie0 {
> <0x300 &pcie0_dart_3 1 1>;
> };
>
> +&sound {
> + compatible = "apple,j474-macaudio", "apple,j473-macaudio", "apple,macaudio";
> + model = "Mac Studio J473";
[Severity: Medium]
Does this set the correct ALSA sound card name for the M2 Pro Mac mini
(J474s)?
The DT model property inside the &sound node defines the card name used by
ALSA Use Case Manager (UCM) to load the audio routing profile. Supplying
"Mac Studio J473" here means userspace might attempt to load a Mac Studio
profile instead of the Mac mini profile, which could break out-of-the-box
sound on this device.
> +};
> +
> #include "hwmon-mini.dtsi"
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260920-macaudio-v1-0-741cc20a74e5@gmail.com?part=28
next prev parent reply other threads:[~2026-09-20 5:15 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 4:53 [PATCH 00/28] Add speaker and headset jack support for Apple Silicon Macs James Calligeros
2026-09-20 4:53 ` [PATCH 01/28] dt-bindings: sound: Add Apple Macs sound peripherals James Calligeros
2026-09-20 5:06 ` sashiko-bot
2026-09-20 18:45 ` Sven Peter
2026-09-21 15:02 ` Mark Brown
2026-09-21 15:22 ` Mark Brown
2026-09-23 11:35 ` Krzysztof Kozlowski
2026-09-20 4:53 ` [PATCH 02/28] ASoC: cs42l42: Fix typo James Calligeros
2026-09-21 15:25 ` Mark Brown
2026-09-20 4:53 ` [PATCH 03/28] ASoC: cs42l42: Set a faster digital ramp-up rate James Calligeros
2026-09-20 4:53 ` [PATCH 04/28] ASoC: apple: mca: Fix PD link double-frees James Calligeros
2026-09-20 4:53 ` [PATCH 05/28] alsa: pcm: Remove the qos request only if active James Calligeros
2026-09-21 15:03 ` Mark Brown
2026-09-22 8:09 ` Mark Brown
2026-09-20 4:53 ` [PATCH 06/28] ALSA: dmaengine: Always terminate DMA when a PCM is closed James Calligeros
2026-09-20 5:05 ` sashiko-bot
2026-09-22 10:12 ` Mark Brown
2026-09-20 4:53 ` [PATCH 07/28] ALSA: Support nonatomic dmaengine PCMs James Calligeros
2026-09-20 5:09 ` sashiko-bot
2026-09-21 15:32 ` Mark Brown
2026-09-20 4:53 ` [PATCH 08/28] ALSA: control: Add kcontrol callbacks for lock/unlock James Calligeros
2026-09-20 5:11 ` sashiko-bot
2026-09-29 9:52 ` Takashi Iwai
2026-10-03 1:34 ` James Calligeros
2026-10-03 6:39 ` Takashi Iwai
2026-10-03 9:22 ` Takashi Iwai
2026-09-20 4:53 ` [PATCH 09/28] ASoC: ops: Move guts out of snd_soc_limit_volume James Calligeros
2026-09-20 4:53 ` [PATCH 10/28] ASoC: ops: Accept patterns in snd_soc_limit_volume James Calligeros
2026-09-20 5:12 ` sashiko-bot
2026-09-21 15:27 ` Mark Brown
2026-09-21 16:27 ` Charles Keepax
2026-09-23 11:12 ` James Calligeros
2026-09-20 4:53 ` [PATCH 11/28] ASoC: ops: Introduce 'snd_soc_deactivate_kctl' James Calligeros
2026-09-20 5:09 ` sashiko-bot
2026-09-22 9:53 ` Mark Brown
2026-09-20 4:53 ` [PATCH 12/28] ASoC: ops: Introduce 'soc_set_enum_kctl' James Calligeros
2026-09-20 5:10 ` sashiko-bot
2026-09-22 9:50 ` Mark Brown
2026-09-20 4:53 ` [PATCH 13/28] ASoC: card: Let 'fixup_controls' return errors James Calligeros
2026-09-20 4:53 ` [PATCH 14/28] ASoC: ops: Export snd_soc_control_matches() James Calligeros
2026-09-22 9:43 ` Mark Brown
2026-09-20 4:53 ` [PATCH 15/28] ASoC: tas2764: Set up V/ISENSE on codec probe James Calligeros
2026-09-20 5:10 ` sashiko-bot
2026-09-22 9:40 ` Mark Brown
2026-09-20 4:53 ` [PATCH 16/28] ASoC: apple: Add macaudio machine driver James Calligeros
2026-09-20 5:14 ` sashiko-bot
2026-09-22 9:38 ` Mark Brown
2026-09-26 1:06 ` James Calligeros
2026-09-28 11:03 ` Mark Brown
2026-09-30 7:36 ` James Calligeros
2026-09-30 11:17 ` Mark Brown
2026-09-20 4:53 ` [PATCH 17/28] arm64: dts: apple: t8103-j274: Add speaker/headset jack nodes James Calligeros
2026-09-20 5:14 ` sashiko-bot
2026-09-20 4:53 ` [PATCH 18/28] arm64: dts: apple: t8103-j313: " James Calligeros
2026-09-20 4:53 ` [PATCH 19/28] arm64: dts: apple: t8103-j293: " James Calligeros
2026-09-20 5:19 ` sashiko-bot
2026-09-20 4:53 ` [PATCH 20/28] arm64: dts: apple: t8103-j45x: Add headset " James Calligeros
2026-09-20 5:16 ` sashiko-bot
2026-09-20 4:54 ` [PATCH 21/28] arm64: dts: apple: t8112-j413: Add speaker/headset " James Calligeros
2026-09-20 5:14 ` sashiko-bot
2026-09-20 4:54 ` [PATCH 22/28] arm64: dts: apple: t8112-j415: " James Calligeros
2026-09-20 4:54 ` [PATCH 23/28] arm64: dts: apple: t8112-j473: " James Calligeros
2026-09-20 5:19 ` sashiko-bot
2026-09-20 4:54 ` [PATCH 24/28] arm64: dts: apple: t8112-j493: " James Calligeros
2026-09-20 5:17 ` sashiko-bot
2026-09-20 4:54 ` [PATCH 25/28] arm64: dts: apple: t600x-j31x: " James Calligeros
2026-09-20 5:17 ` sashiko-bot
2026-09-20 4:54 ` [PATCH 26/28] arm64: dts: apple: t600x-j375: " James Calligeros
2026-09-20 5:16 ` sashiko-bot
2026-09-20 4:54 ` [PATCH 27/28] arm64: dts: apple: t602x-j41x: " James Calligeros
2026-09-20 4:54 ` [PATCH 28/28] arm64: dts: apple: t602x-j47x: " James Calligeros
2026-09-20 5:15 ` sashiko-bot [this message]
2026-09-21 15:14 ` [PATCH 00/28] Add speaker and headset jack support for Apple Silicon Macs Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260920051528.D10E21F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jcalligeros99@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.