Re: [PATCH 24/28] arm64: dts: apple: t8112-j493: Add speaker/headset jack nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: unit_address_vs_reg dtc warning in sound dai-link nodes
--

commit 42436807c12f7cee010fe3350f1045b5d88f9126
Author: James Calligeros <jcalligeros99@gmail.com>

arm64: dts: apple: t8112-j493: Add speaker/headset jack nodes

The M2 MacBook Pro integrates Apple-specific variants of the TI TAS2764
and Cirrus CS42L42. Add these nodes and advertise them to the machine
driver via the sound node.

> diff --git a/arch/arm64/boot/dts/apple/t8112-j493.dts b/arch/arm64/boot/dts/apple/t8112-j493.dts
> index 7cea5c5948108..eb401ae8773e5 100644
> --- a/arch/arm64/boot/dts/apple/t8112-j493.dts
> +++ b/arch/arm64/boot/dts/apple/t8112-j493.dts
[ ... ]
> +/ {
> +	sound: sound {
> +		compatible = "apple,j493-macaudio", "apple,macaudio";
> +		model = "MacBook Pro J493";
> +
> +		dai-link@0 {
> +			dai-tdm-idle-mode-0 = "zero";

[Severity: Low]
Does the sound node need #address-cells and #size-cells properties,
along with a reg property here in dai-link@0? The device tree compiler
will emit a unit_address_vs_reg warning during the build because this child
node uses a unit address without a reg property.

> +			dai-tdm-idle-mode-2 = "zero";
> +			dai-tdm-slot-tx-idle-mask-0 = <0xf0f0>;
> +			dai-tdm-slot-tx-idle-mask-2 = <0x0f0f>;
> +
> +			link-name = "Speakers";
[ ... ]
> +		dai-link@1 {
> +			link-name = "Headphone Jack";

[Severity: Low]
Similarly, does this second dai-link child node need a reg property to
match its unit address and prevent a unit_address_vs_reg dtc warning?

> +
> +			codec {
> +				sound-dai = <&jack_codec>;
> +			};
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260920-macaudio-v1-0-741cc20a74e5@gmail.com?part=24