All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tilman Schmidt <tilman@imap.cc>
To: David Miller <davem@davemloft.net>
Cc: tilman@imap.cc, johannes@sipsolutions.net,
	hidave.darkstar@gmail.com, linux-kernel@vger.kernel.org,
	tglx@linutronix.de, linux-wireless@vger.kernel.org,
	linux-ppp@vger.kernel.org, netdev@vger.kernel.org,
	paulus@samba.org
Subject: Re: NOHZ: local_softirq_pending 08
Date: Mon, 12 Oct 2009 11:25:07 +0000	[thread overview]
Message-ID: <4AD31213.6020006@imap.cc> (raw)
In-Reply-To: <20091012.033246.56701176.davem@davemloft.net>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon, 12 Oct 2009 03:32:46 -0700 (PDT), David Miller wrote:
> The PPP receive paths in ppp_generic.c do a local_bh_disable()/
> local_bh_enable() around packet receiving (via ppp_recv_lock()/
> ppp_recv_unlock() in ppp_do_recv).
> 
> So at least that part is perfectly fine.
> 
> ppp_input(), as called from ppp_sync_process(), also disables BH's
> around ppp_do_recv() calls (via read_lock_bh()/read_unlock_bh()).
> 
> So that's fine too.
> 
> Do you have a bug report or are you just scanning around looking
> for trouble? :-)

I have encountered the message in the subject during a test of
the Gigaset CAPI driver, and would like to determine whether
it's a bug in the driver, a bug somewhere else, or no bug at
all. The test scenario was PPP over ISDN with pppd+capiplugin.
In an alternative scenario, also PPP over ISDN but with
smpppd+capidrv, the message did not occur.

Johannes' answer pointed me to the netif_rx() function.
The Gigaset driver itself doesn't call that function at all.
In the scenario where I saw the message, it was the SYNC_PPP
line discipline that did. But from your explanation I gather
that the cause cannot lie there.

So now I'm looking for other possible causes of that message.

- --
Tilman Schmidt                    E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFK0xITQ3+did9BuFsRAmXGAKCIiqJffUnuKw9rPjxHwbj9AnXOigCdGgS9
MpxRNGs0A4GTydYJaylbjyo=LFxi
-----END PGP SIGNATURE-----

WARNING: multiple messages have this Message-ID (diff)
From: Tilman Schmidt <tilman@imap.cc>
To: David Miller <davem@davemloft.net>
Cc: tilman@imap.cc, johannes@sipsolutions.net,
	hidave.darkstar@gmail.com, linux-kernel@vger.kernel.org,
	tglx@linutronix.de, linux-wireless@vger.kernel.org,
	linux-ppp@vger.kernel.org, netdev@vger.kernel.org,
	paulus@samba.org
Subject: Re: NOHZ: local_softirq_pending 08
Date: Mon, 12 Oct 2009 13:25:07 +0200	[thread overview]
Message-ID: <4AD31213.6020006@imap.cc> (raw)
In-Reply-To: <20091012.033246.56701176.davem@davemloft.net>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon, 12 Oct 2009 03:32:46 -0700 (PDT), David Miller wrote:
> The PPP receive paths in ppp_generic.c do a local_bh_disable()/
> local_bh_enable() around packet receiving (via ppp_recv_lock()/
> ppp_recv_unlock() in ppp_do_recv).
> 
> So at least that part is perfectly fine.
> 
> ppp_input(), as called from ppp_sync_process(), also disables BH's
> around ppp_do_recv() calls (via read_lock_bh()/read_unlock_bh()).
> 
> So that's fine too.
> 
> Do you have a bug report or are you just scanning around looking
> for trouble? :-)

I have encountered the message in the subject during a test of
the Gigaset CAPI driver, and would like to determine whether
it's a bug in the driver, a bug somewhere else, or no bug at
all. The test scenario was PPP over ISDN with pppd+capiplugin.
In an alternative scenario, also PPP over ISDN but with
smpppd+capidrv, the message did not occur.

Johannes' answer pointed me to the netif_rx() function.
The Gigaset driver itself doesn't call that function at all.
In the scenario where I saw the message, it was the SYNC_PPP
line discipline that did. But from your explanation I gather
that the cause cannot lie there.

So now I'm looking for other possible causes of that message.

- --
Tilman Schmidt                    E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFK0xITQ3+did9BuFsRAmXGAKCIiqJffUnuKw9rPjxHwbj9AnXOigCdGgS9
MpxRNGs0A4GTydYJaylbjyo=
=LFxi
-----END PGP SIGNATURE-----

  reply	other threads:[~2009-10-12 11:25 UTC|newest]

Thread overview: 91+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-11  9:52 NOHZ: local_softirq_pending 08 Dave Young
2009-10-11 10:08 ` Johannes Berg
2009-10-11 10:17   ` Michael Buesch
2009-10-11 10:37     ` Johannes Berg
2009-10-11 10:38     ` David Miller
2009-10-11 10:55   ` Dave Young
2009-10-11 11:18   ` Tilman Schmidt
2009-10-11 11:40     ` Johannes Berg
2009-10-12  8:28       ` Tilman Schmidt
2009-10-12  8:28         ` Tilman Schmidt
2009-10-12 10:32         ` David Miller
2009-10-12 10:32           ` David Miller
2009-10-12 11:25           ` Tilman Schmidt [this message]
2009-10-12 11:25             ` Tilman Schmidt
2009-10-15 11:40         ` Jarek Poplawski
2009-10-15 11:40           ` Jarek Poplawski
2009-10-15 17:53           ` Jarek Poplawski
2009-10-15 17:53             ` Jarek Poplawski
2009-10-21 18:46             ` Tilman Schmidt
2009-10-21 18:46               ` Tilman Schmidt
2009-10-21 21:19               ` [PATCH] net: Adjust softirq raising in __napi_schedule Jarek Poplawski
2009-10-21 21:19                 ` Jarek Poplawski
2009-10-21 21:25                 ` Johannes Berg
2009-10-21 21:25                   ` Johannes Berg
2009-10-21 21:37                   ` Tilman Schmidt
2009-10-21 21:37                     ` Tilman Schmidt
2009-10-21 21:39                   ` Jarek Poplawski
2009-10-21 21:39                     ` Jarek Poplawski
2009-10-22  8:27                     ` Johannes Berg
2009-10-22  8:27                       ` Johannes Berg
2009-10-23 14:39                       ` Tilman Schmidt
2009-10-23 14:39                         ` Tilman Schmidt
2009-10-23 14:46                         ` Johannes Berg
2009-10-23 14:46                           ` Johannes Berg
2009-10-26  7:41                           ` Jarek Poplawski
2009-10-26  7:44                             ` Johannes Berg
2009-10-26  7:44                               ` Johannes Berg
2009-10-26  7:54                               ` Jarek Poplawski
2009-10-26  7:58                                 ` Johannes Berg
2009-10-26  7:58                                   ` Johannes Berg
2009-10-26  8:47                                   ` Tilman Schmidt
2009-10-26  8:47                                     ` Tilman Schmidt
2009-10-26  8:56                                     ` Johannes Berg
2009-10-26  8:56                                       ` Johannes Berg
2009-10-27  0:52                                       ` Tilman Schmidt
2009-10-27  0:52                                         ` Tilman Schmidt
2009-10-27  7:01                                         ` Johannes Berg
2009-10-27  7:01                                           ` Johannes Berg
2009-10-22 11:29                     ` David Miller
2009-10-22 11:29                       ` David Miller
2009-10-22 12:54                       ` Jarek Poplawski
2009-10-22 23:37               ` NOHZ: local_softirq_pending 08 Tilman Schmidt
2009-10-22 23:37                 ` Tilman Schmidt
2009-10-23 13:34                 ` Johannes Berg
2009-10-23 13:34                   ` Johannes Berg
2009-10-23 14:27                   ` Tilman Schmidt
2009-10-23 14:27                     ` Tilman Schmidt
2009-10-23 14:31                     ` Johannes Berg
2009-10-23 14:31                       ` Johannes Berg
2009-10-23 16:33                       ` Tilman Schmidt
2009-10-23 16:33                         ` Tilman Schmidt
2009-10-11 16:39 ` Joe Korty
  -- strict thread matches above, loose matches on Subject: below --
2012-05-30 21:48 Dave Jones
2012-05-31  7:52 ` Thomas Gleixner
2012-05-31  7:56   ` Eric Dumazet
2012-05-31 14:04     ` Dave Jones
2012-06-08 16:46       ` Nikos Chantziaras
2012-06-01 22:57   ` Francois Romieu
2012-06-02 20:58     ` Marc Dionne
2012-06-05 23:15       ` Francois Romieu
2012-06-06  1:46         ` Dave Jones
2012-06-06  5:42           ` Francois Romieu
2012-06-08  2:34             ` Dave Jones
2012-06-08  7:57               ` Thomas Gleixner
2012-06-08 14:23                 ` Dave Jones
2012-06-08 14:51                   ` Thomas Gleixner
2012-06-08 20:27                     ` Francois Romieu
2012-06-08 20:41                       ` Thomas Gleixner
2012-06-08 21:53                         ` Francois Romieu
2012-06-08 22:33                           ` Marc Dionne
2012-06-10 20:40                             ` Dave Jones
2012-06-25 12:38                           ` Johannes Stezenbach
2012-06-25 19:28                             ` Francois Romieu
2012-06-25 19:52                               ` Dave Jones
2012-06-08  8:32               ` Johannes Stezenbach
2008-10-03 16:40 liran raz
2008-10-03 16:55 ` Scott Wood
2008-10-02 18:30 liran raz
2007-05-29  6:01 Rafał Bilski
2007-05-28 21:04 Rafał Bilski
2007-05-28 22:12 ` Anant Nitya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD31213.6020006@imap.cc \
    --to=tilman@imap.cc \
    --cc=davem@davemloft.net \
    --cc=hidave.darkstar@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-ppp@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.