All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tilman Schmidt <tilman@imap.cc>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jarek Poplawski <jarkao2@gmail.com>,
	David Miller <davem@davemloft.net>,
	hidave.darkstar@gmail.com, linux-kernel@vger.kernel.org,
	tglx@linutronix.de, linux-wireless@vger.kernel.org,
	linux-ppp@vger.kernel.org, netdev@vger.kernel.org,
	paulus@samba.org, Michael Buesch <mb@bu3sch.de>,
	Oliver Hartkopp <oliver@hartkopp.net>
Subject: Re: [PATCH] net: Adjust softirq raising in __napi_schedule
Date: Wed, 21 Oct 2009 21:37:24 +0000	[thread overview]
Message-ID: <4ADF7F14.7000109@imap.cc> (raw)
In-Reply-To: <1256160330.12174.2.camel@johannes.local>

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

Johannes Berg schrieb:

> This still doesn't make any sense.
> 
> There may or may not be a lot of code that assumes that everything else
> is run with other tasklets disabled, and that it cannot be interrupted
> by a tasklet and thus create a race.
> 
> Can you prove that is not the case, across the entire networking layer?

So what's the solution you propose?

-- 
Tilman Schmidt                    E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Tilman Schmidt <tilman@imap.cc>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jarek Poplawski <jarkao2@gmail.com>,
	David Miller <davem@davemloft.net>,
	hidave.darkstar@gmail.com, linux-kernel@vger.kernel.org,
	tglx@linutronix.de, linux-wireless@vger.kernel.org,
	linux-ppp@vger.kernel.org, netdev@vger.kernel.org,
	paulus@samba.org, Michael Buesch <mb@bu3sch.de>,
	Oliver Hartkopp <oliver@hartkopp.net>
Subject: Re: [PATCH] net: Adjust softirq raising in __napi_schedule
Date: Wed, 21 Oct 2009 23:37:24 +0200	[thread overview]
Message-ID: <4ADF7F14.7000109@imap.cc> (raw)
In-Reply-To: <1256160330.12174.2.camel@johannes.local>

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

Johannes Berg schrieb:

> This still doesn't make any sense.
> 
> There may or may not be a lot of code that assumes that everything else
> is run with other tasklets disabled, and that it cannot be interrupted
> by a tasklet and thus create a race.
> 
> Can you prove that is not the case, across the entire networking layer?

So what's the solution you propose?

-- 
Tilman Schmidt                    E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]

  reply	other threads:[~2009-10-21 21:37 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-11  9:52 NOHZ: local_softirq_pending 08 Dave Young
2009-10-11 10:08 ` Johannes Berg
2009-10-11 10:17   ` Michael Buesch
2009-10-11 10:37     ` Johannes Berg
2009-10-11 10:38     ` David Miller
2009-10-11 10:55   ` Dave Young
2009-10-11 11:18   ` Tilman Schmidt
2009-10-11 11:40     ` Johannes Berg
2009-10-12  8:28       ` Tilman Schmidt
2009-10-12  8:28         ` Tilman Schmidt
2009-10-12 10:32         ` David Miller
2009-10-12 10:32           ` David Miller
2009-10-12 11:25           ` Tilman Schmidt
2009-10-12 11:25             ` Tilman Schmidt
2009-10-15 11:40         ` Jarek Poplawski
2009-10-15 11:40           ` Jarek Poplawski
2009-10-15 17:53           ` Jarek Poplawski
2009-10-15 17:53             ` Jarek Poplawski
2009-10-21 18:46             ` Tilman Schmidt
2009-10-21 18:46               ` Tilman Schmidt
2009-10-21 21:19               ` [PATCH] net: Adjust softirq raising in __napi_schedule Jarek Poplawski
2009-10-21 21:19                 ` Jarek Poplawski
2009-10-21 21:25                 ` Johannes Berg
2009-10-21 21:25                   ` Johannes Berg
2009-10-21 21:37                   ` Tilman Schmidt [this message]
2009-10-21 21:37                     ` Tilman Schmidt
2009-10-21 21:39                   ` Jarek Poplawski
2009-10-21 21:39                     ` Jarek Poplawski
2009-10-22  8:27                     ` Johannes Berg
2009-10-22  8:27                       ` Johannes Berg
2009-10-23 14:39                       ` Tilman Schmidt
2009-10-23 14:39                         ` Tilman Schmidt
2009-10-23 14:46                         ` Johannes Berg
2009-10-23 14:46                           ` Johannes Berg
2009-10-26  7:41                           ` Jarek Poplawski
2009-10-26  7:44                             ` Johannes Berg
2009-10-26  7:44                               ` Johannes Berg
2009-10-26  7:54                               ` Jarek Poplawski
2009-10-26  7:58                                 ` Johannes Berg
2009-10-26  7:58                                   ` Johannes Berg
2009-10-26  8:47                                   ` Tilman Schmidt
2009-10-26  8:47                                     ` Tilman Schmidt
2009-10-26  8:56                                     ` Johannes Berg
2009-10-26  8:56                                       ` Johannes Berg
2009-10-27  0:52                                       ` Tilman Schmidt
2009-10-27  0:52                                         ` Tilman Schmidt
2009-10-27  7:01                                         ` Johannes Berg
2009-10-27  7:01                                           ` Johannes Berg
2009-10-22 11:29                     ` David Miller
2009-10-22 11:29                       ` David Miller
2009-10-22 12:54                       ` Jarek Poplawski
2009-10-22 23:37               ` NOHZ: local_softirq_pending 08 Tilman Schmidt
2009-10-22 23:37                 ` Tilman Schmidt
2009-10-23 13:34                 ` Johannes Berg
2009-10-23 13:34                   ` Johannes Berg
2009-10-23 14:27                   ` Tilman Schmidt
2009-10-23 14:27                     ` Tilman Schmidt
2009-10-23 14:31                     ` Johannes Berg
2009-10-23 14:31                       ` Johannes Berg
2009-10-23 16:33                       ` Tilman Schmidt
2009-10-23 16:33                         ` Tilman Schmidt
2009-10-11 16:39 ` Joe Korty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ADF7F14.7000109@imap.cc \
    --to=tilman@imap.cc \
    --cc=davem@davemloft.net \
    --cc=hidave.darkstar@gmail.com \
    --cc=jarkao2@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-ppp@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mb@bu3sch.de \
    --cc=netdev@vger.kernel.org \
    --cc=oliver@hartkopp.net \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.