All of lore.kernel.org
 help / color / mirror / Atom feed
From: dietmar.eggemann@arm.com (Dietmar Eggemann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 04/11] sched: Allow all archs to set the power_orig
Date: Fri, 30 May 2014 15:04:32 +0100	[thread overview]
Message-ID: <53888FF0.4020403@arm.com> (raw)
In-Reply-To: <1400860385-14555-5-git-send-email-vincent.guittot@linaro.org>

On 23/05/14 16:52, Vincent Guittot wrote:
> power_orig is only changed for system with a SMT sched_domain level in order to
> reflect the lower capacity of CPUs. Heterogenous system also have to reflect an
> original capacity that is different from the default value.
> 
> Create a more generic function arch_scale_cpu_power that can be also used by
> non SMT platform to set power_orig.
> 
> The weak behavior of arch_scale_cpu_power is the previous SMT one in order to
> keep backward compatibility in the use of power_orig.
> 
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>

As you know, besides uarch scaled cpu power for HMP, freq scaled cpu
power is important for energy-aware scheduling to achieve freq scale
invariance for task load.

I know that your patch-set is not about introducing freq scaled cpu
power, but we were discussing how this can be achieved w/ your patch-set
in place, so maybe you can share your opinion regarding the easiest way
to achieve freq scale invariance with us?

(1) We assume that the current way (update_cpu_power() calls
arch_scale_freq_power() to get the avg power(freq) over the time period
since the last call to arch_scale_freq_power()) is suitable
for us. Do you have another opinion here?

(2) Is the current layout of update_cpu_power() adequate for this, where
we scale power_orig related to freq and then related to rt/(irq):

  power_orig = scale_cpu(SCHED_POWER_SCALE)
  power = scale_rt(scale_freq(power_orig))

or do we need an extra power_freq data member on the rq and do:

  power_orig = scale_cpu(SCHED_POWER_SCALE)
  power_freq = scale_freq(power_orig))
  power = scale_rt(power_orig))

In other words, do we consider rt/(irq) pressure when calculating freq
scale invariant task load or not?

Thanks,

-- Dietmar
[...]

WARNING: multiple messages have this Message-ID (diff)
From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"mingo@kernel.org" <mingo@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Cc: "preeti@linux.vnet.ibm.com" <preeti@linux.vnet.ibm.com>,
	Morten Rasmussen <Morten.Rasmussen@arm.com>,
	"efault@gmx.de" <efault@gmx.de>,
	"nicolas.pitre@linaro.org" <nicolas.pitre@linaro.org>,
	"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
	"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>
Subject: Re: [PATCH v2 04/11] sched: Allow all archs to set the power_orig
Date: Fri, 30 May 2014 15:04:32 +0100	[thread overview]
Message-ID: <53888FF0.4020403@arm.com> (raw)
In-Reply-To: <1400860385-14555-5-git-send-email-vincent.guittot@linaro.org>

On 23/05/14 16:52, Vincent Guittot wrote:
> power_orig is only changed for system with a SMT sched_domain level in order to
> reflect the lower capacity of CPUs. Heterogenous system also have to reflect an
> original capacity that is different from the default value.
> 
> Create a more generic function arch_scale_cpu_power that can be also used by
> non SMT platform to set power_orig.
> 
> The weak behavior of arch_scale_cpu_power is the previous SMT one in order to
> keep backward compatibility in the use of power_orig.
> 
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>

As you know, besides uarch scaled cpu power for HMP, freq scaled cpu
power is important for energy-aware scheduling to achieve freq scale
invariance for task load.

I know that your patch-set is not about introducing freq scaled cpu
power, but we were discussing how this can be achieved w/ your patch-set
in place, so maybe you can share your opinion regarding the easiest way
to achieve freq scale invariance with us?

(1) We assume that the current way (update_cpu_power() calls
arch_scale_freq_power() to get the avg power(freq) over the time period
since the last call to arch_scale_freq_power()) is suitable
for us. Do you have another opinion here?

(2) Is the current layout of update_cpu_power() adequate for this, where
we scale power_orig related to freq and then related to rt/(irq):

  power_orig = scale_cpu(SCHED_POWER_SCALE)
  power = scale_rt(scale_freq(power_orig))

or do we need an extra power_freq data member on the rq and do:

  power_orig = scale_cpu(SCHED_POWER_SCALE)
  power_freq = scale_freq(power_orig))
  power = scale_rt(power_orig))

In other words, do we consider rt/(irq) pressure when calculating freq
scale invariant task load or not?

Thanks,

-- Dietmar
[...]


  reply	other threads:[~2014-05-30 14:04 UTC|newest]

Thread overview: 216+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-23 15:52 [PATCH v2 00/11] sched: consolidation of cpu_power Vincent Guittot
2014-05-23 15:52 ` Vincent Guittot
2014-05-23 15:52 ` [PATCH v2 01/11] sched: fix imbalance flag reset Vincent Guittot
2014-05-23 15:52   ` Vincent Guittot
2014-05-25 10:33   ` Preeti U Murthy
2014-05-25 10:33     ` Preeti U Murthy
2014-05-26  7:49     ` Vincent Guittot
2014-05-26  7:49       ` Vincent Guittot
2014-05-26  9:16       ` Preeti U Murthy
2014-05-26  9:16         ` Preeti U Murthy
2014-05-26 10:14         ` Vincent Guittot
2014-05-26 10:14           ` Vincent Guittot
2014-05-23 15:52 ` [PATCH v2 02/11] sched: remove a wake_affine condition Vincent Guittot
2014-05-23 15:52   ` Vincent Guittot
2014-05-27 12:48   ` Peter Zijlstra
2014-05-27 12:48     ` Peter Zijlstra
2014-05-27 15:19     ` Vincent Guittot
2014-05-27 15:19       ` Vincent Guittot
2014-05-27 15:39       ` Peter Zijlstra
2014-05-27 15:39         ` Peter Zijlstra
2014-05-27 16:14         ` Vincent Guittot
2014-05-27 16:14           ` Vincent Guittot
2014-05-28  6:49           ` Vincent Guittot
2014-05-28  6:49             ` Vincent Guittot
2014-05-28 15:09             ` Dietmar Eggemann
2014-05-28 15:09               ` Dietmar Eggemann
2014-05-28 15:25               ` Vincent Guittot
2014-05-28 15:25                 ` Vincent Guittot
2014-05-27 13:43   ` Peter Zijlstra
2014-05-27 13:43     ` Peter Zijlstra
2014-05-27 13:45   ` Peter Zijlstra
2014-05-27 13:45     ` Peter Zijlstra
2014-05-27 15:20     ` Vincent Guittot
2014-05-27 15:20       ` Vincent Guittot
2014-05-23 15:52 ` [PATCH v2 03/11] sched: fix avg_load computation Vincent Guittot
2014-05-23 15:52   ` Vincent Guittot
2014-05-27 13:48   ` Peter Zijlstra
2014-05-27 13:48     ` Peter Zijlstra
2014-05-23 15:52 ` [PATCH v2 04/11] sched: Allow all archs to set the power_orig Vincent Guittot
2014-05-23 15:52   ` Vincent Guittot
2014-05-30 14:04   ` Dietmar Eggemann [this message]
2014-05-30 14:04     ` Dietmar Eggemann
2014-05-30 14:46     ` Peter Zijlstra
2014-05-30 14:46       ` Peter Zijlstra
2014-05-30 20:50     ` Vincent Guittot
2014-05-30 20:50       ` Vincent Guittot
2014-06-04  9:42       ` Dietmar Eggemann
2014-06-04  9:42         ` Dietmar Eggemann
2014-06-04 11:15         ` Vincent Guittot
2014-06-04 11:15           ` Vincent Guittot
2014-06-05  8:59           ` Dietmar Eggemann
2014-06-05  8:59             ` Dietmar Eggemann
2014-06-16  9:01             ` Vincent Guittot
2014-06-16  9:01               ` Vincent Guittot
2014-06-03 13:22   ` Morten Rasmussen
2014-06-03 13:22     ` Morten Rasmussen
2014-06-03 14:02     ` Vincent Guittot
2014-06-03 14:02       ` Vincent Guittot
2014-06-04 11:17       ` Morten Rasmussen
2014-06-04 11:17         ` Morten Rasmussen
2014-06-06  7:01         ` Vincent Guittot
2014-06-06  7:01           ` Vincent Guittot
2014-05-23 15:52 ` [PATCH v2 05/11] ARM: topology: use new cpu_power interface Vincent Guittot
2014-05-23 15:52   ` Vincent Guittot
2014-05-25 13:22   ` Preeti U Murthy
2014-05-25 13:22     ` Preeti U Murthy
2014-05-26  8:25     ` Vincent Guittot
2014-05-26  8:25       ` Vincent Guittot
2014-05-26  9:19       ` Preeti U Murthy
2014-05-26  9:19         ` Preeti U Murthy
2014-05-23 15:53 ` [PATCH v2 06/11] sched: add per rq cpu_power_orig Vincent Guittot
2014-05-23 15:53   ` Vincent Guittot
2014-05-23 15:53 ` [PATCH v2 07/11] Revert "sched: Put rq's sched_avg under CONFIG_FAIR_GROUP_SCHED" Vincent Guittot
2014-05-23 15:53   ` Vincent Guittot
2014-05-23 15:53 ` [PATCH v2 08/11] sched: get CPU's activity statistic Vincent Guittot
2014-05-23 15:53   ` Vincent Guittot
2014-05-27 17:32   ` Peter Zijlstra
2014-05-27 17:32     ` Peter Zijlstra
2014-05-28  7:01     ` Vincent Guittot
2014-05-28  7:01       ` Vincent Guittot
2014-05-28 12:10   ` Morten Rasmussen
2014-05-28 12:10     ` Morten Rasmussen
2014-05-28 13:15     ` Vincent Guittot
2014-05-28 13:15       ` Vincent Guittot
2014-05-28 15:47       ` Morten Rasmussen
2014-05-28 15:47         ` Morten Rasmussen
2014-05-28 16:39         ` Vincent Guittot
2014-05-28 16:39           ` Vincent Guittot
2014-06-03 12:03           ` Morten Rasmussen
2014-06-03 12:03             ` Morten Rasmussen
2014-06-03 15:59             ` Peter Zijlstra
2014-06-03 15:59               ` Peter Zijlstra
2014-06-03 17:41               ` Morten Rasmussen
2014-06-03 17:41                 ` Morten Rasmussen
2014-06-03 15:50         ` Peter Zijlstra
2014-06-03 15:50           ` Peter Zijlstra
2014-06-03 17:20           ` Morten Rasmussen
2014-06-03 17:20             ` Morten Rasmussen
2014-06-04  7:47           ` Vincent Guittot
2014-06-04  7:47             ` Vincent Guittot
2014-06-04  8:08             ` Peter Zijlstra
2014-06-04  8:08               ` Peter Zijlstra
2014-06-04  8:55               ` Morten Rasmussen
2014-06-04  8:55                 ` Morten Rasmussen
2014-06-04  9:23                 ` Peter Zijlstra
2014-06-04  9:23                   ` Peter Zijlstra
2014-06-04  9:35                   ` Vincent Guittot
2014-06-04  9:35                     ` Vincent Guittot
2014-06-04 10:25                     ` Morten Rasmussen
2014-06-04 10:25                       ` Morten Rasmussen
2014-06-04  9:44                   ` Morten Rasmussen
2014-06-04  9:44                     ` Morten Rasmussen
2014-06-04  9:32               ` Vincent Guittot
2014-06-04  9:32                 ` Vincent Guittot
2014-06-04 10:00                 ` Morten Rasmussen
2014-06-04 10:00                   ` Morten Rasmussen
2014-06-04 10:17                 ` Peter Zijlstra
2014-06-04 10:17                   ` Peter Zijlstra
2014-06-04 10:36                   ` Morten Rasmussen
2014-06-04 10:36                     ` Morten Rasmussen
2014-06-04 10:55                     ` Peter Zijlstra
2014-06-04 10:55                       ` Peter Zijlstra
2014-06-04 11:07                     ` Vincent Guittot
2014-06-04 11:07                       ` Vincent Guittot
2014-06-04 11:23                       ` Morten Rasmussen
2014-06-04 11:23                         ` Morten Rasmussen
2014-06-04 11:52                         ` Vincent Guittot
2014-06-04 11:52                           ` Vincent Guittot
2014-06-04 13:09                           ` Morten Rasmussen
2014-06-04 13:09                             ` Morten Rasmussen
2014-06-04 13:23                             ` Morten Rasmussen
2014-06-04 13:23                               ` Morten Rasmussen
2014-05-28 15:17     ` Peter Zijlstra
2014-05-28 15:17       ` Peter Zijlstra
2014-06-03 15:40     ` Peter Zijlstra
2014-06-03 15:40       ` Peter Zijlstra
2014-06-03 17:16       ` Morten Rasmussen
2014-06-03 17:16         ` Morten Rasmussen
2014-06-03 17:37         ` Peter Zijlstra
2014-06-03 17:37           ` Peter Zijlstra
2014-06-03 17:39         ` Peter Zijlstra
2014-06-03 17:39           ` Peter Zijlstra
2014-06-03 23:11       ` Yuyang Du
2014-06-03 23:11         ` Yuyang Du
2014-05-30  9:50   ` Dietmar Eggemann
2014-05-30  9:50     ` Dietmar Eggemann
2014-05-30 19:20     ` Vincent Guittot
2014-05-30 19:20       ` Vincent Guittot
2014-06-01 11:33       ` Dietmar Eggemann
2014-06-01 11:33         ` Dietmar Eggemann
2014-06-02 14:07         ` Vincent Guittot
2014-06-02 14:07           ` Vincent Guittot
2014-05-23 15:53 ` [PATCH v2 09/11] sched: test the cpu's capacity in wake affine Vincent Guittot
2014-05-23 15:53   ` Vincent Guittot
2014-05-28 10:58   ` Peter Zijlstra
2014-05-28 10:58     ` Peter Zijlstra
2014-05-28 11:15     ` Vincent Guittot
2014-05-28 11:15       ` Vincent Guittot
2014-11-24  0:34       ` Wanpeng Li
2014-11-24  0:34         ` Wanpeng Li
2014-11-24 13:23         ` Vincent Guittot
2014-11-24 13:23           ` Vincent Guittot
2014-05-23 15:53 ` [PATCH v2 10/11] sched: move cfs task on a CPU with higher capacity Vincent Guittot
2014-05-23 15:53   ` Vincent Guittot
2014-05-29  9:50   ` Peter Zijlstra
2014-05-29  9:50     ` Peter Zijlstra
2014-05-29 19:37     ` Vincent Guittot
2014-05-29 19:37       ` Vincent Guittot
2014-05-30  6:29       ` Peter Zijlstra
2014-05-30  6:29         ` Peter Zijlstra
2014-05-30 20:05         ` Vincent Guittot
2014-05-30 20:05           ` Vincent Guittot
2014-06-02 17:06         ` Vincent Guittot
2014-06-02 17:06           ` Vincent Guittot
2014-06-03 11:15           ` Peter Zijlstra
2014-06-03 11:15             ` Peter Zijlstra
2014-06-03 12:31             ` Vincent Guittot
2014-06-03 12:31               ` Vincent Guittot
2014-05-29 14:04   ` Peter Zijlstra
2014-05-29 14:04     ` Peter Zijlstra
2014-05-29 19:44     ` Vincent Guittot
2014-05-29 19:44       ` Vincent Guittot
2014-05-30 13:26   ` Dietmar Eggemann
2014-05-30 13:26     ` Dietmar Eggemann
2014-05-30 19:24     ` Vincent Guittot
2014-05-30 19:24       ` Vincent Guittot
2014-05-30 19:45       ` Nicolas Pitre
2014-05-30 19:45         ` Nicolas Pitre
2014-05-30 20:07         ` Vincent Guittot
2014-05-30 20:07           ` Vincent Guittot
2014-05-23 15:53 ` [PATCH v2 11/11] sched: replace capacity by activity Vincent Guittot
2014-05-23 15:53   ` Vincent Guittot
2014-05-29 13:55   ` Peter Zijlstra
2014-05-29 13:55     ` Peter Zijlstra
2014-05-29 19:51     ` Vincent Guittot
2014-05-29 19:51       ` Vincent Guittot
2014-06-02  6:21     ` Preeti U Murthy
2014-06-02  6:21       ` Preeti U Murthy
2014-06-03  9:50       ` Vincent Guittot
2014-06-03  9:50         ` Vincent Guittot
2014-05-29 14:02   ` Peter Zijlstra
2014-05-29 14:02     ` Peter Zijlstra
2014-05-29 19:56     ` Vincent Guittot
2014-05-29 19:56       ` Vincent Guittot
2014-05-30  6:34       ` Peter Zijlstra
2014-05-30  6:34         ` Peter Zijlstra
2014-05-30 19:13         ` Vincent Guittot
2014-05-30 19:13           ` Vincent Guittot
2014-05-26  9:44 ` [PATCH v2 00/11] sched: consolidation of cpu_power Preeti U Murthy
2014-05-26  9:44   ` Preeti U Murthy
2014-05-26 10:04   ` Vincent Guittot
2014-05-26 10:04     ` Vincent Guittot
2014-05-26 15:54     ` Vincent Guittot
2014-05-26 15:54       ` Vincent Guittot
2014-05-27  5:47       ` Preeti U Murthy
2014-05-27  5:47         ` Preeti U Murthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53888FF0.4020403@arm.com \
    --to=dietmar.eggemann@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.