Re: [PATCH 11/18] drm/i915/dpll: Introduce new hook in intel_dpll_funcs

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 09 May 2025, Suraj Kandpal <suraj.kandpal@intel.com> wrote:
> Introduce disable hook to disable individual dpll which is to
> be used by DISPLAY_VER() >= 14.
>
> --v2
> -Rename intel_global_dpll to intel_dpll_global [Jani/Ville]
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>

This is hard to review with no actual user at hand.

> ---
>  drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> index 51dab49d4fc1..85f726b1c5c8 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> @@ -73,7 +73,13 @@ struct intel_dpll_funcs {
>  		       struct intel_encoder *encoder);
>  
>  	/*
> -	 * Hook for disabling the shared pll, called from _intel_disable_shared_dpll()
> +	 * Hook for disabling the individual pll, used from DISPLAY_VER() >= 14
> +	 */
> +	void (*disable)(struct intel_display *display,
> +			struct intel_dpll *pll);
> +
> +	/*
> +	 * Hook for disabling the shared pll, called from intel_disable_global_dpll()
>  	 * only when it is safe to disable the pll, i.e., there are no more
>  	 * tracked users for it.
>  	 */

-- 
Jani Nikula, Intel