Re: [PATCH 17/18] drm/i915/dpll: Rename intel_compute_dpll

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 09 May 2025, Suraj Kandpal <suraj.kandpal@intel.com> wrote:
> Rename intel_compute_dpll to intel_dpll_compute in an
> effort to make sure all function names that are exported have
> the filename at start.
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  drivers/gpu/drm/i915/display/intel_dpll.c     | 6 +++---
>  drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 8 ++++----
>  drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 6 +++---
>  3 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dpll.c b/drivers/gpu/drm/i915/display/intel_dpll.c
> index 6a0bb12eafc4..c15a9af53313 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpll.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpll.c
> @@ -1161,7 +1161,7 @@ static int hsw_crtc_compute_clock(struct intel_atomic_state *state,
>  	    intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DSI))
>  		return 0;
>  
> -	ret = intel_compute_dplls(state, crtc, encoder);
> +	ret = intel_dpll_compute(state, crtc, encoder);
>  	if (ret)
>  		return ret;
>  
> @@ -1223,7 +1223,7 @@ static int mtl_crtc_compute_clock(struct intel_atomic_state *state,
>  	if (ret)
>  		return ret;
>  
> -	/* TODO: Do the readback via intel_compute_dplls() */
> +	/* TODO: Do the readback via intel_dpll_compute() */
>  	crtc_state->port_clock = intel_cx0pll_calc_port_clock(encoder, &crtc_state->dpll_hw_state.cx0pll);
>  
>  	crtc_state->hw.adjusted_mode.crtc_clock = intel_crtc_dotclock(crtc_state);
> @@ -1394,7 +1394,7 @@ static int ilk_crtc_compute_clock(struct intel_atomic_state *state,
>  	ilk_compute_dpll(crtc_state, &crtc_state->dpll,
>  			 &crtc_state->dpll);
>  
> -	ret = intel_compute_dplls(state, crtc, NULL);
> +	ret = intel_dpll_compute(state, crtc, NULL);
>  	if (ret)
>  		return ret;
>  
> diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> index 65dd8c3a3aed..05714e6fbad5 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> @@ -4383,7 +4383,7 @@ void intel_dpll_init(struct intel_display *display)
>  }
>  
>  /**
> - * intel_compute_dplls - compute DPLL state CRTC and encoder combination
> + * intel_dpll_compute - compute DPLL state CRTC and encoder combination
>   * @state: atomic state
>   * @crtc: CRTC to compute DPLLs for
>   * @encoder: encoder
> @@ -4396,9 +4396,9 @@ void intel_dpll_init(struct intel_display *display)
>   * Returns:
>   * 0 on success, negative error code on failure.
>   */
> -int intel_compute_dplls(struct intel_atomic_state *state,
> -			struct intel_crtc *crtc,
> -			struct intel_encoder *encoder)
> +int intel_dpll_compute(struct intel_atomic_state *state,
> +		       struct intel_crtc *crtc,
> +		       struct intel_encoder *encoder)
>  {
>  	struct intel_display *display = to_intel_display(state);
>  	const struct intel_dpll_mgr *dpll_mgr = display->dpll.mgr;
> diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h b/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
> index 4f8074580582..c2658ad409e4 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
> +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
> @@ -396,9 +396,9 @@ void assert_dpll(struct intel_display *display,
>  		 bool state);
>  #define assert_dpll_enabled(d, p) assert_dpll(d, p, true)
>  #define assert_dpll_disabled(d, p) assert_dpll(d, p, false)
> -int intel_compute_dplls(struct intel_atomic_state *state,
> -			struct intel_crtc *crtc,
> -			struct intel_encoder *encoder);
> +int intel_dpll_compute(struct intel_atomic_state *state,
> +		       struct intel_crtc *crtc,
> +		       struct intel_encoder *encoder);
>  int intel_dpll_reserve(struct intel_atomic_state *state,
>  		       struct intel_crtc *crtc,
>  		       struct intel_encoder *encoder);

-- 
Jani Nikula, Intel