Re: [PATCH 18/18] drm/i915/dpll: Rename intel_update_active_dpll

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 09 May 2025, Suraj Kandpal <suraj.kandpal@intel.com> wrote:
> Rename intel_update_active_dpll to intel_dpll_update_active in an
> effort to have function names which are exported to start with
> filenames they are exported from.
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_ddi.c      | 2 +-
>  drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 4 ++--
>  drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 66dea34ebcd3..be26e6b4bc97 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -3650,7 +3650,7 @@ void intel_ddi_update_active_dpll(struct intel_atomic_state *state,
>  
>  	for_each_intel_crtc_in_pipe_mask(display->drm, pipe_crtc,
>  					 intel_crtc_joined_pipe_mask(crtc_state))
> -		intel_update_active_dpll(state, pipe_crtc, encoder);
> +		intel_dpll_update_active(state, pipe_crtc, encoder);
>  }
>  
>  /*
> diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> index 05714e6fbad5..939d92b4cf0f 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> @@ -4472,7 +4472,7 @@ void intel_dpll_release(struct intel_atomic_state *state,
>  }
>  
>  /**
> - * intel_update_active_dpll - update the active DPLL for a CRTC/encoder
> + * intel_dpll_update_active - update the active DPLL for a CRTC/encoder
>   * @state: atomic state
>   * @crtc: the CRTC for which to update the active DPLL
>   * @encoder: encoder determining the type of port DPLL
> @@ -4481,7 +4481,7 @@ void intel_dpll_release(struct intel_atomic_state *state,
>   * from the port DPLLs reserved previously by intel_dpll_reserve(). The
>   * DPLL selected will be based on the current mode of the encoder's port.
>   */
> -void intel_update_active_dpll(struct intel_atomic_state *state,
> +void intel_dpll_update_active(struct intel_atomic_state *state,
>  			      struct intel_crtc *crtc,
>  			      struct intel_encoder *encoder)
>  {
> diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h b/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
> index c2658ad409e4..821ffcc4b8d0 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
> +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
> @@ -409,7 +409,7 @@ void intel_dpll_unreference_crtc(const struct intel_crtc *crtc,
>  				 struct intel_dpll_state *shared_dpll_state);
>  void icl_set_active_port_dpll(struct intel_crtc_state *crtc_state,
>  			      enum icl_port_dpll_id port_dpll_id);
> -void intel_update_active_dpll(struct intel_atomic_state *state,
> +void intel_dpll_update_active(struct intel_atomic_state *state,
>  			      struct intel_crtc *crtc,
>  			      struct intel_encoder *encoder);
>  int intel_dpll_get_freq(struct intel_crtc_state *crtc_state,

-- 
Jani Nikula, Intel