From: Imre Deak <imre.deak@intel.com>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 00/14] drm/i915: Make ILK/SNB/IVB use HSW watermark code
Date: Mon, 16 Dec 2013 23:38:38 +0200 [thread overview]
Message-ID: <1387229918.2529.5.camel@ideak-mobl> (raw)
In-Reply-To: <1386251501-10602-1-git-send-email-ville.syrjala@linux.intel.com>
On Thu, 2013-12-05 at 15:51 +0200, ville.syrjala@linux.intel.com wrote:
> Back on the watermark horse. This series moves ILK/SNB/IVB over to the HSW
> watermark code.
>
> This series still has some underrun issues since the safe watermark
> update mechanism is yet to be introduced. However it shouldn't really
> be any worse than what we have ATM, and I'd like to have all the platforms
> converted so that we have more systems that will excercise the new update
> mechanism when it arrives.
Looks ok to me. I have a couple of bikesheds inlined, regardless of
those on the series:
Reviewed-by: Imre Deak <imre.deak@intel.com>
>
> Ville Syrjälä (14):
> drm/i915: Add IVB DDB partitioning control
> drm/i915: Add ILK/SNB/IVB WM latency field support
> drm/i915: Avoid computing invalid WM levels when sprites/scaling is enabled
> Revert "drm/i915/sprite: Always enable the scaler on IronLake"
> drm/i915: Fix LP1 sprite watermarks for ILK/SNB
> drm/i915: Fix LP1+ watermark disabling ILK
> drm/i915: Don't merge LP1+ watermarks on ILK/SNB/IVB when multiple pipes are enabled
> drm/i915: Disable FBC WM on ILK, and disable LP2+ when FBC is enabled
> drm/i915: Linetime watermarks are a HSW feature
> drm/i915: Disable LP1+ watermarks safely in init
> drm/i915: Move ILK/SNB/IVB over to the HSW WM code
> drm/i915: Try to fix the messy IVB sprite scaling workaround
> drm/i915: Don't disable primary when color keying is used
> drm/i915: Avoid underruns when disabling sprites
>
> drivers/gpu/drm/i915/i915_drv.h | 1 -
> drivers/gpu/drm/i915/i915_reg.h | 2 +
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> drivers/gpu/drm/i915/intel_pm.c | 857 +++++++----------------------------
> drivers/gpu/drm/i915/intel_sprite.c | 50 +-
> 5 files changed, 195 insertions(+), 717 deletions(-)
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2013-12-16 21:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 13:51 [PATCH 00/14] drm/i915: Make ILK/SNB/IVB use HSW watermark code ville.syrjala
2013-12-05 13:51 ` [PATCH 01/14] drm/i915: Add IVB DDB partitioning control ville.syrjala
2013-12-05 13:51 ` [PATCH 02/14] drm/i915: Add ILK/SNB/IVB WM latency field support ville.syrjala
2013-12-05 13:51 ` [PATCH 03/14] drm/i915: Avoid computing invalid WM levels when sprites/scaling is enabled ville.syrjala
2013-12-05 13:51 ` [PATCH 04/14] Revert "drm/i915/sprite: Always enable the scaler on IronLake" ville.syrjala
2013-12-16 21:42 ` Imre Deak
2013-12-05 13:51 ` [PATCH 05/14] drm/i915: Fix LP1 sprite watermarks for ILK/SNB ville.syrjala
2013-12-05 13:51 ` [PATCH 06/14] drm/i915: Fix LP1+ watermark disabling ILK ville.syrjala
2013-12-16 21:46 ` Imre Deak
2013-12-05 13:51 ` [PATCH 07/14] drm/i915: Don't merge LP1+ watermarks on ILK/SNB/IVB when multiple pipes are enabled ville.syrjala
2013-12-05 13:51 ` [PATCH 08/14] drm/i915: Disable FBC WM on ILK, and disable LP2+ when FBC is enabled ville.syrjala
2013-12-05 13:51 ` [PATCH 09/14] drm/i915: Linetime watermarks are a HSW feature ville.syrjala
2013-12-05 13:51 ` [PATCH 10/14] drm/i915: Disable LP1+ watermarks safely in init ville.syrjala
2013-12-05 14:27 ` Chris Wilson
2013-12-05 14:41 ` Ville Syrjälä
2013-12-05 13:51 ` [PATCH 11/14] drm/i915: Move ILK/SNB/IVB over to the HSW WM code ville.syrjala
2013-12-16 22:16 ` Imre Deak
2013-12-05 13:51 ` [PATCH 12/14] drm/i915: Try to fix the messy IVB sprite scaling workaround ville.syrjala
2013-12-05 13:51 ` [PATCH 13/14] drm/i915: Don't disable primary when color keying is used ville.syrjala
2013-12-05 13:51 ` [PATCH 14/14] drm/i915: Avoid underruns when disabling sprites ville.syrjala
2013-12-05 14:30 ` [PATCH 00/14] drm/i915: Make ILK/SNB/IVB use HSW watermark code Daniel Vetter
2013-12-05 14:48 ` Ville Syrjälä
2013-12-16 21:38 ` Imre Deak [this message]
2013-12-17 10:13 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387229918.2529.5.camel@ideak-mobl \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox