* [PATCH 1/2] drm/i915: re-enable semaphores by default
@ 2011-11-14 20:39 Eugeni Dodonov
2011-11-14 20:39 ` [PATCH 2/2] drm/i915: re-enable rc6 " Eugeni Dodonov
` (2 more replies)
0 siblings, 3 replies; 18+ messages in thread
From: Eugeni Dodonov @ 2011-11-14 20:39 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter, Eugeni Dodonov
Semaphores seem to fix most of the hangs on SNB and IVB, and do not cause
any known regressions as of now.
Let's re-enable them by default to provide a wider testing and coverage.
Acked-by: Keith Packard <keithp@keithp.com>
CC: Jesse Barnes <jbarnes@virtuousgeek.org>
CC: Daniel Vetter <daniel.vetter@ffwll.ch>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=42696
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40564
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41353
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38862
Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
---
drivers/gpu/drm/i915/i915_drv.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index cc531bb..71f887a 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -58,10 +58,10 @@ module_param_named(powersave, i915_powersave, int, 0600);
MODULE_PARM_DESC(powersave,
"Enable powersavings, fbc, downclocking, etc. (default: true)");
-unsigned int i915_semaphores __read_mostly = 0;
+unsigned int i915_semaphores __read_mostly = 1;
module_param_named(semaphores, i915_semaphores, int, 0600);
MODULE_PARM_DESC(semaphores,
- "Use semaphores for inter-ring sync (default: false)");
+ "Use semaphores for inter-ring sync (default: true)");
unsigned int i915_enable_rc6 __read_mostly = 0;
module_param_named(i915_enable_rc6, i915_enable_rc6, int, 0600);
--
1.7.7.3
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH 2/2] drm/i915: re-enable rc6 by default
2011-11-14 20:39 [PATCH 1/2] drm/i915: re-enable semaphores by default Eugeni Dodonov
@ 2011-11-14 20:39 ` Eugeni Dodonov
2011-11-14 21:06 ` Lukas Hejtmanek
` (2 more replies)
2011-11-14 21:23 ` [PATCH 1/2] drm/i915: re-enable semaphores " Jesse Barnes
2011-11-16 15:49 ` Daniel Vetter
2 siblings, 3 replies; 18+ messages in thread
From: Eugeni Dodonov @ 2011-11-14 20:39 UTC (permalink / raw)
To: intel-gfx; +Cc: Daniel Vetter, Eugeni Dodonov
Most of the rc6-related hangs and major issues were addressed for the past
months.
Let's re-enable it by default to provide a more wider testing, and catch
the remaining problems.
According to tests, enablement of rc6 results in up to +50% improvements
in power usage and battery life, so it certainly would be a nice feature
to have enabled by default.
Also, most of the issues related to rc6 seem to came from VTd, so if you
are experiencing any problems with it, try disabling VTd in bios or using
intel_iommu=off kernel parameter to investigate whether it solves the
issue.
Acked-by: Keith Packard <keithp@keithp.com>
CC: Daniel Vetter <daniel.vetter@ffwll.ch>
CC: Jesse Barnes <jbarnes@virtuousgeek.org>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38567
Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
---
drivers/gpu/drm/i915/i915_drv.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 71f887a..f72f65d 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -63,7 +63,7 @@ module_param_named(semaphores, i915_semaphores, int, 0600);
MODULE_PARM_DESC(semaphores,
"Use semaphores for inter-ring sync (default: true)");
-unsigned int i915_enable_rc6 __read_mostly = 0;
+unsigned int i915_enable_rc6 __read_mostly = 1;
module_param_named(i915_enable_rc6, i915_enable_rc6, int, 0600);
MODULE_PARM_DESC(i915_enable_rc6,
"Enable power-saving render C-state 6 (default: true)");
--
1.7.7.3
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH 2/2] drm/i915: re-enable rc6 by default
2011-11-14 20:39 ` [PATCH 2/2] drm/i915: re-enable rc6 " Eugeni Dodonov
@ 2011-11-14 21:06 ` Lukas Hejtmanek
2011-11-14 23:04 ` Eugeni Dodonov
2011-11-14 21:22 ` Jesse Barnes
2011-11-16 15:53 ` Daniel Vetter
2 siblings, 1 reply; 18+ messages in thread
From: Lukas Hejtmanek @ 2011-11-14 21:06 UTC (permalink / raw)
To: Eugeni Dodonov; +Cc: Daniel Vetter, intel-gfx
Hi,
On Mon, Nov 14, 2011 at 06:39:15PM -0200, Eugeni Dodonov wrote:
> Most of the rc6-related hangs and major issues were addressed for the past
> months.
which commits should I try to check whether rc6 issue is gone? As of 3.1
kernel, I'm still getting huge screen corruption.
--
Lukáš Hejtmánek
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/2] drm/i915: re-enable rc6 by default
2011-11-14 21:06 ` Lukas Hejtmanek
@ 2011-11-14 23:04 ` Eugeni Dodonov
2011-11-14 23:12 ` Lukas Hejtmanek
0 siblings, 1 reply; 18+ messages in thread
From: Eugeni Dodonov @ 2011-11-14 23:04 UTC (permalink / raw)
To: Lukas Hejtmanek; +Cc: Daniel Vetter, intel-gfx, Eugeni Dodonov
[-- Attachment #1.1: Type: text/plain, Size: 816 bytes --]
2011/11/14 Lukas Hejtmanek <xhejtman@ics.muni.cz>
> Hi,
>
> On Mon, Nov 14, 2011 at 06:39:15PM -0200, Eugeni Dodonov wrote:
> > Most of the rc6-related hangs and major issues were addressed for the
> past
> > months.
>
> which commits should I try to check whether rc6 issue is gone? As of 3.1
> kernel, I'm still getting huge screen corruption.
>
The rc6 issue which are gone are the ones which was causing hard system
hangs and gpu hangs.
Corruptions are still out there, if they don't go away when using
intel_iommu=off then we'll have to investigate them more in-depth.
I am unable to reproduce any rc6-related corruptions on my machine(s)
though. So it looks like this is yet another case in which we'll need to
use Sherlock Holmes methods to get to them...
--
Eugeni Dodonov
<http://eugeni.dodonov.net/>
[-- Attachment #1.2: Type: text/html, Size: 1196 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/2] drm/i915: re-enable rc6 by default
2011-11-14 23:04 ` Eugeni Dodonov
@ 2011-11-14 23:12 ` Lukas Hejtmanek
2011-11-14 23:17 ` Eugeni Dodonov
0 siblings, 1 reply; 18+ messages in thread
From: Lukas Hejtmanek @ 2011-11-14 23:12 UTC (permalink / raw)
To: Eugeni Dodonov; +Cc: Daniel Vetter, intel-gfx, Eugeni Dodonov
On Mon, Nov 14, 2011 at 09:04:37PM -0200, Eugeni Dodonov wrote:
> The rc6 issue which are gone are the ones which was causing hard system
> hangs and gpu hangs.
>
> Corruptions are still out there, if they don't go away when using
> intel_iommu=off then we'll have to investigate them more in-depth.
I disabled iommu in BIOS, so I guess it is not an issue here.
> I am unable to reproduce any rc6-related corruptions on my machine(s)
> though. So it looks like this is yet another case in which we'll need to
> use Sherlock Holmes methods to get to them...
are you using SNA? I do on my SNB system.
--
Lukáš Hejtmánek
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/2] drm/i915: re-enable rc6 by default
2011-11-14 23:12 ` Lukas Hejtmanek
@ 2011-11-14 23:17 ` Eugeni Dodonov
2011-11-14 23:23 ` Lukas Hejtmanek
0 siblings, 1 reply; 18+ messages in thread
From: Eugeni Dodonov @ 2011-11-14 23:17 UTC (permalink / raw)
To: Lukas Hejtmanek; +Cc: Daniel Vetter, intel-gfx, Eugeni Dodonov
[-- Attachment #1.1: Type: text/plain, Size: 518 bytes --]
2011/11/14 Lukas Hejtmanek <xhejtman@ics.muni.cz>
> > I am unable to reproduce any rc6-related corruptions on my machine(s)
> > though. So it looks like this is yet another case in which we'll need to
> > use Sherlock Holmes methods to get to them...
>
> are you using SNA? I do on my SNB system.
>
Are the issues SNA-specific, or they happen with UXA as well?
I do use both SNA and UXA actually (thanks to
http://cgit.freedesktop.org/~eugeni/xf86-video-intel/ :)).
--
Eugeni Dodonov
<http://eugeni.dodonov.net/>
[-- Attachment #1.2: Type: text/html, Size: 927 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/2] drm/i915: re-enable rc6 by default
2011-11-14 23:17 ` Eugeni Dodonov
@ 2011-11-14 23:23 ` Lukas Hejtmanek
0 siblings, 0 replies; 18+ messages in thread
From: Lukas Hejtmanek @ 2011-11-14 23:23 UTC (permalink / raw)
To: Eugeni Dodonov; +Cc: Daniel Vetter, intel-gfx, Eugeni Dodonov
On Mon, Nov 14, 2011 at 09:17:39PM -0200, Eugeni Dodonov wrote:
> Are the issues SNA-specific, or they happen with UXA as well?
>
> I do use both SNA and UXA actually (thanks to
> http://cgit.freedesktop.org/~eugeni/xf86-video-intel/ :)).
I believe they happen with both but with SNA I got regular corruption while
with UXA I got accidental corruption. I.e., with SNA I got corrupted window in
few minutes, with UXA maybe one corruption per few hours.
But I did not try those Eric's gating patches with UXA.
I got also X server segfaults related to XV video (moving window, resing
window with video crashes the X server randomly). Didn't investigate this
(getting core file, e.g.) I have X server 1.10, I think there are some fixes
around 1.12.
--
Lukáš Hejtmánek
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/2] drm/i915: re-enable rc6 by default
2011-11-14 20:39 ` [PATCH 2/2] drm/i915: re-enable rc6 " Eugeni Dodonov
2011-11-14 21:06 ` Lukas Hejtmanek
@ 2011-11-14 21:22 ` Jesse Barnes
2011-11-16 15:53 ` Daniel Vetter
2 siblings, 0 replies; 18+ messages in thread
From: Jesse Barnes @ 2011-11-14 21:22 UTC (permalink / raw)
To: Eugeni Dodonov; +Cc: Daniel Vetter, intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 837 bytes --]
On Mon, 14 Nov 2011 18:39:15 -0200
Eugeni Dodonov <eugeni.dodonov@intel.com> wrote:
> Most of the rc6-related hangs and major issues were addressed for the past
> months.
>
> Let's re-enable it by default to provide a more wider testing, and catch
> the remaining problems.
>
> According to tests, enablement of rc6 results in up to +50% improvements
> in power usage and battery life, so it certainly would be a nice feature
> to have enabled by default.
>
> Also, most of the issues related to rc6 seem to came from VTd, so if you
> are experiencing any problems with it, try disabling VTd in bios or using
> intel_iommu=off kernel parameter to investigate whether it solves the
> issue.
Yes please.
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/2] drm/i915: re-enable rc6 by default
2011-11-14 20:39 ` [PATCH 2/2] drm/i915: re-enable rc6 " Eugeni Dodonov
2011-11-14 21:06 ` Lukas Hejtmanek
2011-11-14 21:22 ` Jesse Barnes
@ 2011-11-16 15:53 ` Daniel Vetter
[not found] ` <CAObL_7HxAt7B7v+CqgTff+ox5eg-=qLkd8jpZGsGAFFHLx73hw@mail.gmail.com>
2 siblings, 1 reply; 18+ messages in thread
From: Daniel Vetter @ 2011-11-16 15:53 UTC (permalink / raw)
To: Eugeni Dodonov; +Cc: intel-gfx
On Mon, Nov 14, 2011 at 21:39, Eugeni Dodonov <eugeni.dodonov@intel.com> wrote:
> Most of the rc6-related hangs and major issues were addressed for the past
> months.
>
> Let's re-enable it by default to provide a more wider testing, and catch
> the remaining problems.
>
> According to tests, enablement of rc6 results in up to +50% improvements
> in power usage and battery life, so it certainly would be a nice feature
> to have enabled by default.
>
> Also, most of the issues related to rc6 seem to came from VTd, so if you
> are experiencing any problems with it, try disabling VTd in bios or using
> intel_iommu=off kernel parameter to investigate whether it solves the
> issue.
>
> Acked-by: Keith Packard <keithp@keithp.com>
> CC: Daniel Vetter <daniel.vetter@ffwll.ch>
> CC: Jesse Barnes <jbarnes@virtuousgeek.org>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38567
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
Iirc the same applies to rc6 as to semaphores. We have bug reports
that it causes hard-hangs in combination with DMAR. I haven't yet
gotten around to poking the relevant reporters whether ppgtt changes
anything, because internet access here at the Intel Poland site sucks.
So again I think we need to disable this on snb when DMAR is on.
-Daniel
--
Daniel Vetter
daniel.vetter@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] drm/i915: re-enable semaphores by default
2011-11-14 20:39 [PATCH 1/2] drm/i915: re-enable semaphores by default Eugeni Dodonov
2011-11-14 20:39 ` [PATCH 2/2] drm/i915: re-enable rc6 " Eugeni Dodonov
@ 2011-11-14 21:23 ` Jesse Barnes
2011-11-16 15:49 ` Daniel Vetter
2 siblings, 0 replies; 18+ messages in thread
From: Jesse Barnes @ 2011-11-14 21:23 UTC (permalink / raw)
To: Eugeni Dodonov; +Cc: Daniel Vetter, intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 1963 bytes --]
On Mon, 14 Nov 2011 18:39:14 -0200
Eugeni Dodonov <eugeni.dodonov@intel.com> wrote:
> Semaphores seem to fix most of the hangs on SNB and IVB, and do not cause
> any known regressions as of now.
>
> Let's re-enable them by default to provide a wider testing and coverage.
>
> Acked-by: Keith Packard <keithp@keithp.com>
> CC: Jesse Barnes <jbarnes@virtuousgeek.org>
> CC: Daniel Vetter <daniel.vetter@ffwll.ch>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=42696
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40564
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41353
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38862
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index cc531bb..71f887a 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -58,10 +58,10 @@ module_param_named(powersave, i915_powersave, int, 0600);
> MODULE_PARM_DESC(powersave,
> "Enable powersavings, fbc, downclocking, etc. (default: true)");
>
> -unsigned int i915_semaphores __read_mostly = 0;
> +unsigned int i915_semaphores __read_mostly = 1;
> module_param_named(semaphores, i915_semaphores, int, 0600);
> MODULE_PARM_DESC(semaphores,
> - "Use semaphores for inter-ring sync (default: false)");
> + "Use semaphores for inter-ring sync (default: true)");
>
> unsigned int i915_enable_rc6 __read_mostly = 0;
> module_param_named(i915_enable_rc6, i915_enable_rc6, int, 0600);
I think we should keep them enabled; if one or two fat cats in the 1%
still have issues we can debug those without bringing down performance
for the other 99%.
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] drm/i915: re-enable semaphores by default
2011-11-14 20:39 [PATCH 1/2] drm/i915: re-enable semaphores by default Eugeni Dodonov
2011-11-14 20:39 ` [PATCH 2/2] drm/i915: re-enable rc6 " Eugeni Dodonov
2011-11-14 21:23 ` [PATCH 1/2] drm/i915: re-enable semaphores " Jesse Barnes
@ 2011-11-16 15:49 ` Daniel Vetter
2011-11-16 17:16 ` Keith Packard
2 siblings, 1 reply; 18+ messages in thread
From: Daniel Vetter @ 2011-11-16 15:49 UTC (permalink / raw)
To: Eugeni Dodonov; +Cc: intel-gfx
On Mon, Nov 14, 2011 at 21:39, Eugeni Dodonov <eugeni.dodonov@intel.com> wrote:
> Semaphores seem to fix most of the hangs on SNB and IVB, and do not cause
> any known regressions as of now.
>
> Let's re-enable them by default to provide a wider testing and coverage.
>
> Acked-by: Keith Packard <keithp@keithp.com>
> CC: Jesse Barnes <jbarnes@virtuousgeek.org>
> CC: Daniel Vetter <daniel.vetter@ffwll.ch>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=42696
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40564
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41353
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38862
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
Semaphores are still broken on my snb in combination with DMAR. ppgtt
seems to slightly change the failure mode and probably helps in
tracking this down, but without ppgtt it's a hard hang a few seconds
after login. So we need to check whether DMAR is enabled (on the
entire system, i.e. the variable exported for the ilk workaround is
not good enough) on snb and then disable it by default. So in this
current form:
Nacked-by: Daniel Vetter <daniel.vetter@ffwll.ch> (still causes easily
reproducible hard-hangs)
I don't have anything against enabling this by default on ivb.
--
Daniel Vetter
daniel.vetter@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] drm/i915: re-enable semaphores by default
2011-11-16 15:49 ` Daniel Vetter
@ 2011-11-16 17:16 ` Keith Packard
2011-11-16 17:24 ` Andrew Lutomirski
2011-11-16 20:18 ` Daniel Vetter
0 siblings, 2 replies; 18+ messages in thread
From: Keith Packard @ 2011-11-16 17:16 UTC (permalink / raw)
To: Daniel Vetter, Eugeni Dodonov; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 429 bytes --]
On Wed, 16 Nov 2011 16:49:40 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> So we need to check whether DMAR is enabled (on the
> entire system, i.e. the variable exported for the ilk workaround is
> not good enough)
Can you figure out what *would* be sufficient? Getting semaphores turned
on for the 99% who aren't enabling VT-d would be a fairly nice
performance improvement.
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] drm/i915: re-enable semaphores by default
2011-11-16 17:16 ` Keith Packard
@ 2011-11-16 17:24 ` Andrew Lutomirski
2011-11-16 19:05 ` Eugeni Dodonov
2011-11-16 20:18 ` Daniel Vetter
1 sibling, 1 reply; 18+ messages in thread
From: Andrew Lutomirski @ 2011-11-16 17:24 UTC (permalink / raw)
To: Keith Packard; +Cc: Daniel Vetter, intel-gfx, Eugeni Dodonov
On Wed, Nov 16, 2011 at 9:16 AM, Keith Packard <keithp@keithp.com> wrote:
> On Wed, 16 Nov 2011 16:49:40 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>
>> So we need to check whether DMAR is enabled (on the
>> entire system, i.e. the variable exported for the ilk workaround is
>> not good enough)
>
> Can you figure out what *would* be sufficient? Getting semaphores turned
> on for the 99% who aren't enabling VT-d would be a fairly nice
> performance improvement.
AFAICT my snb laptop has always been stable with semaphores and VT-d
enabled. Is this problem possibly restricted to just desktop
machines? I'm happy to test, since my box that can reproduce the hang
instantly is still around.
Also, rc6-by-default would be very nice. It decreases the total power
consumption on my laptop from over 13W to around 8W. That's huge.
--Andy
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] drm/i915: re-enable semaphores by default
2011-11-16 17:24 ` Andrew Lutomirski
@ 2011-11-16 19:05 ` Eugeni Dodonov
2011-11-16 19:23 ` Jesse Barnes
0 siblings, 1 reply; 18+ messages in thread
From: Eugeni Dodonov @ 2011-11-16 19:05 UTC (permalink / raw)
To: Andrew Lutomirski; +Cc: Daniel Vetter, intel-gfx, Eugeni Dodonov
[-- Attachment #1.1: Type: text/plain, Size: 675 bytes --]
On Wed, Nov 16, 2011 at 15:24, Andrew Lutomirski <luto@mit.edu> wrote:
> AFAICT my snb laptop has always been stable with semaphores and VT-d
> enabled. Is this problem possibly restricted to just desktop
> machines? I'm happy to test, since my box that can reproduce the hang
> instantly is still around.
>
I cannot reproduce those issues on any mobile SNB, but I am out of desktop
ones. So perhaps it is a clue.
Jesse, Keith, Daniel, what if we add something like:
...
.has_semaphores=1, .has_rc6=1
...
to i915_drv.c intel_sandybridge_m_info, and take them into account when
using default values for those settings?
--
Eugeni Dodonov
<http://eugeni.dodonov.net/>
[-- Attachment #1.2: Type: text/html, Size: 995 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] drm/i915: re-enable semaphores by default
2011-11-16 19:05 ` Eugeni Dodonov
@ 2011-11-16 19:23 ` Jesse Barnes
0 siblings, 0 replies; 18+ messages in thread
From: Jesse Barnes @ 2011-11-16 19:23 UTC (permalink / raw)
To: Eugeni Dodonov; +Cc: Daniel Vetter, intel-gfx, Eugeni Dodonov
On Wed, 16 Nov 2011 17:05:37 -0200
Eugeni Dodonov <eugeni@dodonov.net> wrote:
> On Wed, Nov 16, 2011 at 15:24, Andrew Lutomirski <luto@mit.edu> wrote:
>
> > AFAICT my snb laptop has always been stable with semaphores and VT-d
> > enabled. Is this problem possibly restricted to just desktop
> > machines? I'm happy to test, since my box that can reproduce the hang
> > instantly is still around.
> >
>
> I cannot reproduce those issues on any mobile SNB, but I am out of desktop
> ones. So perhaps it is a clue.
>
> Jesse, Keith, Daniel, what if we add something like:
>
> ...
> .has_semaphores=1, .has_rc6=1
> ...
>
> to i915_drv.c intel_sandybridge_m_info, and take them into account when
> using default values for those settings?
Something like that is fine with me, or just doing it in modeset_init
for certain chipsets.
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] drm/i915: re-enable semaphores by default
2011-11-16 17:16 ` Keith Packard
2011-11-16 17:24 ` Andrew Lutomirski
@ 2011-11-16 20:18 ` Daniel Vetter
2011-11-16 21:37 ` Keith Packard
1 sibling, 1 reply; 18+ messages in thread
From: Daniel Vetter @ 2011-11-16 20:18 UTC (permalink / raw)
To: Keith Packard; +Cc: intel-gfx, Eugeni Dodonov
On Wed, Nov 16, 2011 at 18:16, Keith Packard <keithp@keithp.com> wrote:
> On Wed, 16 Nov 2011 16:49:40 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>
>> So we need to check whether DMAR is enabled (on the
>> entire system, i.e. the variable exported for the ilk workaround is
>> not good enough)
>
> Can you figure out what *would* be sufficient? Getting semaphores turned
> on for the 99% who aren't enabling VT-d would be a fairly nice
> performance improvement.
Last time I've played around with all the combinations, only
intel_iommu=off was good enough to prevent the hang.
intel_iommu=igd_off still hangs (which is what the current value
exported by the dmar code dopends on, iirc). If I remember things
correctly, intel_iommu=off also reliably works around issues for all
reporters (both semaphores and rc6).
And for reproducing it, at least here the key ingredient seems to be a
kde4 desktop. Spare the jokes ;-)
-Daniel
--
Daniel Vetter
daniel.vetter@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] drm/i915: re-enable semaphores by default
2011-11-16 20:18 ` Daniel Vetter
@ 2011-11-16 21:37 ` Keith Packard
0 siblings, 0 replies; 18+ messages in thread
From: Keith Packard @ 2011-11-16 21:37 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx, Eugeni Dodonov
[-- Attachment #1.1: Type: text/plain, Size: 590 bytes --]
On Wed, 16 Nov 2011 21:18:13 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Last time I've played around with all the combinations, only
> intel_iommu=off was good enough to prevent the hang.
> intel_iommu=igd_off still hangs (which is what the current value
> exported by the dmar code dopends on, iirc). If I remember things
> correctly, intel_iommu=off also reliably works around issues for all
> reporters (both semaphores and rc6).
So, the dmar_disabled flag would suffice? Should be trivial to export
that and check in our driver.
--
keith.packard@intel.com
[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2011-11-16 21:37 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-14 20:39 [PATCH 1/2] drm/i915: re-enable semaphores by default Eugeni Dodonov
2011-11-14 20:39 ` [PATCH 2/2] drm/i915: re-enable rc6 " Eugeni Dodonov
2011-11-14 21:06 ` Lukas Hejtmanek
2011-11-14 23:04 ` Eugeni Dodonov
2011-11-14 23:12 ` Lukas Hejtmanek
2011-11-14 23:17 ` Eugeni Dodonov
2011-11-14 23:23 ` Lukas Hejtmanek
2011-11-14 21:22 ` Jesse Barnes
2011-11-16 15:53 ` Daniel Vetter
[not found] ` <CAObL_7HxAt7B7v+CqgTff+ox5eg-=qLkd8jpZGsGAFFHLx73hw@mail.gmail.com>
2011-11-16 20:22 ` Daniel Vetter
2011-11-14 21:23 ` [PATCH 1/2] drm/i915: re-enable semaphores " Jesse Barnes
2011-11-16 15:49 ` Daniel Vetter
2011-11-16 17:16 ` Keith Packard
2011-11-16 17:24 ` Andrew Lutomirski
2011-11-16 19:05 ` Eugeni Dodonov
2011-11-16 19:23 ` Jesse Barnes
2011-11-16 20:18 ` Daniel Vetter
2011-11-16 21:37 ` Keith Packard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox