Re: [Intel-gfx] [PATCH v2 0/7] drm/i915: Baytrail MIPI DSI support Updated

From: Thierry Reding <thierry.reding@gmail.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: jani.nikula@intel.com, Shobhit Kumar <shobhit.kumar@intel.com>,
	intel-gfx <intel-gfx@lists.freedesktop.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	vijayakumar.balakrishnan@intel.com,
	yogesh.mohan.marimuthu@intel.com,
	Thierry Reding <treding@nvidia.com>
Subject: Re: [Intel-gfx] [PATCH v2 0/7] drm/i915: Baytrail MIPI DSI support Updated
Date: Mon, 11 Nov 2013 09:50:58 +0100	[thread overview]
Message-ID: <20131111085057.GB3884@ulmo.nvidia.com> (raw)
In-Reply-To: <20131109102816.GJ14082@phenom.ffwll.local>

[-- Attachment #1.1: Type: text/plain, Size: 2185 bytes --]

On Sat, Nov 09, 2013 at 11:28:16AM +0100, Daniel Vetter wrote:
> On Sat, Nov 09, 2013 at 03:19:01PM +0530, Shobhit Kumar wrote:
> > Hi All - 
> > These patches enhance the current support for MIPI DSI for Baytrail. They
> > continue on the sub-encoder design and adds few more dev_ops to handle
> > sequence correctly. Major changes are -
> > 
> > 1. DSI Clock calculation based on pixel clock
> > 2. Add new dev_ops for better sequencing the enable/disable path
> > 3. Parameterized the hardcoded DSI parameters. These also forms building
> >    block for the generic MIPI driver to come in future based on enhancements
> >    in VBT. All these parameters are initialized or computed in the sub-encoder
> >    driver. Some of them might look unneccesary for now.
> > 
> >  I am also aware of the drm_bridge support now comming in and will in future
> >  migrate from sub-encoder design to drm_bridge.
> 
> Just a quick aside: Thierry Reding from nvidia is also working on a DSI
> design for the tegra driver. Atm he seems to aim for a full-blown DSI bus
> based on his drm_panel patches for getting the panel metadata out of an
> ARM DT (we'd use VBT instead). Iirc there's no patches anywhere yet, but
> maybe Thierry could share a git branch somewhere with the wip stuff?
> 
> Cc'ing Thierry and dri-devel in case a bigger discussion develops.

I've been cleaning up the patches and was going to post them today. The
implementation really isn't as "full-blown" as you make it sound =),
primarily because the DSI panel that I have doesn't support things such
as reading out the DDB, so I cannot test most of the functionality that
I planned to.

However I think introducing a DSI bus type is the right thing and it's
been suggested recently that we have too few bus types. Furthermore it
seems to be playing out rather nicely with the DRM panel work, so it
would be really nice if Intel could test-drive this within their driver
to see if it's good enough for their purposes as well.

Is everyone working on that subscribed to dri-devel or should I Cc the
intel-gfx mailing list (or someone in particular) when posting the
patches?

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel