* [PATCH] drm/i915/vlv: disable PPGTT on early revs
@ 2014-06-13 15:32 Jesse Barnes
2014-06-13 15:54 ` Ville Syrjälä
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Jesse Barnes @ 2014-06-13 15:32 UTC (permalink / raw)
To: intel-gfx
Early revs didn't have PPGTT support, so disable there.
References: https://bugs.freedesktop.org/show_bug.cgi?id=79669
References: https://bugs.freedesktop.org/show_bug.cgi?id=79670
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 8b3cde7..01287d9 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -63,6 +63,10 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt)
}
#endif
+ /* Early VLV doesn't have this */
+ if (IS_VALLEYVIEW(dev) && dev->pdev->revision < 0xc)
+ return 0;
+
return HAS_ALIASING_PPGTT(dev) ? 1 : 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] drm/i915/vlv: disable PPGTT on early revs
2014-06-13 15:32 [PATCH] drm/i915/vlv: disable PPGTT on early revs Jesse Barnes
@ 2014-06-13 15:54 ` Ville Syrjälä
2014-06-13 16:02 ` Chris Wilson
2014-06-13 16:09 ` Jesse Barnes
2014-06-13 16:16 ` [PATCH] drm/i915/vlv: disable PPGTT on early revs v2 Jesse Barnes
2014-06-13 16:28 ` [PATCH] drm/i915/vlv: disable PPGTT on early revs v3 Jesse Barnes
2 siblings, 2 replies; 9+ messages in thread
From: Ville Syrjälä @ 2014-06-13 15:54 UTC (permalink / raw)
To: Jesse Barnes; +Cc: intel-gfx
On Fri, Jun 13, 2014 at 08:32:38AM -0700, Jesse Barnes wrote:
> Early revs didn't have PPGTT support, so disable there.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=79669
> References: https://bugs.freedesktop.org/show_bug.cgi?id=79670
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
> drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 8b3cde7..01287d9 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -63,6 +63,10 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt)
> }
> #endif
>
> + /* Early VLV doesn't have this */
> + if (IS_VALLEYVIEW(dev) && dev->pdev->revision < 0xc)
Did you mean < 0xb?
> + return 0;
> +
> return HAS_ALIASING_PPGTT(dev) ? 1 : 0;
> }
>
> --
> 1.7.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915/vlv: disable PPGTT on early revs
2014-06-13 15:54 ` Ville Syrjälä
@ 2014-06-13 16:02 ` Chris Wilson
2014-06-13 16:31 ` Jesse Barnes
2014-06-13 16:09 ` Jesse Barnes
1 sibling, 1 reply; 9+ messages in thread
From: Chris Wilson @ 2014-06-13 16:02 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Fri, Jun 13, 2014 at 06:54:02PM +0300, Ville Syrjälä wrote:
> On Fri, Jun 13, 2014 at 08:32:38AM -0700, Jesse Barnes wrote:
> > Early revs didn't have PPGTT support, so disable there.
> >
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=79669
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=79670
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > ---
> > drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > index 8b3cde7..01287d9 100644
> > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > @@ -63,6 +63,10 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt)
> > }
> > #endif
> >
> > + /* Early VLV doesn't have this */
> > + if (IS_VALLEYVIEW(dev) && dev->pdev->revision < 0xc)
>
> Did you mean < 0xb?
Also some log message is required.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915/vlv: disable PPGTT on early revs
2014-06-13 16:02 ` Chris Wilson
@ 2014-06-13 16:31 ` Jesse Barnes
0 siblings, 0 replies; 9+ messages in thread
From: Jesse Barnes @ 2014-06-13 16:31 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Fri, 13 Jun 2014 17:02:10 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Fri, Jun 13, 2014 at 06:54:02PM +0300, Ville Syrjälä wrote:
> > On Fri, Jun 13, 2014 at 08:32:38AM -0700, Jesse Barnes wrote:
> > > Early revs didn't have PPGTT support, so disable there.
> > >
> > > References: https://bugs.freedesktop.org/show_bug.cgi?id=79669
> > > References: https://bugs.freedesktop.org/show_bug.cgi?id=79670
> > > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > > ---
> > > drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > > index 8b3cde7..01287d9 100644
> > > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> > > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > > @@ -63,6 +63,10 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt)
> > > }
> > > #endif
> > >
> > > + /* Early VLV doesn't have this */
> > > + if (IS_VALLEYVIEW(dev) && dev->pdev->revision < 0xc)
> >
> > Did you mean < 0xb?
>
> Also some log message is required.
Ok, added.
--
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915/vlv: disable PPGTT on early revs
2014-06-13 15:54 ` Ville Syrjälä
2014-06-13 16:02 ` Chris Wilson
@ 2014-06-13 16:09 ` Jesse Barnes
1 sibling, 0 replies; 9+ messages in thread
From: Jesse Barnes @ 2014-06-13 16:09 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Fri, 13 Jun 2014 18:54:02 +0300
Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Fri, Jun 13, 2014 at 08:32:38AM -0700, Jesse Barnes wrote:
> > Early revs didn't have PPGTT support, so disable there.
> >
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=79669
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=79670
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > ---
> > drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > index 8b3cde7..01287d9 100644
> > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > @@ -63,6 +63,10 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt)
> > }
> > #endif
> >
> > + /* Early VLV doesn't have this */
> > + if (IS_VALLEYVIEW(dev) && dev->pdev->revision < 0xc)
>
> Did you mean < 0xb?
No, unless you tested on 0xb...
--
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] drm/i915/vlv: disable PPGTT on early revs v2
2014-06-13 15:32 [PATCH] drm/i915/vlv: disable PPGTT on early revs Jesse Barnes
2014-06-13 15:54 ` Ville Syrjälä
@ 2014-06-13 16:16 ` Jesse Barnes
2014-06-13 16:28 ` [PATCH] drm/i915/vlv: disable PPGTT on early revs v3 Jesse Barnes
2 siblings, 0 replies; 9+ messages in thread
From: Jesse Barnes @ 2014-06-13 16:16 UTC (permalink / raw)
To: intel-gfx
Early revs didn't have PPGTT support, so disable there.
v2: add debug msg when disabling on early stepping
References: https://bugs.freedesktop.org/show_bug.cgi?id=79669
References: https://bugs.freedesktop.org/show_bug.cgi?id=79670
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 8b3cde7..0f51f83 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -63,6 +63,12 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt)
}
#endif
+ /* Early VLV doesn't have this */
+ if (IS_VALLEYVIEW(dev) && dev->pdev->revision < 0xc) {
+ DRM_DEBUG_DRIVER("disabling PPGTT on pre-rev c VLV\n");
+ return 0;
+ }
+
return HAS_ALIASING_PPGTT(dev) ? 1 : 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] drm/i915/vlv: disable PPGTT on early revs v3
2014-06-13 15:32 [PATCH] drm/i915/vlv: disable PPGTT on early revs Jesse Barnes
2014-06-13 15:54 ` Ville Syrjälä
2014-06-13 16:16 ` [PATCH] drm/i915/vlv: disable PPGTT on early revs v2 Jesse Barnes
@ 2014-06-13 16:28 ` Jesse Barnes
2014-06-13 16:45 ` Ville Syrjälä
2 siblings, 1 reply; 9+ messages in thread
From: Jesse Barnes @ 2014-06-13 16:28 UTC (permalink / raw)
To: intel-gfx
Early revs didn't have PPGTT support, so disable there.
v2: add debug msg when disabling on early stepping
v3: enable on other B3 packages as well (untested) (Ville)
References: https://bugs.freedesktop.org/show_bug.cgi?id=79669
References: https://bugs.freedesktop.org/show_bug.cgi?id=79670
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 8b3cde7..7f226fa 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -63,6 +63,12 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt)
}
#endif
+ /* Early VLV doesn't have this */
+ if (IS_VALLEYVIEW(dev) && dev->pdev->revision < 0xb) {
+ DRM_DEBUG_DRIVER("disabling PPGTT on pre-B3 step VLV\n");
+ return 0;
+ }
+
return HAS_ALIASING_PPGTT(dev) ? 1 : 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] drm/i915/vlv: disable PPGTT on early revs v3
2014-06-13 16:28 ` [PATCH] drm/i915/vlv: disable PPGTT on early revs v3 Jesse Barnes
@ 2014-06-13 16:45 ` Ville Syrjälä
2014-06-13 16:52 ` Daniel Vetter
0 siblings, 1 reply; 9+ messages in thread
From: Ville Syrjälä @ 2014-06-13 16:45 UTC (permalink / raw)
To: Jesse Barnes; +Cc: intel-gfx
On Fri, Jun 13, 2014 at 09:28:33AM -0700, Jesse Barnes wrote:
> Early revs didn't have PPGTT support, so disable there.
>
> v2: add debug msg when disabling on early stepping
> v3: enable on other B3 packages as well (untested) (Ville)
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=79669
> References: https://bugs.freedesktop.org/show_bug.cgi?id=79670
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
I don't have any affected systems myself, but it did fail for me on
a pre-production part and the evidence from the bugs is strong, so:
Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem_gtt.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 8b3cde7..7f226fa 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -63,6 +63,12 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt)
> }
> #endif
>
> + /* Early VLV doesn't have this */
> + if (IS_VALLEYVIEW(dev) && dev->pdev->revision < 0xb) {
> + DRM_DEBUG_DRIVER("disabling PPGTT on pre-B3 step VLV\n");
> + return 0;
> + }
> +
> return HAS_ALIASING_PPGTT(dev) ? 1 : 0;
> }
>
> --
> 1.7.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] drm/i915/vlv: disable PPGTT on early revs v3
2014-06-13 16:45 ` Ville Syrjälä
@ 2014-06-13 16:52 ` Daniel Vetter
0 siblings, 0 replies; 9+ messages in thread
From: Daniel Vetter @ 2014-06-13 16:52 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Fri, Jun 13, 2014 at 07:45:50PM +0300, Ville Syrjälä wrote:
> On Fri, Jun 13, 2014 at 09:28:33AM -0700, Jesse Barnes wrote:
> > Early revs didn't have PPGTT support, so disable there.
> >
> > v2: add debug msg when disabling on early stepping
> > v3: enable on other B3 packages as well (untested) (Ville)
> >
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=79669
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=79670
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> I don't have any affected systems myself, but it did fail for me on
> a pre-production part and the evidence from the bugs is strong, so:
>
> Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Queued for -next, thanks for the patch.
-Daniel
>
> > ---
> > drivers/gpu/drm/i915/i915_gem_gtt.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > index 8b3cde7..7f226fa 100644
> > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > @@ -63,6 +63,12 @@ static int sanitize_enable_ppgtt(struct drm_device *dev, int enable_ppgtt)
> > }
> > #endif
> >
> > + /* Early VLV doesn't have this */
> > + if (IS_VALLEYVIEW(dev) && dev->pdev->revision < 0xb) {
> > + DRM_DEBUG_DRIVER("disabling PPGTT on pre-B3 step VLV\n");
> > + return 0;
> > + }
> > +
> > return HAS_ALIASING_PPGTT(dev) ? 1 : 0;
> > }
> >
> > --
> > 1.7.9.5
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Ville Syrjälä
> Intel OTC
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-06-13 16:52 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-13 15:32 [PATCH] drm/i915/vlv: disable PPGTT on early revs Jesse Barnes
2014-06-13 15:54 ` Ville Syrjälä
2014-06-13 16:02 ` Chris Wilson
2014-06-13 16:31 ` Jesse Barnes
2014-06-13 16:09 ` Jesse Barnes
2014-06-13 16:16 ` [PATCH] drm/i915/vlv: disable PPGTT on early revs v2 Jesse Barnes
2014-06-13 16:28 ` [PATCH] drm/i915/vlv: disable PPGTT on early revs v3 Jesse Barnes
2014-06-13 16:45 ` Ville Syrjälä
2014-06-13 16:52 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox