Re: [PATCH 06/18] drm/i915: Include the vblank delay in the state dump

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 12/11/2024 2:39 AM, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> While one can look at the crtc timings to determine the actual
> vblank dealy, it seems nicer to provide a more human readable
> dump of it to ease our lives.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>


> ---
>   drivers/gpu/drm/i915/display/intel_crtc_state_dump.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> index 9d930ff862cf..27ce34df8482 100644
> --- a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> +++ b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> @@ -283,7 +283,9 @@ void intel_crtc_state_dump(const struct intel_crtc_state *pipe_config,
>   		drm_print_hex_dump(&p, "ELD: ", pipe_config->eld,
>   				   drm_eld_size(pipe_config->eld));
>   
> -	drm_printf(&p, "framestart delay: %d, MSA timing delay: %d\n",
> +	drm_printf(&p, "vblank delay: %d, framestart delay: %d, MSA timing delay: %d\n",
> +		   pipe_config->hw.adjusted_mode.crtc_vblank_start -
> +		   pipe_config->hw.adjusted_mode.crtc_vdisplay,
>   		   pipe_config->framestart_delay, pipe_config->msa_timing_delay);
>   
>   	drm_printf(&p, "vrr: %s, vmin: %d, vmax: %d, pipeline full: %d, guardband: %d flipline: %d, vmin vblank: %d, vmax vblank: %d\n",