Re: [PATCH 07/18] drm/i915/vrr: Improve VRR state dump

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 12/11/2024 2:39 AM, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Dump the calculated vmin/vmax vtotal values in addition to the
> raw vmin/vmax/flipline values. Makes it much easier to see what
> kind of scanline values we should be expecting from the hardware.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>


> ---
>   .../gpu/drm/i915/display/intel_crtc_state_dump.c    | 13 +++++++------
>   1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> index 27ce34df8482..97e3cdccda01 100644
> --- a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> +++ b/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c
> @@ -288,13 +288,14 @@ void intel_crtc_state_dump(const struct intel_crtc_state *pipe_config,
>   		   pipe_config->hw.adjusted_mode.crtc_vdisplay,
>   		   pipe_config->framestart_delay, pipe_config->msa_timing_delay);
>   
> -	drm_printf(&p, "vrr: %s, vmin: %d, vmax: %d, pipeline full: %d, guardband: %d flipline: %d, vmin vblank: %d, vmax vblank: %d\n",
> +	drm_printf(&p, "vrr: %s, vmin: %d, vmax: %d, flipline: %d, pipeline full: %d, guardband: %d\n",
>   		   str_yes_no(pipe_config->vrr.enable),
> -		   pipe_config->vrr.vmin, pipe_config->vrr.vmax,
> -		   pipe_config->vrr.pipeline_full, pipe_config->vrr.guardband,
> -		   pipe_config->vrr.flipline,
> -		   intel_vrr_vmin_vblank_start(pipe_config),
> -		   intel_vrr_vmax_vblank_start(pipe_config));
> +		   pipe_config->vrr.vmin, pipe_config->vrr.vmax, pipe_config->vrr.flipline,
> +		   pipe_config->vrr.pipeline_full, pipe_config->vrr.guardband);
> +
> +	drm_printf(&p, "vrr: vmin vblank: %d, vmax vblank: %d, vmin vtotal: %d, vmax vtotal: %d\n",
> +		   intel_vrr_vmin_vblank_start(pipe_config), intel_vrr_vmax_vblank_start(pipe_config),
> +		   intel_vrr_vmin_vtotal(pipe_config), intel_vrr_vmax_vtotal(pipe_config));
>   
>   	drm_printf(&p, "requested mode: " DRM_MODE_FMT "\n",
>   		   DRM_MODE_ARG(&pipe_config->hw.mode));