Re: [PATCH 00/18] drm/i915: DSB+VRR

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Dec 10, 2024 at 11:09:49PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> bunch of DSB and VRR Stuff:
> - enable DSB based commits when VRR is active
> - fix TGL delayed vblank handling with VRR
> - some tweaks to VRR programming for ADL+
> - bunch of state dump improvements/etc.
> 
> Ville Syrjälä (18):
>   drm/i915: Extract intel_crtc_vblank_delay()
>   drm/i915: Check vblank delay validity
>   drm/i915: Fix include order
>   drm/i915: Introduce intel_vrr_{vmin,vmax}_vtotal()
>   drm/i915: Move framestart/etc. state dump to a better spot
>   drm/i915: Include the vblank delay in the state dump
>   drm/i915/vrr: Improve VRR state dump
>   drm/i915: Include the scanline offset in the state dump
>   drm/i915: Extract intel_mode_vblank_delay()
>   drm/i915: Consolidate intel_pre_commit_crtc_state()
>   drm/i915: Extract intel_crtc_active_timings()
>   drm/i915/vrr: Introduce intel_vrr_vblank_delay()
>   drm/i915/vrr: Drop the extra vmin adjustment for ADL+
>   drm/i915/vrr: Fix vmin/vmax/flipline on TGL when using vblank delay
>   drm/i915/vrr: Add extra vblank delay to estimates
>   drm/i915/vrr: Plumb the DSB into intel_vrr_send_push()

Pushed everyyhing up to here to drm-intel-next. Thanks
for the reviews.

I stopped here for now becaue I suppose I need to go and
ponder about that vblank_start vs. fastboot issue that just
got reported...

>   drm/i915/dsb: Add support for triggering VRR push with DSB
>   drm/i915/dsb: Allow DSB to perform commits when VRR is enabled
> 
>  drivers/gpu/drm/i915/display/intel_crtc.c     |   2 +-
>  .../drm/i915/display/intel_crtc_state_dump.c  |  25 ++--
>  drivers/gpu/drm/i915/display/intel_display.c  |  68 +++++++++--
>  drivers/gpu/drm/i915/display/intel_dsb.c      |  54 ++++-----
>  drivers/gpu/drm/i915/display/intel_vblank.c   |  84 +++++++++----
>  drivers/gpu/drm/i915/display/intel_vblank.h   |   6 +
>  drivers/gpu/drm/i915/display/intel_vrr.c      | 113 +++++++++++++++---
>  drivers/gpu/drm/i915/display/intel_vrr.h      |   7 +-
>  8 files changed, 268 insertions(+), 91 deletions(-)
> 
> -- 
> 2.45.2

-- 
Ville Syrjälä
Intel