Re: [PATCH v3 09/23] drm/i915/tgl: Add maximum resolution supported by PSR2 HW

["Gupta, Anshuman" <anshuman.gupta@intel.com>]

Validated with respect to B.Specs:49199 and 50422.

On 8/26/2019 10:40 PM, Lucas De Marchi wrote:
> On Sat, Aug 24, 2019 at 04:36:52PM +0530, Anshuman Gupta wrote:
>> On 2019-08-23 at 01:20:41 -0700, Lucas De Marchi wrote:
>>> From: José Roberto de Souza <jose.souza@intel.com>
>>>
>>> TGL PSR2 HW supports a bigger resolution, so lets add it
>>>
>>> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
>>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Anshuman Gupta <anshuman.gupta@intel.com>
>>> ---
>>>  drivers/gpu/drm/i915/display/intel_psr.c | 5 ++++-
>>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c 
>>> b/drivers/gpu/drm/i915/display/intel_psr.c
>>> index c33aa16ed038..5d24f1c47a2b 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_psr.c
>>> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
>>> @@ -570,7 +570,10 @@ static bool intel_psr2_config_valid(struct 
>>> intel_dp *intel_dp,
>>>          return false;
>>>      }
>>>
>>> -    if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv)) {
>>> +    if (INTEL_GEN(dev_priv) >= 12) {
>> As per B.Specs:28692 on few Gen11 platform, PSR2 supports max 
>> resolution of 5120X3200.
>> Do we need to handle those Gen11 platform here?
> 
> the only thing I see there for gen11 is:
> 
>      "PSR2 maximum pipe horizontal active size 4096 pixels."
> 
> Lucas De Marchi
> 
>>> +        psr_max_h = 5120;
>>> +        psr_max_v = 3200;
>>> +    } else if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv)) {
>>>          psr_max_h = 4096;
>>>          psr_max_v = 2304;
>>>      } else if (IS_GEN(dev_priv, 9)) {
>>> -- 
>>> 2.23.0
>>>
>>> _______________________________________________
>>> Intel-gfx mailing list
>>> Intel-gfx@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx