* [Intel-gfx] [PATCH 1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping
@ 2021-02-12 18:21 José Roberto de Souza
2021-02-12 18:22 ` [Intel-gfx] [PATCH 2/3] drm/i915: Remove dead code from skl_pipe_wm_get_hw_state() José Roberto de Souza
` (8 more replies)
0 siblings, 9 replies; 23+ messages in thread
From: José Roberto de Souza @ 2021-02-12 18:21 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi
The cfgcr0/1_clk_off mapping is wrong for adl-s what could cause
the wrong clock being disabled and leaving a not needed clock
running consuming more power than needed.
Bspec: 50287
Bspec: 53812
Bspec: 53723
Fixes: d6d2bc996e45 ("drm/i915/adl_s: Configure Port clock registers for ADL-S")
Cc: Aditya Swarup <aditya.swarup@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/display/intel_ddi.c | 4 +++-
drivers/gpu/drm/i915/i915_reg.h | 12 ++++++++++++
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 2d6906f6995f..7631e080349d 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -1585,7 +1585,9 @@ hsw_set_signal_levels(struct intel_dp *intel_dp,
static u32 icl_dpclka_cfgcr0_clk_off(struct drm_i915_private *dev_priv,
enum phy phy)
{
- if (IS_ROCKETLAKE(dev_priv)) {
+ if (IS_ALDERLAKE_S(dev_priv)) {
+ return ADLS_DPCLKA_CFGCR_DDI_CLK_OFF(phy);
+ } else if (IS_ROCKETLAKE(dev_priv)) {
return RKL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy);
} else if (intel_phy_is_combo(dev_priv, phy)) {
return ICL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy);
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 224ad897af34..7c69b50ccc5c 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -10416,6 +10416,18 @@ enum skl_power_gate {
ADLS_DPCLKA_DDIJ_SEL_MASK, \
ADLS_DPCLKA_DDIK_SEL_MASK)
+#define _ADLS_DPCLKA_DDIA_CLK_OFF REG_BIT(10)
+#define _ADLS_DPCLKA_DDIB_CLK_OFF REG_BIT(11)
+#define _ADLS_DPCLKA_DDII_CLK_OFF REG_BIT(24)
+#define _ADLS_DPCLKA_DDIJ_CLK_OFF REG_BIT(4)
+#define _ADLS_DPCLKA_DDIK_CLK_OFF REG_BIT(5)
+#define ADLS_DPCLKA_CFGCR_DDI_CLK_OFF(phy) _PICK((phy), \
+ _ADLS_DPCLKA_DDIA_CLK_OFF, \
+ _ADLS_DPCLKA_DDIB_CLK_OFF, \
+ _ADLS_DPCLKA_DDII_CLK_OFF, \
+ _ADLS_DPCLKA_DDIJ_CLK_OFF, \
+ _ADLS_DPCLKA_DDIK_CLK_OFF)
+
/* CNL PLL */
#define DPLL0_ENABLE 0x46010
#define DPLL1_ENABLE 0x46014
--
2.30.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 23+ messages in thread* [Intel-gfx] [PATCH 2/3] drm/i915: Remove dead code from skl_pipe_wm_get_hw_state() 2021-02-12 18:21 [Intel-gfx] [PATCH 1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping José Roberto de Souza @ 2021-02-12 18:22 ` José Roberto de Souza 2021-02-12 18:33 ` Ville Syrjälä 2021-02-12 18:22 ` [Intel-gfx] [PATCH 3/3] drm/i915: Fix plane watermark mismatches José Roberto de Souza ` (7 subsequent siblings) 8 siblings, 1 reply; 23+ messages in thread From: José Roberto de Souza @ 2021-02-12 18:22 UTC (permalink / raw) To: intel-gfx There is nothing else to be executed after this if block. Signed-off-by: José Roberto de Souza <jose.souza@intel.com> --- drivers/gpu/drm/i915/intel_pm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 8c42fa51c0f6..8cc67f9c4e58 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -6182,9 +6182,6 @@ void skl_pipe_wm_get_hw_state(struct intel_crtc *crtc, skl_wm_level_from_reg_val(val, &wm->trans_wm); } - - if (!crtc->active) - return; } void skl_wm_get_hw_state(struct drm_i915_private *dev_priv) -- 2.30.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] [PATCH 2/3] drm/i915: Remove dead code from skl_pipe_wm_get_hw_state() 2021-02-12 18:22 ` [Intel-gfx] [PATCH 2/3] drm/i915: Remove dead code from skl_pipe_wm_get_hw_state() José Roberto de Souza @ 2021-02-12 18:33 ` Ville Syrjälä 0 siblings, 0 replies; 23+ messages in thread From: Ville Syrjälä @ 2021-02-12 18:33 UTC (permalink / raw) To: José Roberto de Souza; +Cc: intel-gfx On Fri, Feb 12, 2021 at 10:22:00AM -0800, José Roberto de Souza wrote: > There is nothing else to be executed after this if block. > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> Looks like leftovers I forgot to clean up. Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_pm.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index 8c42fa51c0f6..8cc67f9c4e58 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -6182,9 +6182,6 @@ void skl_pipe_wm_get_hw_state(struct intel_crtc *crtc, > > skl_wm_level_from_reg_val(val, &wm->trans_wm); > } > - > - if (!crtc->active) > - return; > } > > void skl_wm_get_hw_state(struct drm_i915_private *dev_priv) > -- > 2.30.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 23+ messages in thread
* [Intel-gfx] [PATCH 3/3] drm/i915: Fix plane watermark mismatches 2021-02-12 18:21 [Intel-gfx] [PATCH 1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping José Roberto de Souza 2021-02-12 18:22 ` [Intel-gfx] [PATCH 2/3] drm/i915: Remove dead code from skl_pipe_wm_get_hw_state() José Roberto de Souza @ 2021-02-12 18:22 ` José Roberto de Souza 2021-02-12 18:35 ` Ville Syrjälä 2021-02-12 18:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping Patchwork ` (6 subsequent siblings) 8 siblings, 1 reply; 23+ messages in thread From: José Roberto de Souza @ 2021-02-12 18:22 UTC (permalink / raw) To: intel-gfx Found a system were firmware/BIOS left the plane_res_b and plane_res_l set with non-zero values for disable planes. As the planes are disabled i915 will not even try to sanitize it so here returning earlier if both skl_wm_levels being compared are disabled, if that is true no need to check the other fields as HW will ignore it. Signed-off-by: José Roberto de Souza <jose.souza@intel.com> --- drivers/gpu/drm/i915/intel_pm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 8cc67f9c4e58..c630dc10c34b 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -5633,6 +5633,8 @@ void skl_write_cursor_wm(struct intel_plane *plane, bool skl_wm_level_equals(const struct skl_wm_level *l1, const struct skl_wm_level *l2) { + if (l1->plane_en == false && l2->plane_en == false) + return true; return l1->plane_en == l2->plane_en && l1->ignore_lines == l2->ignore_lines && l1->plane_res_l == l2->plane_res_l && -- 2.30.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix plane watermark mismatches 2021-02-12 18:22 ` [Intel-gfx] [PATCH 3/3] drm/i915: Fix plane watermark mismatches José Roberto de Souza @ 2021-02-12 18:35 ` Ville Syrjälä 2021-02-12 19:44 ` Souza, Jose 0 siblings, 1 reply; 23+ messages in thread From: Ville Syrjälä @ 2021-02-12 18:35 UTC (permalink / raw) To: José Roberto de Souza; +Cc: intel-gfx On Fri, Feb 12, 2021 at 10:22:01AM -0800, José Roberto de Souza wrote: > Found a system were firmware/BIOS left the plane_res_b and plane_res_l > set with non-zero values for disable planes. It pretty much happens always since the reset value is not zero. IIRC we made the state chcker pedantic enough to complain about that, so we need to clean it up. > As the planes are disabled i915 will not even try to sanitize it so > here returning earlier if both skl_wm_levels being compared are > disabled, if that is true no need to check the other fields as HW > will ignore it. > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> > --- > drivers/gpu/drm/i915/intel_pm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index 8cc67f9c4e58..c630dc10c34b 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -5633,6 +5633,8 @@ void skl_write_cursor_wm(struct intel_plane *plane, > bool skl_wm_level_equals(const struct skl_wm_level *l1, > const struct skl_wm_level *l2) > { > + if (l1->plane_en == false && l2->plane_en == false) > + return true; > return l1->plane_en == l2->plane_en && > l1->ignore_lines == l2->ignore_lines && > l1->plane_res_l == l2->plane_res_l && > -- > 2.30.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix plane watermark mismatches 2021-02-12 18:35 ` Ville Syrjälä @ 2021-02-12 19:44 ` Souza, Jose 2021-02-12 21:13 ` Ville Syrjälä 0 siblings, 1 reply; 23+ messages in thread From: Souza, Jose @ 2021-02-12 19:44 UTC (permalink / raw) To: ville.syrjala@linux.intel.com; +Cc: intel-gfx@lists.freedesktop.org On Fri, 2021-02-12 at 20:35 +0200, Ville Syrjälä wrote: > On Fri, Feb 12, 2021 at 10:22:01AM -0800, José Roberto de Souza wrote: > > Found a system were firmware/BIOS left the plane_res_b and plane_res_l > > set with non-zero values for disable planes. > > It pretty much happens always since the reset value is not zero. > IIRC we made the state chcker pedantic enough to complain about > that, so we need to clean it up. Are you planning to fix it soon? If not I can do it but will need a couple more of hints of what you thinking to do. We will need this fixed soon otherwise this system will block CI testing in this platform. > > > As the planes are disabled i915 will not even try to sanitize it so > > here returning earlier if both skl_wm_levels being compared are > > disabled, if that is true no need to check the other fields as HW > > will ignore it. > > > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> > > --- > > drivers/gpu/drm/i915/intel_pm.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > > index 8cc67f9c4e58..c630dc10c34b 100644 > > --- a/drivers/gpu/drm/i915/intel_pm.c > > +++ b/drivers/gpu/drm/i915/intel_pm.c > > @@ -5633,6 +5633,8 @@ void skl_write_cursor_wm(struct intel_plane *plane, > > bool skl_wm_level_equals(const struct skl_wm_level *l1, > > const struct skl_wm_level *l2) > > { > > + if (l1->plane_en == false && l2->plane_en == false) > > + return true; > > return l1->plane_en == l2->plane_en && > > l1->ignore_lines == l2->ignore_lines && > > l1->plane_res_l == l2->plane_res_l && > > -- > > 2.30.1 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix plane watermark mismatches 2021-02-12 19:44 ` Souza, Jose @ 2021-02-12 21:13 ` Ville Syrjälä 2021-02-17 17:24 ` Souza, Jose 0 siblings, 1 reply; 23+ messages in thread From: Ville Syrjälä @ 2021-02-12 21:13 UTC (permalink / raw) To: Souza, Jose; +Cc: intel-gfx@lists.freedesktop.org On Fri, Feb 12, 2021 at 07:44:22PM +0000, Souza, Jose wrote: > On Fri, 2021-02-12 at 20:35 +0200, Ville Syrjälä wrote: > > On Fri, Feb 12, 2021 at 10:22:01AM -0800, José Roberto de Souza wrote: > > > Found a system were firmware/BIOS left the plane_res_b and plane_res_l > > > set with non-zero values for disable planes. > > > > It pretty much happens always since the reset value is not zero. > > IIRC we made the state chcker pedantic enough to complain about > > that, so we need to clean it up. > > Are you planning to fix it soon? Fix what exactly? I guess you're seeing an actual problem of some sort? > If not I can do it but will need a couple more of hints of what you > thinking to do. > > We will need this fixed soon otherwise this system will block CI > testing in this platform. > > > > > > As the planes are disabled i915 will not even try to sanitize it so > > > here returning earlier if both skl_wm_levels being compared are > > > disabled, if that is true no need to check the other fields as HW > > > will ignore it. > > > > > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> > > > --- > > > drivers/gpu/drm/i915/intel_pm.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > > > index 8cc67f9c4e58..c630dc10c34b 100644 > > > --- a/drivers/gpu/drm/i915/intel_pm.c > > > +++ b/drivers/gpu/drm/i915/intel_pm.c > > > @@ -5633,6 +5633,8 @@ void skl_write_cursor_wm(struct intel_plane *plane, > > > bool skl_wm_level_equals(const struct skl_wm_level *l1, > > > const struct skl_wm_level *l2) > > > { > > > + if (l1->plane_en == false && l2->plane_en == false) > > > + return true; > > > return l1->plane_en == l2->plane_en && > > > l1->ignore_lines == l2->ignore_lines && > > > l1->plane_res_l == l2->plane_res_l && > > > -- > > > 2.30.1 > > > > > > _______________________________________________ > > > Intel-gfx mailing list > > > Intel-gfx@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix plane watermark mismatches 2021-02-12 21:13 ` Ville Syrjälä @ 2021-02-17 17:24 ` Souza, Jose 2021-02-17 22:14 ` Ville Syrjälä 0 siblings, 1 reply; 23+ messages in thread From: Souza, Jose @ 2021-02-17 17:24 UTC (permalink / raw) To: ville.syrjala@linux.intel.com; +Cc: intel-gfx@lists.freedesktop.org On Fri, 2021-02-12 at 23:13 +0200, Ville Syrjälä wrote: > On Fri, Feb 12, 2021 at 07:44:22PM +0000, Souza, Jose wrote: > > On Fri, 2021-02-12 at 20:35 +0200, Ville Syrjälä wrote: > > > On Fri, Feb 12, 2021 at 10:22:01AM -0800, José Roberto de Souza wrote: > > > > Found a system were firmware/BIOS left the plane_res_b and plane_res_l > > > > set with non-zero values for disable planes. > > > > > > It pretty much happens always since the reset value is not zero. > > > IIRC we made the state chcker pedantic enough to complain about > > > that, so we need to clean it up. > > > > Are you planning to fix it soon? > > Fix what exactly? I guess you're seeing an actual problem of some sort? Your comment above made me understand that you were planning to fix this plane watermark mismatches for disabled planes in other way other than what this patch does. Or should we proceed with this solution? > > > If not I can do it but will need a couple more of hints of what you > > thinking to do. > > > > We will need this fixed soon otherwise this system will block CI > > testing in this platform. > > > > > > > > > As the planes are disabled i915 will not even try to sanitize it so > > > > here returning earlier if both skl_wm_levels being compared are > > > > disabled, if that is true no need to check the other fields as HW > > > > will ignore it. > > > > > > > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> > > > > --- > > > > drivers/gpu/drm/i915/intel_pm.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > > > > index 8cc67f9c4e58..c630dc10c34b 100644 > > > > --- a/drivers/gpu/drm/i915/intel_pm.c > > > > +++ b/drivers/gpu/drm/i915/intel_pm.c > > > > @@ -5633,6 +5633,8 @@ void skl_write_cursor_wm(struct intel_plane *plane, > > > > bool skl_wm_level_equals(const struct skl_wm_level *l1, > > > > const struct skl_wm_level *l2) > > > > { > > > > + if (l1->plane_en == false && l2->plane_en == false) > > > > + return true; > > > > return l1->plane_en == l2->plane_en && > > > > l1->ignore_lines == l2->ignore_lines && > > > > l1->plane_res_l == l2->plane_res_l && > > > > -- > > > > 2.30.1 > > > > > > > > _______________________________________________ > > > > Intel-gfx mailing list > > > > Intel-gfx@lists.freedesktop.org > > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > > > > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix plane watermark mismatches 2021-02-17 17:24 ` Souza, Jose @ 2021-02-17 22:14 ` Ville Syrjälä 2021-02-18 17:25 ` Souza, Jose 0 siblings, 1 reply; 23+ messages in thread From: Ville Syrjälä @ 2021-02-17 22:14 UTC (permalink / raw) To: Souza, Jose; +Cc: intel-gfx@lists.freedesktop.org On Wed, Feb 17, 2021 at 05:24:03PM +0000, Souza, Jose wrote: > On Fri, 2021-02-12 at 23:13 +0200, Ville Syrjälä wrote: > > On Fri, Feb 12, 2021 at 07:44:22PM +0000, Souza, Jose wrote: > > > On Fri, 2021-02-12 at 20:35 +0200, Ville Syrjälä wrote: > > > > On Fri, Feb 12, 2021 at 10:22:01AM -0800, José Roberto de Souza wrote: > > > > > Found a system were firmware/BIOS left the plane_res_b and plane_res_l > > > > > set with non-zero values for disable planes. > > > > > > > > It pretty much happens always since the reset value is not zero. > > > > IIRC we made the state chcker pedantic enough to complain about > > > > that, so we need to clean it up. > > > > > > Are you planning to fix it soon? > > > > Fix what exactly? I guess you're seeing an actual problem of some sort? > > Your comment above made me understand that you were planning to fix this plane watermark mismatches for disabled planes in other way other than what > this patch does. > Or should we proceed with this solution? There should be no mismatches with the current scheme. We explicitly program wms to 0 for disabled planes. -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix plane watermark mismatches 2021-02-17 22:14 ` Ville Syrjälä @ 2021-02-18 17:25 ` Souza, Jose 2021-02-18 18:21 ` Ville Syrjälä 0 siblings, 1 reply; 23+ messages in thread From: Souza, Jose @ 2021-02-18 17:25 UTC (permalink / raw) To: ville.syrjala@linux.intel.com; +Cc: intel-gfx@lists.freedesktop.org On Thu, 2021-02-18 at 00:14 +0200, Ville Syrjälä wrote: > On Wed, Feb 17, 2021 at 05:24:03PM +0000, Souza, Jose wrote: > > On Fri, 2021-02-12 at 23:13 +0200, Ville Syrjälä wrote: > > > On Fri, Feb 12, 2021 at 07:44:22PM +0000, Souza, Jose wrote: > > > > On Fri, 2021-02-12 at 20:35 +0200, Ville Syrjälä wrote: > > > > > On Fri, Feb 12, 2021 at 10:22:01AM -0800, José Roberto de Souza wrote: > > > > > > Found a system were firmware/BIOS left the plane_res_b and plane_res_l > > > > > > set with non-zero values for disable planes. > > > > > > > > > > It pretty much happens always since the reset value is not zero. > > > > > IIRC we made the state chcker pedantic enough to complain about > > > > > that, so we need to clean it up. > > > > > > > > Are you planning to fix it soon? > > > > > > Fix what exactly? I guess you're seeing an actual problem of some sort? > > > > Your comment above made me understand that you were planning to fix this plane watermark mismatches for disabled planes in other way other than what > > this patch does. > > Or should we proceed with this solution? > > There should be no mismatches with the current scheme. > We explicitly program wms to 0 for disabled planes. > It still happens when we take over the state that BIOS/firmware left. [ 118.222939] [drm:drm_atomic_commit] committing 00000000676e6290 [ 118.241712] i915 0000:00:02.0: [drm:intel_panel_actually_set_backlight [i915]] set backlight PWM = 96000 [ 118.242314] i915 0000:00:02.0: [drm:__intel_fbc_disable [i915]] Disabling FBC on pipe A [ 118.242726] i915 0000:00:02.0: [drm:intel_fbc_enable [i915]] reserved 16588800 bytes of contiguous stolen space for FBC, threshold: 1 [ 118.243020] i915 0000:00:02.0: [drm:intel_fbc_enable [i915]] Enabling FBC on pipe A [ 118.257685] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 2 level 0 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257698] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 2 level 1 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257706] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 2 level 2 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257714] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 2 level 3 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257721] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 2 level 4 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257729] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 2 level 5 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257737] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 2 level 6 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257745] i915 0000:00:02.0: [drm] *ERROR* mismatch in trans WM pipe A plane 2 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257753] i915 0000:00:02.0: [drm] *ERROR* mismatch in SAGV trans WM pipe A plane 2 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257761] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 3 level 0 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257769] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 3 level 1 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257776] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 3 level 2 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257784] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 3 level 3 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257792] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 3 level 4 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257800] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 3 level 5 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257807] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 3 level 6 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257815] i915 0000:00:02.0: [drm] *ERROR* mismatch in trans WM pipe A plane 3 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257823] i915 0000:00:02.0: [drm] *ERROR* mismatch in SAGV trans WM pipe A plane 3 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257920] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 4 level 0 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257929] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 4 level 1 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257939] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 4 level 2 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257949] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 4 level 3 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257956] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 4 level 4 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257965] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 4 level 5 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257975] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 4 level 6 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257984] i915 0000:00:02.0: [drm] *ERROR* mismatch in trans WM pipe A plane 4 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.257993] i915 0000:00:02.0: [drm] *ERROR* mismatch in SAGV trans WM pipe A plane 4 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.258002] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 5 level 0 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.258011] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 5 level 1 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.258020] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 5 level 2 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.258029] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 5 level 3 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.258037] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 5 level 4 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.258046] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 5 level 5 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.258054] i915 0000:00:02.0: [drm] *ERROR* mismatch in WM pipe A plane 5 level 6 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.258063] i915 0000:00:02.0: [drm] *ERROR* mismatch in trans WM pipe A plane 5 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.258073] i915 0000:00:02.0: [drm] *ERROR* mismatch in SAGV trans WM pipe A plane 5 (expected e=0 b=0 l=0, got e=0 b=7 l=1) [ 118.258494] i915 0000:00:02.0: [drm:verify_connector_state [i915]] [CONNECTOR:381:eDP-1] [ 118.259022] i915 0000:00:02.0: [drm:intel_atomic_commit_tail [i915]] [CRTC:116:pipe A] [ 118.259811] i915 0000:00:02.0: [drm:intel_ddi_read_func_ctl [i915]] [ENCODER:380:DDI B/PHY B] Fec status: 0 [ 118.260284] i915 0000:00:02.0: [drm:verify_single_dpll_state [i915]] DPLL 0 Other option would be to call intel_plane_disable_noatomic() even for non-visible planes: diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 6014c643a89d..20b3844c8875 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -15882,11 +15882,7 @@ static void intel_sanitize_crtc(struct intel_crtc *crtc, /* Disable everything but the primary plane */ for_each_intel_plane_on_crtc(dev, crtc, plane) { - const struct intel_plane_state *plane_state = - to_intel_plane_state(plane->base.state); - - if (plane_state->uapi.visible && - plane->base.type != DRM_PLANE_TYPE_PRIMARY) + if (plane->base.type != DRM_PLANE_TYPE_PRIMARY) intel_plane_disable_noatomic(crtc, plane); } What do you think? _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix plane watermark mismatches 2021-02-18 17:25 ` Souza, Jose @ 2021-02-18 18:21 ` Ville Syrjälä 2021-02-19 19:35 ` Souza, Jose 0 siblings, 1 reply; 23+ messages in thread From: Ville Syrjälä @ 2021-02-18 18:21 UTC (permalink / raw) To: Souza, Jose; +Cc: intel-gfx@lists.freedesktop.org On Thu, Feb 18, 2021 at 05:25:54PM +0000, Souza, Jose wrote: > On Thu, 2021-02-18 at 00:14 +0200, Ville Syrjälä wrote: > > On Wed, Feb 17, 2021 at 05:24:03PM +0000, Souza, Jose wrote: > > > On Fri, 2021-02-12 at 23:13 +0200, Ville Syrjälä wrote: > > > > On Fri, Feb 12, 2021 at 07:44:22PM +0000, Souza, Jose wrote: > > > > > On Fri, 2021-02-12 at 20:35 +0200, Ville Syrjälä wrote: > > > > > > On Fri, Feb 12, 2021 at 10:22:01AM -0800, José Roberto de Souza wrote: > > > > > > > Found a system were firmware/BIOS left the plane_res_b and plane_res_l > > > > > > > set with non-zero values for disable planes. > > > > > > > > > > > > It pretty much happens always since the reset value is not zero. > > > > > > IIRC we made the state chcker pedantic enough to complain about > > > > > > that, so we need to clean it up. > > > > > > > > > > Are you planning to fix it soon? > > > > > > > > Fix what exactly? I guess you're seeing an actual problem of some sort? > > > > > > Your comment above made me understand that you were planning to fix this plane watermark mismatches for disabled planes in other way other than what > > > this patch does. > > > Or should we proceed with this solution? > > > > There should be no mismatches with the current scheme. > > We explicitly program wms to 0 for disabled planes. > > > > It still happens when we take over the state that BIOS/firmware left. That would seem to imply skl_wm_add_affected_planes() isn't working right for some reason. -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix plane watermark mismatches 2021-02-18 18:21 ` Ville Syrjälä @ 2021-02-19 19:35 ` Souza, Jose 0 siblings, 0 replies; 23+ messages in thread From: Souza, Jose @ 2021-02-19 19:35 UTC (permalink / raw) To: ville.syrjala@linux.intel.com; +Cc: intel-gfx@lists.freedesktop.org On Thu, 2021-02-18 at 20:21 +0200, Ville Syrjälä wrote: > On Thu, Feb 18, 2021 at 05:25:54PM +0000, Souza, Jose wrote: > > On Thu, 2021-02-18 at 00:14 +0200, Ville Syrjälä wrote: > > > On Wed, Feb 17, 2021 at 05:24:03PM +0000, Souza, Jose wrote: > > > > On Fri, 2021-02-12 at 23:13 +0200, Ville Syrjälä wrote: > > > > > On Fri, Feb 12, 2021 at 07:44:22PM +0000, Souza, Jose wrote: > > > > > > On Fri, 2021-02-12 at 20:35 +0200, Ville Syrjälä wrote: > > > > > > > On Fri, Feb 12, 2021 at 10:22:01AM -0800, José Roberto de Souza wrote: > > > > > > > > Found a system were firmware/BIOS left the plane_res_b and plane_res_l > > > > > > > > set with non-zero values for disable planes. > > > > > > > > > > > > > > It pretty much happens always since the reset value is not zero. > > > > > > > IIRC we made the state chcker pedantic enough to complain about > > > > > > > that, so we need to clean it up. > > > > > > > > > > > > Are you planning to fix it soon? > > > > > > > > > > Fix what exactly? I guess you're seeing an actual problem of some sort? > > > > > > > > Your comment above made me understand that you were planning to fix this plane watermark mismatches for disabled planes in other way other than what > > > > this patch does. > > > > Or should we proceed with this solution? > > > > > > There should be no mismatches with the current scheme. > > > We explicitly program wms to 0 for disabled planes. > > > > > > > It still happens when we take over the state that BIOS/firmware left. > > That would seem to imply skl_wm_add_affected_planes() isn't working > right for some reason. > Reading out watermark state during initial readout fixed it: drm/i915/display: Read planes watermarks during initial state readout _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 23+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping 2021-02-12 18:21 [Intel-gfx] [PATCH 1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping José Roberto de Souza 2021-02-12 18:22 ` [Intel-gfx] [PATCH 2/3] drm/i915: Remove dead code from skl_pipe_wm_get_hw_state() José Roberto de Souza 2021-02-12 18:22 ` [Intel-gfx] [PATCH 3/3] drm/i915: Fix plane watermark mismatches José Roberto de Souza @ 2021-02-12 18:29 ` Patchwork 2021-02-12 18:30 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork ` (5 subsequent siblings) 8 siblings, 0 replies; 23+ messages in thread From: Patchwork @ 2021-02-12 18:29 UTC (permalink / raw) To: José Roberto de Souza; +Cc: intel-gfx == Series Details == Series: series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping URL : https://patchwork.freedesktop.org/series/87048/ State : warning == Summary == $ dim checkpatch origin/drm-tip cc5ee23b6a3e drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping 6766f32463c4 drm/i915: Remove dead code from skl_pipe_wm_get_hw_state() a6c0f3b65b64 drm/i915: Fix plane watermark mismatches -:26: CHECK:BOOL_COMPARISON: Using comparison to false is error prone #26: FILE: drivers/gpu/drm/i915/intel_pm.c:5636: + if (l1->plane_en == false && l2->plane_en == false) total: 0 errors, 0 warnings, 1 checks, 8 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 23+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping 2021-02-12 18:21 [Intel-gfx] [PATCH 1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping José Roberto de Souza ` (2 preceding siblings ...) 2021-02-12 18:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping Patchwork @ 2021-02-12 18:30 ` Patchwork 2021-02-12 18:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork ` (4 subsequent siblings) 8 siblings, 0 replies; 23+ messages in thread From: Patchwork @ 2021-02-12 18:30 UTC (permalink / raw) To: José Roberto de Souza; +Cc: intel-gfx == Series Details == Series: series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping URL : https://patchwork.freedesktop.org/series/87048/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/gt/intel_reset.c:1323:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block +drivers/gpu/drm/i915/gvt/mmio.c:295:23: warning: memcpy with byte count of 279040 +drivers/gpu/drm/i915/i915_perf.c:1437:15: warning: memset with byte count of 16777216 +drivers/gpu/drm/i915/i915_perf.c:1491:15: warning: memset with byte count of 16777216 +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 23+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping 2021-02-12 18:21 [Intel-gfx] [PATCH 1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping José Roberto de Souza ` (3 preceding siblings ...) 2021-02-12 18:30 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork @ 2021-02-12 18:59 ` Patchwork 2021-02-12 19:15 ` [Intel-gfx] [PATCH 1/3] " Aditya Swarup ` (3 subsequent siblings) 8 siblings, 0 replies; 23+ messages in thread From: Patchwork @ 2021-02-12 18:59 UTC (permalink / raw) To: José Roberto de Souza; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 3452 bytes --] == Series Details == Series: series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping URL : https://patchwork.freedesktop.org/series/87048/ State : success == Summary == CI Bug Log - changes from CI_DRM_9771 -> Patchwork_19672 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/index.html Known issues ------------ Here are the changes found in Patchwork_19672 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_basic@cs-compute: - fi-tgl-y: NOTRUN -> [SKIP][1] ([fdo#109315] / [i915#2575]) +4 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/fi-tgl-y/igt@amdgpu/amd_basic@cs-compute.html * igt@amdgpu/amd_basic@userptr: - fi-byt-j1900: NOTRUN -> [SKIP][2] ([fdo#109271]) +17 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/fi-byt-j1900/igt@amdgpu/amd_basic@userptr.html * igt@prime_vgem@basic-read: - fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#402]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/fi-tgl-y/igt@prime_vgem@basic-read.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/fi-tgl-y/igt@prime_vgem@basic-read.html #### Possible fixes #### * igt@i915_pm_rpm@module-reload: - fi-byt-j1900: [INCOMPLETE][5] ([i915#142] / [i915#2405]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html * igt@prime_self_import@basic-with_one_bo_two_files: - fi-tgl-y: [DMESG-WARN][7] ([i915#402]) -> [PASS][8] +2 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [i915#142]: https://gitlab.freedesktop.org/drm/intel/issues/142 [i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 Participating hosts (45 -> 40) ------------------------------ Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus Build changes ------------- * Linux: CI_DRM_9771 -> Patchwork_19672 CI-20190529: 20190529 CI_DRM_9771: 1b095889c6780e40f6161bfb824b5e944fd69547 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6003: 627cc5353535d61fa33c5f7ff7e64f154c84f10a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_19672: a6c0f3b65b649c2ce7910c3384ce168faa3bfd16 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == a6c0f3b65b64 drm/i915: Fix plane watermark mismatches 6766f32463c4 drm/i915: Remove dead code from skl_pipe_wm_get_hw_state() cc5ee23b6a3e drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/index.html [-- Attachment #1.2: Type: text/html, Size: 4246 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping 2021-02-12 18:21 [Intel-gfx] [PATCH 1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping José Roberto de Souza ` (4 preceding siblings ...) 2021-02-12 18:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2021-02-12 19:15 ` Aditya Swarup 2021-02-12 19:20 ` Ville Syrjälä ` (2 subsequent siblings) 8 siblings, 0 replies; 23+ messages in thread From: Aditya Swarup @ 2021-02-12 19:15 UTC (permalink / raw) To: José Roberto de Souza, intel-gfx; +Cc: Lucas De Marchi On 2/12/21 10:21 AM, José Roberto de Souza wrote: > The cfgcr0/1_clk_off mapping is wrong for adl-s what could cause > the wrong clock being disabled and leaving a not needed clock > running consuming more power than needed. > > Bspec: 50287 > Bspec: 53812 > Bspec: 53723 > Fixes: d6d2bc996e45 ("drm/i915/adl_s: Configure Port clock registers for ADL-S") > Cc: Aditya Swarup <aditya.swarup@intel.com> > Cc: Lucas De Marchi <lucas.demarchi@intel.com> > Cc: Matt Roper <matthew.d.roper@intel.com> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> Changes look correct to me based on the table from Bspec: 53723 and is required. Mistake on my part on missing those changes. Reviewed-by: Aditya Swarup <aditya.swarup@intel.com> > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 4 +++- > drivers/gpu/drm/i915/i915_reg.h | 12 ++++++++++++ > 2 files changed, 15 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c > index 2d6906f6995f..7631e080349d 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -1585,7 +1585,9 @@ hsw_set_signal_levels(struct intel_dp *intel_dp, > static u32 icl_dpclka_cfgcr0_clk_off(struct drm_i915_private *dev_priv, > enum phy phy) > { > - if (IS_ROCKETLAKE(dev_priv)) { > + if (IS_ALDERLAKE_S(dev_priv)) { > + return ADLS_DPCLKA_CFGCR_DDI_CLK_OFF(phy); > + } else if (IS_ROCKETLAKE(dev_priv)) { > return RKL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy); > } else if (intel_phy_is_combo(dev_priv, phy)) { > return ICL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy); > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index 224ad897af34..7c69b50ccc5c 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -10416,6 +10416,18 @@ enum skl_power_gate { > ADLS_DPCLKA_DDIJ_SEL_MASK, \ > ADLS_DPCLKA_DDIK_SEL_MASK) > > +#define _ADLS_DPCLKA_DDIA_CLK_OFF REG_BIT(10) > +#define _ADLS_DPCLKA_DDIB_CLK_OFF REG_BIT(11) > +#define _ADLS_DPCLKA_DDII_CLK_OFF REG_BIT(24) > +#define _ADLS_DPCLKA_DDIJ_CLK_OFF REG_BIT(4) > +#define _ADLS_DPCLKA_DDIK_CLK_OFF REG_BIT(5) > +#define ADLS_DPCLKA_CFGCR_DDI_CLK_OFF(phy) _PICK((phy), \ > + _ADLS_DPCLKA_DDIA_CLK_OFF, \ > + _ADLS_DPCLKA_DDIB_CLK_OFF, \ > + _ADLS_DPCLKA_DDII_CLK_OFF, \ > + _ADLS_DPCLKA_DDIJ_CLK_OFF, \ > + _ADLS_DPCLKA_DDIK_CLK_OFF) > + > /* CNL PLL */ > #define DPLL0_ENABLE 0x46010 > #define DPLL1_ENABLE 0x46014 > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping 2021-02-12 18:21 [Intel-gfx] [PATCH 1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping José Roberto de Souza ` (5 preceding siblings ...) 2021-02-12 19:15 ` [Intel-gfx] [PATCH 1/3] " Aditya Swarup @ 2021-02-12 19:20 ` Ville Syrjälä 2021-02-12 19:42 ` Souza, Jose 2021-02-12 20:15 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] " Patchwork 2021-02-18 20:06 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping (rev2) Patchwork 8 siblings, 1 reply; 23+ messages in thread From: Ville Syrjälä @ 2021-02-12 19:20 UTC (permalink / raw) To: José Roberto de Souza; +Cc: intel-gfx, Lucas De Marchi On Fri, Feb 12, 2021 at 10:21:59AM -0800, José Roberto de Souza wrote: > The cfgcr0/1_clk_off mapping is wrong for adl-s what could cause > the wrong clock being disabled and leaving a not needed clock > running consuming more power than needed. > > Bspec: 50287 > Bspec: 53812 > Bspec: 53723 > Fixes: d6d2bc996e45 ("drm/i915/adl_s: Configure Port clock registers for ADL-S") > Cc: Aditya Swarup <aditya.swarup@intel.com> > Cc: Lucas De Marchi <lucas.demarchi@intel.com> > Cc: Matt Roper <matthew.d.roper@intel.com> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 4 +++- > drivers/gpu/drm/i915/i915_reg.h | 12 ++++++++++++ > 2 files changed, 15 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c > index 2d6906f6995f..7631e080349d 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -1585,7 +1585,9 @@ hsw_set_signal_levels(struct intel_dp *intel_dp, > static u32 icl_dpclka_cfgcr0_clk_off(struct drm_i915_private *dev_priv, > enum phy phy) > { > - if (IS_ROCKETLAKE(dev_priv)) { > + if (IS_ALDERLAKE_S(dev_priv)) { > + return ADLS_DPCLKA_CFGCR_DDI_CLK_OFF(phy); > + } else if (IS_ROCKETLAKE(dev_priv)) { > return RKL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy); > } else if (intel_phy_is_combo(dev_priv, phy)) { > return ICL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy); > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > index 224ad897af34..7c69b50ccc5c 100644 > --- a/drivers/gpu/drm/i915/i915_reg.h > +++ b/drivers/gpu/drm/i915/i915_reg.h > @@ -10416,6 +10416,18 @@ enum skl_power_gate { > ADLS_DPCLKA_DDIJ_SEL_MASK, \ > ADLS_DPCLKA_DDIK_SEL_MASK) > > +#define _ADLS_DPCLKA_DDIA_CLK_OFF REG_BIT(10) > +#define _ADLS_DPCLKA_DDIB_CLK_OFF REG_BIT(11) > +#define _ADLS_DPCLKA_DDII_CLK_OFF REG_BIT(24) > +#define _ADLS_DPCLKA_DDIJ_CLK_OFF REG_BIT(4) > +#define _ADLS_DPCLKA_DDIK_CLK_OFF REG_BIT(5) So shose are apparently split between the two registers. Why aren't we defining these so that it would be obvious which register they live in? This stuff is confusing enough with the hw folks churning the bits around randomly on every platform, so I don't think we should add to the confusion by obfuscating the bit defines. I do like that you named the bits, which isn't case for the other platforms. Would be nice to fix it all up actually. Hmm. However, this new defintion seem to match ICL_DPCLKA_CFGCR0_DDI_CLK_OFF() 100%. So how can this be fixing something? Also ICL for sure can't have that many combo PHYs can it? We should nuke the extra stuff from the ICL defintion if it's no longer used. > +#define ADLS_DPCLKA_CFGCR_DDI_CLK_OFF(phy) _PICK((phy), \ > + _ADLS_DPCLKA_DDIA_CLK_OFF, \ > + _ADLS_DPCLKA_DDIB_CLK_OFF, \ > + _ADLS_DPCLKA_DDII_CLK_OFF, \ > + _ADLS_DPCLKA_DDIJ_CLK_OFF, \ > + _ADLS_DPCLKA_DDIK_CLK_OFF) > + > /* CNL PLL */ > #define DPLL0_ENABLE 0x46010 > #define DPLL1_ENABLE 0x46014 > -- > 2.30.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping 2021-02-12 19:20 ` Ville Syrjälä @ 2021-02-12 19:42 ` Souza, Jose 2021-02-12 21:17 ` Ville Syrjälä 0 siblings, 1 reply; 23+ messages in thread From: Souza, Jose @ 2021-02-12 19:42 UTC (permalink / raw) To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org, De Marchi, Lucas On Fri, 2021-02-12 at 21:20 +0200, Ville Syrjälä wrote: > On Fri, Feb 12, 2021 at 10:21:59AM -0800, José Roberto de Souza wrote: > > The cfgcr0/1_clk_off mapping is wrong for adl-s what could cause > > the wrong clock being disabled and leaving a not needed clock > > running consuming more power than needed. > > > > Bspec: 50287 > > Bspec: 53812 > > Bspec: 53723 > > Fixes: d6d2bc996e45 ("drm/i915/adl_s: Configure Port clock registers for ADL-S") > > Cc: Aditya Swarup <aditya.swarup@intel.com> > > Cc: Lucas De Marchi <lucas.demarchi@intel.com> > > Cc: Matt Roper <matthew.d.roper@intel.com> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_ddi.c | 4 +++- > > drivers/gpu/drm/i915/i915_reg.h | 12 ++++++++++++ > > 2 files changed, 15 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c > > index 2d6906f6995f..7631e080349d 100644 > > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > > @@ -1585,7 +1585,9 @@ hsw_set_signal_levels(struct intel_dp *intel_dp, > > static u32 icl_dpclka_cfgcr0_clk_off(struct drm_i915_private *dev_priv, > > enum phy phy) > > { > > - if (IS_ROCKETLAKE(dev_priv)) { > > + if (IS_ALDERLAKE_S(dev_priv)) { > > + return ADLS_DPCLKA_CFGCR_DDI_CLK_OFF(phy); > > + } else if (IS_ROCKETLAKE(dev_priv)) { > > return RKL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy); > > } else if (intel_phy_is_combo(dev_priv, phy)) { > > return ICL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy); > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > > index 224ad897af34..7c69b50ccc5c 100644 > > --- a/drivers/gpu/drm/i915/i915_reg.h > > +++ b/drivers/gpu/drm/i915/i915_reg.h > > @@ -10416,6 +10416,18 @@ enum skl_power_gate { > > ADLS_DPCLKA_DDIJ_SEL_MASK, \ > > ADLS_DPCLKA_DDIK_SEL_MASK) > > > > > > +#define _ADLS_DPCLKA_DDIA_CLK_OFF REG_BIT(10) > > +#define _ADLS_DPCLKA_DDIB_CLK_OFF REG_BIT(11) > > +#define _ADLS_DPCLKA_DDII_CLK_OFF REG_BIT(24) > > +#define _ADLS_DPCLKA_DDIJ_CLK_OFF REG_BIT(4) > > +#define _ADLS_DPCLKA_DDIK_CLK_OFF REG_BIT(5) > > So shose are apparently split between the two registers. Why aren't > we defining these so that it would be obvious which register they > live in? This stuff is confusing enough with the hw folks churning > the bits around randomly on every platform, so I don't think we > should add to the confusion by obfuscating the bit defines. I do > like that you named the bits, which isn't case for the other > platforms. Would be nice to fix it all up actually. > > Hmm. However, this new defintion seem to match > ICL_DPCLKA_CFGCR0_DDI_CLK_OFF() 100%. So how can this be fixing > something? Also ICL for sure can't have that many combo PHYs can > it? We should nuke the extra stuff from the ICL defintion if it's > no longer used. Good catch & my bad. Was fixing it for other platform and tought that it might be broken for ADL-S too but as all ports are combo ports ICL_DPCLKA_CFGCR0_DDI_CLK_OFF will do the right job. Dropping this patch. > > > +#define ADLS_DPCLKA_CFGCR_DDI_CLK_OFF(phy) _PICK((phy), \ > > + _ADLS_DPCLKA_DDIA_CLK_OFF, \ > > + _ADLS_DPCLKA_DDIB_CLK_OFF, \ > > + _ADLS_DPCLKA_DDII_CLK_OFF, \ > > + _ADLS_DPCLKA_DDIJ_CLK_OFF, \ > > + _ADLS_DPCLKA_DDIK_CLK_OFF) > > + > > /* CNL PLL */ > > #define DPLL0_ENABLE 0x46010 > > #define DPLL1_ENABLE 0x46014 > > -- > > 2.30.1 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping 2021-02-12 19:42 ` Souza, Jose @ 2021-02-12 21:17 ` Ville Syrjälä 2021-02-17 17:25 ` Souza, Jose 0 siblings, 1 reply; 23+ messages in thread From: Ville Syrjälä @ 2021-02-12 21:17 UTC (permalink / raw) To: Souza, Jose; +Cc: intel-gfx@lists.freedesktop.org, De Marchi, Lucas On Fri, Feb 12, 2021 at 07:42:17PM +0000, Souza, Jose wrote: > On Fri, 2021-02-12 at 21:20 +0200, Ville Syrjälä wrote: > > On Fri, Feb 12, 2021 at 10:21:59AM -0800, José Roberto de Souza wrote: > > > The cfgcr0/1_clk_off mapping is wrong for adl-s what could cause > > > the wrong clock being disabled and leaving a not needed clock > > > running consuming more power than needed. > > > > > > Bspec: 50287 > > > Bspec: 53812 > > > Bspec: 53723 > > > Fixes: d6d2bc996e45 ("drm/i915/adl_s: Configure Port clock registers for ADL-S") > > > Cc: Aditya Swarup <aditya.swarup@intel.com> > > > Cc: Lucas De Marchi <lucas.demarchi@intel.com> > > > Cc: Matt Roper <matthew.d.roper@intel.com> > > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> > > > --- > > > drivers/gpu/drm/i915/display/intel_ddi.c | 4 +++- > > > drivers/gpu/drm/i915/i915_reg.h | 12 ++++++++++++ > > > 2 files changed, 15 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c > > > index 2d6906f6995f..7631e080349d 100644 > > > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > > > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > > > @@ -1585,7 +1585,9 @@ hsw_set_signal_levels(struct intel_dp *intel_dp, > > > static u32 icl_dpclka_cfgcr0_clk_off(struct drm_i915_private *dev_priv, > > > enum phy phy) > > > { > > > - if (IS_ROCKETLAKE(dev_priv)) { > > > + if (IS_ALDERLAKE_S(dev_priv)) { > > > + return ADLS_DPCLKA_CFGCR_DDI_CLK_OFF(phy); > > > + } else if (IS_ROCKETLAKE(dev_priv)) { > > > return RKL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy); > > > } else if (intel_phy_is_combo(dev_priv, phy)) { > > > return ICL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy); > > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > > > index 224ad897af34..7c69b50ccc5c 100644 > > > --- a/drivers/gpu/drm/i915/i915_reg.h > > > +++ b/drivers/gpu/drm/i915/i915_reg.h > > > @@ -10416,6 +10416,18 @@ enum skl_power_gate { > > > ADLS_DPCLKA_DDIJ_SEL_MASK, \ > > > ADLS_DPCLKA_DDIK_SEL_MASK) > > > > > > > > > +#define _ADLS_DPCLKA_DDIA_CLK_OFF REG_BIT(10) > > > +#define _ADLS_DPCLKA_DDIB_CLK_OFF REG_BIT(11) > > > +#define _ADLS_DPCLKA_DDII_CLK_OFF REG_BIT(24) > > > +#define _ADLS_DPCLKA_DDIJ_CLK_OFF REG_BIT(4) > > > +#define _ADLS_DPCLKA_DDIK_CLK_OFF REG_BIT(5) > > > > So shose are apparently split between the two registers. Why aren't > > we defining these so that it would be obvious which register they > > live in? This stuff is confusing enough with the hw folks churning > > the bits around randomly on every platform, so I don't think we > > should add to the confusion by obfuscating the bit defines. I do > > like that you named the bits, which isn't case for the other > > platforms. Would be nice to fix it all up actually. > > > > Hmm. However, this new defintion seem to match > > ICL_DPCLKA_CFGCR0_DDI_CLK_OFF() 100%. So how can this be fixing > > something? Also ICL for sure can't have that many combo PHYs can > > it? We should nuke the extra stuff from the ICL defintion if it's > > no longer used. > > Good catch & my bad. > Was fixing it for other platform and tought that it might be broken > for ADL-S too but as all ports are combo ports > ICL_DPCLKA_CFGCR0_DDI_CLK_OFF will do the right job. > > Dropping this patch. I wouldn't mind having this patch, or rather a patch to clean up/clarify all the DPCLKA_CFGCR bits on every platform. As it stands cross checking against the spec is a bit tedious. But at least right now I don't have to rebase my DDI clock routing series [1] :) That one still has a few trivial patches looking for review btw *wink* *nudge*. [1] https://patchwork.freedesktop.org/series/86544/ -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] [PATCH 1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping 2021-02-12 21:17 ` Ville Syrjälä @ 2021-02-17 17:25 ` Souza, Jose 0 siblings, 0 replies; 23+ messages in thread From: Souza, Jose @ 2021-02-17 17:25 UTC (permalink / raw) To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org, De Marchi, Lucas On Fri, 2021-02-12 at 23:17 +0200, Ville Syrjälä wrote: > On Fri, Feb 12, 2021 at 07:42:17PM +0000, Souza, Jose wrote: > > On Fri, 2021-02-12 at 21:20 +0200, Ville Syrjälä wrote: > > > On Fri, Feb 12, 2021 at 10:21:59AM -0800, José Roberto de Souza wrote: > > > > The cfgcr0/1_clk_off mapping is wrong for adl-s what could cause > > > > the wrong clock being disabled and leaving a not needed clock > > > > running consuming more power than needed. > > > > > > > > Bspec: 50287 > > > > Bspec: 53812 > > > > Bspec: 53723 > > > > Fixes: d6d2bc996e45 ("drm/i915/adl_s: Configure Port clock registers for ADL-S") > > > > Cc: Aditya Swarup <aditya.swarup@intel.com> > > > > Cc: Lucas De Marchi <lucas.demarchi@intel.com> > > > > Cc: Matt Roper <matthew.d.roper@intel.com> > > > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com> > > > > --- > > > > drivers/gpu/drm/i915/display/intel_ddi.c | 4 +++- > > > > drivers/gpu/drm/i915/i915_reg.h | 12 ++++++++++++ > > > > 2 files changed, 15 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c > > > > index 2d6906f6995f..7631e080349d 100644 > > > > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > > > > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > > > > @@ -1585,7 +1585,9 @@ hsw_set_signal_levels(struct intel_dp *intel_dp, > > > > static u32 icl_dpclka_cfgcr0_clk_off(struct drm_i915_private *dev_priv, > > > > enum phy phy) > > > > { > > > > - if (IS_ROCKETLAKE(dev_priv)) { > > > > + if (IS_ALDERLAKE_S(dev_priv)) { > > > > + return ADLS_DPCLKA_CFGCR_DDI_CLK_OFF(phy); > > > > + } else if (IS_ROCKETLAKE(dev_priv)) { > > > > return RKL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy); > > > > } else if (intel_phy_is_combo(dev_priv, phy)) { > > > > return ICL_DPCLKA_CFGCR0_DDI_CLK_OFF(phy); > > > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h > > > > index 224ad897af34..7c69b50ccc5c 100644 > > > > --- a/drivers/gpu/drm/i915/i915_reg.h > > > > +++ b/drivers/gpu/drm/i915/i915_reg.h > > > > @@ -10416,6 +10416,18 @@ enum skl_power_gate { > > > > ADLS_DPCLKA_DDIJ_SEL_MASK, \ > > > > ADLS_DPCLKA_DDIK_SEL_MASK) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > +#define _ADLS_DPCLKA_DDIA_CLK_OFF REG_BIT(10) > > > > +#define _ADLS_DPCLKA_DDIB_CLK_OFF REG_BIT(11) > > > > +#define _ADLS_DPCLKA_DDII_CLK_OFF REG_BIT(24) > > > > +#define _ADLS_DPCLKA_DDIJ_CLK_OFF REG_BIT(4) > > > > +#define _ADLS_DPCLKA_DDIK_CLK_OFF REG_BIT(5) > > > > > > So shose are apparently split between the two registers. Why aren't > > > we defining these so that it would be obvious which register they > > > live in? This stuff is confusing enough with the hw folks churning > > > the bits around randomly on every platform, so I don't think we > > > should add to the confusion by obfuscating the bit defines. I do > > > like that you named the bits, which isn't case for the other > > > platforms. Would be nice to fix it all up actually. > > > > > > Hmm. However, this new defintion seem to match > > > ICL_DPCLKA_CFGCR0_DDI_CLK_OFF() 100%. So how can this be fixing > > > something? Also ICL for sure can't have that many combo PHYs can > > > it? We should nuke the extra stuff from the ICL defintion if it's > > > no longer used. > > > > Good catch & my bad. > > Was fixing it for other platform and tought that it might be broken > > for ADL-S too but as all ports are combo ports > > ICL_DPCLKA_CFGCR0_DDI_CLK_OFF will do the right job. > > > > Dropping this patch. > > I wouldn't mind having this patch, or rather a patch to clean up/clarify > all the DPCLKA_CFGCR bits on every platform. As it stands cross checking > against the spec is a bit tedious. Okay, will try to do something better around here. > > But at least right now I don't have to rebase my DDI clock routing > series [1] :) That one still has a few trivial patches looking for review > btw *wink* *nudge*. Lucas already did =] Let me know if you have anything else pending that is not huge. > > [1] https://patchwork.freedesktop.org/series/86544/ > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 23+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping 2021-02-12 18:21 [Intel-gfx] [PATCH 1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping José Roberto de Souza ` (6 preceding siblings ...) 2021-02-12 19:20 ` Ville Syrjälä @ 2021-02-12 20:15 ` Patchwork 2021-02-17 17:32 ` Souza, Jose 2021-02-18 20:06 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping (rev2) Patchwork 8 siblings, 1 reply; 23+ messages in thread From: Patchwork @ 2021-02-12 20:15 UTC (permalink / raw) To: Souza, Jose; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 30307 bytes --] == Series Details == Series: series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping URL : https://patchwork.freedesktop.org/series/87048/ State : success == Summary == CI Bug Log - changes from CI_DRM_9771_full -> Patchwork_19672_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_19672_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_persistence@close-replace-race: - shard-glk: [PASS][1] -> [TIMEOUT][2] ([i915#2918]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-glk4/igt@gem_ctx_persistence@close-replace-race.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-glk9/igt@gem_ctx_persistence@close-replace-race.html * igt@gem_exec_fair@basic-none-rrul@rcs0: - shard-glk: [PASS][3] -> [FAIL][4] ([i915#2842]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-glk5/igt@gem_exec_fair@basic-none-rrul@rcs0.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-glk1/igt@gem_exec_fair@basic-none-rrul@rcs0.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-tglb: [PASS][5] -> [FAIL][6] ([i915#2842]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb3/igt@gem_exec_fair@basic-none-share@rcs0.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-iclb: [PASS][7] -> [FAIL][8] ([i915#2842]) +2 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb7/igt@gem_exec_fair@basic-pace-solo@rcs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb5/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_exec_fair@basic-pace@vcs1: - shard-kbl: [PASS][9] -> [FAIL][10] ([i915#2842]) +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-kbl2/igt@gem_exec_fair@basic-pace@vcs1.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html * igt@gem_exec_params@secure-non-master: - shard-tglb: NOTRUN -> [SKIP][11] ([fdo#112283]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@gem_exec_params@secure-non-master.html * igt@gem_exec_schedule@u-fairslice@vcs0: - shard-iclb: [PASS][12] -> [DMESG-WARN][13] ([i915#2803]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb6/igt@gem_exec_schedule@u-fairslice@vcs0.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb4/igt@gem_exec_schedule@u-fairslice@vcs0.html * igt@gem_exec_suspend@basic-s3: - shard-kbl: [PASS][14] -> [DMESG-WARN][15] ([i915#180]) +3 similar issues [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-kbl4/igt@gem_exec_suspend@basic-s3.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-kbl7/igt@gem_exec_suspend@basic-s3.html * igt@gem_exec_whisper@basic-queues-forked: - shard-glk: [PASS][16] -> [DMESG-WARN][17] ([i915#118] / [i915#95]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-glk7/igt@gem_exec_whisper@basic-queues-forked.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-glk3/igt@gem_exec_whisper@basic-queues-forked.html * igt@gen9_exec_parse@secure-batches: - shard-tglb: NOTRUN -> [SKIP][18] ([fdo#112306]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@gen9_exec_parse@secure-batches.html * igt@kms_async_flips@alternate-sync-async-flip: - shard-kbl: [PASS][19] -> [FAIL][20] ([i915#2521]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-kbl3/igt@kms_async_flips@alternate-sync-async-flip.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-kbl2/igt@kms_async_flips@alternate-sync-async-flip.html * igt@kms_big_fb@yf-tiled-8bpp-rotate-0: - shard-tglb: NOTRUN -> [SKIP][21] ([fdo#111615]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@kms_big_fb@yf-tiled-8bpp-rotate-0.html * igt@kms_ccs@pipe-c-crc-primary-rotation-180: - shard-skl: NOTRUN -> [SKIP][22] ([fdo#109271] / [fdo#111304]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl8/igt@kms_ccs@pipe-c-crc-primary-rotation-180.html * igt@kms_chamelium@hdmi-hpd-storm: - shard-kbl: NOTRUN -> [SKIP][23] ([fdo#109271] / [fdo#111827]) +3 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-kbl2/igt@kms_chamelium@hdmi-hpd-storm.html * igt@kms_color_chamelium@pipe-a-ctm-green-to-red: - shard-apl: NOTRUN -> [SKIP][24] ([fdo#109271] / [fdo#111827]) +2 similar issues [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl4/igt@kms_color_chamelium@pipe-a-ctm-green-to-red.html - shard-tglb: NOTRUN -> [SKIP][25] ([fdo#109284] / [fdo#111827]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@kms_color_chamelium@pipe-a-ctm-green-to-red.html * igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes: - shard-skl: NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +6 similar issues [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl9/igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes.html * igt@kms_content_protection@legacy: - shard-kbl: NOTRUN -> [TIMEOUT][27] ([i915#1319]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-kbl2/igt@kms_content_protection@legacy.html - shard-tglb: NOTRUN -> [SKIP][28] ([fdo#111828]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@kms_content_protection@legacy.html - shard-apl: NOTRUN -> [TIMEOUT][29] ([i915#1319]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl4/igt@kms_content_protection@legacy.html * igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding: - shard-skl: [PASS][30] -> [FAIL][31] ([i915#54]) +4 similar issues [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl2/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl8/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html * igt@kms_cursor_crc@pipe-c-cursor-512x512-random: - shard-tglb: NOTRUN -> [SKIP][32] ([fdo#109279]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@kms_cursor_crc@pipe-c-cursor-512x512-random.html * igt@kms_cursor_crc@pipe-d-cursor-128x42-sliding: - shard-kbl: NOTRUN -> [SKIP][33] ([fdo#109271]) +40 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-kbl2/igt@kms_cursor_crc@pipe-d-cursor-128x42-sliding.html * igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic: - shard-skl: NOTRUN -> [FAIL][34] ([i915#2346]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html * igt@kms_flip@2x-flip-vs-panning: - shard-apl: NOTRUN -> [SKIP][35] ([fdo#109271]) +24 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl4/igt@kms_flip@2x-flip-vs-panning.html * igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset-interruptible: - shard-tglb: NOTRUN -> [SKIP][36] ([fdo#111825]) +2 similar issues [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset-interruptible.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1: - shard-skl: NOTRUN -> [FAIL][37] ([i915#79]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html * igt@kms_flip@flip-vs-expired-vblank@a-edp1: - shard-tglb: [PASS][38] -> [FAIL][39] ([i915#2598]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb5/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb5/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-apl: NOTRUN -> [DMESG-WARN][40] ([i915#180]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs: - shard-apl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#2672]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl1/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt: - shard-skl: NOTRUN -> [SKIP][42] ([fdo#109271]) +58 similar issues [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - shard-skl: [PASS][43] -> [INCOMPLETE][44] ([i915#198]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html - shard-apl: [PASS][45] -> [DMESG-WARN][46] ([i915#180]) +1 similar issue [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max: - shard-apl: NOTRUN -> [FAIL][47] ([fdo#108145] / [i915#265]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl4/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html - shard-kbl: NOTRUN -> [FAIL][48] ([fdo#108145] / [i915#265]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-kbl2/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html - shard-skl: NOTRUN -> [FAIL][49] ([fdo#108145] / [i915#265]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4: - shard-apl: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#658]) +1 similar issue [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl4/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html - shard-skl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#658]) +1 similar issue [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl4/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html - shard-tglb: NOTRUN -> [SKIP][52] ([i915#2920]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5: - shard-kbl: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#658]) +1 similar issue [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-kbl2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [PASS][54] -> [SKIP][55] ([fdo#109441]) +2 similar issues [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb8/igt@kms_psr@psr2_sprite_plane_move.html * igt@perf@polling-parameterized: - shard-glk: [PASS][56] -> [FAIL][57] ([i915#1542]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-glk1/igt@perf@polling-parameterized.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-glk7/igt@perf@polling-parameterized.html * igt@sysfs_clients@recycle: - shard-glk: [PASS][58] -> [FAIL][59] ([i915#3028]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-glk5/igt@sysfs_clients@recycle.html [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-glk7/igt@sysfs_clients@recycle.html #### Possible fixes #### * igt@gem_ctx_isolation@preservation-s3@bcs0: - shard-skl: [INCOMPLETE][60] ([i915#198]) -> [PASS][61] +1 similar issue [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl1/igt@gem_ctx_isolation@preservation-s3@bcs0.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl8/igt@gem_ctx_isolation@preservation-s3@bcs0.html * igt@gem_eio@unwedge-stress: - shard-tglb: [TIMEOUT][62] ([i915#1037] / [i915#3063]) -> [PASS][63] [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb7/igt@gem_eio@unwedge-stress.html [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb2/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-flow@rcs0: - shard-tglb: [FAIL][64] ([i915#2842]) -> [PASS][65] [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb5/igt@gem_exec_fair@basic-flow@rcs0.html [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb6/igt@gem_exec_fair@basic-flow@rcs0.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-glk: [FAIL][66] ([i915#2842]) -> [PASS][67] +1 similar issue [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-glk2/igt@gem_exec_fair@basic-pace@vcs0.html [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-glk6/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-iclb: [FAIL][68] ([i915#2849]) -> [PASS][69] [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_exec_reloc@basic-many-active@rcs0: - shard-apl: [FAIL][70] ([i915#2389]) -> [PASS][71] [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl1/igt@gem_exec_reloc@basic-many-active@rcs0.html [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl4/igt@gem_exec_reloc@basic-many-active@rcs0.html - shard-glk: [FAIL][72] ([i915#2389]) -> [PASS][73] [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-glk4/igt@gem_exec_reloc@basic-many-active@rcs0.html [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-glk3/igt@gem_exec_reloc@basic-many-active@rcs0.html * igt@gem_exec_schedule@u-fairslice@rcs0: - shard-skl: [DMESG-WARN][74] ([i915#1610] / [i915#2803]) -> [PASS][75] [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl4/igt@gem_exec_schedule@u-fairslice@rcs0.html [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl4/igt@gem_exec_schedule@u-fairslice@rcs0.html * igt@gem_exec_schedule@u-fairslice@vcs0: - shard-apl: [DMESG-WARN][76] ([i915#1610]) -> [PASS][77] [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl1/igt@gem_exec_schedule@u-fairslice@vcs0.html [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl4/igt@gem_exec_schedule@u-fairslice@vcs0.html * igt@gem_exec_schedule@u-fairslice@vecs0: - shard-tglb: [DMESG-WARN][78] ([i915#2803]) -> [PASS][79] [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb3/igt@gem_exec_schedule@u-fairslice@vecs0.html [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@gem_exec_schedule@u-fairslice@vecs0.html * igt@i915_pm_rc6_residency@rc6-fence: - shard-hsw: [WARN][80] ([i915#1519]) -> [PASS][81] [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-hsw1/igt@i915_pm_rc6_residency@rc6-fence.html [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-hsw6/igt@i915_pm_rc6_residency@rc6-fence.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-apl: [DMESG-WARN][82] ([i915#180]) -> [PASS][83] +2 similar issues [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl7/igt@i915_suspend@fence-restore-tiled2untiled.html * igt@kms_async_flips@alternate-sync-async-flip: - shard-skl: [FAIL][84] ([i915#2521]) -> [PASS][85] [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl3/igt@kms_async_flips@alternate-sync-async-flip.html [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl7/igt@kms_async_flips@alternate-sync-async-flip.html * igt@kms_cursor_crc@pipe-b-cursor-128x128-random: - shard-skl: [FAIL][86] ([i915#54]) -> [PASS][87] +8 similar issues [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl2/igt@kms_cursor_crc@pipe-b-cursor-128x128-random.html [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-128x128-random.html * igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy: - shard-skl: [FAIL][88] ([i915#2346]) -> [PASS][89] [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html * igt@kms_hdr@bpc-switch-suspend: - shard-skl: [FAIL][90] ([i915#1188]) -> [PASS][91] +1 similar issue [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl8/igt@kms_hdr@bpc-switch-suspend.html [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl6/igt@kms_hdr@bpc-switch-suspend.html * igt@kms_psr@psr2_primary_page_flip: - shard-iclb: [SKIP][92] ([fdo#109441]) -> [PASS][93] +2 similar issues [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb1/igt@kms_psr@psr2_primary_page_flip.html [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-apl: [DMESG-WARN][94] ([i915#180] / [i915#295]) -> [PASS][95] [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@kms_vblank@pipe-b-accuracy-idle: - shard-skl: [DMESG-WARN][96] ([i915#1982]) -> [PASS][97] [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl4/igt@kms_vblank@pipe-b-accuracy-idle.html [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl1/igt@kms_vblank@pipe-b-accuracy-idle.html * igt@kms_vblank@pipe-b-ts-continuation-suspend: - shard-kbl: [DMESG-WARN][98] ([i915#180]) -> [PASS][99] [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-kbl6/igt@kms_vblank@pipe-b-ts-continuation-suspend.html [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-kbl2/igt@kms_vblank@pipe-b-ts-continuation-suspend.html * igt@sysfs_clients@recycle: - shard-tglb: [FAIL][100] ([i915#3028]) -> [PASS][101] [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb2/igt@sysfs_clients@recycle.html [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@sysfs_clients@recycle.html * {igt@sysfs_clients@recycle-many}: - shard-iclb: [FAIL][102] ([i915#3028]) -> [PASS][103] [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb1/igt@sysfs_clients@recycle-many.html [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb3/igt@sysfs_clients@recycle-many.html - shard-hsw: [FAIL][104] ([i915#3028]) -> [PASS][105] [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-hsw8/igt@sysfs_clients@recycle-many.html [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-hsw8/igt@sysfs_clients@recycle-many.html #### Warnings #### * igt@gem_exec_balancer@hang: - shard-iclb: [INCOMPLETE][106] ([i915#1895] / [i915#2295] / [i915#3031]) -> [INCOMPLETE][107] ([i915#1895] / [i915#2295]) [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb4/igt@gem_exec_balancer@hang.html [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb4/igt@gem_exec_balancer@hang.html * igt@i915_pm_dc@dc3co-vpb-simulation: - shard-iclb: [SKIP][108] ([i915#588]) -> [SKIP][109] ([i915#658]) [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb1/igt@i915_pm_dc@dc3co-vpb-simulation.html * igt@i915_selftest@live@gt_pm: - shard-tglb: [DMESG-FAIL][110] ([i915#1759] / [i915#2291]) -> [DMESG-FAIL][111] ([i915#2291]) [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb2/igt@i915_selftest@live@gt_pm.html [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb1/igt@i915_selftest@live@gt_pm.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5: - shard-iclb: [SKIP][112] ([i915#2920]) -> [SKIP][113] ([i915#658]) +1 similar issue [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5.html [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3: - shard-iclb: [SKIP][114] ([i915#658]) -> [SKIP][115] ([i915#2920]) +2 similar issues [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html * igt@runner@aborted: - shard-iclb: ([FAIL][116], [FAIL][117], [FAIL][118]) ([i915#2295] / [i915#2724] / [i915#3002]) -> ([FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122]) ([i915#2295] / [i915#2426] / [i915#2724] / [i915#3002]) [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb6/igt@runner@aborted.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb5/igt@runner@aborted.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb3/igt@runner@aborted.html [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb1/igt@runner@aborted.html [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb3/igt@runner@aborted.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb7/igt@runner@aborted.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb4/igt@runner@aborted.html - shard-apl: ([FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130]) ([i915#1610] / [i915#1814] / [i915#2295] / [i915#2426] / [i915#3002]) -> ([FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136]) ([fdo#109271] / [i915#1814] / [i915#2295] / [i915#3002]) [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl1/igt@runner@aborted.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl6/igt@runner@aborted.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl8/igt@runner@aborted.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl3/igt@runner@aborted.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl3/igt@runner@aborted.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl4/igt@runner@aborted.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl6/igt@runner@aborted.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl2/igt@runner@aborted.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl7/igt@runner@aborted.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl6/igt@runner@aborted.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl6/igt@runner@aborted.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl7/igt@runner@aborted.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl2/igt@runner@aborted.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl6/igt@runner@aborted.html - shard-tglb: ([FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140]) ([i915#1764] / [i915#2295] / [i915#2426] / [i915#2667] / [i915#2803] / [i915#3002]) -> ([FAIL][141], [FAIL][142], [FAIL][143]) ([i915#2295] / [i915#2667] / [i915#3002]) [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb8/igt@runner@aborted.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb8/igt@runner@aborted.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb3/igt@runner@aborted.html [140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb1/igt@runner@aborted.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb1/igt@runner@aborted.html [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb6/igt@runner@aborted.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb5/igt@runner@aborted.html - shard-skl: ([FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148]) ([i915#1814] / [i915#2029] / [i915#2295] / [i915#2426] / [i915#3002]) -> ([FAIL][149], [FAIL][150], [FAIL][151]) ([i915#2295] / [i915#3002]) [144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl4/igt@runner@aborted.html [145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl4/igt@runner@aborted.html [146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl5/igt@runner@aborted.html [147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl5/igt@runner@aborted.html [148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl4/igt@runner@aborted.html [149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl1/igt@runner@aborted.html [150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl2/igt@runner@aborted.html [151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl9/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#111304]: https://bugs.freedesktop.org/show_bug.cgi?id=111304 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [fdo#111828]: https://bugs.freedesktop.org/show_bug.cgi?id=111828 [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283 [fdo#112306]: https://bugs.freedesktop.org/show_bug.cgi?id=112306 [i915#1037]: https://gitlab.freedesktop.org/drm/intel/issues/1037 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319 [i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519 [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542 [i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610 [i915#1759]: https://gitlab.freedesktop.org/drm/intel/issues/1759 [i915#1764]: https://gitlab.freedesktop.org/drm/intel/issues/1764 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814 [i915#1895]: https://gitlab.freedesktop.org/drm/intel/issues/1895 [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029 [i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291 [i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389 [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426 [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521 [i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#2667]: https://gitlab.freedesktop.org/drm/i == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/index.html [-- Attachment #1.2: Type: text/html, Size: 36191 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping 2021-02-12 20:15 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] " Patchwork @ 2021-02-17 17:32 ` Souza, Jose 0 siblings, 0 replies; 23+ messages in thread From: Souza, Jose @ 2021-02-17 17:32 UTC (permalink / raw) To: intel-gfx@lists.freedesktop.org [-- Attachment #1.1: Type: text/plain, Size: 29858 bytes --] On Fri, 2021-02-12 at 20:15 +0000, Patchwork wrote: Patch Details Series: series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping URL: https://patchwork.freedesktop.org/series/87048/ State: success Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/index.html CI Bug Log - changes from CI_DRM_9771_full -> Patchwork_19672_full Summary SUCCESS No regressions found. Patch 2 pushed. Thanks for the review Ville. Known issues Here are the changes found in Patchwork_19672_full that come from known issues: IGT changes Issues hit * igt@gem_ctx_persistence@close-replace-race: * shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-glk4/igt@gem_ctx_persistence@close-replace-race.html> -> TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-glk9/igt@gem_ctx_persistence@close-replace-race.html> ([i915#2918]) * igt@gem_exec_fair@basic-none-rrul@rcs0: * shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-glk5/igt@gem_exec_fair@basic-none-rrul@rcs0.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-glk1/igt@gem_exec_fair@basic-none-rrul@rcs0.html> ([i915#2842]) +1 similar issue * igt@gem_exec_fair@basic-none-share@rcs0: * shard-tglb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb3/igt@gem_exec_fair@basic-none-share@rcs0.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@gem_exec_fair@basic-none-share@rcs0.html> ([i915#2842]) * igt@gem_exec_fair@basic-pace-solo@rcs0: * shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb7/igt@gem_exec_fair@basic-pace-solo@rcs0.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb5/igt@gem_exec_fair@basic-pace-solo@rcs0.html> ([i915#2842]) +2 similar issues * igt@gem_exec_fair@basic-pace@vcs1: * shard-kbl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-kbl2/igt@gem_exec_fair@basic-pace@vcs1.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html> ([i915#2842]) +1 similar issue * igt@gem_exec_params@secure-non-master: * shard-tglb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@gem_exec_params@secure-non-master.html> (fdo#112283<https://bugs.freedesktop.org/show_bug.cgi?id=112283>) * igt@gem_exec_schedule@u-fairslice@vcs0: * shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb6/igt@gem_exec_schedule@u-fairslice@vcs0.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb4/igt@gem_exec_schedule@u-fairslice@vcs0.html> ([i915#2803]) * igt@gem_exec_suspend@basic-s3: * shard-kbl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-kbl4/igt@gem_exec_suspend@basic-s3.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-kbl7/igt@gem_exec_suspend@basic-s3.html> (i915#180<https://gitlab.freedesktop.org/drm/intel/issues/180>) +3 similar issues * igt@gem_exec_whisper@basic-queues-forked: * shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-glk7/igt@gem_exec_whisper@basic-queues-forked.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-glk3/igt@gem_exec_whisper@basic-queues-forked.html> (i915#118<https://gitlab.freedesktop.org/drm/intel/issues/118> / [i915#95]) * igt@gen9_exec_parse@secure-batches: * shard-tglb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@gen9_exec_parse@secure-batches.html> (fdo#112306<https://bugs.freedesktop.org/show_bug.cgi?id=112306>) * igt@kms_async_flips@alternate-sync-async-flip: * shard-kbl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-kbl3/igt@kms_async_flips@alternate-sync-async-flip.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-kbl2/igt@kms_async_flips@alternate-sync-async-flip.html> (i915#2521<https://gitlab.freedesktop.org/drm/intel/issues/2521>) * igt@kms_big_fb@yf-tiled-8bpp-rotate-0: * shard-tglb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@kms_big_fb@yf-tiled-8bpp-rotate-0.html> (fdo#111615<https://bugs.freedesktop.org/show_bug.cgi?id=111615>) * igt@kms_ccs@pipe-c-crc-primary-rotation-180: * shard-skl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl8/igt@kms_ccs@pipe-c-crc-primary-rotation-180.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111304<https://bugs.freedesktop.org/show_bug.cgi?id=111304>) * igt@kms_chamelium@hdmi-hpd-storm: * shard-kbl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-kbl2/igt@kms_chamelium@hdmi-hpd-storm.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +3 similar issues * igt@kms_color_chamelium@pipe-a-ctm-green-to-red: * shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl4/igt@kms_color_chamelium@pipe-a-ctm-green-to-red.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +2 similar issues * shard-tglb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@kms_color_chamelium@pipe-a-ctm-green-to-red.html> (fdo#109284<https://bugs.freedesktop.org/show_bug.cgi?id=109284> / fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>) * igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes: * shard-skl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl9/igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / fdo#111827<https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +6 similar issues * igt@kms_content_protection@legacy: * shard-kbl: NOTRUN -> TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-kbl2/igt@kms_content_protection@legacy.html> (i915#1319<https://gitlab.freedesktop.org/drm/intel/issues/1319>) * shard-tglb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@kms_content_protection@legacy.html> (fdo#111828<https://bugs.freedesktop.org/show_bug.cgi?id=111828>) * shard-apl: NOTRUN -> TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl4/igt@kms_content_protection@legacy.html> (i915#1319<https://gitlab.freedesktop.org/drm/intel/issues/1319>) * igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding: * shard-skl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl2/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl8/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html> ([i915#54]) +4 similar issues * igt@kms_cursor_crc@pipe-c-cursor-512x512-random: * shard-tglb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@kms_cursor_crc@pipe-c-cursor-512x512-random.html> (fdo#109279<https://bugs.freedesktop.org/show_bug.cgi?id=109279>) * igt@kms_cursor_crc@pipe-d-cursor-128x42-sliding: * shard-kbl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-kbl2/igt@kms_cursor_crc@pipe-d-cursor-128x42-sliding.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +40 similar issues * igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic: * shard-skl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html> (i915#2346<https://gitlab.freedesktop.org/drm/intel/issues/2346>) * igt@kms_flip@2x-flip-vs-panning: * shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl4/igt@kms_flip@2x-flip-vs-panning.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +24 similar issues * igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset-interruptible: * shard-tglb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset-interruptible.html> (fdo#111825<https://bugs.freedesktop.org/show_bug.cgi?id=111825>) +2 similar issues * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1: * shard-skl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html> ([i915#79]) * igt@kms_flip@flip-vs-expired-vblank@a-edp1: * shard-tglb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb5/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb5/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html> (i915#2598<https://gitlab.freedesktop.org/drm/intel/issues/2598>) * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: * shard-apl: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html> (i915#180<https://gitlab.freedesktop.org/drm/intel/issues/180>) * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs: * shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl1/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / [i915#2672]) * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt: * shard-skl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +58 similar issues * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: * shard-skl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html> (i915#198<https://gitlab.freedesktop.org/drm/intel/issues/198>) * shard-apl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html> (i915#180<https://gitlab.freedesktop.org/drm/intel/issues/180>) +1 similar issue * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max: * shard-apl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl4/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html> (fdo#108145<https://bugs.freedesktop.org/show_bug.cgi?id=108145> / i915#265<https://gitlab.freedesktop.org/drm/intel/issues/265>) * shard-kbl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-kbl2/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html> (fdo#108145<https://bugs.freedesktop.org/show_bug.cgi?id=108145> / i915#265<https://gitlab.freedesktop.org/drm/intel/issues/265>) * shard-skl: NOTRUN -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html> (fdo#108145<https://bugs.freedesktop.org/show_bug.cgi?id=108145> / i915#265<https://gitlab.freedesktop.org/drm/intel/issues/265>) * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4: * shard-apl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl4/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / [i915#658]) +1 similar issue * shard-skl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl4/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / [i915#658]) +1 similar issue * shard-tglb: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4.html> ([i915#2920]) * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5: * shard-kbl: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-kbl2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html> (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / [i915#658]) +1 similar issue * igt@kms_psr@psr2_sprite_plane_move: * shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb8/igt@kms_psr@psr2_sprite_plane_move.html> (fdo#109441<https://bugs.freedesktop.org/show_bug.cgi?id=109441>) +2 similar issues * igt@perf@polling-parameterized: * shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-glk1/igt@perf@polling-parameterized.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-glk7/igt@perf@polling-parameterized.html> (i915#1542<https://gitlab.freedesktop.org/drm/intel/issues/1542>) * igt@sysfs_clients@recycle: * shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-glk5/igt@sysfs_clients@recycle.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-glk7/igt@sysfs_clients@recycle.html> ([i915#3028]) Possible fixes * igt@gem_ctx_isolation@preservation-s3@bcs0: * shard-skl: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl1/igt@gem_ctx_isolation@preservation-s3@bcs0.html> (i915#198<https://gitlab.freedesktop.org/drm/intel/issues/198>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl8/igt@gem_ctx_isolation@preservation-s3@bcs0.html> +1 similar issue * igt@gem_eio@unwedge-stress: * shard-tglb: TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb7/igt@gem_eio@unwedge-stress.html> (i915#1037<https://gitlab.freedesktop.org/drm/intel/issues/1037> / [i915#3063]) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb2/igt@gem_eio@unwedge-stress.html> * igt@gem_exec_fair@basic-flow@rcs0: * shard-tglb: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb5/igt@gem_exec_fair@basic-flow@rcs0.html> ([i915#2842]) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb6/igt@gem_exec_fair@basic-flow@rcs0.html> * igt@gem_exec_fair@basic-pace@vcs0: * shard-glk: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-glk2/igt@gem_exec_fair@basic-pace@vcs0.html> ([i915#2842]) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-glk6/igt@gem_exec_fair@basic-pace@vcs0.html> +1 similar issue * igt@gem_exec_fair@basic-throttle@rcs0: * shard-iclb: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html> ([i915#2849]) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html> * igt@gem_exec_reloc@basic-many-active@rcs0: * shard-apl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl1/igt@gem_exec_reloc@basic-many-active@rcs0.html> (i915#2389<https://gitlab.freedesktop.org/drm/intel/issues/2389>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl4/igt@gem_exec_reloc@basic-many-active@rcs0.html> * shard-glk: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-glk4/igt@gem_exec_reloc@basic-many-active@rcs0.html> (i915#2389<https://gitlab.freedesktop.org/drm/intel/issues/2389>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-glk3/igt@gem_exec_reloc@basic-many-active@rcs0.html> * igt@gem_exec_schedule@u-fairslice@rcs0: * shard-skl: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl4/igt@gem_exec_schedule@u-fairslice@rcs0.html> (i915#1610<https://gitlab.freedesktop.org/drm/intel/issues/1610> / [i915#2803]) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl4/igt@gem_exec_schedule@u-fairslice@rcs0.html> * igt@gem_exec_schedule@u-fairslice@vcs0: * shard-apl: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl1/igt@gem_exec_schedule@u-fairslice@vcs0.html> (i915#1610<https://gitlab.freedesktop.org/drm/intel/issues/1610>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl4/igt@gem_exec_schedule@u-fairslice@vcs0.html> * igt@gem_exec_schedule@u-fairslice@vecs0: * shard-tglb: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb3/igt@gem_exec_schedule@u-fairslice@vecs0.html> ([i915#2803]) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@gem_exec_schedule@u-fairslice@vecs0.html> * igt@i915_pm_rc6_residency@rc6-fence: * shard-hsw: WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-hsw1/igt@i915_pm_rc6_residency@rc6-fence.html> (i915#1519<https://gitlab.freedesktop.org/drm/intel/issues/1519>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-hsw6/igt@i915_pm_rc6_residency@rc6-fence.html> * igt@i915_suspend@fence-restore-tiled2untiled: * shard-apl: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl4/igt@i915_suspend@fence-restore-tiled2untiled.html> (i915#180<https://gitlab.freedesktop.org/drm/intel/issues/180>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl7/igt@i915_suspend@fence-restore-tiled2untiled.html> +2 similar issues * igt@kms_async_flips@alternate-sync-async-flip: * shard-skl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl3/igt@kms_async_flips@alternate-sync-async-flip.html> (i915#2521<https://gitlab.freedesktop.org/drm/intel/issues/2521>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl7/igt@kms_async_flips@alternate-sync-async-flip.html> * igt@kms_cursor_crc@pipe-b-cursor-128x128-random: * shard-skl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl2/igt@kms_cursor_crc@pipe-b-cursor-128x128-random.html> ([i915#54]) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-128x128-random.html> +8 similar issues * igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy: * shard-skl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html> (i915#2346<https://gitlab.freedesktop.org/drm/intel/issues/2346>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html> * igt@kms_hdr@bpc-switch-suspend: * shard-skl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl8/igt@kms_hdr@bpc-switch-suspend.html> (i915#1188<https://gitlab.freedesktop.org/drm/intel/issues/1188>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl6/igt@kms_hdr@bpc-switch-suspend.html> +1 similar issue * igt@kms_psr@psr2_primary_page_flip: * shard-iclb: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb1/igt@kms_psr@psr2_primary_page_flip.html> (fdo#109441<https://bugs.freedesktop.org/show_bug.cgi?id=109441>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html> +2 similar issues * igt@kms_vblank@pipe-a-ts-continuation-suspend: * shard-apl: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html> (i915#180<https://gitlab.freedesktop.org/drm/intel/issues/180> / [i915#295]) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html> * igt@kms_vblank@pipe-b-accuracy-idle: * shard-skl: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl4/igt@kms_vblank@pipe-b-accuracy-idle.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl1/igt@kms_vblank@pipe-b-accuracy-idle.html> * igt@kms_vblank@pipe-b-ts-continuation-suspend: * shard-kbl: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-kbl6/igt@kms_vblank@pipe-b-ts-continuation-suspend.html> (i915#180<https://gitlab.freedesktop.org/drm/intel/issues/180>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-kbl2/igt@kms_vblank@pipe-b-ts-continuation-suspend.html> * igt@sysfs_clients@recycle: * shard-tglb: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb2/igt@sysfs_clients@recycle.html> ([i915#3028]) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb3/igt@sysfs_clients@recycle.html> * {igt@sysfs_clients@recycle-many}: * shard-iclb: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb1/igt@sysfs_clients@recycle-many.html> ([i915#3028]) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb3/igt@sysfs_clients@recycle-many.html> * shard-hsw: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-hsw8/igt@sysfs_clients@recycle-many.html> ([i915#3028]) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-hsw8/igt@sysfs_clients@recycle-many.html> Warnings * igt@gem_exec_balancer@hang: * shard-iclb: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb4/igt@gem_exec_balancer@hang.html> (i915#1895<https://gitlab.freedesktop.org/drm/intel/issues/1895> / i915#2295<https://gitlab.freedesktop.org/drm/intel/issues/2295> / [i915#3031]) -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb4/igt@gem_exec_balancer@hang.html> (i915#1895<https://gitlab.freedesktop.org/drm/intel/issues/1895> / i915#2295<https://gitlab.freedesktop.org/drm/intel/issues/2295>) * igt@i915_pm_dc@dc3co-vpb-simulation: * shard-iclb: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html> ([i915#588]) -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb1/igt@i915_pm_dc@dc3co-vpb-simulation.html> ([i915#658]) * igt@i915_selftest@live@gt_pm: * shard-tglb: DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb2/igt@i915_selftest@live@gt_pm.html> (i915#1759<https://gitlab.freedesktop.org/drm/intel/issues/1759> / i915#2291<https://gitlab.freedesktop.org/drm/intel/issues/2291>) -> DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb1/igt@i915_selftest@live@gt_pm.html> (i915#2291<https://gitlab.freedesktop.org/drm/intel/issues/2291>) * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5: * shard-iclb: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5.html> ([i915#2920]) -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5.html> ([i915#658]) +1 similar issue * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3: * shard-iclb: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html> ([i915#658]) -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html> ([i915#2920]) +2 similar issues * igt@runner@aborted: * shard-iclb: (FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb6/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb5/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-iclb3/igt@runner@aborted.html>) (i915#2295<https://gitlab.freedesktop.org/drm/intel/issues/2295> / [i915#2724] / [i915#3002]) -> (FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb1/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb3/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb7/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-iclb4/igt@runner@aborted.html>) (i915#2295<https://gitlab.freedesktop.org/drm/intel/issues/2295> / i915#2426<https://gitlab.freedesktop.org/drm/intel/issues/2426> / [i915#2724] / [i915#3002]) * shard-apl: (FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl1/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl6/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl8/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl3/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl3/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl4/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl6/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-apl2/igt@runner@aborted.html>) (i915#1610<https://gitlab.freedesktop.org/drm/intel/issues/1610> / i915#1814<https://gitlab.freedesktop.org/drm/intel/issues/1814> / i915#2295<https://gitlab.freedesktop.org/drm/intel/issues/2295> / i915#2426<https://gitlab.freedesktop.org/drm/intel/issues/2426> / [i915#3002]) -> (FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl7/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl6/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl6/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl7/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl2/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-apl6/igt@runner@aborted.html>) (fdo#109271<https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#1814<https://gitlab.freedesktop.org/drm/intel/issues/1814> / i915#2295<https://gitlab.freedesktop.org/drm/intel/issues/2295> / [i915#3002]) * shard-tglb: (FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb8/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb8/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb3/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-tglb1/igt@runner@aborted.html>) (i915#1764<https://gitlab.freedesktop.org/drm/intel/issues/1764> / i915#2295<https://gitlab.freedesktop.org/drm/intel/issues/2295> / i915#2426<https://gitlab.freedesktop.org/drm/intel/issues/2426> / i915#2667<https://gitlab.freedesktop.org/drm/i> / [i915#2803] / [i915#3002]) -> (FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb1/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb6/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-tglb5/igt@runner@aborted.html>) (i915#2295<https://gitlab.freedesktop.org/drm/intel/issues/2295> / i915#2667<https://gitlab.freedesktop.org/drm/i> / [i915#3002]) * shard-skl: (FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl4/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl4/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl5/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl5/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9771/shard-skl4/igt@runner@aborted.html>) (i915#1814<https://gitlab.freedesktop.org/drm/intel/issues/1814> / i915#2029<https://gitlab.freedesktop.org/drm/intel/issues/2029> / i915#2295<https://gitlab.freedesktop.org/drm/intel/issues/2295> / i915#2426<https://gitlab.freedesktop.org/drm/intel/issues/2426> / [i915#3002]) -> (FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl1/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl2/igt@runner@aborted.html>, FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19672/shard-skl9/igt@runner@aborted.html>) (i915#2295<https://gitlab.freedesktop.org/drm/intel/issues/2295> / [i915#3002]) {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [-- Attachment #1.2: Type: text/html, Size: 36125 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 23+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping (rev2) 2021-02-12 18:21 [Intel-gfx] [PATCH 1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping José Roberto de Souza ` (7 preceding siblings ...) 2021-02-12 20:15 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] " Patchwork @ 2021-02-18 20:06 ` Patchwork 8 siblings, 0 replies; 23+ messages in thread From: Patchwork @ 2021-02-18 20:06 UTC (permalink / raw) To: Souza, Jose; +Cc: intel-gfx == Series Details == Series: series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping (rev2) URL : https://patchwork.freedesktop.org/series/87048/ State : failure == Summary == Applying: drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping Using index info to reconstruct a base tree... M drivers/gpu/drm/i915/display/intel_ddi.c Falling back to patching base and 3-way merge... Auto-merging drivers/gpu/drm/i915/display/intel_ddi.c CONFLICT (content): Merge conflict in drivers/gpu/drm/i915/display/intel_ddi.c error: Failed to merge in the changes. hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch failed at 0001 drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2021-02-19 19:35 UTC | newest] Thread overview: 23+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-02-12 18:21 [Intel-gfx] [PATCH 1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping José Roberto de Souza 2021-02-12 18:22 ` [Intel-gfx] [PATCH 2/3] drm/i915: Remove dead code from skl_pipe_wm_get_hw_state() José Roberto de Souza 2021-02-12 18:33 ` Ville Syrjälä 2021-02-12 18:22 ` [Intel-gfx] [PATCH 3/3] drm/i915: Fix plane watermark mismatches José Roberto de Souza 2021-02-12 18:35 ` Ville Syrjälä 2021-02-12 19:44 ` Souza, Jose 2021-02-12 21:13 ` Ville Syrjälä 2021-02-17 17:24 ` Souza, Jose 2021-02-17 22:14 ` Ville Syrjälä 2021-02-18 17:25 ` Souza, Jose 2021-02-18 18:21 ` Ville Syrjälä 2021-02-19 19:35 ` Souza, Jose 2021-02-12 18:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping Patchwork 2021-02-12 18:30 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2021-02-12 18:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-02-12 19:15 ` [Intel-gfx] [PATCH 1/3] " Aditya Swarup 2021-02-12 19:20 ` Ville Syrjälä 2021-02-12 19:42 ` Souza, Jose 2021-02-12 21:17 ` Ville Syrjälä 2021-02-17 17:25 ` Souza, Jose 2021-02-12 20:15 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] " Patchwork 2021-02-17 17:32 ` Souza, Jose 2021-02-18 20:06 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/3] drm/i915/display/adl_s: Fix dpclka_cfgcr0_clk_off mapping (rev2) Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox