Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] drm/i915/display: Couple of DC3co fixes
@ 2026-09-24  5:57 Suraj Kandpal
  2026-09-24  5:57 ` [PATCH 1/2] drm/i915/cmtg: Select the right CMTG vblank for DC3co Suraj Kandpal
                   ` (4 more replies)
  0 siblings, 5 replies; 11+ messages in thread
From: Suraj Kandpal @ 2026-09-24  5:57 UTC (permalink / raw)
  To: intel-gfx, intel-xe
  Cc: ankit.k.nautiyal, dibin.moolakadan.subrahmanian, animesh.manna,
	Suraj Kandpal

While looking at why DC3co sequences I came across some steps
that were missed or miscoded.
The first one is a plain missing register write. DC3co enabling is
double buffered on a CMTG delayed vblank and CHICKEN_DCPR_1 bit 5 picks
which CMTG that is, but we never program it. Setups running on CMTG B
end up armed off CMTG A's vblank and only work because the reset value
happens to be the one we want half the time.
The second one is us being stricter than the spec. We only allow DC3co
when pipe A drives port A or pipe B drives port B, but Bspec has no such
restriction and neither does CMTG, so an eDP panel on the other port
just loses DC3co for no reason.

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>

Suraj Kandpal (2):
  drm/i915/cmtg: Select the right CMTG vblank for DC3co
  drm/i915/display: Don't require a 1:1 pipe to port mapping for DC3co

 drivers/gpu/drm/i915/display/intel_cmtg.c          |  2 ++
 drivers/gpu/drm/i915/display/intel_display_power.c | 10 +++-------
 drivers/gpu/drm/i915/display/intel_display_regs.h  |  1 +
 3 files changed, 6 insertions(+), 7 deletions(-)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2026-09-29  4:10 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-24  5:57 [PATCH 0/2] drm/i915/display: Couple of DC3co fixes Suraj Kandpal
2026-09-24  5:57 ` [PATCH 1/2] drm/i915/cmtg: Select the right CMTG vblank for DC3co Suraj Kandpal
2026-09-25 10:52   ` Jani Nikula
2026-09-24  5:57 ` [PATCH 2/2] drm/i915/display: Don't require a 1:1 pipe to port mapping " Suraj Kandpal
2026-09-24  6:05   ` sashiko-bot
2026-09-24  6:12     ` Kandpal, Suraj
2026-09-28  7:01   ` Dibin Moolakadan Subrahmanian
2026-09-29  4:09     ` Kandpal, Suraj
2026-09-24  6:06 ` ✓ CI.KUnit: success for drm/i915/display: Couple of DC3co fixes Patchwork
2026-09-24  6:47 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-24 19:57 ` ✓ Xe.CI.FULL: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox