Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: michal.wajdeczko@intel.com, mallesh.koujalagi@intel.com,
	Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
Subject: [PATCH v4 11/12] drm/xe/vram: Report tile vs device VRAM visibility errors
Date: Mon, 28 Sep 2026 14:51:13 +0530	[thread overview]
Message-ID: <20260928092114.1610203-12-dnyaneshwar.bhadane@intel.com> (raw)
In-Reply-To: <20260928092114.1610203-1-dnyaneshwar.bhadane@intel.com>

Derive the owning tile of a struct xe_vram_region inside
vram_region_init() from vram->id, so the "no CPU visible VRAM"
error can distinguish a per-tile region from the device-wide
region without changing the function's signature.

Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
---
 drivers/gpu/drm/xe/xe_vram.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_vram.c b/drivers/gpu/drm/xe/xe_vram.c
index dcedd8cfd731..fa06c7ae56b1 100644
--- a/drivers/gpu/drm/xe/xe_vram.c
+++ b/drivers/gpu/drm/xe/xe_vram.c
@@ -244,6 +244,7 @@ static int vram_region_init(struct xe_device *xe, struct xe_vram_region *vram,
 			    struct xe_vram_region *lmem_bar, u64 offset, u64 usable_size,
 			    u64 region_size, resource_size_t remain_io_size)
 {
+	struct xe_tile *tile = vram == xe->mem.vram ? NULL : &xe->tiles[vram->id];
 	/* Check if VRAM region is already initialized */
 	if (vram->mapping)
 		return 0;
@@ -253,7 +254,8 @@ static int vram_region_init(struct xe_device *xe, struct xe_vram_region *vram,
 	vram->io_size = min_t(u64, usable_size, remain_io_size);
 
 	if (!vram->io_size) {
-		drm_err(&xe->drm, "Tile without any CPU visible VRAM. Aborting.\n");
+		drm_err(&xe->drm, "%s without any CPU visible VRAM. Aborting.\n",
+			tile ? "Tile" : "Device");
 		return -ENODEV;
 	}
 
-- 
2.54.0


  parent reply	other threads:[~2026-09-28  9:24 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28  9:21 [PATCH v4 00/12] drm/xe: Convert IO_BUS errors to structured xe_log API Dnyaneshwar Bhadane
2026-09-28  9:21 ` [PATCH v4 01/12] drm/xe/log: Add VRAM, PAT, and HWMON DRIVER_HARDWARE components Dnyaneshwar Bhadane
2026-09-28  9:21 ` [PATCH v4 02/12] drm/xe/ggtt: Report GGTT errors using structured logging Dnyaneshwar Bhadane
2026-09-29  5:15   ` Mallesh, Koujalagi
2026-09-28  9:21 ` [PATCH v4 03/12] drm/xe/hwmon: Report errors using structured xe_log API Dnyaneshwar Bhadane
2026-09-29  5:25   ` Mallesh, Koujalagi
2026-09-28  9:21 ` [PATCH v4 04/12] drm/xe/mmio: Report BAR mapping " Dnyaneshwar Bhadane
2026-09-29  5:34   ` Mallesh, Koujalagi
2026-10-01  9:50   ` Dnyaneshwar Bhadane
2026-09-28  9:21 ` [PATCH v4 05/12] drm/xe/memirq: Report " Dnyaneshwar Bhadane
2026-09-28  9:30   ` sashiko-bot
2026-09-28 12:32     ` Bhadane, Dnyaneshwar
2026-09-29  5:40   ` Mallesh, Koujalagi
2026-09-28  9:21 ` [PATCH v4 06/12] drm/xe/reg_sr: Report save-restore " Dnyaneshwar Bhadane
2026-09-28  9:31   ` sashiko-bot
2026-09-28 12:35     ` Bhadane, Dnyaneshwar
2026-09-28  9:21 ` [PATCH v4 07/12] drm/xe/pat: Return error from xe_pat_init_early() on unknown platform Dnyaneshwar Bhadane
2026-09-29  5:58   ` Mallesh, Koujalagi
2026-09-28  9:21 ` [PATCH v4 08/12] drm/xe/pat: Report missing PAT table using structured xe_log API Dnyaneshwar Bhadane
2026-09-28  9:21 ` [PATCH v4 09/12] drm/xe/pci: Report unknown GMDID versions " Dnyaneshwar Bhadane
2026-09-29  6:34   ` Mallesh, Koujalagi
2026-09-28  9:21 ` [PATCH v4 10/12] drm/xe/lmtt: Report invalidation errors " Dnyaneshwar Bhadane
2026-09-28  9:36   ` sashiko-bot
2026-09-29  4:51     ` Dnyaneshwar Bhadane
2026-09-29  4:52     ` Dnyaneshwar Bhadane
2026-09-30  8:36   ` Mallesh, Koujalagi
2026-09-28  9:21 ` Dnyaneshwar Bhadane [this message]
2026-09-28  9:21 ` [PATCH v4 12/12] drm/xe/vram: Report VRAM " Dnyaneshwar Bhadane
2026-09-28  9:33   ` sashiko-bot
2026-09-30  6:48   ` Mallesh, Koujalagi
2026-10-07 20:20     ` Dnyaneshwar Bhadane
2026-09-28 16:14 ` ✓ CI.KUnit: success for drm/xe: Convert IO_BUS errors to structured xe_log API (rev4) Patchwork
2026-09-28 16:53 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-28 20:42 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260928092114.1610203-12-dnyaneshwar.bhadane@intel.com \
    --to=dnyaneshwar.bhadane@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=mallesh.koujalagi@intel.com \
    --cc=michal.wajdeczko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox