Re: [PATCH v4 02/12] drm/xe/ggtt: Report GGTT errors using structured logging

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

On 28-09-2026 02:51 pm, Dnyaneshwar Bhadane wrote:
> Replace xe_tile_err() calls with xe_log_err_fatal() using the GGTT
> component tag in GGTT initialization error paths.
>
> Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
LGTM,
Reviewed-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_ggtt.c | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c
> index 63e8bf193605..773777afc68a 100644
> --- a/drivers/gpu/drm/xe/xe_ggtt.c
> +++ b/drivers/gpu/drm/xe/xe_ggtt.c
> @@ -23,6 +23,7 @@
>   #include "xe_gt.h"
>   #include "xe_gt_printk.h"
>   #include "xe_gt_types.h"
> +#include "xe_log.h"
>   #include "xe_map.h"
>   #include "xe_mmio.h"
>   #include "xe_pat.h"
> @@ -403,7 +404,8 @@ int xe_ggtt_init_early(struct xe_ggtt *ggtt)
>   		else
>   			gsm_size = probe_gsm_size(pdev);
>   		if (gsm_size == 0) {
> -			xe_tile_err(ggtt->tile, "Hardware reported no preallocated GSM\n");
> +			xe_log_err_fatal(ggtt->tile, GGTT, -ENOMEM,
> +					 "Hardware reported no preallocated GSM\n");
>   			return -ENOMEM;
>   		}
>   		ggtt_start = wopcm;
> @@ -414,8 +416,9 @@ int xe_ggtt_init_early(struct xe_ggtt *ggtt)
>   
>   		if (ggtt_start < wopcm ||
>   		    ggtt_start + ggtt_size > GUC_GGTT_TOP) {
> -			xe_tile_err(ggtt->tile, "Invalid GGTT configuration: %#llx-%#llx\n",
> -				    ggtt_start, ggtt_start + ggtt_size - 1);
> +			xe_log_err_fatal(ggtt->tile, GGTT, -ERANGE,
> +					 "Invalid GGTT configuration: %#llx-%#llx\n",
> +					 ggtt_start, ggtt_start + ggtt_size - 1);
>   			return -ERANGE;
>   		}
>   	}